From: "Tone Zhang (Arm Technology China)" <Tone.Zhang@arm.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
Steve Capper <Steve.Capper@arm.com>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v3] pci_vfio: Support 64KB kernel page_size with vfio-pci driver
Date: Wed, 12 Dec 2018 10:49:39 +0000 [thread overview]
Message-ID: <AM0PR08MB3409F5E419491709E83CBF6A8FA70@AM0PR08MB3409.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20181210075542.6ff59014@xeon-e3>
Hi Stephen,
Thanks for the comments.
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Monday, December 10, 2018 11:56 PM
> To: Burakov, Anatoly <anatoly.burakov@intel.com>
> Cc: Tone Zhang (Arm Technology China) <Tone.Zhang@arm.com>;
> dev@dpdk.org; Gavin Hu (Arm Technology China) <Gavin.Hu@arm.com>;
> Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>; Steve Capper
> <Steve.Capper@arm.com>; nd <nd@arm.com>
> Subject: Re: [dpdk-dev] [PATCH v3] pci_vfio: Support 64KB kernel page_size with
> vfio-pci driver
>
> On Mon, 10 Dec 2018 11:45:37 +0000
> "Burakov, Anatoly" <anatoly.burakov@intel.com> wrote:
>
> > > /* Skip this BAR */
> > > + RTE_LOG(INFO, EAL, "Skipping BAR%d\n", bar_index);
> > > return 0;
> >
> > I would perhaps make it a DEBUG rather than INFO.
>
> And drop the comment...
Will drop the comment in v4.
Thanks.
Br,
Tone
next prev parent reply other threads:[~2018-12-12 10:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 2:20 [dpdk-dev] [PATCH] " tone.zhang
2018-10-24 9:09 ` Burakov, Anatoly
2018-11-01 2:33 ` Tone Zhang (Arm Technology China)
2018-11-01 10:01 ` Burakov, Anatoly
[not found] ` <DB7PR08MB33859242951014EF340C897AE9C80@DB7PR08MB3385.eurprd08.prod.outlook.com>
2018-11-03 5:46 ` Tone Zhang (Arm Technology China)
2018-11-06 11:03 ` Burakov, Anatoly
2018-11-07 4:55 ` Tone Zhang (Arm Technology China)
2018-11-07 10:12 ` Burakov, Anatoly
2018-11-08 0:45 ` Tone Zhang (Arm Technology China)
2018-11-09 5:57 ` [dpdk-dev] [PATCH v2] " tone.zhang
2018-11-09 12:15 ` Burakov, Anatoly
2018-11-15 0:49 ` Tone Zhang (Arm Technology China)
2018-11-16 2:34 ` Tone Zhang (Arm Technology China)
2018-11-16 10:36 ` Burakov, Anatoly
2018-11-19 2:37 ` [dpdk-dev] [PATCH v3] " tone.zhang
2018-12-03 7:25 ` Tone Zhang (Arm Technology China)
2018-12-10 11:40 ` Burakov, Anatoly
2018-12-10 11:45 ` Burakov, Anatoly
2018-12-10 15:55 ` Stephen Hemminger
2018-12-12 10:49 ` Tone Zhang (Arm Technology China) [this message]
2018-12-12 10:48 ` Tone Zhang (Arm Technology China)
2018-12-12 11:25 ` [dpdk-dev] [PATCH v4] " tone.zhang
2018-12-12 11:27 ` Burakov, Anatoly
2018-12-19 23:05 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR08MB3409F5E419491709E83CBF6A8FA70@AM0PR08MB3409.eurprd08.prod.outlook.com \
--to=tone.zhang@arm.com \
--cc=Gavin.Hu@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Steve.Capper@arm.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=nd@arm.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).