* [dpdk-dev] [PATCH 1/3] drivers/crypto: remove unused element from device operations
@ 2020-03-06 11:16 Artur Trybula
2020-03-06 11:16 ` [dpdk-dev] [PATCH 2/3] cryptodev: " Artur Trybula
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: Artur Trybula @ 2020-03-06 11:16 UTC (permalink / raw)
To: dev, pablo.de.lara.guarch, declan.doherty, ruifeng.wang, g.singh,
ravi1.kumar, akhil.goyal, tdu, anoobj, fiona.trahe,
roy.fan.zhang, jianjay.zhou, shallyv, arturx.trybula
This commit removes unused function pointer (queue_pair_count) from
rte_cryptodev_ops objects. Related functions removed as well.
Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
---
drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c | 8 --------
drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 8 --------
drivers/crypto/armv8/rte_armv8_pmd_ops.c | 8 --------
drivers/crypto/caam_jr/caam_jr.c | 10 ----------
drivers/crypto/ccp/ccp_pmd_ops.c | 7 -------
drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 10 ----------
drivers/crypto/dpaa_sec/dpaa_sec.c | 10 ----------
drivers/crypto/kasumi/rte_kasumi_pmd_ops.c | 8 --------
drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 12 ------------
drivers/crypto/null/null_crypto_pmd_ops.c | 8 --------
drivers/crypto/octeontx/otx_cryptodev_ops.c | 1 -
drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 1 -
drivers/crypto/openssl/rte_openssl_pmd_ops.c | 8 --------
drivers/crypto/qat/qat_asym_pmd.c | 1 -
drivers/crypto/qat/qat_sym_pmd.c | 1 -
drivers/crypto/scheduler/scheduler_pmd_ops.c | 8 --------
drivers/crypto/snow3g/rte_snow3g_pmd_ops.c | 8 --------
drivers/crypto/virtio/virtio_cryptodev.c | 1 -
drivers/crypto/zuc/rte_zuc_pmd_ops.c | 8 --------
19 files changed, 126 deletions(-)
diff --git a/drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c b/drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c
index c5e0878f5..18dbc4c18 100644
--- a/drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c
+++ b/drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c
@@ -248,13 +248,6 @@ aesni_gcm_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,
return -1;
}
-/** Return the number of allocated queue pairs */
-static uint32_t
-aesni_gcm_pmd_qp_count(struct rte_cryptodev *dev)
-{
- return dev->data->nb_queue_pairs;
-}
-
/** Returns the size of the aesni gcm session structure */
static unsigned
aesni_gcm_pmd_sym_session_get_size(struct rte_cryptodev *dev __rte_unused)
@@ -329,7 +322,6 @@ struct rte_cryptodev_ops aesni_gcm_pmd_ops = {
.queue_pair_setup = aesni_gcm_pmd_qp_setup,
.queue_pair_release = aesni_gcm_pmd_qp_release,
- .queue_pair_count = aesni_gcm_pmd_qp_count,
.sym_cpu_process = aesni_gcm_pmd_cpu_crypto_process,
diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
index d8609ad11..845661174 100644
--- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
+++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
@@ -721,13 +721,6 @@ aesni_mb_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,
return ret;
}
-/** Return the number of allocated queue pairs */
-static uint32_t
-aesni_mb_pmd_qp_count(struct rte_cryptodev *dev)
-{
- return dev->data->nb_queue_pairs;
-}
-
/** Returns the size of the aesni multi-buffer session structure */
static unsigned
aesni_mb_pmd_sym_session_get_size(struct rte_cryptodev *dev __rte_unused)
@@ -803,7 +796,6 @@ struct rte_cryptodev_ops aesni_mb_pmd_ops = {
.queue_pair_setup = aesni_mb_pmd_qp_setup,
.queue_pair_release = aesni_mb_pmd_qp_release,
- .queue_pair_count = aesni_mb_pmd_qp_count,
.sym_session_get_size = aesni_mb_pmd_sym_session_get_size,
.sym_session_configure = aesni_mb_pmd_sym_session_configure,
diff --git a/drivers/crypto/armv8/rte_armv8_pmd_ops.c b/drivers/crypto/armv8/rte_armv8_pmd_ops.c
index 4fd384d1a..01ccfb4b2 100644
--- a/drivers/crypto/armv8/rte_armv8_pmd_ops.c
+++ b/drivers/crypto/armv8/rte_armv8_pmd_ops.c
@@ -257,13 +257,6 @@ armv8_crypto_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,
return -1;
}
-/** Return the number of allocated queue pairs */
-static uint32_t
-armv8_crypto_pmd_qp_count(struct rte_cryptodev *dev)
-{
- return dev->data->nb_queue_pairs;
-}
-
/** Returns the size of the session structure */
static unsigned
armv8_crypto_pmd_sym_session_get_size(struct rte_cryptodev *dev __rte_unused)
@@ -337,7 +330,6 @@ struct rte_cryptodev_ops armv8_crypto_pmd_ops = {
.queue_pair_setup = armv8_crypto_pmd_qp_setup,
.queue_pair_release = armv8_crypto_pmd_qp_release,
- .queue_pair_count = armv8_crypto_pmd_qp_count,
.sym_session_get_size = armv8_crypto_pmd_sym_session_get_size,
.sym_session_configure = armv8_crypto_pmd_sym_session_configure,
diff --git a/drivers/crypto/caam_jr/caam_jr.c b/drivers/crypto/caam_jr/caam_jr.c
index 8aaa3d45f..5a29dd169 100644
--- a/drivers/crypto/caam_jr/caam_jr.c
+++ b/drivers/crypto/caam_jr/caam_jr.c
@@ -1538,15 +1538,6 @@ caam_jr_queue_pair_setup(
return 0;
}
-/* Return the number of allocated queue pairs */
-static uint32_t
-caam_jr_queue_pair_count(struct rte_cryptodev *dev)
-{
- PMD_INIT_FUNC_TRACE();
-
- return dev->data->nb_queue_pairs;
-}
-
/* Returns the size of the aesni gcm session structure */
static unsigned int
caam_jr_sym_session_get_size(struct rte_cryptodev *dev __rte_unused)
@@ -2062,7 +2053,6 @@ static struct rte_cryptodev_ops caam_jr_ops = {
.stats_reset = caam_jr_stats_reset,
.queue_pair_setup = caam_jr_queue_pair_setup,
.queue_pair_release = caam_jr_queue_pair_release,
- .queue_pair_count = caam_jr_queue_pair_count,
.sym_session_get_size = caam_jr_sym_session_get_size,
.sym_session_configure = caam_jr_sym_session_configure,
.sym_session_clear = caam_jr_sym_session_clear
diff --git a/drivers/crypto/ccp/ccp_pmd_ops.c b/drivers/crypto/ccp/ccp_pmd_ops.c
index a19e85ecb..98f964f36 100644
--- a/drivers/crypto/ccp/ccp_pmd_ops.c
+++ b/drivers/crypto/ccp/ccp_pmd_ops.c
@@ -749,12 +749,6 @@ ccp_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,
return -1;
}
-static uint32_t
-ccp_pmd_qp_count(struct rte_cryptodev *dev)
-{
- return dev->data->nb_queue_pairs;
-}
-
static unsigned
ccp_pmd_sym_session_get_size(struct rte_cryptodev *dev __rte_unused)
{
@@ -824,7 +818,6 @@ struct rte_cryptodev_ops ccp_ops = {
.queue_pair_setup = ccp_pmd_qp_setup,
.queue_pair_release = ccp_pmd_qp_release,
- .queue_pair_count = ccp_pmd_qp_count,
.sym_session_get_size = ccp_pmd_sym_session_get_size,
.sym_session_configure = ccp_pmd_sym_session_configure,
diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
index 6ed2701ab..241ec8857 100644
--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c
@@ -1798,15 +1798,6 @@ dpaa2_sec_queue_pair_setup(struct rte_cryptodev *dev, uint16_t qp_id,
return retcode;
}
-/** Return the number of allocated queue pairs */
-static uint32_t
-dpaa2_sec_queue_pair_count(struct rte_cryptodev *dev)
-{
- PMD_INIT_FUNC_TRACE();
-
- return dev->data->nb_queue_pairs;
-}
-
/** Returns the size of the aesni gcm session structure */
static unsigned int
dpaa2_sec_sym_session_get_size(struct rte_cryptodev *dev __rte_unused)
@@ -3674,7 +3665,6 @@ static struct rte_cryptodev_ops crypto_ops = {
.stats_reset = dpaa2_sec_stats_reset,
.queue_pair_setup = dpaa2_sec_queue_pair_setup,
.queue_pair_release = dpaa2_sec_queue_pair_release,
- .queue_pair_count = dpaa2_sec_queue_pair_count,
.sym_session_get_size = dpaa2_sec_sym_session_get_size,
.sym_session_configure = dpaa2_sec_sym_session_configure,
.sym_session_clear = dpaa2_sec_sym_session_clear,
diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c
index df684d265..a11b17bda 100644
--- a/drivers/crypto/dpaa_sec/dpaa_sec.c
+++ b/drivers/crypto/dpaa_sec/dpaa_sec.c
@@ -1990,15 +1990,6 @@ dpaa_sec_queue_pair_setup(struct rte_cryptodev *dev, uint16_t qp_id,
return 0;
}
-/** Return the number of allocated queue pairs */
-static uint32_t
-dpaa_sec_queue_pair_count(struct rte_cryptodev *dev)
-{
- PMD_INIT_FUNC_TRACE();
-
- return dev->data->nb_queue_pairs;
-}
-
/** Returns the size of session structure */
static unsigned int
dpaa_sec_sym_session_get_size(struct rte_cryptodev *dev __rte_unused)
@@ -3296,7 +3287,6 @@ static struct rte_cryptodev_ops crypto_ops = {
.dev_infos_get = dpaa_sec_dev_infos_get,
.queue_pair_setup = dpaa_sec_queue_pair_setup,
.queue_pair_release = dpaa_sec_queue_pair_release,
- .queue_pair_count = dpaa_sec_queue_pair_count,
.sym_session_get_size = dpaa_sec_sym_session_get_size,
.sym_session_configure = dpaa_sec_sym_session_configure,
.sym_session_clear = dpaa_sec_sym_session_clear
diff --git a/drivers/crypto/kasumi/rte_kasumi_pmd_ops.c b/drivers/crypto/kasumi/rte_kasumi_pmd_ops.c
index 55fbe00b7..43376c1aa 100644
--- a/drivers/crypto/kasumi/rte_kasumi_pmd_ops.c
+++ b/drivers/crypto/kasumi/rte_kasumi_pmd_ops.c
@@ -232,13 +232,6 @@ kasumi_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,
return -1;
}
-/** Return the number of allocated queue pairs */
-static uint32_t
-kasumi_pmd_qp_count(struct rte_cryptodev *dev)
-{
- return dev->data->nb_queue_pairs;
-}
-
/** Returns the size of the KASUMI session structure */
static unsigned
kasumi_pmd_sym_session_get_size(struct rte_cryptodev *dev __rte_unused)
@@ -314,7 +307,6 @@ struct rte_cryptodev_ops kasumi_pmd_ops = {
.queue_pair_setup = kasumi_pmd_qp_setup,
.queue_pair_release = kasumi_pmd_qp_release,
- .queue_pair_count = kasumi_pmd_qp_count,
.sym_session_get_size = kasumi_pmd_sym_session_get_size,
.sym_session_configure = kasumi_pmd_sym_session_configure,
diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
index 2dfaa0b11..c61bdca36 100644
--- a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
+++ b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
@@ -702,17 +702,6 @@ mrvl_crypto_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,
return -1;
}
-/** Return the number of allocated queue pairs (PMD ops callback).
- *
- * @param dev Pointer to the device structure.
- * @returns Number of allocated queue pairs.
- */
-static uint32_t
-mrvl_crypto_pmd_qp_count(struct rte_cryptodev *dev)
-{
- return dev->data->nb_queue_pairs;
-}
-
/** Returns the size of the session structure (PMD ops callback).
*
* @param dev Pointer to the device structure [Unused].
@@ -827,7 +816,6 @@ static struct rte_cryptodev_ops mrvl_crypto_pmd_ops = {
.queue_pair_setup = mrvl_crypto_pmd_qp_setup,
.queue_pair_release = mrvl_crypto_pmd_qp_release,
- .queue_pair_count = mrvl_crypto_pmd_qp_count,
.sym_session_get_size = mrvl_crypto_pmd_sym_session_get_size,
.sym_session_configure = mrvl_crypto_pmd_sym_session_configure,
diff --git a/drivers/crypto/null/null_crypto_pmd_ops.c b/drivers/crypto/null/null_crypto_pmd_ops.c
index d988bfe96..d67892a1b 100644
--- a/drivers/crypto/null/null_crypto_pmd_ops.c
+++ b/drivers/crypto/null/null_crypto_pmd_ops.c
@@ -247,13 +247,6 @@ null_crypto_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,
return -1;
}
-/** Return the number of allocated queue pairs */
-static uint32_t
-null_crypto_pmd_qp_count(struct rte_cryptodev *dev)
-{
- return dev->data->nb_queue_pairs;
-}
-
/** Returns the size of the NULL crypto session structure */
static unsigned
null_crypto_pmd_sym_session_get_size(struct rte_cryptodev *dev __rte_unused)
@@ -327,7 +320,6 @@ static struct rte_cryptodev_ops pmd_ops = {
.queue_pair_setup = null_crypto_pmd_qp_setup,
.queue_pair_release = null_crypto_pmd_qp_release,
- .queue_pair_count = null_crypto_pmd_qp_count,
.sym_session_get_size = null_crypto_pmd_sym_session_get_size,
.sym_session_configure = null_crypto_pmd_sym_session_configure,
diff --git a/drivers/crypto/octeontx/otx_cryptodev_ops.c b/drivers/crypto/octeontx/otx_cryptodev_ops.c
index d7f3d0827..51520e753 100644
--- a/drivers/crypto/octeontx/otx_cryptodev_ops.c
+++ b/drivers/crypto/octeontx/otx_cryptodev_ops.c
@@ -898,7 +898,6 @@ static struct rte_cryptodev_ops cptvf_ops = {
.stats_reset = otx_cpt_stats_reset,
.queue_pair_setup = otx_cpt_que_pair_setup,
.queue_pair_release = otx_cpt_que_pair_release,
- .queue_pair_count = NULL,
/* Crypto related operations */
.sym_session_get_size = otx_cpt_get_session_size,
diff --git a/drivers/crypto/octeontx2/otx2_cryptodev_ops.c b/drivers/crypto/octeontx2/otx2_cryptodev_ops.c
index 7eebb4963..a8305f41f 100644
--- a/drivers/crypto/octeontx2/otx2_cryptodev_ops.c
+++ b/drivers/crypto/octeontx2/otx2_cryptodev_ops.c
@@ -1204,7 +1204,6 @@ struct rte_cryptodev_ops otx2_cpt_ops = {
.stats_reset = NULL,
.queue_pair_setup = otx2_cpt_queue_pair_setup,
.queue_pair_release = otx2_cpt_queue_pair_release,
- .queue_pair_count = NULL,
/* Symmetric crypto ops */
.sym_session_get_size = otx2_cpt_sym_session_get_size,
diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
index cbfb8149f..ed7587758 100644
--- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c
+++ b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
@@ -754,13 +754,6 @@ openssl_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,
return -1;
}
-/** Return the number of allocated queue pairs */
-static uint32_t
-openssl_pmd_qp_count(struct rte_cryptodev *dev)
-{
- return dev->data->nb_queue_pairs;
-}
-
/** Returns the size of the symmetric session structure */
static unsigned
openssl_pmd_sym_session_get_size(struct rte_cryptodev *dev __rte_unused)
@@ -1242,7 +1235,6 @@ struct rte_cryptodev_ops openssl_pmd_ops = {
.queue_pair_setup = openssl_pmd_qp_setup,
.queue_pair_release = openssl_pmd_qp_release,
- .queue_pair_count = openssl_pmd_qp_count,
.sym_session_get_size = openssl_pmd_sym_session_get_size,
.asym_session_get_size = openssl_pmd_asym_session_get_size,
diff --git a/drivers/crypto/qat/qat_asym_pmd.c b/drivers/crypto/qat/qat_asym_pmd.c
index cdf10de51..af3cc25f7 100644
--- a/drivers/crypto/qat/qat_asym_pmd.c
+++ b/drivers/crypto/qat/qat_asym_pmd.c
@@ -203,7 +203,6 @@ struct rte_cryptodev_ops crypto_qat_ops = {
.stats_reset = qat_asym_stats_reset,
.queue_pair_setup = qat_asym_qp_setup,
.queue_pair_release = qat_asym_qp_release,
- .queue_pair_count = NULL,
/* Crypto related operations */
.asym_session_get_size = qat_asym_session_get_private_size,
diff --git a/drivers/crypto/qat/qat_sym_pmd.c b/drivers/crypto/qat/qat_sym_pmd.c
index 666ede726..50abdf6f5 100644
--- a/drivers/crypto/qat/qat_sym_pmd.c
+++ b/drivers/crypto/qat/qat_sym_pmd.c
@@ -203,7 +203,6 @@ static struct rte_cryptodev_ops crypto_qat_ops = {
.stats_reset = qat_sym_stats_reset,
.queue_pair_setup = qat_sym_qp_setup,
.queue_pair_release = qat_sym_qp_release,
- .queue_pair_count = NULL,
/* Crypto related operations */
.sym_session_get_size = qat_sym_session_get_private_size,
diff --git a/drivers/crypto/scheduler/scheduler_pmd_ops.c b/drivers/crypto/scheduler/scheduler_pmd_ops.c
index cf70218b7..14e5a3712 100644
--- a/drivers/crypto/scheduler/scheduler_pmd_ops.c
+++ b/drivers/crypto/scheduler/scheduler_pmd_ops.c
@@ -454,13 +454,6 @@ scheduler_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,
return 0;
}
-/** Return the number of allocated queue pairs */
-static uint32_t
-scheduler_pmd_qp_count(struct rte_cryptodev *dev)
-{
- return dev->data->nb_queue_pairs;
-}
-
static uint32_t
scheduler_pmd_sym_session_get_size(struct rte_cryptodev *dev __rte_unused)
{
@@ -534,7 +527,6 @@ static struct rte_cryptodev_ops scheduler_pmd_ops = {
.queue_pair_setup = scheduler_pmd_qp_setup,
.queue_pair_release = scheduler_pmd_qp_release,
- .queue_pair_count = scheduler_pmd_qp_count,
.sym_session_get_size = scheduler_pmd_sym_session_get_size,
.sym_session_configure = scheduler_pmd_sym_session_configure,
diff --git a/drivers/crypto/snow3g/rte_snow3g_pmd_ops.c b/drivers/crypto/snow3g/rte_snow3g_pmd_ops.c
index ea7663749..906a0fe60 100644
--- a/drivers/crypto/snow3g/rte_snow3g_pmd_ops.c
+++ b/drivers/crypto/snow3g/rte_snow3g_pmd_ops.c
@@ -239,13 +239,6 @@ snow3g_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,
return -1;
}
-/** Return the number of allocated queue pairs */
-static uint32_t
-snow3g_pmd_qp_count(struct rte_cryptodev *dev)
-{
- return dev->data->nb_queue_pairs;
-}
-
/** Returns the size of the SNOW 3G session structure */
static unsigned
snow3g_pmd_sym_session_get_size(struct rte_cryptodev *dev __rte_unused)
@@ -321,7 +314,6 @@ struct rte_cryptodev_ops snow3g_pmd_ops = {
.queue_pair_setup = snow3g_pmd_qp_setup,
.queue_pair_release = snow3g_pmd_qp_release,
- .queue_pair_count = snow3g_pmd_qp_count,
.sym_session_get_size = snow3g_pmd_sym_session_get_size,
.sym_session_configure = snow3g_pmd_sym_session_configure,
diff --git a/drivers/crypto/virtio/virtio_cryptodev.c b/drivers/crypto/virtio/virtio_cryptodev.c
index 4af479f54..e7fb71a64 100644
--- a/drivers/crypto/virtio/virtio_cryptodev.c
+++ b/drivers/crypto/virtio/virtio_cryptodev.c
@@ -514,7 +514,6 @@ static struct rte_cryptodev_ops virtio_crypto_dev_ops = {
.queue_pair_setup = virtio_crypto_qp_setup,
.queue_pair_release = virtio_crypto_qp_release,
- .queue_pair_count = NULL,
/* Crypto related operations */
.sym_session_get_size = virtio_crypto_sym_get_session_private_size,
diff --git a/drivers/crypto/zuc/rte_zuc_pmd_ops.c b/drivers/crypto/zuc/rte_zuc_pmd_ops.c
index ddd0f9243..dc9dc25ef 100644
--- a/drivers/crypto/zuc/rte_zuc_pmd_ops.c
+++ b/drivers/crypto/zuc/rte_zuc_pmd_ops.c
@@ -239,13 +239,6 @@ zuc_pmd_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,
return -1;
}
-/** Return the number of allocated queue pairs */
-static uint32_t
-zuc_pmd_qp_count(struct rte_cryptodev *dev)
-{
- return dev->data->nb_queue_pairs;
-}
-
/** Returns the size of the ZUC session structure */
static unsigned
zuc_pmd_sym_session_get_size(struct rte_cryptodev *dev __rte_unused)
@@ -320,7 +313,6 @@ struct rte_cryptodev_ops zuc_pmd_ops = {
.queue_pair_setup = zuc_pmd_qp_setup,
.queue_pair_release = zuc_pmd_qp_release,
- .queue_pair_count = zuc_pmd_qp_count,
.sym_session_get_size = zuc_pmd_sym_session_get_size,
.sym_session_configure = zuc_pmd_sym_session_configure,
--
2.17.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-dev] [PATCH 2/3] cryptodev: remove unused element from device operations
2020-03-06 11:16 [dpdk-dev] [PATCH 1/3] drivers/crypto: remove unused element from device operations Artur Trybula
@ 2020-03-06 11:16 ` Artur Trybula
2020-03-09 5:45 ` Ruifeng Wang
` (2 more replies)
2020-03-06 11:16 ` [dpdk-dev] [PATCH 3/3] compressdef: remove unused function pointer prototype Artur Trybula
` (3 subsequent siblings)
4 siblings, 3 replies; 11+ messages in thread
From: Artur Trybula @ 2020-03-06 11:16 UTC (permalink / raw)
To: dev, pablo.de.lara.guarch, declan.doherty, ruifeng.wang, g.singh,
ravi1.kumar, akhil.goyal, tdu, anoobj, fiona.trahe,
roy.fan.zhang, jianjay.zhou, shallyv, arturx.trybula
This commit removes unused function pointer (queue_pair_count)
from struct rte_cryptodev_ops.
Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
---
lib/librte_cryptodev/rte_cryptodev_pmd.h | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/lib/librte_cryptodev/rte_cryptodev_pmd.h b/lib/librte_cryptodev/rte_cryptodev_pmd.h
index 0e6b5f443..81975d72b 100644
--- a/lib/librte_cryptodev/rte_cryptodev_pmd.h
+++ b/lib/librte_cryptodev/rte_cryptodev_pmd.h
@@ -207,15 +207,6 @@ typedef int (*cryptodev_queue_pair_setup_t)(struct rte_cryptodev *dev,
typedef int (*cryptodev_queue_pair_release_t)(struct rte_cryptodev *dev,
uint16_t qp_id);
-/**
- * Get number of available queue pairs of a device.
- *
- * @param dev Crypto device pointer
- *
- * @return Returns number of queue pairs on success.
- */
-typedef uint32_t (*cryptodev_queue_pair_count_t)(struct rte_cryptodev *dev);
-
/**
* Create a session mempool to allocate sessions from
*
@@ -344,8 +335,6 @@ struct rte_cryptodev_ops {
/**< Set up a device queue pair. */
cryptodev_queue_pair_release_t queue_pair_release;
/**< Release a queue pair. */
- cryptodev_queue_pair_count_t queue_pair_count;
- /**< Get count of the queue pairs. */
cryptodev_sym_get_session_private_size_t sym_session_get_size;
/**< Return private session. */
--
2.17.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [PATCH 2/3] cryptodev: remove unused element from device operations
2020-03-06 11:16 ` [dpdk-dev] [PATCH 2/3] cryptodev: " Artur Trybula
@ 2020-03-09 5:45 ` Ruifeng Wang
2020-03-10 11:06 ` Trahe, Fiona
2020-03-10 16:37 ` [dpdk-dev] [EXT] " Anoob Joseph
2 siblings, 0 replies; 11+ messages in thread
From: Ruifeng Wang @ 2020-03-09 5:45 UTC (permalink / raw)
To: Artur Trybula, dev, pablo.de.lara.guarch, declan.doherty,
g.singh, ravi1.kumar, Akhil.goyal@nxp.com, tdu, anoobj,
fiona.trahe, roy.fan.zhang, jianjay.zhou, shallyv
Cc: nd, nd
> -----Original Message-----
> From: Artur Trybula <arturx.trybula@intel.com>
> Sent: Friday, March 6, 2020 19:17
> To: dev@dpdk.org; pablo.de.lara.guarch@intel.com;
> declan.doherty@intel.com; Ruifeng Wang <Ruifeng.Wang@arm.com>;
> g.singh@nxp.com; ravi1.kumar@amd.com; Akhil.goyal@nxp.com;
> tdu@semihalf.com; anoobj@marvell.com; fiona.trahe@intel.com;
> roy.fan.zhang@intel.com; jianjay.zhou@huawei.com; shallyv@marvell.com;
> arturx.trybula@intel.com
> Subject: [PATCH 2/3] cryptodev: remove unused element from device
> operations
>
> This commit removes unused function pointer (queue_pair_count) from
> struct rte_cryptodev_ops.
>
> Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
> ---
> lib/librte_cryptodev/rte_cryptodev_pmd.h | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/lib/librte_cryptodev/rte_cryptodev_pmd.h
> b/lib/librte_cryptodev/rte_cryptodev_pmd.h
> index 0e6b5f443..81975d72b 100644
> --- a/lib/librte_cryptodev/rte_cryptodev_pmd.h
> +++ b/lib/librte_cryptodev/rte_cryptodev_pmd.h
> @@ -207,15 +207,6 @@ typedef int
> (*cryptodev_queue_pair_setup_t)(struct rte_cryptodev *dev, typedef int
> (*cryptodev_queue_pair_release_t)(struct rte_cryptodev *dev,
> uint16_t qp_id);
>
> -/**
> - * Get number of available queue pairs of a device.
> - *
> - * @param dev Crypto device pointer
> - *
> - * @return Returns number of queue pairs on success.
> - */
> -typedef uint32_t (*cryptodev_queue_pair_count_t)(struct rte_cryptodev
> *dev);
> -
> /**
> * Create a session mempool to allocate sessions from
> *
> @@ -344,8 +335,6 @@ struct rte_cryptodev_ops {
> /**< Set up a device queue pair. */
> cryptodev_queue_pair_release_t queue_pair_release;
> /**< Release a queue pair. */
> - cryptodev_queue_pair_count_t queue_pair_count;
> - /**< Get count of the queue pairs. */
>
> cryptodev_sym_get_session_private_size_t sym_session_get_size;
> /**< Return private session. */
> --
> 2.17.1
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [PATCH 2/3] cryptodev: remove unused element from device operations
2020-03-06 11:16 ` [dpdk-dev] [PATCH 2/3] cryptodev: " Artur Trybula
2020-03-09 5:45 ` Ruifeng Wang
@ 2020-03-10 11:06 ` Trahe, Fiona
2020-03-10 16:37 ` [dpdk-dev] [EXT] " Anoob Joseph
2 siblings, 0 replies; 11+ messages in thread
From: Trahe, Fiona @ 2020-03-10 11:06 UTC (permalink / raw)
To: Trybula, ArturX, dev, De Lara Guarch, Pablo, Doherty, Declan,
ruifeng.wang, g.singh, ravi1.kumar, akhil.goyal, tdu, anoobj,
Zhang, Roy Fan, jianjay.zhou, shallyv
> -----Original Message-----
> From: Trybula, ArturX <arturx.trybula@intel.com>
> Sent: Friday, March 6, 2020 11:17 AM
> To: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>; ruifeng.wang@arm.com; g.singh@nxp.com; ravi1.kumar@amd.com;
> akhil.goyal@nxp.com; tdu@semihalf.com; anoobj@marvell.com; Trahe, Fiona
> <fiona.trahe@intel.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com>; jianjay.zhou@huawei.com;
> shallyv@marvell.com; Trybula, ArturX <arturx.trybula@intel.com>
> Subject: [PATCH 2/3] cryptodev: remove unused element from device operations
>
> This commit removes unused function pointer (queue_pair_count)
> from struct rte_cryptodev_ops.
>
> Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [EXT] [PATCH 2/3] cryptodev: remove unused element from device operations
2020-03-06 11:16 ` [dpdk-dev] [PATCH 2/3] cryptodev: " Artur Trybula
2020-03-09 5:45 ` Ruifeng Wang
2020-03-10 11:06 ` Trahe, Fiona
@ 2020-03-10 16:37 ` Anoob Joseph
2 siblings, 0 replies; 11+ messages in thread
From: Anoob Joseph @ 2020-03-10 16:37 UTC (permalink / raw)
To: Artur Trybula, dev, pablo.de.lara.guarch, declan.doherty,
ruifeng.wang, g.singh, ravi1.kumar, akhil.goyal, tdu,
fiona.trahe, roy.fan.zhang, jianjay.zhou, Shally Verma
> This commit removes unused function pointer (queue_pair_count) from struct
> rte_cryptodev_ops.
>
> Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
Acked-by: Anoob Joseph <anoobj@marvell.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-dev] [PATCH 3/3] compressdef: remove unused function pointer prototype
2020-03-06 11:16 [dpdk-dev] [PATCH 1/3] drivers/crypto: remove unused element from device operations Artur Trybula
2020-03-06 11:16 ` [dpdk-dev] [PATCH 2/3] cryptodev: " Artur Trybula
@ 2020-03-06 11:16 ` Artur Trybula
2020-03-09 5:50 ` Ruifeng Wang
2020-03-09 5:45 ` [dpdk-dev] [PATCH 1/3] drivers/crypto: remove unused element from device operations Ruifeng Wang
` (2 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Artur Trybula @ 2020-03-06 11:16 UTC (permalink / raw)
To: dev, pablo.de.lara.guarch, declan.doherty, ruifeng.wang, g.singh,
ravi1.kumar, akhil.goyal, tdu, anoobj, fiona.trahe,
roy.fan.zhang, jianjay.zhou, shallyv, arturx.trybula
This commit removes unused prototype of the function pointer
compressdev_queue_pair_count_t.
Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
---
lib/librte_compressdev/rte_compressdev_pmd.h | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/lib/librte_compressdev/rte_compressdev_pmd.h b/lib/librte_compressdev/rte_compressdev_pmd.h
index c8e017577..d5898a5b7 100644
--- a/lib/librte_compressdev/rte_compressdev_pmd.h
+++ b/lib/librte_compressdev/rte_compressdev_pmd.h
@@ -173,16 +173,6 @@ typedef int (*compressdev_queue_pair_setup_t)(struct rte_compressdev *dev,
typedef int (*compressdev_queue_pair_release_t)(struct rte_compressdev *dev,
uint16_t qp_id);
-/**
- * Get number of available queue pairs of a device.
- *
- * @param dev
- * Compress device
- * @return
- * Returns number of queue pairs on success.
- */
-typedef uint32_t (*compressdev_queue_pair_count_t)(struct rte_compressdev *dev);
-
/**
* Create driver private stream data.
*
--
2.17.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [PATCH 3/3] compressdef: remove unused function pointer prototype
2020-03-06 11:16 ` [dpdk-dev] [PATCH 3/3] compressdef: remove unused function pointer prototype Artur Trybula
@ 2020-03-09 5:50 ` Ruifeng Wang
0 siblings, 0 replies; 11+ messages in thread
From: Ruifeng Wang @ 2020-03-09 5:50 UTC (permalink / raw)
To: Artur Trybula, dev, pablo.de.lara.guarch, declan.doherty,
g.singh, ravi1.kumar, Akhil.goyal@nxp.com, tdu, anoobj,
fiona.trahe, roy.fan.zhang, jianjay.zhou, shallyv
Cc: nd, nd
> -----Original Message-----
> From: Artur Trybula <arturx.trybula@intel.com>
> Sent: Friday, March 6, 2020 19:17
> To: dev@dpdk.org; pablo.de.lara.guarch@intel.com;
> declan.doherty@intel.com; Ruifeng Wang <Ruifeng.Wang@arm.com>;
> g.singh@nxp.com; ravi1.kumar@amd.com; Akhil.goyal@nxp.com;
> tdu@semihalf.com; anoobj@marvell.com; fiona.trahe@intel.com;
> roy.fan.zhang@intel.com; jianjay.zhou@huawei.com; shallyv@marvell.com;
> arturx.trybula@intel.com
> Subject: [PATCH 3/3] compressdef: remove unused function pointer
> prototype
>
s/compressdef/compressdev
With the minor change:
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> This commit removes unused prototype of the function pointer
> compressdev_queue_pair_count_t.
>
> Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
> ---
> lib/librte_compressdev/rte_compressdev_pmd.h | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/lib/librte_compressdev/rte_compressdev_pmd.h
> b/lib/librte_compressdev/rte_compressdev_pmd.h
> index c8e017577..d5898a5b7 100644
> --- a/lib/librte_compressdev/rte_compressdev_pmd.h
> +++ b/lib/librte_compressdev/rte_compressdev_pmd.h
> @@ -173,16 +173,6 @@ typedef int
> (*compressdev_queue_pair_setup_t)(struct rte_compressdev *dev,
> typedef int (*compressdev_queue_pair_release_t)(struct rte_compressdev
> *dev,
> uint16_t qp_id);
>
> -/**
> - * Get number of available queue pairs of a device.
> - *
> - * @param dev
> - * Compress device
> - * @return
> - * Returns number of queue pairs on success.
> - */
> -typedef uint32_t (*compressdev_queue_pair_count_t)(struct
> rte_compressdev *dev);
> -
> /**
> * Create driver private stream data.
> *
> --
> 2.17.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [PATCH 1/3] drivers/crypto: remove unused element from device operations
2020-03-06 11:16 [dpdk-dev] [PATCH 1/3] drivers/crypto: remove unused element from device operations Artur Trybula
2020-03-06 11:16 ` [dpdk-dev] [PATCH 2/3] cryptodev: " Artur Trybula
2020-03-06 11:16 ` [dpdk-dev] [PATCH 3/3] compressdef: remove unused function pointer prototype Artur Trybula
@ 2020-03-09 5:45 ` Ruifeng Wang
2020-03-10 11:05 ` Trahe, Fiona
2020-03-10 16:35 ` [dpdk-dev] [EXT] " Anoob Joseph
4 siblings, 0 replies; 11+ messages in thread
From: Ruifeng Wang @ 2020-03-09 5:45 UTC (permalink / raw)
To: Artur Trybula, dev, pablo.de.lara.guarch, declan.doherty,
g.singh, ravi1.kumar, Akhil.goyal@nxp.com, tdu, anoobj,
fiona.trahe, roy.fan.zhang, jianjay.zhou, shallyv
Cc: nd, nd
> -----Original Message-----
> From: Artur Trybula <arturx.trybula@intel.com>
> Sent: Friday, March 6, 2020 19:17
> To: dev@dpdk.org; pablo.de.lara.guarch@intel.com;
> declan.doherty@intel.com; Ruifeng Wang <Ruifeng.Wang@arm.com>;
> g.singh@nxp.com; ravi1.kumar@amd.com; Akhil.goyal@nxp.com;
> tdu@semihalf.com; anoobj@marvell.com; fiona.trahe@intel.com;
> roy.fan.zhang@intel.com; jianjay.zhou@huawei.com; shallyv@marvell.com;
> arturx.trybula@intel.com
> Subject: [PATCH 1/3] drivers/crypto: remove unused element from device
> operations
>
> This commit removes unused function pointer (queue_pair_count) from
> rte_cryptodev_ops objects. Related functions removed as well.
>
> Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
> ---
> drivers/crypto/aesni_gcm/aesni_gcm_pmd_ops.c | 8 --------
> drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 8 --------
> drivers/crypto/armv8/rte_armv8_pmd_ops.c | 8 --------
> drivers/crypto/caam_jr/caam_jr.c | 10 ----------
> drivers/crypto/ccp/ccp_pmd_ops.c | 7 -------
> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 10 ----------
> drivers/crypto/dpaa_sec/dpaa_sec.c | 10 ----------
> drivers/crypto/kasumi/rte_kasumi_pmd_ops.c | 8 --------
> drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 12 ------------
> drivers/crypto/null/null_crypto_pmd_ops.c | 8 --------
> drivers/crypto/octeontx/otx_cryptodev_ops.c | 1 -
> drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 1 -
> drivers/crypto/openssl/rte_openssl_pmd_ops.c | 8 --------
> drivers/crypto/qat/qat_asym_pmd.c | 1 -
> drivers/crypto/qat/qat_sym_pmd.c | 1 -
> drivers/crypto/scheduler/scheduler_pmd_ops.c | 8 --------
> drivers/crypto/snow3g/rte_snow3g_pmd_ops.c | 8 --------
> drivers/crypto/virtio/virtio_cryptodev.c | 1 -
> drivers/crypto/zuc/rte_zuc_pmd_ops.c | 8 --------
> 19 files changed, 126 deletions(-)
>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [PATCH 1/3] drivers/crypto: remove unused element from device operations
2020-03-06 11:16 [dpdk-dev] [PATCH 1/3] drivers/crypto: remove unused element from device operations Artur Trybula
` (2 preceding siblings ...)
2020-03-09 5:45 ` [dpdk-dev] [PATCH 1/3] drivers/crypto: remove unused element from device operations Ruifeng Wang
@ 2020-03-10 11:05 ` Trahe, Fiona
2020-03-10 16:35 ` [dpdk-dev] [EXT] " Anoob Joseph
4 siblings, 0 replies; 11+ messages in thread
From: Trahe, Fiona @ 2020-03-10 11:05 UTC (permalink / raw)
To: Trybula, ArturX, dev, De Lara Guarch, Pablo, Doherty, Declan,
ruifeng.wang, g.singh, ravi1.kumar, akhil.goyal, tdu, anoobj,
Zhang, Roy Fan, jianjay.zhou, shallyv
> -----Original Message-----
> From: Trybula, ArturX <arturx.trybula@intel.com>
> Sent: Friday, March 6, 2020 11:17 AM
> To: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>; ruifeng.wang@arm.com; g.singh@nxp.com; ravi1.kumar@amd.com;
> akhil.goyal@nxp.com; tdu@semihalf.com; anoobj@marvell.com; Trahe, Fiona
> <fiona.trahe@intel.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com>; jianjay.zhou@huawei.com;
> shallyv@marvell.com; Trybula, ArturX <arturx.trybula@intel.com>
> Subject: [PATCH 1/3] drivers/crypto: remove unused element from device operations
>
> This commit removes unused function pointer (queue_pair_count) from
> rte_cryptodev_ops objects. Related functions removed as well.
>
> Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [EXT] [PATCH 1/3] drivers/crypto: remove unused element from device operations
2020-03-06 11:16 [dpdk-dev] [PATCH 1/3] drivers/crypto: remove unused element from device operations Artur Trybula
` (3 preceding siblings ...)
2020-03-10 11:05 ` Trahe, Fiona
@ 2020-03-10 16:35 ` Anoob Joseph
2020-03-25 19:08 ` Akhil Goyal
4 siblings, 1 reply; 11+ messages in thread
From: Anoob Joseph @ 2020-03-10 16:35 UTC (permalink / raw)
To: Artur Trybula, dev, pablo.de.lara.guarch, declan.doherty,
ruifeng.wang, g.singh, ravi1.kumar, akhil.goyal, tdu,
fiona.trahe, roy.fan.zhang, jianjay.zhou, Shally Verma
> This commit removes unused function pointer (queue_pair_count) from
> rte_cryptodev_ops objects. Related functions removed as well.
>
> Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
Acked-by: Anoob Joseph <anoobj@marvell.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [EXT] [PATCH 1/3] drivers/crypto: remove unused element from device operations
2020-03-10 16:35 ` [dpdk-dev] [EXT] " Anoob Joseph
@ 2020-03-25 19:08 ` Akhil Goyal
0 siblings, 0 replies; 11+ messages in thread
From: Akhil Goyal @ 2020-03-25 19:08 UTC (permalink / raw)
To: Anoob Joseph, Artur Trybula, dev, pablo.de.lara.guarch,
declan.doherty, ruifeng.wang, Gagandeep Singh, ravi1.kumar, tdu,
fiona.trahe, roy.fan.zhang, jianjay.zhou, Shally Verma
>
> > This commit removes unused function pointer (queue_pair_count) from
> > rte_cryptodev_ops objects. Related functions removed as well.
> >
> > Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
>
> Acked-by: Anoob Joseph <anoobj@marvell.com>
Series applied to dpdk-next-crypto
Thanks.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-03-25 19:08 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-06 11:16 [dpdk-dev] [PATCH 1/3] drivers/crypto: remove unused element from device operations Artur Trybula
2020-03-06 11:16 ` [dpdk-dev] [PATCH 2/3] cryptodev: " Artur Trybula
2020-03-09 5:45 ` Ruifeng Wang
2020-03-10 11:06 ` Trahe, Fiona
2020-03-10 16:37 ` [dpdk-dev] [EXT] " Anoob Joseph
2020-03-06 11:16 ` [dpdk-dev] [PATCH 3/3] compressdef: remove unused function pointer prototype Artur Trybula
2020-03-09 5:50 ` Ruifeng Wang
2020-03-09 5:45 ` [dpdk-dev] [PATCH 1/3] drivers/crypto: remove unused element from device operations Ruifeng Wang
2020-03-10 11:05 ` Trahe, Fiona
2020-03-10 16:35 ` [dpdk-dev] [EXT] " Anoob Joseph
2020-03-25 19:08 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).