DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Ruifeng Wang (Arm Technology China)" <Ruifeng.Wang@arm.com>
To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
	Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
	"konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH 4/7] test/rcu: use size_t instead of int
Date: Mon, 9 Sep 2019 15:16:43 +0000	[thread overview]
Message-ID: <AM0PR08MB39868347176384B5B58939739EB70@AM0PR08MB3986.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20190908224949.34851-5-honnappa.nagarahalli@arm.com>


> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Honnappa Nagarahalli
> Sent: Monday, September 9, 2019 06:50
> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>;
> konstantin.ananyev@intel.com
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH 4/7] test/rcu: use size_t instead of int
> 
> Variables used to store the return value of rte_rcu_qsbr_get_memsize in
> variables of type 'int'. The variables are of type 'size_t' now.
> 
> Fixes: b87089b0bb19 ("test/rcu: add API and functional tests")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> ---
>  app/test/test_rcu_qsbr_perf.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/app/test/test_rcu_qsbr_perf.c b/app/test/test_rcu_qsbr_perf.c
> index cb2d177b7..e0598614c 100644
> --- a/app/test/test_rcu_qsbr_perf.c
> +++ b/app/test/test_rcu_qsbr_perf.c
> @@ -125,7 +125,7 @@ test_rcu_qsbr_writer_perf(void *arg)  static int
>  test_rcu_qsbr_perf(void)
>  {
> -	int sz;
> +	size_t sz;
>  	unsigned int i, tmp_num_cores;
> 
>  	writer_done = 0;
> @@ -188,7 +188,7 @@ test_rcu_qsbr_perf(void)  static int
>  test_rcu_qsbr_rperf(void)
>  {
> -	int sz;
> +	size_t sz;
>  	unsigned int i, tmp_num_cores;
> 
>  	rte_atomic64_clear(&updates);
> @@ -234,7 +234,7 @@ test_rcu_qsbr_rperf(void)  static int
>  test_rcu_qsbr_wperf(void)
>  {
> -	int sz;
> +	size_t sz;
>  	unsigned int i;
> 
>  	rte_atomic64_clear(&checks);
> @@ -379,7 +379,7 @@ static int
>  test_rcu_qsbr_sw_sv_1qs(void)
>  {
>  	uint64_t token, begin, cycles;
> -	int sz;
> +	size_t sz;
>  	unsigned int i, j, tmp_num_cores;
>  	int32_t pos;
> 
> --
> 2.17.1

The same change is needed by test_rcu_qsbr_sw_sv_1qs_non_blocking.
And there are another 2 occurrences in test_rcu_qsbr.c.
Thanks.

  reply	other threads:[~2019-09-09 15:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-08 22:49 [dpdk-dev] [PATCH 0/7] typo, doc, simple fixes and some optimizations Honnappa Nagarahalli
2019-09-08 22:49 ` [dpdk-dev] [PATCH 1/7] doc/rcu: fix typos Honnappa Nagarahalli
2019-09-08 22:49 ` [dpdk-dev] [PATCH 2/7] doc/rcu: correct the limitation on number of threads Honnappa Nagarahalli
2019-09-08 22:49 ` [dpdk-dev] [PATCH 3/7] doc/rcu: add information about storing token and resource Honnappa Nagarahalli
2019-09-08 22:49 ` [dpdk-dev] [PATCH 4/7] test/rcu: use size_t instead of int Honnappa Nagarahalli
2019-09-09 15:16   ` Ruifeng Wang (Arm Technology China) [this message]
2019-10-07 14:00     ` David Marchand
2019-09-08 22:49 ` [dpdk-dev] [PATCH 5/7] test/rcu: use correct nomenclature while printing results Honnappa Nagarahalli
2019-09-08 22:49 ` [dpdk-dev] [PATCH 6/7] lib/rcu: add least acknowledged token optimization Honnappa Nagarahalli
2019-09-08 22:49 ` [dpdk-dev] [PATCH 7/7] lib/rcu: update QS only when there are updates from writer Honnappa Nagarahalli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM0PR08MB39868347176384B5B58939739EB70@AM0PR08MB3986.eurprd08.prod.outlook.com \
    --to=ruifeng.wang@arm.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=nd@arm.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).