[dpdk-dev] [PATCH] ci: fix telemetry dependency in Travis

[dpdk-dev] [PATCH] ci: fix telemetry dependency in Travis

[juraj.linkes]

From: "juraj.linkes" <juraj.linkes@pantheon.tech>

libjansson4 is not enough to build telemetry. Replace it with
libjansson-dev.

Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index fd4f79cfc..2d2292ff6 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -15,7 +15,7 @@ addons:
     update: true
     packages: &required_packages
       - [libnuma-dev, python3-setuptools, python3-wheel, python3-pip, ninja-build]
-      - [libbsd-dev, libpcap-dev, libibverbs-dev, libcrypto++-dev, libfdt-dev, libjansson4]
+      - [libbsd-dev, libpcap-dev, libibverbs-dev, libcrypto++-dev, libfdt-dev, libjansson-dev]
 
 _aarch64_packages: &aarch64_packages
   - *required_packages
-- 
2.11.0

Re: [dpdk-dev] [PATCH] ci: fix telemetry dependency in Travis

[Aaron Conole]

juraj.linkes@pantheon.tech writes:

> From: "juraj.linkes" <juraj.linkes@pantheon.tech>
>
> libjansson4 is not enough to build telemetry. Replace it with
> libjansson-dev.
>
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---

I see that earlier builds would print:

  =================
  Content Skipped
  =================

  libs:
	telemetry:	missing dependency "jansson"


But with this patch, I see that telemetry is included in the built libs.

Thanks for the catch.

Acked-by: Aaron Conole <aconole@redhat.com>

Re: [dpdk-dev] [PATCH] ci: fix telemetry dependency in Travis

[Ruifeng Wang]

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of
> juraj.linkes@pantheon.tech
> Sent: Friday, April 3, 2020 8:46 PM
> To: aconole@redhat.com; maicolgabriel@hotmail.com
> Cc: dev@dpdk.org; juraj.linkes <juraj.linkes@pantheon.tech>
> Subject: [dpdk-dev] [PATCH] ci: fix telemetry dependency in Travis
> 
> From: "juraj.linkes" <juraj.linkes@pantheon.tech>
> 
> libjansson4 is not enough to build telemetry. Replace it with libjansson-dev.
> 
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---
>  .travis.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index fd4f79cfc..2d2292ff6 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -15,7 +15,7 @@ addons:
>      update: true
>      packages: &required_packages
>        - [libnuma-dev, python3-setuptools, python3-wheel, python3-pip, ninja-
> build]
> -      - [libbsd-dev, libpcap-dev, libibverbs-dev, libcrypto++-dev, libfdt-dev,
> libjansson4]
> +      - [libbsd-dev, libpcap-dev, libibverbs-dev, libcrypto++-dev,
> + libfdt-dev, libjansson-dev]
> 
>  _aarch64_packages: &aarch64_packages
>    - *required_packages
> --
> 2.11.0

Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>

[dpdk-dev] [PATCH v2] ci: fix telemetry dependency in Travis

[Juraj Linkeš]

libjansson4 is not enough to build telemetry. Replace it with
libjansson-dev.

Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
---
 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index fd4f79cfc..2d2292ff6 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -15,7 +15,7 @@ addons:
     update: true
     packages: &required_packages
       - [libnuma-dev, python3-setuptools, python3-wheel, python3-pip, ninja-build]
-      - [libbsd-dev, libpcap-dev, libibverbs-dev, libcrypto++-dev, libfdt-dev, libjansson4]
+      - [libbsd-dev, libpcap-dev, libibverbs-dev, libcrypto++-dev, libfdt-dev, libjansson-dev]
 
 _aarch64_packages: &aarch64_packages
   - *required_packages
-- 
2.11.0
v2:
* Fix sender to match signoff

Re: [dpdk-dev] [PATCH v2] ci: fix telemetry dependency in Travis

[Aaron Conole]

Juraj Linkeš <juraj.linkes@pantheon.tech> writes:

> libjansson4 is not enough to build telemetry. Replace it with
> libjansson-dev.
>
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> ---

Acked-by: Aaron Conole <aconole@redhat.com>

Re: [dpdk-dev] [PATCH v2] ci: fix telemetry dependency in Travis

[David Marchand]

Hello,

On Wed, Apr 8, 2020 at 2:49 PM Juraj Linkeš <juraj.linkes@pantheon.tech> wrote:
>
> libjansson4 is not enough to build telemetry. Replace it with
> libjansson-dev.

Thanks for the patch Juraj.
Just a little comment, for the v2, there was no significant change and
you could have kept Aaron and Ruifeng review tags.


I just want others' opinion, since there is a work on removing the
dependency on libjansson for telemetry.

This current patch is a fix for the CI, that could be worth
backporting to 19.11.
Hence I am for taking it in master.
Then when the telemetry rework is merged, this rework will remove the
dependency.


-- 
David Marchand

Re: [dpdk-dev] [PATCH v2] ci: fix telemetry dependency in Travis

[Bruce Richardson]

On Thu, Apr 09, 2020 at 10:00:51AM +0200, David Marchand wrote:
> Hello,
> 
> On Wed, Apr 8, 2020 at 2:49 PM Juraj Linkeš <juraj.linkes@pantheon.tech> wrote:
> >
> > libjansson4 is not enough to build telemetry. Replace it with
> > libjansson-dev.
> 
> Thanks for the patch Juraj.
> Just a little comment, for the v2, there was no significant change and
> you could have kept Aaron and Ruifeng review tags.
> 
> 
> I just want others' opinion, since there is a work on removing the
> dependency on libjansson for telemetry.
> 
That would be an end-goal but we are not fully there yet. Even with the
rework some parts of the library for legacy compatibility still depend on
jansson, though the majority of the code will compile without it. Therefore
this dependency should be kept in the CI beyond this release, as we weren't
planning on doing the additional work to completely replace it - though we
can re-evaluate that if people think that it's important to remove the
dependency completely.

/Bruce

Re: [dpdk-dev] [PATCH v2] ci: fix telemetry dependency in Travis

[David Marchand]

On Thu, Apr 9, 2020 at 11:24 AM Bruce Richardson
<bruce.richardson@intel.com> wrote:
> On Thu, Apr 09, 2020 at 10:00:51AM +0200, David Marchand wrote:
> > I just want others' opinion, since there is a work on removing the
> > dependency on libjansson for telemetry.
> >
> That would be an end-goal but we are not fully there yet. Even with the
> rework some parts of the library for legacy compatibility still depend on
> jansson, though the majority of the code will compile without it. Therefore
> this dependency should be kept in the CI beyond this release, as we weren't
> planning on doing the additional work to completely replace it - though we
> can re-evaluate that if people think that it's important to remove the
> dependency completely.

Ok, thanks for the clarification Bruce.
I will go with this patch.


-- 
David Marchand

Re: [dpdk-dev] [PATCH v2] ci: fix telemetry dependency in Travis

[David Marchand]

On Wed, Apr 8, 2020 at 2:49 PM Juraj Linkeš <juraj.linkes@pantheon.tech> wrote:
> libjansson4 is not enough to build telemetry. Replace it with
> libjansson-dev.

Fixes: 99889bd85228 ("ci: introduce Travis builds for GitHub repositories")
Cc: stable@dpdk.org

> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>

Acked-by: Aaron Conole <aconole@redhat.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>


Applied, thanks.

-- 
David Marchand