From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C47AA2EEB for ; Tue, 10 Sep 2019 11:56:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BBFCE1E554; Tue, 10 Sep 2019 11:56:51 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00061.outbound.protection.outlook.com [40.107.0.61]) by dpdk.org (Postfix) with ESMTP id 77B5E2C30 for ; Tue, 10 Sep 2019 11:56:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gs7wHnnboWjC2++2rC0jzvLIezKMr7cxQiI1sIEKbHQ=; b=INPiYwluZHEd/MWDvIT0DpuCleT19Rgn1tDKKsDoOkifcZSUC1uEvVAnv6MYV1wZx14K+vK1AcLI4Uih2XbNQTwqQulEX48At3rc7PzfF+Ws71WKxIJkxiXMpm42EStftIxhDnvDfBmzzGgp3oaWo2S6fIyfPK4zCc2nZqxPi1Y= Received: from HE1PR08CA0069.eurprd08.prod.outlook.com (2603:10a6:7:2a::40) by AM0PR08MB3860.eurprd08.prod.outlook.com (2603:10a6:208:10b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.18; Tue, 10 Sep 2019 09:56:45 +0000 Received: from AM5EUR03FT051.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::201) by HE1PR08CA0069.outlook.office365.com (2603:10a6:7:2a::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.13 via Frontend Transport; Tue, 10 Sep 2019 09:56:45 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT051.mail.protection.outlook.com (10.152.16.246) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.14 via Frontend Transport; Tue, 10 Sep 2019 09:56:43 +0000 Received: ("Tessian outbound 32e58c90c37b:v28"); Tue, 10 Sep 2019 09:56:41 +0000 X-CR-MTA-TID: 64aa7808 Received: from d97bfb5687c9.2 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.14.51]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3A985149-FE5F-4F44-93F0-5CE6A3156333.1; Tue, 10 Sep 2019 09:56:36 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2051.outbound.protection.outlook.com [104.47.14.51]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d97bfb5687c9.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 10 Sep 2019 09:56:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ym7z4AoiNXKb3piasA/Jkv5iOFHMuOh9sU9WQ6XjF7xrfaKNEIBHSp1IJMOCstuTfkhkt6tWQRt/y9V55AKPRSMqbnntddqsWbfKXltkbsIIWqzLiAwTU2DpUgN33hEoFIMs9xYH1f7JItRVuNSMXcJ4z0FmIhsa1UP6yQFwhp/cnw2RRFapPWsszplJjc5tyeRocsekBED7uDm4An8FlP91wdYeXdA5QXIFMwh1nCpUxC0RhdxX85Q8+2bp9uMs/cECPviPrHCQtUKMth7IvWjQvk6yyOF/8RZ2vVQijwfy1ScjrxymjKSybugZaMeC/t9Wkmgl3LTnwjcAjL+RYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gs7wHnnboWjC2++2rC0jzvLIezKMr7cxQiI1sIEKbHQ=; b=X5SYXDhkAwcubvzHNoMWt7g/4AFFAJXFzaD5VIqm8blZvU1a8l3mNfsxCDxk3X2kKw9xq//Kb0YS2suLdiqn4EnTsKQnvthDgT/yeGkj9tJgZeECo6uiYhHcwVJjzaARs49+Jaia9JnykgJJX/e5jL/BgXadRs1+JEVgSD4XjoCHKJMgOGNzB0aPbbeEmmjM3FnmO7kAgF1+VK7e7nxlOnSFIkvNg3v9lBH40kK+2e09Bik9WNTZmIHw4J9SZErXIceRDf5/uWlZ8GYjEQ2GrrgWsKbTel2/Bb1ClEc1ubEcALaMc/qA/NXOmRVXq6gQ4NAUKfowmmLcVuM4JU+rwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gs7wHnnboWjC2++2rC0jzvLIezKMr7cxQiI1sIEKbHQ=; b=INPiYwluZHEd/MWDvIT0DpuCleT19Rgn1tDKKsDoOkifcZSUC1uEvVAnv6MYV1wZx14K+vK1AcLI4Uih2XbNQTwqQulEX48At3rc7PzfF+Ws71WKxIJkxiXMpm42EStftIxhDnvDfBmzzGgp3oaWo2S6fIyfPK4zCc2nZqxPi1Y= Received: from AM0PR08MB3986.eurprd08.prod.outlook.com (20.178.118.90) by AM0PR08MB3155.eurprd08.prod.outlook.com (52.134.90.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.18; Tue, 10 Sep 2019 09:56:33 +0000 Received: from AM0PR08MB3986.eurprd08.prod.outlook.com ([fe80::8194:f229:b0d2:b5df]) by AM0PR08MB3986.eurprd08.prod.outlook.com ([fe80::8194:f229:b0d2:b5df%7]) with mapi id 15.20.2263.005; Tue, 10 Sep 2019 09:56:33 +0000 From: "Ruifeng Wang (Arm Technology China)" To: "Ananyev, Konstantin" , "Kantecki, Tomasz" CC: "dev@dpdk.org" , "Gavin Hu (Arm Technology China)" , Honnappa Nagarahalli , nd , nd , nd Thread-Topic: [dpdk-dev] [PATCH 0/2] add lock-free mode for l3fwd Thread-Index: AQHVZJ2RE3+uO/G+WUmOLRh3JRpdcqcedEgAgAQfuaCAAhDKgIAABz/w Date: Tue, 10 Sep 2019 09:56:33 +0000 Message-ID: References: <20190906102615.36942-1-ruifeng.wang@arm.com> <2601191342CEEE43887BDE71AB977258019192657B@irsmsx105.ger.corp.intel.com> <2601191342CEEE43887BDE71AB977258019196218E@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB977258019196218E@irsmsx105.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 6a5e41da-5a8b-4692-a6f5-a67f91c6be35.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Ruifeng.Wang@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 5992fb1c-333d-4d08-628d-08d735d52f96 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam-Untrusted: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600166)(711020)(4605104)(1401327)(4618075)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:AM0PR08MB3155; X-MS-TrafficTypeDiagnostic: AM0PR08MB3155:|AM0PR08MB3155:|AM0PR08MB3860: X-MS-Exchange-PUrlCount: 1 x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:9508;OLM:9508; x-forefront-prvs: 01565FED4C X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(366004)(136003)(346002)(39860400002)(396003)(376002)(13464003)(189003)(199004)(3846002)(86362001)(76116006)(305945005)(7736002)(8676002)(81156014)(81166006)(8936002)(4326008)(64756008)(52536014)(74316002)(66446008)(5660300002)(14444005)(55016002)(6306002)(99286004)(256004)(9686003)(66476007)(6246003)(71190400001)(71200400001)(53936002)(25786009)(316002)(66946007)(66556008)(7696005)(478600001)(110136005)(54906003)(76176011)(102836004)(966005)(14454004)(6506007)(53546011)(186003)(26005)(446003)(11346002)(55236004)(486006)(476003)(229853002)(6436002)(33656002)(66066001)(2906002)(6116002)(32563001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR08MB3155; H:AM0PR08MB3986.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: 51FOO8x0AK6K4QzgEJaxj5S73RLjrwD7cORJgreV/Pz6O0B0oCPMumif/b/XSwp8BDcfW9A37UEJO7xRIoPwRqj5ehaX6Ck1QttHqNR0dgKzMJsRZJ4qfYT3kglYPF4u0vzyIRI92e+VvJXISdYKm5gEYoSa2ed6zZPkPTC1hZ6rIoZO4ieLIyJoBD4Qrq3kvpw12O0ON7mtpVfNqnLfBSi4BIuSE3e8lMT+Aa5dKSUFlFK1fQOM4K3QKpO6mTSeIMm3og9IPRgZniGHQMZvdam9aG82MbwGvgTbwE6sUL2p5Eyzumwpq3HwAQKrsDuBVIaZY2Zz0CLCW2xoaN+EAtiGbX9Lo0fvVxwRnFSQrOuC0lqcU/BU/OC0Bj5IIZvRSDxezJ1GbwgiXAbt4Rg9mwTK0Smjx579TRTEZEmj1TY= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3155 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Ruifeng.Wang@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT051.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(136003)(346002)(376002)(396003)(2980300002)(13464003)(199004)(189003)(26826003)(14444005)(126002)(229853002)(6506007)(53546011)(305945005)(316002)(478600001)(7736002)(22756006)(186003)(4326008)(3846002)(356004)(55016002)(99286004)(6246003)(76176011)(336012)(54906003)(33656002)(36906005)(8676002)(2906002)(97756001)(9686003)(7696005)(81156014)(81166006)(966005)(6306002)(8936002)(8746002)(76130400001)(70206006)(70586007)(446003)(86362001)(23726003)(6116002)(74316002)(110136005)(5660300002)(50466002)(14454004)(476003)(47776003)(63350400001)(102836004)(63370400001)(25786009)(26005)(46406003)(11346002)(52536014)(486006)(66066001)(32563001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR08MB3860; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; A:1; MX:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 01c6143d-face-4b1f-c4bf-08d735d5294f X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(710020)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM0PR08MB3860; NoDisclaimer: True X-Forefront-PRVS: 01565FED4C X-Microsoft-Antispam-Message-Info: shJelcNSOvjSl0QAtGeUWSVbhxv4CD3cIKRvOyGmjZciic1w/EvzHHJ6M2kjpm0Hm1K/ajVjZSnPlNCQjGxVjoGj9KeY0bkGGt+F5WgTbH3lrKBGlXosCruxk5wyENhLNHyCDm9ukfMx5fSIACZTvaiKdWgxOKx1qsmW6zf3fVgO7oRyZ5H6trP6BIbGXdb5VjWH05SJ/grdV5TlISxWfkCwr1q4n9c97PGqxB0Z4Vz2ZDdxEftiR7+VDVAQW/EfD0IGfCNk6omqXkJUJ3fVKDu39Au7us8LRvlt7TVXQk+rFJpv1s1i8/LzonYSEXtvslW7meD+HD5xYv9WWywv4IxA3kkGfcgEp3kD7Wz7OESFidDLDzluWQVqKRhWMswWdho+WuyxOHEwQdIQDQEq4JZMADbVAhWcoZ8MK39+hf4= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2019 09:56:43.8114 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5992fb1c-333d-4d08-628d-08d735d52f96 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3860 Subject: Re: [dpdk-dev] [PATCH 0/2] add lock-free mode for l3fwd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ananyev, Konstantin > Sent: Tuesday, September 10, 2019 17:06 > To: Ruifeng Wang (Arm Technology China) ; > Kantecki, Tomasz > Cc: dev@dpdk.org; Gavin Hu (Arm Technology China) ; > Honnappa Nagarahalli ; nd > ; nd > Subject: RE: [dpdk-dev] [PATCH 0/2] add lock-free mode for l3fwd >=20 >=20 >=20 > > > > > > > > > > > Lock-free mode is supported by hash library and LPM library. > > > > Now we add an option for l3fwd example to enable the lock-free mode= . > > > > Necessary preparation steps are added to use lock-free LPM mode. > > > > > > Can I ask about the purpose of these changes? > > > Right now in l3fwd both lpm and hash tables are static and hard-code= d. > > > we initialize them at startup and then just do read from them. > > > Do you plan to enhance l3fwd with ability to dynamically update > > > tables contents? > > > Though fir that we first have to get rid of hard-coded values (config= file or > so). > > > Konstantin > > > > > Thanks for your questions. > > Currently, we have no plan to enhance l3fwd with ability to dynamically > update table contents. > > Lock-free method is being integrated into Hash library and LPM > > library. Lock-free algorithms are not only about control plane > > (adding or deleting routes), they affect the data path performance as w= ell. > > Since l3fwd application is showcasing data path performance, we need > > to show the impact of including the quiescent state reporting on data p= ath. > > This change also serves as an example of using the RCU APIs. >=20 >=20 > But what you suggest doesn't provide the complete picture. > With dynamic updates in place (via control path) the data-path impact mig= ht > be completely different then without. > Again without dynamic updates how can you test that your data-path lock- > free approach does work as expected? > Also it can't even be used as a reference implementation for users, as ha= lf of > the functionality they need to implement is simply missing. > My opinion - we either need to leave l3fwd as it is (static routes), or > implement a proper control path with ability to dynamically update routes > before starting to introduce some synchronization schemes (RCU or > whatever). >=20 > Konstantin >=20 Agree that dynamic control path updates should be included for a whole pict= ure. I will add dynamic update to l3fwd and reroll the patch series. Thanks. > > > > > > > > > > Patch 2/2 has dependency on RCU QSBR integration with LPM library: > > > > http://patches.dpdk.org/project/dpdk/list/?series=3D6288 > > > > > > > > > > > > Ruifeng Wang (2): > > > > examples/l3fwd: add lock-free option for l3fwd > > > > examples/l3fwd: integrate RCU QSBR for LPM mode > > > > > > > > doc/guides/sample_app_ug/l3_forward.rst | 3 ++ > > > > examples/l3fwd/Makefile | 1 + > > > > examples/l3fwd/l3fwd.h | 4 +- > > > > examples/l3fwd/l3fwd_em.c | 10 +++- > > > > examples/l3fwd/l3fwd_lpm.c | 72 > +++++++++++++++++++++++-- > > > > examples/l3fwd/main.c | 27 ++++++++-- > > > > examples/l3fwd/meson.build | 1 + > > > > 7 files changed, 108 insertions(+), 10 deletions(-) > > > > > > > > -- > > > > 2.17.1