From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C999CA2EEB for ; Wed, 11 Sep 2019 08:18:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A5CF61EB34; Wed, 11 Sep 2019 08:18:29 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10069.outbound.protection.outlook.com [40.107.1.69]) by dpdk.org (Postfix) with ESMTP id E06CC1EAC9 for ; Wed, 11 Sep 2019 08:18:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VA8a5/wKBtLm0WSDT9Fl9wDl7m57hI7fix5l9hglbQE=; b=cLsGwSJe0S+n1s4qPzQeM8BSfDcKqiNAgsLJgK+9bH1IJhNJoQHb1XJ5eDAbTY4Qh5XfRc8s/9Rwo0OtZDByHJfd/kk9ec3ogiy3xG125X2rB8DFcp0XV7uwVSm4BYs7hM3qY4+UUUA7i7rVw8uyeCxVE8gmhMOqnSetvhdcjPo= Received: from VI1PR08CA0195.eurprd08.prod.outlook.com (2603:10a6:800:d2::25) by AM0PR08MB3217.eurprd08.prod.outlook.com (2603:10a6:208:5e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.15; Wed, 11 Sep 2019 06:18:25 +0000 Received: from DB5EUR03FT053.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e0a::206) by VI1PR08CA0195.outlook.office365.com (2603:10a6:800:d2::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.15 via Frontend Transport; Wed, 11 Sep 2019 06:18:24 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dpdk.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dpdk.org; dmarc=none action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT053.mail.protection.outlook.com (10.152.21.119) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.14 via Frontend Transport; Wed, 11 Sep 2019 06:18:23 +0000 Received: ("Tessian outbound 6ca4f653aa3e:v29"); Wed, 11 Sep 2019 06:18:21 +0000 X-CR-MTA-TID: 64aa7808 Received: from 574536e4543e.2 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.5.56]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8F83D3C9-08AD-4ECE-A287-E13CBBCEC330.1; Wed, 11 Sep 2019 06:18:16 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-he1eur02lp2056.outbound.protection.outlook.com [104.47.5.56]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 574536e4543e.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384); Wed, 11 Sep 2019 06:18:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BFt5ySlNOZnMcSzZbkIAXsHq2IxDbm+hDeRBuj0c0ESi/SiDt2/prk3jsbAuUu106vVaiiG7DcGlcKKNJvYklBf4m63NOGvBuVpdEVs3hffCQUBBYt43Cs38ofgkYSwX962z5e+lvKRtUsSau9jwQYs8Z8jUfFQv+sq4i5zyuN2omPorvh/NqcfJm9SGHZ2drXUQrEg/Soz/GhNM5nGwyeJsZNDStoO2Yjx3FDUnsw7DskyQc7QWjED9nv81SVGGWrPfuNhPvx0IDPW22myjwgNVayqn+kEkSTC71Ms0ju+jbYJdU3I+etDqij5T9uS0zSUiVXpc0P7/Vj5U9dMGDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VA8a5/wKBtLm0WSDT9Fl9wDl7m57hI7fix5l9hglbQE=; b=a/lRk9qp7ezDBPT+szQpDFXP3FQG6U2AKqKo7WuI/tK1ObSiJ0Yzx9JSoRnLFjN+M1vFZa/ZdDsv+9KKpPQIjRCCVcohIJVKkPG0HLnanht2riwln8AC3C+F8/pfgX2D9gEDChKT5HsPpheYYZA57abO36m3m4WCAjYnLp/0Hvrm5j1v0M/pUduN/EThHteZEfGXbeY6dy+twgqC7dFNPF3n9n5x6uIjk+i8fJ++ITYwn38RL5gAcPvCe834a++SntsS34kUTtdsqpqZcb9egfqed/kPeYxJgbRRkrnRoM/CrYPh2H71D7dq/qSevcdnx8YoWBBUXZ6UUTPaQ+tESw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VA8a5/wKBtLm0WSDT9Fl9wDl7m57hI7fix5l9hglbQE=; b=cLsGwSJe0S+n1s4qPzQeM8BSfDcKqiNAgsLJgK+9bH1IJhNJoQHb1XJ5eDAbTY4Qh5XfRc8s/9Rwo0OtZDByHJfd/kk9ec3ogiy3xG125X2rB8DFcp0XV7uwVSm4BYs7hM3qY4+UUUA7i7rVw8uyeCxVE8gmhMOqnSetvhdcjPo= Received: from AM0PR08MB3986.eurprd08.prod.outlook.com (20.178.118.90) by AM0PR08MB4291.eurprd08.prod.outlook.com (20.179.33.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.15; Wed, 11 Sep 2019 06:18:11 +0000 Received: from AM0PR08MB3986.eurprd08.prod.outlook.com ([fe80::8194:f229:b0d2:b5df]) by AM0PR08MB3986.eurprd08.prod.outlook.com ([fe80::8194:f229:b0d2:b5df%7]) with mapi id 15.20.2263.015; Wed, 11 Sep 2019 06:18:11 +0000 From: "Ruifeng Wang (Arm Technology China)" To: Honnappa Nagarahalli , "Ananyev, Konstantin" , "Kantecki, Tomasz" CC: "dev@dpdk.org" , "Gavin Hu (Arm Technology China)" , nd , nd , nd Thread-Topic: [dpdk-dev] [PATCH 0/2] add lock-free mode for l3fwd Thread-Index: AQHVZJ2RE3+uO/G+WUmOLRh3JRpdcqcedEgAgAQfuaCAAWM+AIAAcrAwgAGRcQCAAAlwUA== Date: Wed, 11 Sep 2019 06:18:11 +0000 Message-ID: References: <20190906102615.36942-1-ruifeng.wang@arm.com> <2601191342CEEE43887BDE71AB977258019192657B@irsmsx105.ger.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 43f95d5c-dcc1-4c7f-b451-d6676de0b277.0 x-checkrecipientchecked: true Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=Ruifeng.Wang@arm.com; x-originating-ip: [113.29.88.7] x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: a0e3367d-627c-4488-adad-08d7367fd993 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam-Untrusted: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM0PR08MB4291; X-MS-TrafficTypeDiagnostic: AM0PR08MB4291:|AM0PR08MB4291:|AM0PR08MB3217: X-MS-Exchange-PUrlCount: 2 x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:10000;OLM:10000; x-forefront-prvs: 0157DEB61B X-Forefront-Antispam-Report-Untrusted: SFV:NSPM; SFS:(10009020)(4636009)(136003)(346002)(39860400002)(396003)(376002)(366004)(13464003)(189003)(199004)(229853002)(52536014)(186003)(26005)(478600001)(2906002)(66066001)(54906003)(14444005)(256004)(316002)(110136005)(6116002)(53546011)(55236004)(14454004)(3846002)(5660300002)(6506007)(6436002)(102836004)(966005)(486006)(71200400001)(476003)(66556008)(64756008)(66446008)(11346002)(7696005)(66946007)(76116006)(76176011)(71190400001)(25786009)(86362001)(446003)(9686003)(6306002)(99286004)(4326008)(66476007)(81166006)(53936002)(33656002)(7736002)(305945005)(55016002)(8676002)(8936002)(74316002)(81156014)(6246003)(32563001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR08MB4291; H:AM0PR08MB3986.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info-Original: 4I+Zs1+Ibi3mssA6DHzQOeHWqwLbw1hO7GiOffL27oOWyspnFc1v+foXAjpgqwVk+HifVPMeZ8VCHCVlnqBh7uWni78F/Hr+LgDHeshPIdJSVJdXne9yiBbiMUDpczwowcg62lBGhA7yGLW4Sr3F+2IHXUcVR5YaF9GwE9by17h4o9206swv/jkFWXWmbe3VROV82mk7QIJIQN54Kkmous2ohBitn1qkmOGVCPsWQBhiwrAAVbhLzec5jGY8NcMBjl2CpGxMlp9MwjA1Ia6eoFpqrzCuh2UijHYdH+XEBL1NiB1Aoh3mmsBfUBpofZ+el7//ou1ORilk9BvXJ+OOmG+zv+NO1bLOQWq8RWqM5Hmga7JkOq0TZ9oIw19G44T3rSNYpFwZ42kgEhEqfhlS0glbaKXna16Lgkfjj4F88Fk= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4291 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Ruifeng.Wang@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT053.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123; IPV:CAL; SCL:-1; CTRY:IE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(376002)(136003)(396003)(346002)(13464003)(189003)(199004)(7736002)(97756001)(110136005)(54906003)(2906002)(23726003)(74316002)(14454004)(8676002)(33656002)(3846002)(50466002)(14444005)(966005)(305945005)(6116002)(356004)(81166006)(8746002)(26826003)(8936002)(7696005)(76130400001)(4326008)(81156014)(478600001)(70586007)(70206006)(6506007)(53546011)(52536014)(9686003)(25786009)(5660300002)(55016002)(6306002)(22756006)(66066001)(47776003)(316002)(11346002)(102836004)(446003)(6246003)(76176011)(86362001)(336012)(63350400001)(476003)(486006)(126002)(99286004)(46406003)(229853002)(26005)(186003)(32563001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR08MB3217; H:64aa7808-outbound-1.mta.getcheckrecipient.com; FPR:; SPF:TempError; LANG:en; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; MX:1; A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: 46c966e7-6939-47a0-0bc8-08d7367fd22f X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600166)(710020)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM0PR08MB3217; NoDisclaimer: True X-Forefront-PRVS: 0157DEB61B X-Microsoft-Antispam-Message-Info: TAFWfPe8ogQMvmZT7iCjXuQo6nTa7VGFEolcsy9xpy2dl1qlcPTEb/xgfmjdOkcr2QAED4bxYQ9VBkmWqi+QWvn5/NbLD/dEyORfArOoQQ9ZkMpeGZmqkNmpDE4tY3trfaYdutwhGFcAOy+T7BF2qjWK0m3m9YAyz213Q3EBStf0CXoC087orG6B+/4AMyojr4QdNoX11aLEMp8Rx1GGNIdnMUE83XA1AJMd/iYsRPMcww4iIRFJMQUDJ7euF4EE4AYR64uG/hK0eulA6K5nrXaQvd16W+BhyjApaoi7QtTLliNeDJ2X2yMkamtiuYMktmPpsyk+fd/5nf/iA3DasOrSVIUzK/PL+oF83cjlFXTtud4ny/IaxX9ejUcppRrmxes3iJr//DQdLvr2Co1PUcQJ6zrXdukuGBGvKEjztiQ= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Sep 2019 06:18:23.4764 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a0e3367d-627c-4488-adad-08d7367fd993 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3217 Subject: Re: [dpdk-dev] [PATCH 0/2] add lock-free mode for l3fwd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Honnappa Nagarahalli > Sent: Wednesday, September 11, 2019 13:33 > To: Ruifeng Wang (Arm Technology China) ; > Ananyev, Konstantin ; Kantecki, Tomasz > > Cc: dev@dpdk.org; Gavin Hu (Arm Technology China) ; > nd ; nd > Subject: RE: [dpdk-dev] [PATCH 0/2] add lock-free mode for l3fwd >=20 > > > > > > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > > Lock-free mode is supported by hash library and LPM library. > > > > > > Now we add an option for l3fwd example to enable the lock-free > > mode. > > > > > > Necessary preparation steps are added to use lock-free LPM mode= . > > > > > > > > > > Can I ask about the purpose of these changes? > > > > > Right now in l3fwd both lpm and hash tables are static and hard- > coded. > > > > > we initialize them at startup and then just do read from them. > > > > > Do you plan to enhance l3fwd with ability to dynamically update > > > > > tables contents? > > > > > Though fir that we first have to get rid of hard-coded values > > > > > (config file or > > > > so). > > > > > Konstantin > > > > > > > > > Thanks for your questions. > > > > Currently, we have no plan to enhance l3fwd with ability to > > > > dynamically update table contents. > > > > Lock-free method is being integrated into Hash library and LPM > > > > library. Lock- free algorithms are not only about control plane > > > > (adding or deleting routes), they affect the data path performance = as > well. > > > > Since l3fwd application is showcasing data path performance, we > > > > need to show the impact of including the quiescent state reporting > > > > on data > > path. > > > > This change also serves as an example of using the RCU APIs. > > > > > > > Without the dynamic deletes the quiescent state reporting overhead > > > is not captured completely. > > > I suggest that we add and delete a small set of unrelated routes > > > (the routes that are not used currently) on a regular basis. > > > > > Add and delete unrelated routes on a regular basis will simulate > > overhead on control path. However, control path performance is not a > > l3fwd showcase, and it is covered by LPM performance unit test. > > On data path, quiescent state reporting overhead is constant (calling > > of rte_rcu_qsbr_quiescent). > > It will not be impacted by route addition / deletion. > The recent changes to RCU [1] are such that the reader threads avoid a wr= ite > if there are no deletes. So, without the deletion, the impact on readers = is > complete. >=20 > [1] https://patchwork.dpdk.org/patch/58961/ OK, understand that.=20 Assumptions based on current implementation of rte_rcu_qsbr_quiescent is no= t reliable.=20 The part on control path will be added. > > > > > > > > > > > > > > Patch 2/2 has dependency on RCU QSBR integration with LPM > library: > > > > > > http://patches.dpdk.org/project/dpdk/list/?series=3D6288 > > > > > > > > > > > > > > > > > > Ruifeng Wang (2): > > > > > > examples/l3fwd: add lock-free option for l3fwd > > > > > > examples/l3fwd: integrate RCU QSBR for LPM mode > > > > > > > > > > > > doc/guides/sample_app_ug/l3_forward.rst | 3 ++ > > > > > > examples/l3fwd/Makefile | 1 + > > > > > > examples/l3fwd/l3fwd.h | 4 +- > > > > > > examples/l3fwd/l3fwd_em.c | 10 +++- > > > > > > examples/l3fwd/l3fwd_lpm.c | 72 > > > +++++++++++++++++++++++-- > > > > > > examples/l3fwd/main.c | 27 ++++++++-- > > > > > > examples/l3fwd/meson.build | 1 + > > > > > > 7 files changed, 108 insertions(+), 10 deletions(-) > > > > > > > > > > > > -- > > > > > > 2.17.1 > > > > > > > > > >=20