From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE96844043; Thu, 16 May 2024 20:30:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 698B2402F2; Thu, 16 May 2024 20:30:56 +0200 (CEST) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2075.outbound.protection.outlook.com [40.107.6.75]) by mails.dpdk.org (Postfix) with ESMTP id 92D4E40261 for ; Thu, 16 May 2024 20:30:54 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=maQy8gC3esgFOHZfYigk1yYPBZsCawQYGyblHua5/M3NxFK5v2NpkpsA/v/tmUX43lPXYOB3GS2RTBWDoyhNhHA7e2ZyEdAv4tUmoLoO10nw2bw7Y6qScV43TI7lnyZHmKbuWmhwoPoWEuE6EG155voPmoS1Snx6agsiWB4hmH+/k/xcBT4bo5l+yQuEcgJkmOaAGkaKBzYK9s+h1N27iUEAomU56yA0PWNVc3ibBSXBq/+LPtIaBkjhe3iKlvwISEAUBqEjivgO356JoSR46I/9c6ADUuakOak6K50+ceXKtPiuTHSkCyxTfuuJib+xOc/V5CZGh5lMt5I/PfySkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dFVxPsY2zd8LYHGWYFDW6kP9JsshWRkSrPP4i93W3ig=; b=Tox17biObfDxoDHAGebN79LaSpoRz7wu8ES/mE0TcO02u9Mz+DFM8lBbS1+33w6XeJJnRS1Owrz7tuHbWTAFVxOl+xbJyqkbIVE+Guadp4lxReVRV4DRkRIsPfMUVoD6SGqwhtL+mW6EQYQh0KtltOG6dimgg1kMuHa5dPMKq0eLhBRLpeP35yhSeHEbYUJiW2mVUAst8PV0kOU3TtajyjRLMcgw0fsrHHfgYUcCslVsCWRJQj9UGkgGG3OqiySAD8lSQ5oz5Mmy6JH07WKUBc7bPvKtQUhEiZRuQR8/WeKitHCoSZx+9RWYbnurh15OM5kGLJvIctQQ98rODw0oiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dFVxPsY2zd8LYHGWYFDW6kP9JsshWRkSrPP4i93W3ig=; b=NLr03633wg1jNVPdZhQTdYIPIdCBFxPjEmz1rw/M1Jq5x66Yy3bBDZR92/3LFC6N7Qx2XytaAAQakkwk+BI3x5t6PudkSiw7DZmnIOoKHngGFlW05NYY5I8uukxHP1ecMfGrXVJJrFKk7XFUluh5CTmUYWhXDkDltD/wpOGD+sA= Received: from AM0PR08MB5073.eurprd08.prod.outlook.com (2603:10a6:208:15c::27) by GV2PR08MB9400.eurprd08.prod.outlook.com (2603:10a6:150:dd::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.27; Thu, 16 May 2024 18:30:52 +0000 Received: from AM0PR08MB5073.eurprd08.prod.outlook.com ([fe80::6eb8:f4fd:f86d:a8d0]) by AM0PR08MB5073.eurprd08.prod.outlook.com ([fe80::6eb8:f4fd:f86d:a8d0%2]) with mapi id 15.20.7587.028; Thu, 16 May 2024 18:30:52 +0000 From: Wathsala Wathawana Vithanage To: Stephen Hemminger , "dev@dpdk.org" CC: "thomas@monjalon.net" , Ferruh Yigit , Andrew Rybchenko , nd Subject: RE: [PATCH v5 2/9] ethdev: add common counters for statistics Thread-Topic: [PATCH v5 2/9] ethdev: add common counters for statistics Thread-Index: AQHap6fk86NhVCUFYUKpAEYYehlPKbGaLecw Date: Thu, 16 May 2024 18:30:52 +0000 Message-ID: References: <20240510050507.14381-1-stephen@networkplumber.org> <20240516154327.64104-1-stephen@networkplumber.org> <20240516154327.64104-3-stephen@networkplumber.org> In-Reply-To: <20240516154327.64104-3-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 3985D93F7B9D1E4184291DED472E8C81.0 x-checkrecipientchecked: true authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AM0PR08MB5073:EE_|GV2PR08MB9400:EE_ x-ms-office365-filtering-correlation-id: 5f96a687-8620-47f5-80fe-08dc75d6510a x-ld-processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr nodisclaimer: true x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230031|376005|366007|1800799015|38070700009; x-microsoft-antispam-message-info: =?us-ascii?Q?4vdeXU1WBjcg2iGWTl31WWbbzxoiUPdZZUscfJNKEaay4WhUoqAbqxhstPsW?= =?us-ascii?Q?YHYaLeI87aNDdm4fNHMRIX2fB38VVGuuItsY75iKGmEX7D955RKZrk6TJ2jr?= =?us-ascii?Q?Zlc6RfWmauaoVE7cmljjeFmZz4rVd2vZab1r3r8gVgekTlXfMSx7Ahg7bcYd?= =?us-ascii?Q?Nd7icfRKN40BXdXU1ORSjgP8k94BMJrtsRqt++cbHgrkzLsnxzmbAoWNN32h?= =?us-ascii?Q?gn0I/GcbtHsm2V+dLIL8K/L7JpKj+1EcC8QtoduFSLRVskUQGW12a9cRWahq?= =?us-ascii?Q?IWW8Au1NqqUwaIob8faCBRpZetmSV2A4u0xT6UQltgLApL+SyROhZMsRO5/1?= =?us-ascii?Q?KZgGoO96UyNg6AWSWFw+N/hj5RqvnRfrBxTZhIPIhwPjhIq8uI11XdLIbYHV?= =?us-ascii?Q?3SQ2yrf2eaPFlbDp2rVgnshpj7sho9YxAgc7c8O17FPUie4CZceYzx7AmhNy?= =?us-ascii?Q?uEgzGAImJChVfXnKu9zyUewwuVGpiuNHqORNVaCy87fjQdR+vAmgT/Tz401F?= =?us-ascii?Q?UIu9z76Uv+Kl81LU+YfxwaUCpTooszI4R9x3Tw5oHPuAbeFelbRpPGx5Y0xL?= =?us-ascii?Q?fyY8VECaHH9gC53CVMJ2y9MRKvsNGPfLFt8J72JrcEWmq2d/9q2ZswP7dl+d?= =?us-ascii?Q?czTqlrUBVudhD8ypzAFVpsTFgSPzkBCmveOCb2X9LzadIcby7JNfqMf1wIFb?= =?us-ascii?Q?tEqjQZ8KaifQD4GfQ0AhIIJAGRg5vWxfgSqehfuwwYqXGwd56gTtSTQdFkDa?= =?us-ascii?Q?DuobmX9SwN/PG6CdWba+sESAmmhNrKycQiOqSvhjbB6/pzqpcqrTtUrI6t5N?= =?us-ascii?Q?oDaGsJbaInp316y+wn+4pA5+Sq+5fRzZckfFe1IB4Rp7PsuVzUxJ/JSFI6C9?= =?us-ascii?Q?x9toANEz0arPs25l3YMtrbPn3uUEhUiW1Vaq8P2QoEN1sNLyKzvM0xHJynRa?= =?us-ascii?Q?wMkFLcxgMUls4luqHtGquniDUGhdqEkqhTLhOSKrXrBwVL5JDwAkGO93apMv?= =?us-ascii?Q?dfZhPWFYK+yVt91TvGfKtsPjw+oJ7PyvAMXBpRPcv2qvJcCoDIIKwxIzrY37?= =?us-ascii?Q?tzFlNPKjUBdaG8AEFSasW4BLS4EhSEDCY8FT8ESoJPIyoSJKJklrsmoRfQVX?= =?us-ascii?Q?Ag6Y+Eo0PlzDNA2EvoIYzsBSnZiL3FnLpXWIQ/j8FdJHXVaEoK9FgknK9oiz?= =?us-ascii?Q?OtG20L0+fKRolNRQv2b9sIp9tmotCO+WRObfsik+aqQCL6+OvxNSgYXzhw1Z?= =?us-ascii?Q?Gq9O4SPU2S7VP7nXnm4O0aTW+NGE3fUYNYCDgzK7P0oceQ8jQSgonodRb8Dv?= =?us-ascii?Q?XZ3EBu6gTqrQTOZQsgqQ/GLzxJaERrBzBiG54m9ne9Fy6A=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR08MB5073.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(1800799015)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HjruZ8ftEyzxZX/zVL6LtmiktR2+A/UsSbfXE+QkGcd9LMbAc6ZOSEgccojR?= =?us-ascii?Q?8h/bfKTLvcVkbbPieVdiidnbdZhpjRESXl0PB2Zyi4SdrAENuSpbjEgf/Wyn?= =?us-ascii?Q?yHbzIKmvdA7f9VX5Tjp7wspPWguc7/RKn/naSQTDjTPmw5aIRHwKWx1L/5K9?= =?us-ascii?Q?I98vEYV1OVkYPLLQ+Vjw3Kdc5wi6W8UdpoPKtp96eJzlsJEDAdY4UnEGLAQL?= =?us-ascii?Q?ROHSDmgEEj49Via2DOiGCX56dYRKujZ6o87wBG7UvaPdXZY5n/EBp/2fcaZo?= =?us-ascii?Q?auh2isTOTASRxNq5m142ETgVC4qVgtBn+BshrZGTUFRELURMkrCv7auAbIqt?= =?us-ascii?Q?u36etOzwHejJw6t1OVsR4olq9KrUnCh5LvBGeIQ4wWSFv0VurM+UvReLvImC?= =?us-ascii?Q?cwogOeGNBq4dq9pQEDV8LkqIxenLBCndo/W7V1bLndyvl+QhjKssVD4ZkIw0?= =?us-ascii?Q?8HYPjK+bfy4EVJUCPqMzIjt/xMYKCG+RJycPP5J1ypYXTB7hptCqAjweZJqf?= =?us-ascii?Q?Gvvg/+/EgTDNkbK35fUuScdy5JIUeLYutgeKLZzPTuN1MCVibuf2xGjwYgpv?= =?us-ascii?Q?lGwOXCZNuDZNBmjgDJ27vsI95pYOekzxaEV9j7xiwygBLJhc74JLc/2ntxsn?= =?us-ascii?Q?HjirbqHxuzsdYpdKWEzSgl7l3YNoWngoAE+9MYracnKZmn+Ly6jXmi2oSzBp?= =?us-ascii?Q?sE5mD3bZVBVs73+NwwL5BAeE+rdWioptupFWQf5N+1hns8DB9S+1/3ugv+CN?= =?us-ascii?Q?spByHPGwOcDVyr/+IdIVp32dyl4O1KCYL7j+H9nhUP63/5bvTG71f+pe4yQ5?= =?us-ascii?Q?QgMqwPAkDFojfF3FDt6oXppwqZTldTgFCUsOwHYKG/jj6Se+lT3bhP9Cm+rl?= =?us-ascii?Q?K9f+Ey/2xHSJctCC+2vdF901aKRfQYth3MuMPOKja3zMgoMVBn0y8p/8KtQG?= =?us-ascii?Q?bqZxsvlP8tbPvZy0pUaOUtdk3K1qO/IvNenhMHdLLP0iXiZdk0SvKb3fmATx?= =?us-ascii?Q?w4cPiavSgQCcIKUUv7nMxYfwbpkg6mvk89M5YsjjgQPwpFbcLRcRkvGNkAmO?= =?us-ascii?Q?jHbFFBxZzDRfA7ATxhIS2/1OkpuIg54QIF9KZp+NNeJWybWnMyMR+9c2up4g?= =?us-ascii?Q?Cgw8xyYhiY4QhVjvR2gymP6toPEWRu6cjFKPBtk5mc1z8RzIvoTrFRfa63Lp?= =?us-ascii?Q?7o4ntxPzOTU1pQw4Xrm0n0xc9pbfpoZYwUPQFwGGiFXYDnCr0cnM8a/w5D1R?= =?us-ascii?Q?UmtOiyu5reJZ+YvEDHUGOX9wb/s5feC94aMQCZPHQ5bGHK/T/zUBnUBv5DqE?= =?us-ascii?Q?sKMFFEcTEBEfbXtsAbQauTDAP8WSPVRlk6uKQMCtBuSZcOc4I55smTmuhyrO?= =?us-ascii?Q?jrqO6OffVDjopw4cwNDwuRCPpo6UmM5n1a5tw0pWLfeboaAyb5QTjQfgii1u?= =?us-ascii?Q?+A+z4YTaTzf42j6gLq7+VQ6Hu5BdCZNArhmPWTcfAcPb03jrmQ+ADurKmq6k?= =?us-ascii?Q?eZWLPvOMNG48WcvB88NzoAcijucv5VJrxaTrNNSQkttIiVnnulOGQNlxGy6E?= =?us-ascii?Q?is7MKpNho5HQJ8/at0Iz2YRR2ky6kvg4LdihQeNdJ7oEXBoTCzzhWT1IoVu/?= =?us-ascii?Q?Eg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM0PR08MB5073.eurprd08.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f96a687-8620-47f5-80fe-08dc75d6510a X-MS-Exchange-CrossTenant-originalarrivaltime: 16 May 2024 18:30:52.2463 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fcFiYPzLSyFdf6TWZq/9cgFlZl74/Rv57hWZabWMN+FFuQ60iexFnRObEtOqGRkQzRxX31Vrk2oyJAUYfwSU9LJqpsvLEl8pzyhxhekPC8g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9400 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > + packets =3D rte_counter64_fetch(&counters->packets); > + bytes =3D rte_counter64_fetch(&counters->bytes); > + errors =3D rte_counter64_fetch(&counters->errors); > + > + rte_compiler_barrier(); > + > + stats->ipackets +=3D packets; > + stats->ibytes +=3D bytes; > + stats->ierrors +=3D errors; > + there seems to be a dependency chain in the above loads and subsequent stor= es. If that's the case what's the purpose of the compiler barrier? --wathsala