From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Shreyansh Jain <shreyansh.jain@nxp.com>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Nipun Gupta <nipun.gupta@nxp.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] event/dpaa2: remove check on return value from epoll wait
Date: Wed, 9 May 2018 10:02:32 +0000 [thread overview]
Message-ID: <AM2PR04MB07531443D5E9FE28C045B98989990@AM2PR04MB0753.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20180509092053.5956-1-shreyansh.jain@nxp.com>
Subject: [PATCH 1/2] event/dpaa2: remove check on return value from epoll wait
Importance: High
From: Nipun Gupta <nipun.gupta@nxp.com>
Driver shouldn't take decision on signals received. The return from epoll was blocking on EINTR which is not the right use-case.
Fixes: 36d87bb92230 ("event/dpaa2: handle timeout using interrupts in dequeue")
Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
prev parent reply other threads:[~2018-05-09 10:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 9:20 Shreyansh Jain
2018-05-09 9:20 ` [dpdk-dev] [PATCH 2/2] event/dpaa2: Remove usage of link under evq_info_t structure Shreyansh Jain
2018-05-09 10:03 ` Hemant Agrawal
2018-05-09 10:51 ` Jerin Jacob
2018-05-09 10:02 ` Hemant Agrawal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM2PR04MB07531443D5E9FE28C045B98989990@AM2PR04MB0753.eurprd04.prod.outlook.com \
--to=hemant.agrawal@nxp.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=nipun.gupta@nxp.com \
--cc=shreyansh.jain@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).