From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"pbhagavatula@caviumnetworks.com"
<pbhagavatula@caviumnetworks.com>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] Revert "eal: fix default mempool ops"
Date: Thu, 1 Feb 2018 19:56:47 +0000 [thread overview]
Message-ID: <AM2PR04MB075328F278065579C22D31F189FA0@AM2PR04MB0753.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <1517514427-28843-1-git-send-email-hemant.agrawal@nxp.com>
Hi Pavan,
Your patch was breaking the design of the best_mempool_ops and the whole purpose of selection was getting lost.
I guess you were trying to fix test_mempool. I have sent another patch, which fixes that and start using the best mempool ops API
instead of default mempool ops API.
Regards,
Hemant
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hemant Agrawal
> Sent: Friday, February 02, 2018 1:17 AM
> To: olivier.matz@6wind.com; pbhagavatula@caviumnetworks.com
> Cc: thomas@monjalon.net; dev@dpdk.org
> Subject: [dpdk-dev] [PATCH 1/2] Revert "eal: fix default mempool ops"
>
> This reverts commit fe06cb6c54fe5ada299ebba40a382bee37c919f2.
> ---
> lib/librte_eal/bsdapp/eal/eal.c | 3 ---
> lib/librte_eal/linuxapp/eal/eal.c | 3 ---
> 2 files changed, 6 deletions(-)
>
> diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c
> index 1622a41..b612af0 100644
> --- a/lib/librte_eal/bsdapp/eal/eal.c
> +++ b/lib/librte_eal/bsdapp/eal/eal.c
> @@ -86,9 +86,6 @@ int rte_cycles_vmware_tsc_map; const char *
> rte_eal_mbuf_default_mempool_ops(void)
> {
> - if (internal_config.user_mbuf_pool_ops_name == NULL)
> - return RTE_MBUF_DEFAULT_MEMPOOL_OPS;
> -
> return internal_config.user_mbuf_pool_ops_name;
> }
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
> index 451fdaf..21024b4 100644
> --- a/lib/librte_eal/linuxapp/eal/eal.c
> +++ b/lib/librte_eal/linuxapp/eal/eal.c
> @@ -96,9 +96,6 @@ int rte_cycles_vmware_tsc_map; const char *
> rte_eal_mbuf_default_mempool_ops(void)
> {
> - if (internal_config.user_mbuf_pool_ops_name == NULL)
> - return RTE_MBUF_DEFAULT_MEMPOOL_OPS;
> -
> return internal_config.user_mbuf_pool_ops_name;
> }
>
> --
> 2.7.4
next prev parent reply other threads:[~2018-02-01 19:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 19:47 Hemant Agrawal
2018-02-01 19:47 ` [dpdk-dev] [PATCH 2/2] test: use the best mempool ops API to get mbuf pool Hemant Agrawal
2018-02-01 19:56 ` Hemant Agrawal [this message]
2018-02-01 20:40 ` [dpdk-dev] [PATCH 1/2] Revert "eal: fix default mempool ops" Pavan Nikhilesh
2018-02-02 5:43 ` Hemant Agrawal
2018-02-02 8:03 ` [dpdk-dev] [PATCH FIX-OPTION-2 1/2] eal: use named memzone to store user mempool ops name Hemant Agrawal
2018-02-02 8:03 ` [dpdk-dev] [PATCH FIX-OPTION-1] mbuf: fix the logic of user mempool ops API Hemant Agrawal
2018-02-02 13:40 ` Olivier Matz
2018-02-02 13:47 ` Hemant Agrawal
2018-02-06 0:05 ` Thomas Monjalon
[not found] ` <BY1PR0701MB1895B37B913A223180EED6D3EAFF0@BY1PR0701MB1895.namprd07.prod.outlook.com>
2018-02-04 6:34 ` [dpdk-dev] Fw: " santosh
2018-02-04 10:27 ` [dpdk-dev] " Hemant Agrawal
2018-02-02 8:03 ` [dpdk-dev] [PATCH FIX-OPTION-2 2/2] mbuf: fix user mempool ops get to use only named memzone Hemant Agrawal
2018-02-02 8:03 ` [dpdk-dev] [PATCH] doc: remove eal API for default mempool ops name Hemant Agrawal
2018-02-02 8:31 ` [dpdk-dev] [PATCH v2] " Hemant Agrawal
2018-02-02 14:01 ` Olivier Matz
2018-02-13 11:28 ` Ferruh Yigit
2018-02-14 14:58 ` Thomas Monjalon
2018-02-03 13:28 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM2PR04MB075328F278065579C22D31F189FA0@AM2PR04MB0753.eurprd04.prod.outlook.com \
--to=hemant.agrawal@nxp.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=pbhagavatula@caviumnetworks.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).