From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0055.outbound.protection.outlook.com [104.47.1.55]) by dpdk.org (Postfix) with ESMTP id 2594C3250 for ; Thu, 1 Feb 2018 20:56:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=je3l6gRta0pfTix32dVzqoJ6eAaaLc+6SGPDULK7U4k=; b=Ar8pOc8DTpxnXgmyAf1oH6OqfgbkvCzqtDRtGstUGGGg0zGkaayK7dQtNdNX9L8sf1bKvGtAkRx1uRybMMCFtCLSrQ0WZl9DfKMI2dBx7xhC7jG30NfPftdTCUEnxJHFt3sJN9bmg7yUfz3OKlWL86GaMlBSIoDSZZz6YGK87Uc= Received: from AM2PR04MB0753.eurprd04.prod.outlook.com (10.160.56.141) by AM2PR04MB0897.eurprd04.prod.outlook.com (10.161.70.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.464.11; Thu, 1 Feb 2018 19:56:48 +0000 Received: from AM2PR04MB0753.eurprd04.prod.outlook.com ([fe80::611d:d573:928:ad23]) by AM2PR04MB0753.eurprd04.prod.outlook.com ([fe80::611d:d573:928:ad23%13]) with mapi id 15.20.0444.016; Thu, 1 Feb 2018 19:56:48 +0000 From: Hemant Agrawal To: Hemant Agrawal , "olivier.matz@6wind.com" , "pbhagavatula@caviumnetworks.com" CC: "thomas@monjalon.net" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/2] Revert "eal: fix default mempool ops" Thread-Index: AQHTm5WsFWFv8mRQ8Ueq7Rff4aSnrqOP9E0g Date: Thu, 1 Feb 2018 19:56:47 +0000 Message-ID: References: <1517514427-28843-1-git-send-email-hemant.agrawal@nxp.com> In-Reply-To: <1517514427-28843-1-git-send-email-hemant.agrawal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; x-originating-ip: [122.161.220.15] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM2PR04MB0897; 7:bIATEjogAZbmKpdL8B65aVvF8bNCEJ743kBFxRzdhKApkG7mSdIKB/VA/zWm6u7dz82ZyMyuTJm3SATvkVc9X5Jh40bYeCOrOy0lmfAeygyLzkO9u4h/77JVmY8MIkIWaP99peBHrF6AyJudiy+H7a4LaM3D6QXeAQShL1NG9PgY79P2izcQThRqjq0gJMHRHdINx5lzMc7AnaFz6hEIq/WaD1v9gl6/Eu4KGnEZkBu5rUSgqoTLxqjqvsiS/gf2 x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(346002)(396003)(39380400002)(376002)(366004)(39860400002)(189003)(199004)(13464003)(2501003)(478600001)(3660700001)(14454004)(229853002)(2900100001)(110136005)(2950100002)(3280700002)(33656002)(54906003)(6436002)(74316002)(68736007)(53936002)(99286004)(106356001)(7736002)(316002)(5660300001)(7696005)(305945005)(9686003)(55016002)(25786009)(81166006)(105586002)(6506007)(8936002)(2906002)(81156014)(8676002)(53546011)(4326008)(66066001)(102836004)(26005)(3846002)(97736004)(76176011)(6116002)(86362001)(6246003)(2201001)(5250100002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0897; H:AM2PR04MB0753.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 211bfe4e-8dd7-44ef-2475-08d569adedb0 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:AM2PR04MB0897; x-ms-traffictypediagnostic: AM2PR04MB0897: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231101)(2400082)(944501161)(3002001)(10201501046)(6055026)(6041288)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011); SRVR:AM2PR04MB0897; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0897; x-forefront-prvs: 0570F1F193 received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: S7oBrjU6R9liY3BA3CfRf7I6/zb/UG7QTsLy2N519EcLDxWDRjW8txsyTjLY74w05UVHwg48AQRW1QyZtisw/Q== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 211bfe4e-8dd7-44ef-2475-08d569adedb0 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Feb 2018 19:56:47.9545 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0897 Subject: Re: [dpdk-dev] [PATCH 1/2] Revert "eal: fix default mempool ops" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Feb 2018 19:56:50 -0000 Hi Pavan, Your patch was breaking the design of the best_mempool_ops and the whole p= urpose of selection was getting lost.=20 I guess you were trying to fix test_mempool. I have sent another patch, w= hich fixes that and start using the best mempool ops API instead of default mempool ops API. Regards, Hemant > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hemant Agrawal > Sent: Friday, February 02, 2018 1:17 AM > To: olivier.matz@6wind.com; pbhagavatula@caviumnetworks.com > Cc: thomas@monjalon.net; dev@dpdk.org > Subject: [dpdk-dev] [PATCH 1/2] Revert "eal: fix default mempool ops" >=20 > This reverts commit fe06cb6c54fe5ada299ebba40a382bee37c919f2. > --- > lib/librte_eal/bsdapp/eal/eal.c | 3 --- > lib/librte_eal/linuxapp/eal/eal.c | 3 --- > 2 files changed, 6 deletions(-) >=20 > diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/= eal.c > index 1622a41..b612af0 100644 > --- a/lib/librte_eal/bsdapp/eal/eal.c > +++ b/lib/librte_eal/bsdapp/eal/eal.c > @@ -86,9 +86,6 @@ int rte_cycles_vmware_tsc_map; const char * > rte_eal_mbuf_default_mempool_ops(void) > { > - if (internal_config.user_mbuf_pool_ops_name =3D=3D NULL) > - return RTE_MBUF_DEFAULT_MEMPOOL_OPS; > - > return internal_config.user_mbuf_pool_ops_name; > } >=20 > diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/= eal/eal.c > index 451fdaf..21024b4 100644 > --- a/lib/librte_eal/linuxapp/eal/eal.c > +++ b/lib/librte_eal/linuxapp/eal/eal.c > @@ -96,9 +96,6 @@ int rte_cycles_vmware_tsc_map; const char * > rte_eal_mbuf_default_mempool_ops(void) > { > - if (internal_config.user_mbuf_pool_ops_name =3D=3D NULL) > - return RTE_MBUF_DEFAULT_MEMPOOL_OPS; > - > return internal_config.user_mbuf_pool_ops_name; > } >=20 > -- > 2.7.4