From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0070.outbound.protection.outlook.com [104.47.1.70]) by dpdk.org (Postfix) with ESMTP id 8A70B532C for ; Fri, 2 Feb 2018 06:43:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NNBkg6UcqyjITMW8oy500N8Bjp2PYptXVFKineQQXLY=; b=AnNuxqBIifwVYxHAhAMIcVqPev/ROzwQG3kd/DydgARxD5adn49gma+2zmKTlf7rETTkTYM2Qj0CNe2c9wIwPMbtquB6oMnVBz49CyXwRSxOcdB0CofSIinpP3kWjoBiV2wmwuAttBsLOHlcE3Pz35MLPKfFebyfXx6jHv7HyUQ= Received: from AM2PR04MB0753.eurprd04.prod.outlook.com (10.160.56.141) by AM2PR04MB0993.eurprd04.prod.outlook.com (10.162.35.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Fri, 2 Feb 2018 05:43:51 +0000 Received: from AM2PR04MB0753.eurprd04.prod.outlook.com ([fe80::611d:d573:928:ad23]) by AM2PR04MB0753.eurprd04.prod.outlook.com ([fe80::611d:d573:928:ad23%13]) with mapi id 15.20.0444.016; Fri, 2 Feb 2018 05:43:51 +0000 From: Hemant Agrawal To: Pavan Nikhilesh , "olivier.matz@6wind.com" , "thomas@monjalon.net" , "jerin.jacob@caviumnetworks.com" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/2] Revert "eal: fix default mempool ops" Thread-Index: AQHTm5WsFWFv8mRQ8Ueq7Rff4aSnrqOP9E0ggAAOLwCAAJdX4A== Date: Fri, 2 Feb 2018 05:43:51 +0000 Message-ID: References: <1517514427-28843-1-git-send-email-hemant.agrawal@nxp.com> <20180201203959.wi3e56buepnu3px6@Pavan-LT> In-Reply-To: <20180201203959.wi3e56buepnu3px6@Pavan-LT> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; x-originating-ip: [192.88.169.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM2PR04MB0993; 7:/tlY06YfrlQ2Im5BVcz443Y3HBMLcwoWGV7xRSujLWurERih9s/7acSH7WXmUiR9xFLZMd/HpK0yUlQQVrR2tvEeyBc5NdfiEjpySjyD8oIncSIND0Yl44bwHWfFNgRxV0p/+gH85HZPFlFf6syfQP2EaxFul7KxCaG4KDR7vRFGH9v287OqTwccmwRK5zI3/TznY+e2IcL3vA1pmH5c886jTRl8ph+WNT5NGIcYoRvfqIQJuHENboFYTshROsxY x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 81764fe5-90f8-4ee7-2b24-08d569fff0a9 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:AM2PR04MB0993; x-ms-traffictypediagnostic: AM2PR04MB0993: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(10201501046)(3231101)(2400082)(944501161)(3002001)(93006095)(93001095)(6055026)(6041288)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:AM2PR04MB0993; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0993; x-forefront-prvs: 05715BE7FD x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(396003)(346002)(376002)(39860400002)(39380400002)(199004)(189003)(13464003)(25786009)(305945005)(105586002)(8936002)(33656002)(3280700002)(81166006)(2906002)(6436002)(106356001)(81156014)(14454004)(8676002)(478600001)(7736002)(68736007)(5250100002)(3660700001)(74316002)(97736004)(2501003)(5660300001)(186003)(53936002)(102836004)(55016002)(26005)(76176011)(2950100002)(7696005)(99286004)(316002)(2900100001)(66066001)(6246003)(3846002)(6116002)(86362001)(229853002)(53546011)(6506007)(9686003)(2201001)(4326008)(110136005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0993; H:AM2PR04MB0753.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: tKiRSoIjMn7BQvMeKV443d5ZaCGatXkcywV7upCIF/pRFzRoTlS2NGPQ92fHo+OMY/yFDAYJG3Wdg3MqTOk58g== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 81764fe5-90f8-4ee7-2b24-08d569fff0a9 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2018 05:43:51.7363 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0993 Subject: Re: [dpdk-dev] [PATCH 1/2] Revert "eal: fix default mempool ops" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Feb 2018 05:43:53 -0000 HI Pavan, > Currently, best_mempool_ops is broken because when > rte_mbuf_user_mempool_ops is invoked it is expected to returns 'NULL' thr= ough > internal_config.user_mbuf_pool_ops_name. IMO it is best to create a named > memzone ('mbuf_user_pool_ops') at the end of eal_init and copy mbuf-pool-= ops > passed to eal. >=20 > `rte_eal_mbuf_default_mempool_ops` is not expected to return 'NULL' would > doing so break the ABI?. >=20 > --- > /** > * Get default pool ops name for mbuf > * > * @return > * returns default pool ops name. > */ > const char * > rte_eal_mbuf_default_mempool_ops(void); > --- >=20 > IMO creating named mempool at the end of eal_init and changing > `rte_mbuf_user_mempool_ops` as below would be a better solution. >=20 > rte_mbuf_user_mempool_ops(void) > { > ... > mz =3D rte_memzone_lookup("mbuf_user_pool_ops"); > if (mz =3D=3D NULL) > return NULL; > ... > } >=20 > Thoughts? [Hemant] It seems reasonable. We can also deprecate the eal default mempoo= l ops API . I will be sending patch shortly. =20 Unfortunately all NXP platforms are broken at the moment, so we need to get= it fixed fast. Hemant >=20 > Pavan. >=20 > On Thu, Feb 01, 2018 at 07:56:47PM +0000, Hemant Agrawal wrote: > > Hi Pavan, > > Your patch was breaking the design of the best_mempool_ops and the > whole purpose of selection was getting lost. > > I guess you were trying to fix test_mempool. I have sent another > > patch, which fixes that and start using the best mempool ops API instea= d of > default mempool ops API. > > > > Regards, > > Hemant > > > > > -----Original Message----- > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hemant Agrawal > > > Sent: Friday, February 02, 2018 1:17 AM > > > To: olivier.matz@6wind.com; pbhagavatula@caviumnetworks.com > > > Cc: thomas@monjalon.net; dev@dpdk.org > > > Subject: [dpdk-dev] [PATCH 1/2] Revert "eal: fix default mempool ops" > > > > > > This reverts commit fe06cb6c54fe5ada299ebba40a382bee37c919f2. > > > ---