Re: [dpdk-dev] [PATCH] dpaa: Augment linker line to include needed libraries for dpaa

[Hemant Agrawal <hemant.agrawal@nxp.com>]

HI  Neil,
	Thanks for the patch.  This issue was identified and fixed in the following patches (yet to be merged)

V1:http://dpdk.org/dev/patchwork/patch/35366/
V2: http://dpdk.org/dev/patchwork/patch/35369/

Regards,
Hemant

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Neil Horman
> Sent: Tuesday, February 27, 2018 12:50 AM
> To: dev@dpdk.org
> Cc: Neil Horman <nhorman@tuxdriver.com>; Thomas Monjalon
> <thomas@monjalon.net>; Ferruh Yigit <ferruh.yigit@intel.com>; Hemant
> Agrawal <hemant.agrawal@nxp.com>
> Subject: [dpdk-dev] [PATCH] dpaa: Augment linker line to include needed
> libraries for dpaa
> Importance: High
> 
> When preforming a shared library build, if the dpaa pmd is configured, the build
> fails when linking testpmd.  This occurs because the makefile fails to include
> dependent libraries dpaa_mempool and dpaa_bus.
> 
> Fix is to simply include them in the makefile.  We could perhaps fix this more
> generally by using the copy-dt-needed-entries linker option, but doing so has a
> significant effect on link order, which may be undesireable.  Given this is fairly
> isolated, and that we have precident for this (see rte.app.mk), just add the
> needed libraries for this specific app
> 
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> CC: Thomas Monjalon <thomas@monjalon.net>
> CC: Ferruh Yigit <ferruh.yigit@intel.com>
> CC: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
>  app/test-pmd/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile index
> ed588ab6d..77a02ca0d 100644
> --- a/app/test-pmd/Makefile
> +++ b/app/test-pmd/Makefile
> @@ -45,7 +45,7 @@ LDLIBS += -lrte_pmd_bond  endif
> 
>  ifeq ($(CONFIG_RTE_LIBRTE_DPAA_PMD),y)
> -LDLIBS += -lrte_pmd_dpaa
> +LDLIBS += -lrte_pmd_dpaa -lrte_bus_dpaa -lrte_mempool_dpaa
>  endif
> 
>  ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y)
> --
> 2.14.3