From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0077.outbound.protection.outlook.com [104.47.2.77]) by dpdk.org (Postfix) with ESMTP id 765F02C8 for ; Tue, 27 Feb 2018 04:55:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=QLyTFV/Yhvw9UiWuyJ12eLWkNUNf7VWX6TsNttLHsg8=; b=RITvCm4S6m+aQN3f6Oj+Pz2NB3nh3K0qboJ9cUTDdYFZifwlyLKGnwBQboX6J94KURnN49T+d+ji9QViz0yfosYiukUpNU2acy9tVtYKa9uKEN8yTQttNrq4tXVGFotCYbj9rKHqRTZjIIw4bqv+2ZFYIYBmDunWyRXwDI/UO6c= Received: from AM2PR04MB0753.eurprd04.prod.outlook.com (10.160.56.141) by AM2PR04MB0705.eurprd04.prod.outlook.com (10.160.55.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.506.18; Tue, 27 Feb 2018 03:55:20 +0000 Received: from AM2PR04MB0753.eurprd04.prod.outlook.com ([fe80::4cd2:dcec:e711:c5f3]) by AM2PR04MB0753.eurprd04.prod.outlook.com ([fe80::4cd2:dcec:e711:c5f3%15]) with mapi id 15.20.0527.021; Tue, 27 Feb 2018 03:55:20 +0000 From: Hemant Agrawal To: Neil Horman , "dev@dpdk.org" CC: Thomas Monjalon , Ferruh Yigit Thread-Topic: [dpdk-dev] [PATCH] dpaa: Augment linker line to include needed libraries for dpaa Thread-Index: AQHTrzbuHF/pAM9XJUKzHP4MTE1+EqO3noNQ Date: Tue, 27 Feb 2018 03:55:20 +0000 Message-ID: References: <20180226192001.30220-1-nhorman@tuxdriver.com> In-Reply-To: <20180226192001.30220-1-nhorman@tuxdriver.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; x-originating-ip: [122.176.3.124] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM2PR04MB0705; 7:Ua2f7IEd9ddWfAFXiJ2Nbg8ahC9dhfeppX3jreGpoeJyVgviPIFBo5YMqPP19kCCdnbAMtLvbTEQXGzmSuvIXll0JllUW+Ak5loGoFSCLKGNkyXiAo7X+1XDQAcY4gaL1eNidYJagr3EFT3n4yT6xAVhnZ7vIvytCG066EAcTZnc1uD1qcp6BJds3t2MfVnMUL2L4hl74ZehrxCivguXth6MEkUToRlV69ExdITDbWr3EHynp+V1CoDOY/zFILFi x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 77287f2e-c734-492c-bc93-08d57d95ec29 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(3008032)(48565401081)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603307)(7153060)(7193020); SRVR:AM2PR04MB0705; x-ms-traffictypediagnostic: AM2PR04MB0705: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(66839620246622)(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231220)(2232076)(944501161)(52105095)(3002001)(6055026)(6041288)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011); SRVR:AM2PR04MB0705; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0705; x-forefront-prvs: 05961EBAFC x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(346002)(376002)(396003)(39380400002)(51914003)(189003)(199004)(13464003)(6306002)(66066001)(55016002)(6436002)(6246003)(5250100002)(53376002)(9686003)(53936002)(478600001)(59450400001)(7736002)(6506007)(53546011)(68736007)(33656002)(2501003)(81166006)(81156014)(2900100001)(99286004)(186003)(305945005)(55236004)(3660700001)(7696005)(102836004)(26005)(8936002)(25786009)(76176011)(74316002)(3846002)(6116002)(4326008)(5660300001)(2950100002)(229853002)(2906002)(3280700002)(106356001)(316002)(86362001)(110136005)(97736004)(575784001)(105586002)(14454004)(54906003)(966005)(59010400001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0705; H:AM2PR04MB0753.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 4LBVdRa2rAxF2QiG35mxuj9UXLllghI9/Ltp+4pmTrnK4lNY1cuteRj1se8XMbMDKTPa9CZlo5zdjNPvYGcYgU3GYN5ebWta1iN6MtDtRBsoiKsohobfN28/ymVRTY5L8fcvh11fPI1ylEH1evQPbGmti2yjqXCNUrPP29X+U/27DB7xQMXPDmDqVkdH6+XbWZQbOVKg5DKkbaQxGpVeoOOIp9Bu8KlGB+qNXm/RO0Stt6tirbPGZ2NEyz+E2nVZv9IuM5dw9Lc7vjUpnHUVsxjYT99WeNpriVZbv0BQr8Y= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 77287f2e-c734-492c-bc93-08d57d95ec29 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Feb 2018 03:55:20.7300 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0705 Subject: Re: [dpdk-dev] [PATCH] dpaa: Augment linker line to include needed libraries for dpaa X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Feb 2018 03:55:23 -0000 HI Neil, Thanks for the patch. This issue was identified and fixed in the followin= g patches (yet to be merged) V1:http://dpdk.org/dev/patchwork/patch/35366/ V2: http://dpdk.org/dev/patchwork/patch/35369/ Regards, Hemant > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Neil Horman > Sent: Tuesday, February 27, 2018 12:50 AM > To: dev@dpdk.org > Cc: Neil Horman ; Thomas Monjalon > ; Ferruh Yigit ; Hemant > Agrawal > Subject: [dpdk-dev] [PATCH] dpaa: Augment linker line to include needed > libraries for dpaa > Importance: High >=20 > When preforming a shared library build, if the dpaa pmd is configured, th= e build > fails when linking testpmd. This occurs because the makefile fails to in= clude > dependent libraries dpaa_mempool and dpaa_bus. >=20 > Fix is to simply include them in the makefile. We could perhaps fix this= more > generally by using the copy-dt-needed-entries linker option, but doing so= has a > significant effect on link order, which may be undesireable. Given this = is fairly > isolated, and that we have precident for this (see rte.app.mk), just add = the > needed libraries for this specific app >=20 > Signed-off-by: Neil Horman > CC: Thomas Monjalon > CC: Ferruh Yigit > CC: Hemant Agrawal > --- > app/test-pmd/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile index > ed588ab6d..77a02ca0d 100644 > --- a/app/test-pmd/Makefile > +++ b/app/test-pmd/Makefile > @@ -45,7 +45,7 @@ LDLIBS +=3D -lrte_pmd_bond endif >=20 > ifeq ($(CONFIG_RTE_LIBRTE_DPAA_PMD),y) > -LDLIBS +=3D -lrte_pmd_dpaa > +LDLIBS +=3D -lrte_pmd_dpaa -lrte_bus_dpaa -lrte_mempool_dpaa > endif >=20 > ifeq ($(CONFIG_RTE_LIBRTE_IXGBE_PMD),y) > -- > 2.14.3