From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0040.outbound.protection.outlook.com [104.47.1.40]) by dpdk.org (Postfix) with ESMTP id 7A9023977; Tue, 18 Jul 2017 19:32:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=01F8yocP+MG81bDrfvDNNhdC2SMEmjcBlttZom8kzNM=; b=rbeezoCIqldNl0E/sr/idNSWs5yVRYNLYUVvDzVXDa5IHeB1GMPF5vQODSdN6OxjUke90b9K3QjDOL6bPnCBozKungGYg79BFBQP2ixkf8uvegOv3XNMIwgZmMX29xCcBi5qY2LeU65Jzzi2g6EIAB53dbsQCkMpmBz9/NYizKg= Received: from AM2PR04MB0753.eurprd04.prod.outlook.com (10.160.56.141) by VI1PR04MB1390.eurprd04.prod.outlook.com (10.163.166.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1261.13; Tue, 18 Jul 2017 17:32:46 +0000 Received: from AM2PR04MB0753.eurprd04.prod.outlook.com ([fe80::3110:c7c6:12b8:830c]) by AM2PR04MB0753.eurprd04.prod.outlook.com ([fe80::3110:c7c6:12b8:830c%16]) with mapi id 15.01.1240.023; Tue, 18 Jul 2017 17:32:44 +0000 From: Hemant Agrawal To: "De Lara Guarch, Pablo" , Yuanhan Liu CC: Akhil Goyal , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2] crypto/dpaa2_sec: fix the return of supported API Thread-Index: AQHS/5hvOf0GmNfO+UKgCwEe9AQ7RaJZYX2AgABGioCAAByBAIAAEujg Date: Tue, 18 Jul 2017 17:32:44 +0000 Message-ID: References: <20170718073356.14288-1-akhil.goyal@nxp.com> <20170718143907.GV11626@yliu-home> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [182.69.67.100] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR04MB1390; 7:MbqsiV3v6n8RCBpUgp57X8YazU8xg/XX0CSkUz34VNIr8qGFKzDDZKGUyBtWrtImTYgv5jwB7oFgaPktqSyRGzuV4qDS6Xr6EfNhTE37LLFvmYXiNfMYTuBE3PdepRKUpjIG0iolw03+eCtasqiB9JUvCzxCmUDunIE49wMuNS45mK1Uw/kG096lzFX8PvJGFQITzp0HsGMl7DISwq578X48zFh6Jq91cuWFhq7WZP1GJrIfjwBvpZyNQ1PFj9hjKjI9ZfjDGCdy+QjCwEr5KRiB+owrY6LirKFv0GT0reNR5/xODsSFHXgCf+EiKEKxDIAOUcHMN/m1qTjJDEGqAoyuYUZCSjMbaTf7+Yfwo6bLDR1eLEo4wQf60M1ecw9j/gPBQjr+fKupUoA2V2u/JNBI7V/xALWhixtOf6M8P1W7TbeggF2hZSy8JUz0y4BC4q0gUjZq6/cuV2IKqAf+Yo1eMh7UQROrZ2QGbtKDgaiFAaz8sf259Qofo5XwFg+Afomi5Gqoom03v+6thsV+R0jBbfrZkDV9GstkIQ3wRZJks/RU+z8HuEnFjXKN8nto6og5e+8wxEib2697l/7Y+uUFL+krFkhusxMOgmBGyJwZEXEoqy1vsTKfKN2/mrhLHvF1L7J/rLTCWxlotoFcWthaJYVmzmZtAkfi58pt3nrbP1Nk/tWlU8AN08+fVAi2qxUuTzmpSzcN5voj2E/D5AbgeVsZG6UyfsP+X9ZtdW6Sn4siwac9hD8bdyUANCDyMNwtx7yWe5iBr1nUeqQynljtIrldz41AlMibTWZfOXI= x-forefront-antispam-report: SFV:SKI; SCL:-1SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(39400400002)(39410400002)(39840400002)(39450400003)(39850400002)(377454003)(13464003)(7736002)(6116002)(478600001)(5660300001)(102836003)(93886004)(8936002)(3846002)(229853002)(305945005)(7696004)(3280700002)(86362001)(3660700001)(2950100002)(2900100001)(74316002)(14454004)(81166006)(5250100002)(6506006)(8676002)(2906002)(9686003)(99286003)(54906002)(6246003)(53936002)(55016002)(38730400002)(6436002)(66066001)(54356999)(33656002)(50986999)(189998001)(76176999)(25786009)(4326008)(53546010); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB1390; H:AM2PR04MB0753.eurprd04.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; x-ms-office365-filtering-correlation-id: 480d1c48-2c85-4376-b5ed-08d4ce030025 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254075)(300000503095)(300135400095)(48565401081)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:VI1PR04MB1390; x-ms-traffictypediagnostic: VI1PR04MB1390: x-exchange-antispam-report-test: UriScan:(133145235818549)(236129657087228)(185117386973197)(228905959029699); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(2017060910075)(5005006)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(6055026)(6041248)(20161123560025)(20161123564025)(20161123562025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:VI1PR04MB1390; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:VI1PR04MB1390; x-forefront-prvs: 037291602B spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2017 17:32:44.6746 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB1390 Subject: Re: [dpdk-dev] [PATCH v2] crypto/dpaa2_sec: fix the return of supported API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jul 2017 17:32:47 -0000 HI Yuanhan, > > > > -----Original Message----- > > > > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > > > > Sent: Tuesday, July 18, 2017 8:34 AM > > > > To: dev@dpdk.org; stable@dpdk.org > > > > Cc: hemant.agrawal@nxp.com; De Lara Guarch, Pablo > > > > ; yliu@fridaylinux.org; Akhil > > > > Goyal > > > > Subject: [PATCH v2] crypto/dpaa2_sec: fix the return of supported > > > > API > > > > > > > > call to dpaa2_sec_dev_configure() is made mandatory, but > > > > dpaa2_sec_pmd returns a ENOTSUP which results in device not > > > > getting > > configured. > > > > > > > > dpaa2_sec PMD does not need any further configuration to be done > > > > in dpaa2_sec_dev_configure, hence returning 0 > > > > > > > > Fixes: e5cbdfc53765 ("crypto/dpaa2_sec: add basic operations") > > > > > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Akhil Goyal > > > > > > Looks ok to me, but this is only applicable in the stable branch, so > > > no need to send it to dev@dpdk.org. > > > > Why? We already have such fix in upstream? Normally, we just pick > > upstream commits (but not patches: the emails) to stable release. >=20 > It looks like this fix was included in > 13273250eec5 ("crypto/dpaa2_sec: support AES-GCM and CTR"). > Unfortunately, this patch should have been split into two different patch= es. > Since this has already been merged, I think our only way to integrate thi= s In > 17.05.1 is by getting it separately. In general, there may be other incidents, where a patch is only applicable = for the stable tree. It may not be applicable for upstream tree due to arch= itecture changes or other reasons. How do you want to handle such patches?=20 e.g. in OVS, we can do it by marking the patch header with "[branch-2.6]" Regards, Hemant