From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0070.outbound.protection.outlook.com [104.47.1.70]) by dpdk.org (Postfix) with ESMTP id D8103A84C for ; Fri, 2 Feb 2018 14:47:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=57vBB2hRAqXJCXWaCz3kUWeHG3f5koYhnOqB4wmA+SM=; b=I1/5LAxO31mmUFxDVEWMgGidnpaITFHanYPnHZAFjblw97+MyUoZ07jkWVkYjCYp4Q+6EH32vgGsWWpKHpf2QdSyy522CdGOwtY9Qznta+1coBbMnUS+SlkUXldApfCKkgeeD5AeV0JhmuYsuRQBCl1wiqOHwkdJrMAMFXQw1bw= Received: from AM2PR04MB0753.eurprd04.prod.outlook.com (10.160.56.141) by AM2PR04MB0945.eurprd04.prod.outlook.com (10.161.70.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.464.11; Fri, 2 Feb 2018 13:47:26 +0000 Received: from AM2PR04MB0753.eurprd04.prod.outlook.com ([fe80::611d:d573:928:ad23]) by AM2PR04MB0753.eurprd04.prod.outlook.com ([fe80::611d:d573:928:ad23%13]) with mapi id 15.20.0444.016; Fri, 2 Feb 2018 13:47:26 +0000 From: Hemant Agrawal To: Olivier Matz CC: "thomas@monjalon.net" , "pbhagavatula@caviumnetworks.com" , "Nipun Gupta" , "jerin.jacob@caviumnetworks.com" , "santosh.shukla@caviumnetworks.com" , "dev@dpdk.org" Thread-Topic: [PATCH FIX-OPTION-1] mbuf: fix the logic of user mempool ops API Thread-Index: AQHTnCtarhs0ud7BK0yMK1vrf4ud2qORH4OQ Date: Fri, 2 Feb 2018 13:47:26 +0000 Message-ID: References: <1517514427-28843-1-git-send-email-hemant.agrawal@nxp.com> <1517558582-27108-1-git-send-email-hemant.agrawal@nxp.com> <1517558582-27108-2-git-send-email-hemant.agrawal@nxp.com> <20180202134007.qvip4jkiv2gksxoj@platinum> In-Reply-To: <20180202134007.qvip4jkiv2gksxoj@platinum> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; x-originating-ip: [192.88.169.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM2PR04MB0945; 7:PFcviI7NvMx9jmujyZ1v5z2xyuK3gAESsGGuD+Cg5EJpERUD2dNLqQq4iUxzctmAaLmpOviCHxEdKo/brcfVKOJwTpRPP7E43ScoZs0IUAcerMTnvlYasQ1nnXTH5sd2JUgQFq/WE3qzrCO6cwP6sG6MwohZ/0JQI3jDjXu4zdMh0HeKMGdFd1FE0o5byoDng4vwe4ep7NyRAL/TFEbf+K0nl3xUFbWMNpgCCl5D8/zGgDO/AXnMBY3yLiulRNCx x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(366004)(396003)(376002)(346002)(39860400002)(39380400002)(199004)(189003)(8936002)(54906003)(6436002)(81156014)(93886005)(2950100002)(3280700002)(3660700001)(5660300001)(478600001)(2900100001)(2906002)(8676002)(106356001)(86362001)(575784001)(305945005)(76176011)(81166006)(316002)(7696005)(105586002)(74316002)(53936002)(68736007)(4326008)(26005)(6506007)(6246003)(59450400001)(5250100002)(14454004)(3846002)(186003)(6116002)(7736002)(6916009)(97736004)(25786009)(55016002)(102836004)(229853002)(33656002)(9686003)(99286004)(66066001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0945; H:AM2PR04MB0753.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 6f5ddf13-ace2-4054-2606-08d56a437ea2 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:AM2PR04MB0945; x-ms-traffictypediagnostic: AM2PR04MB0945: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(3231101)(2400082)(944501161)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041288)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(6072148)(201708071742011); SRVR:AM2PR04MB0945; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0945; x-forefront-prvs: 05715BE7FD received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: bYXQF/ep1XlvBi19PTu5mINFosGlFJgOgA8JuXaX4yaV88yp8dsFDjayp3WctobRn5ZAFCM0hWJawkNAkI+/hg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f5ddf13-ace2-4054-2606-08d56a437ea2 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2018 13:47:26.1139 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0945 Subject: Re: [dpdk-dev] [PATCH FIX-OPTION-1] mbuf: fix the logic of user mempool ops API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Feb 2018 13:47:28 -0000 Hi Olivier, > On Fri, Feb 02, 2018 at 01:33:01PM +0530, Hemant Agrawal wrote: > > From: Nipun Gupta > > > > The existing rte_eal_mbuf_default mempool ops can return the compile > > time default ops name if the user has not provided command line inputs > > for mempool ops name. It will break the logic of best mempool ops as > > it will never return platform hw mempool ops. > > > > This patch introduces a new API to just return the user mempool ops onl= y. > > > > Fixes: 8b0f7f434132 ("mbuf: maintain user and compile time mempool ops > > name") > > > > Signed-off-by: Nipun Gupta >=20 > This option is fine for me. I think we may also consider deprecating > rte_eal_mbuf_default_mempool_ops(), as it is done in option 2. [Hemant] Ok. Please also ack following. I will update patchwork for remai= ning patches accordingly. [PATCH v2] doc: remove eal API for default mempool ops name > Acked-by: Olivier Matz Thanks Hemant