From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0077.outbound.protection.outlook.com [104.47.1.77]) by dpdk.org (Postfix) with ESMTP id DE6A42F42 for ; Sun, 4 Feb 2018 11:27:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Xf0fGRKnLfl4NxNA2OTFc4eJciHCKnxq8BwZccQDQ5A=; b=jkb8iNHv/UnbFL9n39D+j8/Id/RpSw1YCBn1ora9iPnxEaIfd/cPNEDrGsKXs39op4I4SIIVjcpiU5M6JvY2zkepzMt0X2FGyLxxSdjei4dPLpqi1K2enf4AxJlCumqsCD84FdiHs+IvsLQnit0z7hZSJgOMzOSKXpNPCdoEzNw= Received: from AM2PR04MB0753.eurprd04.prod.outlook.com (10.160.56.141) by AM2PR04MB0611.eurprd04.prod.outlook.com (10.160.32.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.464.11; Sun, 4 Feb 2018 10:27:24 +0000 Received: from AM2PR04MB0753.eurprd04.prod.outlook.com ([fe80::611d:d573:928:ad23]) by AM2PR04MB0753.eurprd04.prod.outlook.com ([fe80::611d:d573:928:ad23%13]) with mapi id 15.20.0444.023; Sun, 4 Feb 2018 10:27:23 +0000 From: Hemant Agrawal To: "santosh.shukla@caviumnetworks.com" , "dev@dpdk.org" CC: "jerin.jacob@caviumnetworks.com" , "olivier.matz@6wind.com" , Nipun Gupta Thread-Topic: [PATCH FIX-OPTION-1] mbuf: fix the logic of user mempool ops API Thread-Index: AQHTnaK+k4LDH6l1tkC8fQvnlzSp0A== Date: Sun, 4 Feb 2018 10:27:22 +0000 Message-ID: References: <1517514427-28843-1-git-send-email-hemant.agrawal@nxp.com> <1517558582-27108-1-git-send-email-hemant.agrawal@nxp.com> <1517558582-27108-2-git-send-email-hemant.agrawal@nxp.com> , <0e0099bc-99f5-bd41-cc53-b0ea9ded2f53@caviumnetworks.com> In-Reply-To: <0e0099bc-99f5-bd41-cc53-b0ea9ded2f53@caviumnetworks.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; x-originating-ip: [106.202.249.209] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM2PR04MB0611; 7:9eX9QK9S0/5aJWfwIOyzq1AamoaUrJnqFidlmoEl995NHfkfiMpKhhJ+XiXh7PmleAoOipuiVDtAv0npXUMX5YnSOIfu4+sZ3e2h8sgDjqBCvhE4e5BjMmmBG0lzsvNbq8+nNF8zEckcBkyFKqxaHa+kPV6myGG9RihkRxRljmDVs5FXhlEqZXtXxBIcS2q7csl13NjrBCCwWNfplYk8NVuxHr/P8zRyoq/O4s+Qd0fj9cDmImDkPBLXlcbk3zgR x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(376002)(346002)(366004)(39860400002)(396003)(39380400002)(13464003)(189003)(199004)(6116002)(33656002)(3846002)(4326008)(76176011)(5660300001)(66066001)(102836004)(93886005)(26005)(55236004)(2906002)(6506007)(7736002)(7696005)(74316002)(14454004)(2950100002)(68736007)(9886003)(6246003)(99286004)(8936002)(229853002)(3280700002)(6436002)(3660700001)(105586002)(186003)(106356001)(2900100001)(2501003)(97736004)(5250100002)(316002)(478600001)(53936002)(86362001)(575784001)(9686003)(8676002)(54896002)(54906003)(110136005)(81166006)(81156014)(55016002)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR04MB0611; H:AM2PR04MB0753.eurprd04.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 5d1894a5-31bb-44d8-f196-08d56bb9e0f7 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(2017052603307)(7153060)(7193020); SRVR:AM2PR04MB0611; x-ms-traffictypediagnostic: AM2PR04MB0611: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(158342451672863)(185117386973197)(258766100185102); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231101)(2400082)(944501161)(3002001)(6055026)(6041288)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(6072148)(201708071742011); SRVR:AM2PR04MB0611; BCL:0; PCL:0; RULEID:; SRVR:AM2PR04MB0611; x-forefront-prvs: 05739BA1B5 received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: mo+bQ+8+NSfbETtQ26f2elRsMw9qQbikiWyKhn3+p7KLNUtV3mvXMFV5cM8VOaza79LVH2Q1WwUOUGVhd5ipYA== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d1894a5-31bb-44d8-f196-08d56bb9e0f7 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2018 10:27:22.8385 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR04MB0611 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH FIX-OPTION-1] mbuf: fix the logic of user mempool ops API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Feb 2018 10:27:26 -0000 Thanks we also identified it. The fix is on the way. Sent from my Android phone using TouchDown (www.symantec.com) -----Original Message----- From: santosh [santosh.shukla@caviumnetworks.com] Received: Sunday, 04 Feb 2018, 12:05PM To: Hemant Agrawal [hemant.agrawal@nxp.com]; dev [dev@dpdk.org] CC: Olivier MATZ [olivier.matz@6wind.com]; Jerin Jacob [jerin.jacob@caviumn= etworks.com]; Nipun Gupta [nipun.gupta@nxp.com] Subject: Re: Fw: [PATCH FIX-OPTION-1] mbuf: fix the logic of user mempool o= ps API Hi Hemant, On Sunday 04 February 2018 11:52 AM, Shukla, Santosh wrote: > The existing rte_eal_mbuf_default mempool ops can return the compile time > default ops name if the user has not provided command line inputs for > mempool ops name. It will break the logic of best mempool ops as it will > never return platform hw mempool ops. > > This patch introduces a new API to just return the user mempool ops only. > > Fixes: 8b0f7f434132 ("mbuf: maintain user and compile time mempool ops na= me") > > Signed-off-by: Nipun Gupta > --- This patch introduces regression for octeontx platform. Fails with: --------- testpmd: create a new mbuf pool : n=3D163456, size=3D21= 76, socket=3D0 testpmd: preferred mempool ops selected: dpaa dpaa_mbuf_create_pool(): bman_new_pool() failed EAL: Error - exiting with code: 1 ---------- Command: ./testpmd -c 0xe00000 -n 4 -- --portmask 0x1 --nb-cores=3D2 --port-topolo= gy=3Dloop --rxq=3D2 --txq=3D2 --rss-ip --no-flush-rx ------------- It's because rte_dpaa_bus_probe() sets platform mempool ops i.e. rte_mbuf_set_platform_mempool_ops(DPAA_MEMPOOL_OPS_NAME); therefore `rte_mbuf_best_mempool_ops` returns with `dpaa` ops which is incorrect mempool_ops choice for octeontx platform. We can fix such regression with following ways: # option 1) unset LIBRTE_DPAA_MEMPOOL=3Dy from common_armv8a_linuxapp confi= g and set at dpaa/dpaa2 specific configs commit: 1ee9569576f6 ("config: enable dpaaX drivers for generic ARMv8") # option 2) Don;t set platform mempool ops in dpaa bus layer instead defer = it to driver layer. Thanks.