From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50049.outbound.protection.outlook.com [40.107.5.49]) by dpdk.org (Postfix) with ESMTP id BE6DF10A7; Wed, 6 Sep 2017 12:54:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=VEYHEBgq/u3xmxlxjO5T0vH7+1merS2foQD8wMJFZJI=; b=cJwRlMOAD+mB/GebdV6qHYgosR32RHSzG5WL2EolfNSnFX8mGj7Ywk7JZt+J/2+vSYSPfGxLv9PxIgi1XnO3f5drpXccvv1JE1ZsRRKIXTjyDu5wA4EGemQ4iI3QpyOe3yY5eQyfc2m72n3C9pUiO30jP8YlECoudHvKR42nyos= Received: from AM2PR05MB0689.eurprd05.prod.outlook.com (10.161.20.16) by AM2PR05MB1041.eurprd05.prod.outlook.com (10.161.234.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10; Wed, 6 Sep 2017 10:54:24 +0000 Received: from AM2PR05MB0689.eurprd05.prod.outlook.com ([fe80::d8e0:56cd:5be8:29b3]) by AM2PR05MB0689.eurprd05.prod.outlook.com ([fe80::d8e0:56cd:5be8:29b3%13]) with mapi id 15.20.0013.018; Wed, 6 Sep 2017 10:54:24 +0000 From: Shachar Beiser To: Adrien Mazarguil CC: "dev@dpdk.org" , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "stable@dpdk.org" Thread-Topic: [PATCH v2 3/3] net/mlx5: fix interrupt enable return value Thread-Index: AQHTJkelbfFbH378VESDU+c/ZxeGR6KmSNcAgAFmnSA= Date: Wed, 6 Sep 2017 10:54:24 +0000 Message-ID: References: <20170905132720.GD4301@6wind.com> In-Reply-To: <20170905132720.GD4301@6wind.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=shacharbe@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM2PR05MB1041; 6:Aru2QlszLsYRGdn/DS4rpdNwFE0j50iMy3uQ/mSA8BQrk+qmEMK6lVp59NPKyyMh1TWxCY7l8ssPDIhW6fxStMQ8hSbVZUHMt32wf9OuSVPLMDqExOq1FjkxjrYBnmlR5AnQKkbce1HOVthPhpoFe9MGZ+4FxLu0kAyFFv8JzkahzJ4hLRM0p4oEuaxNbcimpJ0KAOK65bHC8ISWg6q6RDEZeLwg4p8aH0dy22aDXx3CJw+gvkfcbZWgfNeqFrT8aBbCIXfR1eEjhCU1wqxR4S3Lu6ni+0SzpH6tcTg0RfZhNi6Ui3YvehiGnhmPIMEtRIJf1opUdKsIQQGfbIyRkg==; 5:BfWRKR3knCwCDJ4jXXpl1JJ71J0ibspGBl2xIELMrTUB94S9/UiBs0zSAF9Uy4XrdbUeohy8PG3gDO5KiIgPgdJleXkMSlS6SrFsRXpAImQYePHXyB1+YZXURAUsVoT0ArrvElo2s4O+0mNecaq0DLnVW+2p3TKitRfcjRPsp9M=; 24:6699QDgZ7MiGTMF+cZJ6xjVUB8U9T1JU6hASmyXH7PFa02Sb0swptHuRFXnXVqjjx5HwJOUrJk77p0NuCn5+R+d916MnCJ3R9tryurK0SOo=; 7:Shaqb60R0rSwQYDSl3KyxBtIp5P9BYDrvlcV31gD3CYGcKvVMR9ON7llUlPxJWkaRSyvc8icLRmgOolf4i7pCOfCMgUrh5TegzrbAcpFnry5guuu6dEHmWTENtg8tWFmJXivdpgNeVH+dp2SuGWqBeioOyYaKS4qIEkNfc4mYdOu5Zg65n9ly2Y/D5y/TP2C42lEgMKeeeIqa6FUGob9E9c5VHcDuBmSb5fJiOzN/HA= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-office365-filtering-correlation-id: 072ee569-07c3-4753-1c7a-08d4f515a302 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:AM2PR05MB1041; x-ms-traffictypediagnostic: AM2PR05MB1041: x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123560025)(20161123562025)(20161123555025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM2PR05MB1041; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM2PR05MB1041; x-forefront-prvs: 0422860ED4 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39860400002)(377454003)(13464003)(199003)(24454002)(189002)(101416001)(33656002)(2950100002)(6916009)(86362001)(229853002)(50986999)(7696004)(76176999)(5660300001)(54356999)(74316002)(54906002)(53546010)(14454004)(110136004)(6246003)(2900100001)(53936002)(189998001)(6436002)(66066001)(55016002)(8676002)(97736004)(9686003)(99286003)(81166006)(5250100002)(305945005)(6506006)(4326008)(7736002)(3846002)(8936002)(106356001)(25786009)(102836003)(81156014)(105586002)(478600001)(6116002)(3660700001)(3280700002)(68736007)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR05MB1041; H:AM2PR05MB0689.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Sep 2017 10:54:24.2931 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR05MB1041 Subject: Re: [dpdk-dev] [PATCH v2 3/3] net/mlx5: fix interrupt enable return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Sep 2017 10:54:27 -0000 Hi , The problem was that the value ret was not set to 0. As a result we got a warning message: WARN("unable to arm interrupt on rx queue %d", rx_queue_id); The fix is ret =3D0; I was looking with Nelio for the right commits that this bug fixes = I am=20 pretty sure that this ret value was not initialized. -Shachar Beiser. > -----Original Message----- > From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com] > Sent: Tuesday, September 5, 2017 4:27 PM > To: Shachar Beiser > Cc: dev@dpdk.org; N=E9lio Laranjeiro ; > stable@dpdk.org > Subject: Re: [PATCH v2 3/3] net/mlx5: fix interrupt enable return value >=20 > Hi Shachar, >=20 > On Tue, Sep 05, 2017 at 01:04:38PM +0000, Shachar Beiser wrote: > > return value is sometimes returned uninitialized > > > > Fixes: e1016cb73383 ("net/mlx5: fix Rx interrupts management") > > Fixes: b18042fb8f49 ("net/mlx5: fix misplaced Rx interrupts > > functions") > > > > Cc: adrien.mazarguil@6wind.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Shachar Beiser >=20 > Looks like in both commits, ret is properly initialized so I'm wondering = if the > fixes line is right? Did you even get a compilation error? >=20 > Otherwise, you should drop this patch from the series. >=20 > > --- > > drivers/net/mlx5/mlx5_rxq.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c > > index 437dc02..24887fb 100644 > > --- a/drivers/net/mlx5/mlx5_rxq.c > > +++ b/drivers/net/mlx5/mlx5_rxq.c > > @@ -1330,7 +1330,7 @@ > > struct priv *priv =3D mlx5_get_priv(dev); > > struct rxq *rxq =3D (*priv->rxqs)[rx_queue_id]; > > struct rxq_ctrl *rxq_ctrl =3D container_of(rxq, struct rxq_ctrl, rxq)= ; > > - int ret; > > + int ret =3D 0; > > > > if (!rxq || !rxq_ctrl->channel) { > > ret =3D EINVAL; > > -- > > 1.8.3.1 > > >=20 > -- > Adrien Mazarguil > 6WIND