Re: [dpdk-dev] [PATCH v2] net/failsafe: fix Rx interrupt reinstallation

[Matan Azrad <matan@mellanox.com>]

Hi Gaetan

From: Gaëtan Rivet, Sent: Wednesday, February 14, 2018 5:01 PM
> On Wed, Feb 14, 2018 at 04:00:13PM +0100, Gaëtan Rivet wrote:
> > On Wed, Feb 14, 2018 at 02:47:26PM +0000, Matan Azrad wrote:
> > > Fail-safe dev_start() operation can be called by both the
> > > application and the hot-plug alarm mechanism.
> > >
> > > The installation of Rx interrupt are triggered from dev_start() in
> > > any time it is called while actually the Rx interrupt should be
> > > installed only by the application calls.
> > >
> > > So, each plug-in event causes reinstallation which causes memory
> > > leak and spoils the fail-safe Rx interrupt mechanism.
> > >
> > > Trigger the Rx interrupt installation only when it does not exist.
> > >
> > > Fixes: 9e0360aebf23 ("net/failsafe: register as Rx interrupt mode")
> > >
> > > Signed-off-by: Matan Azrad <matan@mellanox.com>
> >
> > Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> 
> Actually no!
> 
> There is a mistake in the patch, you disabled the uninstall, instead of the
> installation.
>
No Gaetan, I think it is in the install.
Please recheck maybe by applying.
 
> --
> Gaëtan Rivet
> 6WIND