From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0057.outbound.protection.outlook.com [104.47.0.57]) by dpdk.org (Postfix) with ESMTP id B5F5B1C858 for ; Wed, 4 Apr 2018 20:23:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=B6uM0Wt19WwlDGf1RqVT0TP4KCuSYol1qKW88VNj9Aw=; b=cTO0Mh0ITbg7ICtfaZgS/VJkNxqm2K1w/tnRBwK3ufMTaGJUoyUThsjrYlZ71ZIL7b/pad1gyWFRIMHoM81DEjbl+BXlKMvH8RBkiq3mG7Inp/fLrB+j/s2w6T7CWChol6yw8tN1PoKQ1MaUR8GiOds5RMc1ZL6ofel6VS37hvA= Received: from AM4PR0501MB2657.eurprd05.prod.outlook.com (10.172.215.19) by AM4PR0501MB2642.eurprd05.prod.outlook.com (10.172.215.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.653.12; Wed, 4 Apr 2018 18:23:19 +0000 Received: from AM4PR0501MB2657.eurprd05.prod.outlook.com ([fe80::6885:c169:afcb:37e6]) by AM4PR0501MB2657.eurprd05.prod.outlook.com ([fe80::6885:c169:afcb:37e6%7]) with mapi id 15.20.0653.012; Wed, 4 Apr 2018 18:23:19 +0000 From: Matan Azrad To: Pavan Nikhilesh , "jerin.jacob@caviumnetworks.com" , "keith.wiles@intel.com" , Thomas Monjalon CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 1/2] eal: add API to align integer to previous power of 2 Thread-Index: AQHTy/4PDze0s6BzekuJxdjllw+CNqPwxeaQgAAJ2wCAAAOT4IAAD++AgAACtMCAAAQCAIAAAYVQ Date: Wed, 4 Apr 2018 18:23:19 +0000 Message-ID: References: <20180217104934.17291-1-pbhagavatula@caviumnetworks.com> <20180404101606.5156-1-pbhagavatula@caviumnetworks.com> <20180404164207.GA21153@ltp-pvn> <20180404175156.GA5416@ltp-pvn> <20180404181557.GA30549@ltp-pvn> In-Reply-To: <20180404181557.GA30549@ltp-pvn> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [85.64.136.190] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR0501MB2642; 7:299/3+SbJL9IDo/xJL5LqZbhwffBSfyundbtJ84zI3CZu1lkSu9vgzn5mOzKiI7fH5TuXTwgkSsIGYSBjyAWBUZyUm0Bvnb+lTjQ6VJEmLzpjtCpfHD2e4a/Hm5XlRUHJe4NiTKSOs7VPhHYb/WMkqMwCU3TL/wsPQuE3cqfx/ZYW6zpkmsVWxsttAtlPf3G80QL6bJXTZ5d9g4v/nN8PqFWoaJDcmMsygKSjUSOwEJtkgdX0ZE05GLglR9pR+ii x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 3622d2fc-3ac3-45a8-8b8f-08d59a59241e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(3008032)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM4PR0501MB2642; x-ms-traffictypediagnostic: AM4PR0501MB2642: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3002001)(3231221)(944501327)(52105095)(6055026)(6041310)(20161123564045)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011); SRVR:AM4PR0501MB2642; BCL:0; PCL:0; RULEID:; SRVR:AM4PR0501MB2642; x-forefront-prvs: 0632519F33 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(39380400002)(346002)(39860400002)(396003)(366004)(199004)(189003)(76176011)(26005)(110136005)(186003)(476003)(53936002)(11346002)(446003)(99286004)(7696005)(7736002)(6116002)(3846002)(2501003)(14454004)(55016002)(9686003)(81156014)(81166006)(8936002)(229853002)(5250100002)(2201001)(102836004)(8676002)(86362001)(6506007)(6246003)(106356001)(3280700002)(2906002)(478600001)(97736004)(33656002)(3660700001)(66066001)(316002)(305945005)(93886005)(74316002)(68736007)(2900100001)(4326008)(25786009)(5660300001)(105586002)(6436002)(486006); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR0501MB2642; H:AM4PR0501MB2657.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: BBYgI5Yd9AME2TvYHKryU007jbch68Pg94zuOJc59TuIq6D2mROAyg3AiIqEjHC9pv47f6K9IJ2uEZjUBWcs9OHKKKBhdjVp4YX2CP2XJL2YZtePYpgQcxNyRxAnIRO1J67FtBa1sjsklX8kScd4Y6aNv8DojKxnd0jktb//uBJwD8DwivOFgCbNj+bApnAYAfNBMP2BgYrW9YhkJMUJrqQuEBu/MSb1eEZtSvREJNij/OHPIyA27egdg+tjarwngcrcvBJ/ovzWeY9RTRkiINmZZIlNdV4UO+FIoeMf6tmGkK4dYmiVbYYkCZmizL/xcBW7wsMdzse6NPCzg7tbjKu2rpoV1ijdmG9pCyMxOqaM802uXwHCrAbYjYmn2WblS81fKKAHujCbTi9kMg2qs8UF+7shbG3Yj4OFv/n2EIQ= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3622d2fc-3ac3-45a8-8b8f-08d59a59241e X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Apr 2018 18:23:19.0604 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0501MB2642 Subject: Re: [dpdk-dev] [PATCH v3 1/2] eal: add API to align integer to previous power of 2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Apr 2018 18:23:21 -0000 Hi Pavan From: Pavan Nikhilesh, Wednesday, April 4, 2018 9:16 PM > Hi Matan, >=20 > > > > Got you. > > Looks like you found issue here... > > The experimental tag probably should be in a root .h file. > > Probably, need a fix patch to move it for a different\new .h file. > > > > What do you think? > > >=20 > Actually thats just start of the rabbit hole, if we succeed to tag a inli= ne > function in rte_common.h as experimental every lib/driver that uses > rte_common.h (almost everything) needs to have CFLAGS set to - > DALLOW_EXPERIMENTAL_API. >=20 Isn't it relevant only for the libs which are using the new tagged APIs? > Regards, > Pavan.