From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40065.outbound.protection.outlook.com [40.107.4.65]) by dpdk.org (Postfix) with ESMTP id 360E71C81E for ; Wed, 4 Apr 2018 19:11:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=hppQ3pb8OnY9kcHTI0r3AlGrO5dQCbbHInfuMajtkWY=; b=WTN1Gpynys7cauXxFK3HChipnL8K7Er6kYgBkmDJhmAT4O6yAToObQ+2GkxWET3qbgFCWVQ3w0D373NDLHbsLBIe3Qi8DI3ww4q9gIF5MGdo5ZUDZbaLSOgpe8wGg7BETpzkinne4auHsqsHQCN82tqudmLu5UntI515A3rCvDU= Received: from AM4PR0501MB2657.eurprd05.prod.outlook.com (10.172.215.19) by AM4PR0501MB3587.eurprd05.prod.outlook.com (10.167.90.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.653.12; Wed, 4 Apr 2018 17:11:22 +0000 Received: from AM4PR0501MB2657.eurprd05.prod.outlook.com ([fe80::6885:c169:afcb:37e6]) by AM4PR0501MB2657.eurprd05.prod.outlook.com ([fe80::6885:c169:afcb:37e6%7]) with mapi id 15.20.0653.012; Wed, 4 Apr 2018 17:11:22 +0000 From: Matan Azrad To: Pavan Nikhilesh , "jerin.jacob@caviumnetworks.com" , "keith.wiles@intel.com" , Thomas Monjalon CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 1/2] eal: add API to align integer to previous power of 2 Thread-Index: AQHTy/4PDze0s6BzekuJxdjllw+CNqPwxeaQgAAJ2wCAAAOT4A== Date: Wed, 4 Apr 2018 17:11:22 +0000 Message-ID: References: <20180217104934.17291-1-pbhagavatula@caviumnetworks.com> <20180404101606.5156-1-pbhagavatula@caviumnetworks.com> <20180404164207.GA21153@ltp-pvn> In-Reply-To: <20180404164207.GA21153@ltp-pvn> Accept-Language: en-US, he-IL Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=matan@mellanox.com; x-originating-ip: [85.64.136.190] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR0501MB3587; 7:k1RpcY1KttT7A3H3z/IQbifKzSSy5y+jC4CM2ZFwSV88goVVp7FhM67P71hp2gzm8EUNBf/WP4XuVINFToEokBZuRYJTA2dFpIGOyKN9X3eAZQK6D8vXuwCBimyke5y7HwZGdOK55Amn36cdR4OeKLE7k87RARsZ4YFzp3sVFhLqrvbwHT35uxVqlusQWcGF68wiIOBKFosP9l4EhaOguysNQj4zl9bSEMPnTUOxSBTTvmcfZFA1rLRb9GcbDEbJ x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 77cec791-3e6d-4741-eba5-08d59a4f170e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(3008032)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM4PR0501MB3587; x-ms-traffictypediagnostic: AM4PR0501MB3587: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(244540007438412); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231221)(944501327)(52105095)(6055026)(6041310)(20161123560045)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(6072148)(201708071742011); SRVR:AM4PR0501MB3587; BCL:0; PCL:0; RULEID:; SRVR:AM4PR0501MB3587; x-forefront-prvs: 0632519F33 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(366004)(346002)(376002)(39860400002)(39380400002)(189003)(199004)(6506007)(305945005)(2201001)(229853002)(6116002)(7736002)(316002)(86362001)(5250100002)(99286004)(8936002)(102836004)(68736007)(186003)(26005)(5660300001)(2501003)(476003)(93886005)(14454004)(478600001)(486006)(74316002)(81156014)(8676002)(81166006)(446003)(25786009)(3660700001)(33656002)(2906002)(106356001)(97736004)(11346002)(110136005)(4326008)(66066001)(7696005)(3280700002)(6246003)(105586002)(966005)(6436002)(55016002)(9686003)(53936002)(76176011)(2900100001)(6306002)(3846002)(357404004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR0501MB3587; H:AM4PR0501MB2657.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 26Qp0FFJsSgOxthg5toh9/gZncC+qIDuibegmShji8gk3Y6d+idHm6wWefLcvMmuSdAYwxTktTVqn5Zh2iKlU+0Uv22VbxReQIbf7eK+BqBSdDU7ktDMWwgze+XklKYZ85waPLujFAhH0reh/FXADs2uEcZjt8BjZc/FkMy87amf3Md0kzPyQrZHFia38+17jSMRAzghLQzpuwH5PrYHldPrVH4gkEACCctiYR51x9JTUdH7oN7w7R96GYEz9ojPo7j0GivwBL6c9rIMZNCl2eCCqXB/JMrBGM/H2VuG2ji07CyoXtOGjUkkvK98BsO3C7j14S5+zr2dUBskYl6OPA8PApYxHHByWdZyvv9jvg9K3fYdYuBPp/Wx/Iev8M5spIyvkgE23/Bdy9i3pktOeJTqRFeKddKrMwI1j3SayLo= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 77cec791-3e6d-4741-eba5-08d59a4f170e X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Apr 2018 17:11:22.1334 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0501MB3587 Subject: Re: [dpdk-dev] [PATCH v3 1/2] eal: add API to align integer to previous power of 2 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Apr 2018 17:11:30 -0000 From: Pavan Nikhilesh, Wednesday, April 4, 2018 7:42 PM > Hi Matan, >=20 > On Wed, Apr 04, 2018 at 04:10:36PM +0000, Matan Azrad wrote: > > Hi Pavan > > > > Shouldn't the new APIs be tagged with the experimental tag as agreed? >=20 > Can't tag it experimental as it causes cyclic dependency (need to include > rte_compact.h). You probably mean rte_compat.h. It is ok to add it, what is the issue with that? > Besides it's a simple proven math API I don't think it will change anytim= e > soon. It has already discussed: https://dpdk.org/dev/patchwork/patch/35211/ I think you need to add it anyway. > Thanks, > Pavan >=20 > > > > Besides that, > > Acked-by: Matan Azrad > > > > From: Pavan Nikhilesh, Wednesday, April 4, 2018 1:16 PM > > > Add 32b and 64b API's to align the given integer to the previous powe= r of > 2. > > > > > > Signed-off-by: Pavan Nikhilesh > > > --- > > > v3 Changes: > > > - Move commonly used code to rte_combine(32/64)ms1b so that it can > > > be reused. > > > > > > v2 Changes: > > > - Modified api name to `rte_align(32/64)prevpow2` from > > > `rte_align(32/64)lowpow2`. > > > - corrected fuction to return if the integer is already aligned to = power of > 2. > > > > > > lib/librte_eal/common/include/rte_common.h | 92 > > > ++++++++++++++++++++++++++---- > > > 1 file changed, 81 insertions(+), 11 deletions(-) > > > > > > diff --git a/lib/librte_eal/common/include/rte_common.h > > > b/lib/librte_eal/common/include/rte_common.h > > > index c7803e41c..7e147dcf2 100644 > > > --- a/lib/librte_eal/common/include/rte_common.h > > > +++ b/lib/librte_eal/common/include/rte_common.h > > > @@ -223,6 +223,51 @@ extern int > RTE_BUILD_BUG_ON_detected_error; } > > > while(0) #endif > > > > > > +/** > > > + * Combines 32b inputs most significant set bits into the least > > > + * significant bits to construct a value with the same MSBs as x > > > + * but all 1's under it. > > > + * > > > + * @param x > > > + * The integer whose MSBs need to be combined with its LSBs > > > + * @return > > > + * The combined value. > > > + */ > > > +static inline uint32_t > > > +rte_combine32ms1b(register uint32_t x) { > > > + x |=3D x >> 1; > > > + x |=3D x >> 2; > > > + x |=3D x >> 4; > > > + x |=3D x >> 8; > > > + x |=3D x >> 16; > > > + > > > + return x; > > > +} > > > + > > > +/** > > > + * Combines 64b inputs most significant set bits into the least > > > + * significant bits to construct a value with the same MSBs as x > > > + * but all 1's under it. > > > + * > > > + * @param v > > > + * The integer whose MSBs need to be combined with its LSBs > > > + * @return > > > + * The combined value. > > > + */ > > > +static inline uint64_t > > > +rte_combine64ms1b(register uint64_t v) { > > > + v |=3D v >> 1; > > > + v |=3D v >> 2; > > > + v |=3D v >> 4; > > > + v |=3D v >> 8; > > > + v |=3D v >> 16; > > > + v |=3D v >> 32; > > > + > > > + return v; > > > +} > > > + > > > /*********** Macros to work with powers of 2 ********/ > > > > > > /** > > > @@ -250,15 +295,28 @@ static inline uint32_t rte_align32pow2(uint32_= t > x) { > > > x--; > > > - x |=3D x >> 1; > > > - x |=3D x >> 2; > > > - x |=3D x >> 4; > > > - x |=3D x >> 8; > > > - x |=3D x >> 16; > > > + x =3D rte_combine32ms1b(x); > > > > > > return x + 1; > > > } > > > > > > +/** > > > + * Aligns input parameter to the previous power of 2 > > > + * > > > + * @param x > > > + * The integer value to algin > > > + * > > > + * @return > > > + * Input parameter aligned to the previous power of 2 > > > + */ > > > +static inline uint32_t > > > +rte_align32prevpow2(uint32_t x) > > > +{ > > > + x =3D rte_combine32ms1b(x); > > > + > > > + return x - (x >> 1); > > > +} > > > + > > > /** > > > * Aligns 64b input parameter to the next power of 2 > > > * > > > @@ -272,16 +330,28 @@ static inline uint64_t rte_align64pow2(uint64_= t > v) { > > > v--; > > > - v |=3D v >> 1; > > > - v |=3D v >> 2; > > > - v |=3D v >> 4; > > > - v |=3D v >> 8; > > > - v |=3D v >> 16; > > > - v |=3D v >> 32; > > > + v =3D rte_combine64ms1b(v); > > > > > > return v + 1; > > > } > > > > > > +/** > > > + * Aligns 64b input parameter to the previous power of 2 > > > + * > > > + * @param v > > > + * The 64b value to align > > > + * > > > + * @return > > > + * Input parameter aligned to the previous power of 2 > > > + */ > > > +static inline uint64_t > > > +rte_align64prevpow2(uint64_t v) > > > +{ > > > + v =3D rte_combine64ms1b(v); > > > + > > > + return v - (v >> 1); > > > +} > > > + > > > /*********** Macros for calculating min and max **********/ > > > > > > /** > > > -- > > > 2.16.3 > >