From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vasilyf@mellanox.com>
Received: from EUR01-DB5-obe.outbound.protection.outlook.com
 (mail-db5eur01on0086.outbound.protection.outlook.com [104.47.2.86])
 by dpdk.org (Postfix) with ESMTP id 1B6CB293B
 for <dev@dpdk.org>; Mon, 26 Jun 2017 07:53:09 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;
 s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
 bh=ohjls3shnlOCVK2RR4ElhGfzjsd3C62TaCDj3z7D314=;
 b=RnbIZrLFxeAX50zfCZqQreL8e0ecV9eD7tFxX5AtqQUKpq29qhykHAVfYe4+MSwVBlr8RfjIqoA8rhnD898AmpxJhKeUXbXW8tMVtMMkXdrHZ7Clr1owXDg7njGajDKJvbcTIX3faxCdHUtvd4uae/6jTdmrf24n1EMkRyNiyoY=
Received: from AM4PR0501MB2689.eurprd05.prod.outlook.com (10.172.215.138) by
 AM4PR0501MB2692.eurprd05.prod.outlook.com (10.172.215.141) with Microsoft
 SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1199.15; Mon, 26
 Jun 2017 05:53:07 +0000
Received: from AM4PR0501MB2689.eurprd05.prod.outlook.com
 ([fe80::cdf4:db73:a1e:9f12]) by AM4PR0501MB2689.eurprd05.prod.outlook.com
 ([fe80::cdf4:db73:a1e:9f12%13]) with mapi id 15.01.1199.019; Mon, 26 Jun 2017
 05:53:07 +0000
From: Vasily Philipov <vasilyf@mellanox.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 =?iso-8859-1?Q?N=E9lio_Laranjeiro?= <nelio.laranjeiro@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH v4 4/4] app/testpmd: add isolated mode
 parameter
Thread-Index: AQHS3Td2i/6qZCYXCkyZp2xlGfVpyKItDioAgAIcd7CAAQRpgIAGldcQ
Date: Mon, 26 Jun 2017 05:53:07 +0000
Message-ID: <AM4PR0501MB26894E7348B85E15EA11F1AADBDF0@AM4PR0501MB2689.eurprd05.prod.outlook.com>
References: <0dca86aa1372d6ff09d0aff01d522c580e0e24ab.1495717153.git.vasilyf@mellanox.com>
 <96c3dca8015a755afb37bf35ae85e6fa16282c0c.1496583000.git.vasilyf@mellanox.com>
 <9BB6961774997848B5B42BEC655768F810DAA4BE@SHSMSX103.ccr.corp.intel.com>
 <AM4PR0501MB26896736C1579D254960D25FDBDA0@AM4PR0501MB2689.eurprd05.prod.outlook.com>
 <9BB6961774997848B5B42BEC655768F810DAC7A8@SHSMSX103.ccr.corp.intel.com>
In-Reply-To: <9BB6961774997848B5B42BEC655768F810DAC7A8@SHSMSX103.ccr.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: intel.com; dkim=none (message not signed)
 header.d=none;intel.com; dmarc=none action=none header.from=mellanox.com;
x-originating-ip: [193.47.165.251]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; AM4PR0501MB2692;
 7:YJAduelEo5bSxaRNCFNe9v/FNvyh20ni+2dGk1df9+7P4K8vCeywSBI7kWvf6NMnEY++fjeh/YGzxlwvJtP2mXA0vGxQgrQRoQG9Gi+9Cr6e5RWmFA7byJ1mqM8C65uOsTTU2CNBV3QyLs5z6EYdMRHwjt7/HTdpEZAq1P85cZ8tKjP1n6/CofFzt97qhHTHkMVtpebtk6pGKQ6KAHZC5X+CkptkuHKRlPAp86NJRORJDOBUPuAGuvX9x78JSsYXuoP74s3+DV6/ii5amjjtBKAXqFctwrCqWfGStpiJ58hMgaY7xvmDcbDqeClFazZI9DVSBsTlwwz6a6Z5yKWUv0uVUmelxutOyYaEVFJ2UpwTyyavKHYs7W05ve7UQnCYCf9uh49aQgzws0hS8/MVT4nTvwj81z7YqFemlfs9lsaTI/m0FTdesPDczS7idtU6s7qg3dGM1QE0TQ+BIiu0wdTWN/PXsmufkuLTzeJe4Vt3/e/FdZgo3xhaWiuUhaEnxZ44M70QS8n/p4+OTYAOG4dr+293RdkWAR55tUksVnzd+QkZz9pJz8o58lprbjZWqfj8reEhvsXXZx9g6gqZlLSzDoeFg5A0sM3OH2CM7dk0gCWYfMs3vk91144Q6mW17BQz2RID4pQCCSWocBqu48+l99iqV3q3nD3erHZLy5d67dwhIL6jklhem/yyegKaLh52ktD+IM4KkgFzZzb9ipbayTjXAYMvHvMgcImKWP3EgbqjJnYkPVUgtFDAzzo3uVKzD7Lj7WR0nBvVjajz53hLUogydLA4JfiuHXwnSMI=
x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr
x-ms-office365-filtering-correlation-id: ccee26b3-84d1-4f05-3455-08d4bc579ec9
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: UriScan:; BCL:0; PCL:0;
 RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254075)(48565401081)(300000503095)(300135400095)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506067)(300135500095);
 SRVR:AM4PR0501MB2692; 
x-ms-traffictypediagnostic: AM4PR0501MB2692:
x-microsoft-antispam-prvs: <AM4PR0501MB2692940B99DA93047F997555DBDF0@AM4PR0501MB2692.eurprd05.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(236129657087228)(228905959029699);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0;
 RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123564025)(20161123560025)(20161123562025)(20161123555025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);
 SRVR:AM4PR0501MB2692; BCL:0; PCL:0;
 RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);
 SRVR:AM4PR0501MB2692; 
x-forefront-prvs: 0350D7A55D
x-forefront-antispam-report: SFV:NSPM;
 SFS:(10009020)(6009001)(39450400003)(39840400002)(39860400002)(39850400002)(39410400002)(39400400002)(13464003)(377454003)(50986999)(54356999)(74316002)(76176999)(5660300001)(305945005)(2900100001)(2501003)(478600001)(966005)(2950100002)(5250100002)(38730400002)(9686003)(33656002)(53376002)(6506006)(6306002)(54906002)(99286003)(55016002)(7696004)(53546010)(14454004)(53936002)(6246003)(6436002)(25786009)(6116002)(4326008)(8936002)(189998001)(2906002)(3846002)(3280700002)(66066001)(3660700001)(81166006)(8676002)(102836003)(7736002)(229853002)(86362001)(93886004);
 DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR0501MB2692;
 H:AM4PR0501MB2689.eurprd05.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en;
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jun 2017 05:53:07.6023 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0501MB2692
Subject: Re: [dpdk-dev] [PATCH v4 4/4] app/testpmd: add isolated mode
 parameter
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Jun 2017 05:53:09 -0000



> -----Original Message-----
> From: Wu, Jingjing [mailto:jingjing.wu@intel.com]
> Sent: Thursday, June 22, 2017 04:13
> To: Vasily Philipov <vasilyf@mellanox.com>; dev@dpdk.org
> Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>; N=E9lio Laranjeiro
> <nelio.laranjeiro@6wind.com>=09
> Subject: RE: [dpdk-dev] [PATCH v4 4/4] app/testpmd: add isolated mode
> parameter
>=20
>=20
>=20
> > -----Original Message-----
> > From: Vasily Philipov [mailto:vasilyf@mellanox.com]
> > Sent: Wednesday, June 21, 2017 5:44 PM
> > To: Wu, Jingjing <jingjing.wu@intel.com>; dev@dpdk.org
> > Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>; N=E9lio Laranjeiro
> > <nelio.laranjeiro@6wind.com>
> > Subject: RE: [dpdk-dev] [PATCH v4 4/4] app/testpmd: add isolated mode
> > parameter
> >
> >
> >
> > > -----Original Message-----
> > > From: Wu, Jingjing [mailto:jingjing.wu@intel.com]
> > > Sent: Tuesday, June 20, 2017 04:27
> > > To: Vasily Philipov <vasilyf@mellanox.com>; dev@dpdk.org
> > > Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>; N=E9lio Laranjeiro
> > > <nelio.laranjeiro@6wind.com>
> > > Subject: RE: [dpdk-dev] [PATCH v4 4/4] app/testpmd: add isolated
> > > mode parameter
> > >
> > >
> > > > +/*
> > > >   * Avoids to check link status when starting/stopping a port.
> > > >   */
> > > >  uint8_t no_link_check =3D 0; /* check by default */ @@ -1422,6
> > > > +1427,15 @@ static void eth_event_callback(uint8_t port_id,
> > > >  		if (port->need_reconfig > 0) {
> > > >  			port->need_reconfig =3D 0;
> > > >
> > > > +			if (isolated_mode) {
> > > > +				int ret =3D port_flow_isolate(pi, 1);
> > > > +				if (ret) {
> > > > +					printf("Failed to apply isolated"
> > > > +					       " mode on port %d\n", pi);
> > > > +					return -1;
> > > > +				}
> > > > +			}
> > > > +
> > > Should it block the app startup if isolated-mode setting fails?
> >
> > if isolated mode cannot be enabled on any port, that port cannot be
> > initialized and that causes testpmd to quit, at least it won't go
> > against the user's wishes
>=20
> If so, I prefer the isolated_mode to be port's argument but not global on=
e.

Could you please provide some example of such argument - I will take it as =
a reference...


> How about to add a command to configure the isolate mode?

This is already exists - just type "flow isolate {port_id} {boolean}" from =
testpmd prompt=20
Please see at:

http://dpdk.org/ml/archives/dev/2017-April/064327.html
http://dpdk.org/dev/patchwork/patch/23741/