From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on0085.outbound.protection.outlook.com [104.47.2.85]) by dpdk.org (Postfix) with ESMTP id 7BDFA559A for ; Wed, 21 Jun 2017 11:43:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NVwaMDFfQSknQxnBilSSgPUc1vqaaDj/Np1FRsLBaFA=; b=oXb2tPjQVhBTreA5ZvklFFCCGVFxYPlNBq1FVBIo/bvBjDBztIyolmdzljyiztHMlCvbETdsIMCua86ZI+ib8kHhT5/nuX/3ElWNXn0meDEsNvlkUo5s0vm3DLT+eh8qFjQWTtg9/c38A1rQmkOFl1zRrFUxwnnh3gOBanZMnLQ= Received: from AM4PR0501MB2689.eurprd05.prod.outlook.com (10.172.215.138) by AM4PR0501MB2691.eurprd05.prod.outlook.com (10.172.215.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1178.14; Wed, 21 Jun 2017 09:43:45 +0000 Received: from AM4PR0501MB2689.eurprd05.prod.outlook.com ([fe80::25d8:40d3:86af:a35]) by AM4PR0501MB2689.eurprd05.prod.outlook.com ([fe80::25d8:40d3:86af:a35%15]) with mapi id 15.01.1178.023; Wed, 21 Jun 2017 09:43:45 +0000 From: Vasily Philipov To: "Wu, Jingjing" , "dev@dpdk.org" CC: Adrien Mazarguil , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= Thread-Topic: [dpdk-dev] [PATCH v4 4/4] app/testpmd: add isolated mode parameter Thread-Index: AQHS3Td2i/6qZCYXCkyZp2xlGfVpyKItDioAgAIcd7A= Date: Wed, 21 Jun 2017 09:43:45 +0000 Message-ID: References: <0dca86aa1372d6ff09d0aff01d522c580e0e24ab.1495717153.git.vasilyf@mellanox.com> <96c3dca8015a755afb37bf35ae85e6fa16282c0c.1496583000.git.vasilyf@mellanox.com> <9BB6961774997848B5B42BEC655768F810DAA4BE@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <9BB6961774997848B5B42BEC655768F810DAA4BE@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR0501MB2691; 7:rZ28fh6xDuZUXOvrY6Fa8SdUCG7DXBTThsEMp8UCZojby5jSYnRSFW0nO15ZZIncsEktm6WUPTBDIbcEQWv/38du154fZFCrHpJXKT1vMpMfc7Q4BkjvzvY4Ial56W1+kzugAshgIIqll+OND2WINQ4EM+rd/dCrYBzd2+VGQLNr2Ax7Z6qMNpxeGWvp5sNYak+6SGKOBVZOlUZ6kJxApa4xHxZiFSWZ9ANg7QZStlqIRy0zlPULgPruP+9Y0QgDnWCm/Eo93Jp3b+T+BD4pwgjsAPlHr6r8ajbccV4pm07TJliJVTzmzq1Dr3sJ3r/wMON5aOJyZ7i2myLrkEPiPZ8RQkai2v17L57wVuqursHxyPkkyalr+2OEG07GV1zRP6jE8sD6U7xhc7ES5qWArcRVt8osuAnvuoXXr355KQzA8bk0zZjyuwkTd7VwUczWG5IO2L+M/spHqMnCKJrwHS88yIfgTwarSY56uMhZBeyXTKp8UE2+xz2VZY/Wb6+ye2W7KTomBHXYgbzLP8ucDIhMgKRNz3+cQ0ur3EAypONzTH6wGUWmJzRs2YEjeVNzl5fpBOO9xni9zKy+eTJp00hiXS+WyRqfq5DzqRt48IoKlI57Z0sAt5vtxpQGFKsDGsbFyNEU9sRXmWfUMwRTzgyv8GpEZdEpfH4EgQ6BLb4CGKO7Koxnq06Y6vshDclRW/PgxcPkQmq1t1lbgJpGMOiYqk8YFTyPtFsI5jBEAc0GGtgktrVIgQN+Ll0/ZgyKb/fnAlZWd7ISDDONDb+Rv+7pcXqwuuLKjcjuDVA0r2g= x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-office365-filtering-correlation-id: 9631acc2-4b89-422e-8381-08d4b88a0289 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081); SRVR:AM4PR0501MB2691; x-ms-traffictypediagnostic: AM4PR0501MB2691: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123558100)(20161123564025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM4PR0501MB2691; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM4PR0501MB2691; x-forefront-prvs: 0345CFD558 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39840400002)(39850400002)(39860400002)(39400400002)(39450400003)(39410400002)(13464003)(14454004)(99286003)(38730400002)(5660300001)(81166006)(4326008)(478600001)(6116002)(8676002)(53546010)(189998001)(54906002)(229853002)(53936002)(102836003)(8936002)(3846002)(9686003)(55016002)(86362001)(2501003)(33656002)(2900100001)(305945005)(6436002)(3660700001)(3280700002)(50986999)(2950100002)(25786009)(7736002)(66066001)(5250100002)(76176999)(74316002)(54356999)(6506006)(7696004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR0501MB2691; H:AM4PR0501MB2689.eurprd05.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2017 09:43:45.2084 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0501MB2691 Subject: Re: [dpdk-dev] [PATCH v4 4/4] app/testpmd: add isolated mode parameter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2017 09:43:46 -0000 > -----Original Message----- > From: Wu, Jingjing [mailto:jingjing.wu@intel.com] > Sent: Tuesday, June 20, 2017 04:27 > To: Vasily Philipov ; dev@dpdk.org > Cc: Adrien Mazarguil ; N=E9lio Laranjeiro > > Subject: RE: [dpdk-dev] [PATCH v4 4/4] app/testpmd: add isolated mode > parameter >=20 >=20 > > +/* > > * Avoids to check link status when starting/stopping a port. > > */ > > uint8_t no_link_check =3D 0; /* check by default */ @@ -1422,6 +1427,1= 5 > > @@ static void eth_event_callback(uint8_t port_id, > > if (port->need_reconfig > 0) { > > port->need_reconfig =3D 0; > > > > + if (isolated_mode) { > > + int ret =3D port_flow_isolate(pi, 1); > > + if (ret) { > > + printf("Failed to apply isolated" > > + " mode on port %d\n", pi); > > + return -1; > > + } > > + } > > + > Should it block the app startup if isolated-mode setting fails? if isolated mode cannot be enabled on any port, that port cannot be initial= ized and that causes testpmd to quit, at least it won't go against the user's wi= shes