From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10071.outbound.protection.outlook.com [40.107.1.71]) by dpdk.org (Postfix) with ESMTP id 77A9E1B23D for ; Tue, 26 Dec 2017 15:08:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=juto40LBHiSEriFg5LrAP5bL5nMZYW2rJyvJWsIJDTk=; b=ju/DHVbCN/lSeUz7NfV9jCgmDHfeMKJWa6Trrdw3sbOtpAbfYWTC1lsKlaqLe+PAjBwxFpzQ9PK7fPHoC/kKX8JHZpnvDQd2VRhIeom4UIHNFZO5An7HndIh6QIOTHaKyhc5YJxxLdseoDkNZz0XNjJr8rEh7lyYAlnrSXif18g= Received: from AM4PR05MB1476.eurprd05.prod.outlook.com (10.164.79.142) by AM4PR05MB1476.eurprd05.prod.outlook.com (10.164.79.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.345.14; Tue, 26 Dec 2017 14:08:47 +0000 Received: from AM4PR05MB1476.eurprd05.prod.outlook.com ([fe80::d1dc:f4f0:aba8:5d3f]) by AM4PR05MB1476.eurprd05.prod.outlook.com ([fe80::d1dc:f4f0:aba8:5d3f%14]) with mapi id 15.20.0345.017; Tue, 26 Dec 2017 14:08:47 +0000 From: Ori Kam To: "Zhao1, Wei" CC: "Lu, Wenzhuo" , "dev@dpdk.org" Thread-Topic: [PATCH] examples/flow_filtering: add Tx queues setup process Thread-Index: AQHTfjDBUJuHQhVbPk6zH5jyc2hZeaNVpqGA Date: Tue, 26 Dec 2017 14:08:47 +0000 Message-ID: References: <20171226092104.82707-1-wei.zhao1@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR05MB1476; 7:+JwuYcEk2gTYRPbhdrBMCohcLxoPy9o5JBKiBrUX2qaYMjc30TtkW0j3nEUdpFIpX73hMuVxEyilC8zMPIwN9sUSglCeqzoul8vzbGIvkJi/gOVI4/pLIVFol5QILAmOcarOTdwkUMADKpEqVFq1JbIOsIakjnOy1/QeLso2fELf1h86rWnXzESCgwI3B1SgwRbzzu/SeRithFwlQ/kSnn+acpOpt6p46t37pCH2xZ14sE5/zxb0PvhW5zim+0Wr x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: fe7ac751-369f-43ce-0047-08d54c6a2e9c x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(5600026)(4604075)(3008032)(48565401081)(2017052603307)(7153060); SRVR:AM4PR05MB1476; x-ms-traffictypediagnostic: AM4PR05MB1476: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040470)(2401047)(5005006)(8121501046)(3231023)(944501075)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041268)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(6072148)(201708071742011); SRVR:AM4PR05MB1476; BCL:0; PCL:0; RULEID:(100000803101)(100110400095); SRVR:AM4PR05MB1476; x-forefront-prvs: 053315510E x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(376002)(39860400002)(39380400002)(366004)(346002)(13464003)(189003)(199004)(3280700002)(478600001)(54906003)(66066001)(76176011)(33656002)(7696005)(316002)(5660300001)(6306002)(68736007)(8936002)(6916009)(105586002)(2950100002)(305945005)(9686003)(97736004)(7736002)(5250100002)(966005)(55016002)(86362001)(99286004)(81166006)(74316002)(8676002)(2900100001)(81156014)(14454004)(2906002)(53936002)(3660700001)(4326008)(15188555004)(106356001)(3846002)(229853002)(6116002)(6436002)(102836004)(59450400001)(53376002)(6506007)(25786009)(53546011)(6246003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB1476; H:AM4PR05MB1476.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: IcXMKBq/9mCFJMpCGYZj93aaOwBfRdvdO97V/IYfRipLFxHi2OWesPfL7I9H2nISbonmPFosLkiQgiR8nkWE1A== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe7ac751-369f-43ce-0047-08d54c6a2e9c X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Dec 2017 14:08:47.3138 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB1476 Subject: Re: [dpdk-dev] [PATCH] examples/flow_filtering: add Tx queues setup process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Dec 2017 14:08:49 -0000 Hi Wei, Your patch looks good, but there is an ack patch that deals with offloads. http://dpdk.org/ml/archives/dev/2017-December/083639.html Please update your patch to support the new tx offloads.=20 Regards, Ori > -----Original Message----- > From: Zhao1, Wei [mailto:wei.zhao1@intel.com] > Sent: Tuesday, December 26, 2017 12:03 PM > To: Ori Kam > Cc: Lu, Wenzhuo ; dev@dpdk.org > Subject: RE: [PATCH] examples/flow_filtering: add Tx queues setup process >=20 > Add maintainer orika@mellanox.com into cc list. >=20 >=20 > > -----Original Message----- > > From: Zhao1, Wei > > Sent: Tuesday, December 26, 2017 5:21 PM > > To: dev@dpdk.org > > Cc: Lu, Wenzhuo ; Zhao1, Wei > > > > Subject: [PATCH] examples/flow_filtering: add Tx queues setup process > > > > This example do not has the process of set up tx queues, but some NIC > > start up process will be blocked if this is no tx queue and only rx > > queues. So add tx queues setup process in main code. > > > > Signed-off-by: Wei Zhao > > --- > > examples/flow_filtering/main.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/examples/flow_filtering/main.c > > b/examples/flow_filtering/main.c index 7d739b4..b5c7677 100644 > > --- a/examples/flow_filtering/main.c > > +++ b/examples/flow_filtering/main.c > > @@ -173,6 +173,17 @@ init_port(void) > > } > > } > > > > + for (i =3D 0; i < nr_queues; i++) { > > + ret =3D rte_eth_tx_queue_setup(port_id, i, 512, > > + rte_eth_dev_socket_id(port_id), > > + NULL); > > + if (ret < 0) { > > + rte_exit(EXIT_FAILURE, > > + ":: Tx queue setup failed: err=3D%d, > > port=3D%u\n", > > + ret, port_id); > > + } > > + } > > + > > rte_eth_promiscuous_enable(port_id); > > ret =3D rte_eth_dev_start(port_id); > > if (ret < 0) { > > -- > > 2.9.3