From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50066.outbound.protection.outlook.com [40.107.5.66]) by dpdk.org (Postfix) with ESMTP id F13EB2C6E for ; Tue, 4 Apr 2017 15:54:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=SVnqiFVRxQPKI6q/D5V4ekFFF6ErDo8hym3d339/ncA=; b=gogM7sq5CkOwl8btruRlRixum4A5B2Nh4QNUweyp1fWeBuxSEzCtpUMUcGUW/nNKBb5m9+3AcEcRaxkHEBFaa7vJA22thlieewL6j/eJJlK+6mvkcsx/9mBrHvaOZ9BFKesE6N6tTzHMHl2SMG+cHVbTyD5NriyVkFXte52t6Zk= Received: from AM4PR05MB1505.eurprd05.prod.outlook.com (10.164.79.147) by AM4PR05MB1507.eurprd05.prod.outlook.com (10.164.79.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1005.10; Tue, 4 Apr 2017 13:54:27 +0000 Received: from AM4PR05MB1505.eurprd05.prod.outlook.com ([fe80::6828:c9cb:35da:71f2]) by AM4PR05MB1505.eurprd05.prod.outlook.com ([fe80::6828:c9cb:35da:71f2%14]) with mapi id 15.01.1005.018; Tue, 4 Apr 2017 13:54:27 +0000 From: Shahaf Shuler To: Qi Zhang , "thomas.monjalon@6wind.com" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v4 2/2] eal: clean up interrupt handle Thread-Index: AQHSrUdBYZcngJ/7SkiKo7M2EtdeLqG1OiCg Date: Tue, 4 Apr 2017 13:54:27 +0000 Message-ID: References: <20170331020913.19004-1-qi.z.zhang@intel.com> <20170404212125.32114-1-qi.z.zhang@intel.com> <20170404212125.32114-3-qi.z.zhang@intel.com> In-Reply-To: <20170404212125.32114-3-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [193.47.165.251] x-microsoft-exchange-diagnostics: 1; AM4PR05MB1507; 7:TPe1W+2AMXaKqNAGm49VjQxJqp4FUrKGYzVStx1thfkcW6O3jTgo0CqXkN+LzwW7rcO9H290anjNK1sdoF9l+ykxwFtAghYkagX2iq+ccQfK4vcPKRRmjgkh8l+nF24yol3a6RDob9ZKh7RyjcVuRWQxWMGRA0haYN7J3Eylw62jdBmLXlvh/wrHc4h5FrMrIuf6HT7gmfDjz2kd77SCIC805ISUSODUdAfoMLrP+RKnbEzorPSjn0dE/EtXQJk/KL1JPs5VYoYSa3+CfxUUwhKfhjkRDlNN9r238sqixrwFt1GiD76TwyepHiAnONGjqLSMuZBz8r8jDlXhkEiweQ== x-ms-office365-filtering-correlation-id: 44bef999-99a1-4e99-a0b8-08d47b621c3b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081); SRVR:AM4PR05MB1507; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041248)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(20161123560025)(20161123564025)(20161123562025)(6072148); SRVR:AM4PR05MB1507; BCL:0; PCL:0; RULEID:; SRVR:AM4PR05MB1507; x-forefront-prvs: 0267E514F9 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39450400003)(39400400002)(39860400002)(39850400002)(39840400002)(39410400002)(377454003)(3846002)(74316002)(102836003)(5250100002)(3280700002)(2501003)(6116002)(6246003)(2906002)(7696004)(99286003)(9686003)(55016002)(2900100001)(25786009)(53936002)(81166006)(86362001)(8676002)(4326008)(229853002)(38730400002)(7736002)(189998001)(6436002)(50986999)(305945005)(66066001)(3660700001)(5660300001)(2950100002)(33656002)(6506006)(8936002)(54356999); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB1507; H:AM4PR05MB1505.eurprd05.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Apr 2017 13:54:27.4752 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB1507 Subject: Re: [dpdk-dev] [PATCH v4 2/2] eal: clean up interrupt handle X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2017 13:54:29 -0000 Wednesday, April 5, 2017 12:21 AM, Qi Zhang: > The patch change the prototype of callback function > (rte_intr_callback_fn) by removing the unnecessary parameter. >=20 > Signed-off-by: Qi Zhang > --- >=20 > v4: >=20 > - Update mlx5 driver which is missed in v1, v2, v3. Thanks for the update of mlx5. The compilation is still failing for mlx4. the implementation there is much= similar to mlx5. >=20 > v3: >=20 > - Update bnx2x driver which is missed in v1,v2 >=20 > v2: >=20 > - Seperate patch 1 of v1 into 2 patches.(part 2) >=20 > drivers/net/bnx2x/bnx2x_ethdev.c | 5 +++-- > drivers/net/bnxt/bnxt_irq.c | 3 +-- > drivers/net/e1000/em_ethdev.c | 8 +++----- > drivers/net/e1000/igb_ethdev.c | 15 ++++++--------- > drivers/net/enic/enic_main.c | 3 +-- > drivers/net/fm10k/fm10k_ethdev.c | 12 ++++-------- > drivers/net/i40e/i40e_ethdev.c | 8 +++----- > drivers/net/i40e/i40e_ethdev_vf.c | 5 ++--- > drivers/net/ixgbe/ixgbe_ethdev.c | 14 +++++--------- > drivers/net/mlx5/mlx5.h | 2 +- > drivers/net/mlx5/mlx5_ethdev.c | 3 +-- > drivers/net/nfp/nfp_net.c | 6 ++---- > drivers/net/qede/qede_ethdev.c | 4 ++-- > drivers/net/sfc/sfc_intr.c | 10 ++++++---- > drivers/net/virtio/virtio_ethdev.c | 5 ++--- > lib/librte_eal/common/include/rte_interrupts.h | 3 +-- > lib/librte_eal/linuxapp/eal/eal_alarm.c | 5 ++--- > lib/librte_eal/linuxapp/eal/eal_interrupts.c | 3 +-- > 18 files changed, 46 insertions(+), 68 deletions(-) [...] > @@ -119,12 +119,13 @@ bnx2x_interrupt_action(struct rte_eth_dev *dev)