From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20048.outbound.protection.outlook.com [40.107.2.48]) by dpdk.org (Postfix) with ESMTP id C07472BAE for ; Wed, 19 Apr 2017 07:22:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=NKFivn2XzOVaZPK2BBQiLIP6ZlHTNqtMaBXxreryURc=; b=Ee2XAYwskhJ9SqD8tTU9SAOt9OKWq4z/eQ1koFJ7b7H4YSQR0IT839ozXolDg+frvX0cQjpqDlIHHdEk40+8P7kivA/MUw1XJ8vpGW36/s7s4KmDBCWfTJZFkP4ApDgDdYKuoeTY8clWPmBJ2p9X0jQ0zaJuUroXVsHwIY19hoo= Received: from AM4PR05MB1505.eurprd05.prod.outlook.com (10.164.79.147) by AM4PR05MB1506.eurprd05.prod.outlook.com (10.164.79.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.10; Wed, 19 Apr 2017 05:22:26 +0000 Received: from AM4PR05MB1505.eurprd05.prod.outlook.com ([fe80::5c3d:704c:90d6:8bca]) by AM4PR05MB1505.eurprd05.prod.outlook.com ([fe80::5c3d:704c:90d6:8bca%14]) with mapi id 15.01.1034.018; Wed, 19 Apr 2017 05:22:26 +0000 From: Shahaf Shuler To: "Van Haaren, Harry" , "thomas.monjalon@6wind.com" , "thomas@monjalon.net" CC: Adrien Mazarguil , =?iso-8859-1?Q?N=E9lio_Laranjeiro?= , "dev@dpdk.org" , Gaetan Rivet Thread-Topic: [dpdk-dev] [PATCH] ethdev: fix compilation issue with strict flags Thread-Index: AQHStBb0lub8D7Izzka8C2YHdVta16HDCpQAgAkmRkA= Date: Wed, 19 Apr 2017 05:22:26 +0000 Message-ID: References: <20170413052927.82842-1-shahafs@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [193.47.165.251] x-microsoft-exchange-diagnostics: 1; AM4PR05MB1506; 7:NVMBFXBTqB0k0TT8F0wJKH8iraq+m160VDSf6/OtFo1KlpzG96Rl9wknODO+t4C/U4U9bEPxEubWdJ53P8phnnp0U8h+X+u1IPtTmIuG/IL+wIDIdlkYIL3H7I0DLK4NOc9cQtSW6ZaJwxF3uorjdLCYX3pWZ6bppzsA8OmEX6VPFvTQMv+deFuEgBoZit70OdoMju1Li4liOoHkv3pDKEohkI28+ydjqYQuU9u0H3hZQuyGpg7fGUyuYfwkOlhOsIz+ErLNSqL7Q2yy8gVcC87rUCTYMTmRL8AZkS5TdY6fKkPxjr7SP7+W/+LpjMrAFWyXeoQThZe9EML2ifi75g== x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-ms-office365-filtering-correlation-id: 2c6f792d-cb6c-4e4a-0fd2-08d486e41127 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081); SRVR:AM4PR05MB1506; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123560025)(20161123564025)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(6072148); SRVR:AM4PR05MB1506; BCL:0; PCL:0; RULEID:; SRVR:AM4PR05MB1506; x-forefront-prvs: 028256169F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39850400002)(39410400002)(39400400002)(39840400002)(39450400003)(39860400002)(377454003)(2900100001)(66066001)(54906002)(50986999)(76176999)(54356999)(9686003)(99286003)(55016002)(38730400002)(229853002)(33656002)(53546009)(25786009)(2501003)(4326008)(3846002)(6506006)(6436002)(7696004)(102836003)(189998001)(2950100002)(6116002)(74316002)(8676002)(86362001)(53936002)(3280700002)(81166006)(305945005)(2201001)(6246003)(5660300001)(8936002)(2906002)(7736002)(3660700001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB1506; H:AM4PR05MB1505.eurprd05.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Apr 2017 05:22:26.1598 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB1506 Subject: Re: [dpdk-dev] [PATCH] ethdev: fix compilation issue with strict flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Apr 2017 05:22:28 -0000 Hi, Any more comments on this commit? Could it be merged? Compilation is still = failing..=20 Thursday, April 13, 2017 12:36 PM, Van Haaren, Harry: > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shahaf Shuler > > Sent: Thursday, April 13, 2017 6:29 AM > > To: thomas.monjalon@6wind.com > > Cc: adrien.mazarguil@6wind.com; nelio.laranjeiro@6wind.com; > > dev@dpdk.org > > Subject: [dpdk-dev] [PATCH] ethdev: fix compilation issue with strict > > flags > > > > Compilation error seen while compiling mlx5 in debug mode under RHEL > > 7.3: > > > > rte_ethdev.h:1670:7: error: type of bit-field 'state' is a GCC extensio= n > > [-Werror=3Dpedantic] > > > > Address it by removing the unnecessary bit-field width limitation. > > > > Fixes: d52268a8b24b ("ethdev: expose device states") > > > > Signed-off-by: Shahaf Shuler Acked-by: Harry van Haaren Acked-by: Gaetan Rivet > > --- > > lib/librte_ether/rte_ethdev.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/librte_ether/rte_ethdev.h > > b/lib/librte_ether/rte_ethdev.h index d07253874..2d1bc12aa 100644 > > --- a/lib/librte_ether/rte_ethdev.h > > +++ b/lib/librte_ether/rte_ethdev.h > > @@ -1667,7 +1667,7 @@ struct rte_eth_dev { > > * received packets before passing them to the driver for > transmission. > > */ > > struct rte_eth_rxtx_callback > *pre_tx_burst_cbs[RTE_MAX_QUEUES_PER_PORT]; > > - enum rte_eth_dev_state state:8; /**< Flag indicating the port state > */ > > + enum rte_eth_dev_state state; /**< Flag indicating the port state */ > > } __rte_cache_aligned; > > > > struct rte_eth_dev_sriov {