From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10046.outbound.protection.outlook.com [40.107.1.46]) by dpdk.org (Postfix) with ESMTP id D638B1B3A3 for ; Sun, 29 Oct 2017 17:04:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=JYPhhxhLBudn+jrqgEblxzVxySslUBfYDH0g0npfb+I=; b=he3gOT+P3JXymoTqpwZw3wUGkxBNv15tDz9EnVee5FgPuHjm9a54E0CHZjJGcH0GlfDWHtGyajC/9zBsne2APTsFGrTL/CSINGDiybM7tCs0LbgCHA1jFWjAe9Yb5gvK+pALbTzaWKGFSAKzK/HB10UBQG7vx2YTfm/4rGMV+ng= Received: from AM4PR05MB3202.eurprd05.prod.outlook.com (10.171.186.31) by AM4PR05MB3204.eurprd05.prod.outlook.com (10.171.186.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.178.6; Sun, 29 Oct 2017 16:04:41 +0000 Received: from AM4PR05MB3202.eurprd05.prod.outlook.com ([fe80::7d32:49d9:bab3:fb94]) by AM4PR05MB3202.eurprd05.prod.outlook.com ([fe80::7d32:49d9:bab3:fb94%13]) with mapi id 15.20.0178.012; Sun, 29 Oct 2017 16:04:41 +0000 From: Ori Kam To: Thomas Monjalon CC: "dev@dpdk.org" , Adrien Mazarguil , "john.mcnamara@intel.com" , Ori Kam Thread-Topic: [dpdk-dev] [PATCH v2] examples/flow_filtering: demo of simple rte flow Thread-Index: AQHTTbrtbRJ4E4tgYUemT4z6I6gtE6L2xNKAgAQxiiA= Date: Sun, 29 Oct 2017 16:04:41 +0000 Message-ID: References: <1508407471-6252-1-git-send-email-orika@mellanox.com> <28eeef90ebaf5e8afb31837fade1b36c484f29a5.1508953769.git.orika@mellanox.com> <4865583.3QcsuuSVpe@xps> In-Reply-To: <4865583.3QcsuuSVpe@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR05MB3204; 6:ZlRbi8BBswnVENBeLbrNEPoPtgPt3V3ZVhmkvd+5VUwp8khjcNIS4mqAFKDEfNS9TcHO2H1iIjsxy6RkakTdsqZSI3r2hGfJnEtlja2e63ZjeOf/rMHU7/UyUOeoqRsvKHVi66eiK5CCLeHHLJUmZFyTBnUgsC1wt/TqFZcC+oUJyXG3zogIb28vzk7MqszQ2Sk25EIbtndBPw8hnWNb5G9knfZHMTTgaVX58bKHvIhhqE5KwqBap73t12UJp/ja+kOkyYbSDMb7KHh0DhyM7U2PZYWOxcMce2f4Q6OVkupsCGk4pB/9nkc32XxP21oIv8IJG+GwZ/SZz+ChbGpjAXjN5+t0HGIRaIFt3SueMdU=; 5:HMFyPU78dj/VmECIHjtIujtY+Cw9b/7Dr7GSUcEFJxuHHWcGSci+onlJBKkhCC4ls8B/LXHyo/7mRzZa6o5kN24fwFMQAFXuPlSZkg+FeII6ClEzeQGuwYtn5MNJDMIDyVHARZrmTrEkszVhuN+k140LuWxXwa//raGREGW8ZAI=; 24:ExgTMjwH55XFJP5QXKFBKWWuB0qMVB0+6GmbZTrAFJsqUAwf2CNvkSPMdPbu7XwDwS+FSUtEpsuZOsriQ22BLNZ/XRPKWR8z5C1WeiXIkfQ=; 7:c5hXJJXdX1nMAjRJO70w3P8Xhi/or2yJGyZgKOFpZVbFOWabrtQrOPXpKfXsS+g776cYFeQmFeIRusTUS+dWyyRv2MeLeYNyXcm8ANOw+Fhe4iiC0s7kuRr8QybnDHM1HTLttUU9ylCMZOR4K2MLno4WNdHOIODhejePNOPi65J88cFqgICpqtsSZCMEeDWRRULyUpU7OO3+1Wx0Hz/gS7rPtVhXsQWFSnguueLUslkXzBTK8CpDULk8+neCsFkJ x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: f5fb8738-0ede-466b-a904-08d51ee6c379 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(4534020)(4602075)(2017052603199); SRVR:AM4PR05MB3204; x-ms-traffictypediagnostic: AM4PR05MB3204: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-exchange-antispam-report-test: UriScan:(278428928389397)(228905959029699); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(3231020)(10201501046)(3002001)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(20161123562025)(20161123555025)(20161123560025)(20161123564025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM4PR05MB3204; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM4PR05MB3204; x-forefront-prvs: 0475418F50 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(39860400002)(346002)(13464003)(189002)(199003)(7736002)(3660700001)(316002)(3280700002)(106356001)(305945005)(478600001)(6916009)(4326008)(55016002)(99286003)(2950100002)(2906002)(2900100001)(6436002)(9686003)(53546010)(5660300001)(53936002)(66066001)(107886003)(54906003)(105586002)(6246003)(229853002)(7696004)(33656002)(189998001)(68736007)(5250100002)(81166006)(81156014)(8936002)(8676002)(86362001)(25786009)(76176999)(54356999)(101416001)(50986999)(74316002)(6506006)(14454004)(97736004)(102836003)(6116002)(3846002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3204; H:AM4PR05MB3202.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: f5fb8738-0ede-466b-a904-08d51ee6c379 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2017 16:04:41.3009 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3204 Subject: Re: [dpdk-dev] [PATCH v2] examples/flow_filtering: demo of simple rte flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Oct 2017 16:04:43 -0000 Hi, I will send the new version. > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Friday, October 27, 2017 2:14 AM > To: Ori Kam > Cc: dev@dpdk.org; Adrien Mazarguil ; > john.mcnamara@intel.com > Subject: Re: [dpdk-dev] [PATCH v2] examples/flow_filtering: demo of simpl= e > rte flow >=20 > Few comments below, Ori: >=20 > 25/10/2017 19:58, Ori Kam: > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -978,3 +978,7 @@ F: examples/tep_termination/ > > F: examples/vmdq/ > > F: examples/vmdq_dcb/ > > F: doc/guides/sample_app_ug/vmdq_dcb_forwarding.rst > > + > > +M: Ori Kam > > +F: examples/flow_filtering/ > > +F: doc/guides/sample_app_ug/flow_filtering.rst >=20 > Please keep examples in alphabetical order. >=20 Done. > > --- a/doc/guides/sample_app_ug/index.rst > > +++ b/doc/guides/sample_app_ug/index.rst > > @@ -77,6 +77,7 @@ Sample Applications User Guides > > ptpclient > > performance_thread > > ipsec_secgw > > + flow_filtering >=20 > I don't know whether there is an order in this index. >=20 I don't see any order either, so last in appear last? > > --- a/examples/Makefile > > +++ b/examples/Makefile > > @@ -100,5 +100,6 @@ endif > > endif > > > > DIRS-y +=3D eventdev_pipeline_sw_pmd > > +DIRS-y +=3D flow_filtering >=20 > Most of apps are in alphabetical order in this Makefile. >=20 Yes this is what got me confused. Fixed > > --- /dev/null > > +++ b/examples/flow_filtering/Makefile > > @@ -0,0 +1,17 @@ >=20 > A license header is required. > Added. =20 > > +ifeq ($(RTE_SDK),) > > +$(error "Please define RTE_SDK environment variable") endif > > + > > +# Default target, can be overridden by command line or environment > > +RTE_TARGET ?=3D x86_64-native-linuxapp-gcc > > + > > +include $(RTE_SDK)/mk/rte.vars.mk > > + > > +APP =3D flow > > + > > +SRCS-y :=3D main.c > > + > > +CFLAGS +=3D -g3 >=20 > -g3 ? Is it a mistake? >=20 Yep. Fixed > > --- /dev/null > > +++ b/examples/flow_filtering/main.c > > @@ -0,0 +1,244 @@ > > +/*- > > + * BSD LICENSE > > + * > > + * Copyright 2017 Mellanox. > > + * > > + * Redistribution and use in source and binary forms, with or withou= t > > + * modification, are permitted provided that the following condition= s > > + * are met: > > + * > > + * * Redistributions of source code must retain the above copyrigh= t > > + * notice, this list of conditions and the following disclaimer. > > + * * Redistributions in binary form must reproduce the above copyr= ight > > + * notice, this list of conditions and the following disclaimer = in > > + * the documentation and/or other materials provided with the > > + * distribution. > > + * * Neither the name of 6WIND S.A. nor the names of its >=20 > Wrong copyright holder reference here. Fixed. Regards, Ori Kam