From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40064.outbound.protection.outlook.com [40.107.4.64]) by dpdk.org (Postfix) with ESMTP id 115E91B6D3 for ; Mon, 16 Oct 2017 15:25:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=73UYovHasUHuuIg99xZJ6s9oOZaVB5d3w+gDfZ1RqJQ=; b=HAujRm68tji/ao78JaiGpauNqExhSAsgPQH6JsNZC/RRPUQkF6QWfdzn0YgHuI2LvA45Dh3cLEg8QPlQyq+GPGoWIw3+XTE9pCESaSov0tz1jQfecTe5jFSgcfNUIksBf/kRh5GNzYCosK2DaIDZ5xqoxWXM3aazcvXlycztjrI= Received: from AM4PR05MB3202.eurprd05.prod.outlook.com (10.171.186.31) by HE1PR0501MB2044.eurprd05.prod.outlook.com (10.167.245.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Mon, 16 Oct 2017 13:25:47 +0000 Received: from AM4PR05MB3202.eurprd05.prod.outlook.com ([fe80::49f9:72b9:df85:7a8]) by AM4PR05MB3202.eurprd05.prod.outlook.com ([fe80::49f9:72b9:df85:7a8%13]) with mapi id 15.20.0077.022; Mon, 16 Oct 2017 13:25:47 +0000 From: Ori Kam To: =?iso-8859-1?Q?N=E9lio_Laranjeiro?= CC: Adrien Mazarguil , Yongseok Koh , "dev@dpdk.org" Thread-Topic: [PATCH v2] doc: update mlx5 flow count limitations Thread-Index: AQHTRnBoQ3pxKVUNT02Qcq1Om1EE7aLmVFHggAAVkICAAA12UA== Date: Mon, 16 Oct 2017 13:25:47 +0000 Message-ID: References: <1508142759-24829-1-git-send-email-orika@mellanox.com> <20171016111742.qcb2u7omvomfscgc@laranjeiro-vm> <20171016123625.pjm7kvrfdfqxobiz@laranjeiro-vm> In-Reply-To: <20171016123625.pjm7kvrfdfqxobiz@laranjeiro-vm> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [193.47.165.251] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0501MB2044; 6:5coKalSu0M7bhWfNb/EzksqfhSYee48dH7+PsDgf1oc+MCfoXp0i91W00QZuZ+qLIh/+9j0sxmiI0+u7uSfMc4xISGNjFoXqMaTtV2WLdzUIlR5Xqj1MOu0U9LIIDpny+/7OUiG122Di8ddNXxSasy2UhNqzqJ5zCxbaKJsPdtFB7InDJtN0TRLau1s/v8n2RreDB5Y5mG5Ehzb/8W/MP26SCg60HyOs7SdKaHhZMCNv53sVfwsBdDitn6aHNQNTamDc6tWgmhm4ZiQ7GgEJLO7lTqyOrqhD5Nw3AIylJJOfZgVgrOb9/qOna2Xup058kkIIodkQ6IqAtm6di9TcjA==; 5:jDzKEiR5lI5dp4MYwKq1ySAPsYYRIltRcGAiMho5eGZcnR83RfvlBI2FjBS2VaEMQG7rb6h1FgUH7KufMvQaytbD/BCNpSGCr5k9BRdk705UbpafRTHOgnWOJAD9jLUsRWGIqQPDxP6TThbyMWaEmw==; 24:jMS7jlV37zvrwxs9VpbiNgHKJcCc6QeaTiWspmAib3Ww2EIXhOyVP/iA8jVuoOGCzdBAVem48cRGMms8/SpPTfJ8OuK/VoqVOGZw7/BAATA=; 7:vYz/FeZ7n1fEsfxcTdMRjY6OzdvSYMLQnulDFHQncA5UIAJdgDOC8EjC10KPxN/s8vRA/H4mURimR6rHsNaIqZcVyYf+NKadMUSu+jrQxAumTyXG39YekEQh5u5tAzhGSFJc+U/xvXsSRuGnWiasM1cdGx2DU+GnE/u45A7/eQKK5/jPYM51uGfR5oAvEc6UT/KlW4yb+DRSJCLKozfR5LzahHP5DcNNrkxh4FwarVs= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: ba49dacb-7dfe-42fa-9523-08d5149969bd x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075); SRVR:HE1PR0501MB2044; x-ms-traffictypediagnostic: HE1PR0501MB2044: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-exchange-antispam-report-test: UriScan:(189930954265078)(45079756050767); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123560025)(20161123555025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:HE1PR0501MB2044; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:HE1PR0501MB2044; x-forefront-prvs: 0462918D61 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(39860400002)(189002)(377454003)(13464003)(199003)(24454002)(53546010)(966005)(478600001)(5660300001)(189998001)(99286003)(6306002)(6246003)(2906002)(3660700001)(14454004)(229853002)(9686003)(3280700002)(45080400002)(54906003)(316002)(6916009)(2950100002)(74316002)(15650500001)(86362001)(5250100002)(97736004)(575784001)(93886005)(7696004)(66066001)(101416001)(2900100001)(53936002)(55016002)(305945005)(105586002)(7736002)(33656002)(106356001)(3846002)(6116002)(6506006)(6436002)(102836003)(25786009)(8936002)(68736007)(8676002)(81156014)(50986999)(4326008)(54356999)(76176999)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2044; H:AM4PR05MB3202.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Oct 2017 13:25:47.8908 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2044 Subject: Re: [dpdk-dev] [PATCH v2] doc: update mlx5 flow count limitations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2017 13:25:51 -0000 > -----Original Message----- > From: N=E9lio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] > Sent: Monday, October 16, 2017 3:36 PM > To: Ori Kam > Cc: Adrien Mazarguil ; Yongseok Koh > ; dev@dpdk.org > Subject: Re: [PATCH v2] doc: update mlx5 flow count limitations >=20 > On Mon, Oct 16, 2017 at 11:31:32AM +0000, Ori Kam wrote: > > Please see my comments, > > > > > -----Original Message----- > > > From: N=E9lio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] > > > Sent: Monday, October 16, 2017 2:18 PM > > > To: Ori Kam > > > Cc: Adrien Mazarguil ; Yongseok Koh > > > ; dev@dpdk.org > > > Subject: Re: [PATCH v2] doc: update mlx5 flow count limitations > > > > > > On Mon, Oct 16, 2017 at 11:32:39AM +0300, Ori Kam wrote: > > > > Signed-off-by: Ori Kam > > > > Acked-by: Shahaf Shuler > > > > --- > > > > doc/guides/nics/mlx5.rst | 5 ++++- > > > > 1 files changed, 4 insertions(+), 1 deletions(-) > > > > > > > > diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst > > > > index > > > > d24941a..7da5c87 100644 > > > > --- a/doc/guides/nics/mlx5.rst > > > > +++ b/doc/guides/nics/mlx5.rst > > > > @@ -104,7 +104,8 @@ Limitations > > > > ----------- > > > > > > > > - Inner RSS for VXLAN frames is not supported yet. > > > > -- Port statistics through software counters only. > > > > +- Port statistics through software counters only. Flow statistics > > > > +are > > > > + supported by hardware counters. > > > > - Hardware checksum RX offloads for VXLAN inner header are not > > > supported yet. > > > > - Forked secondary process not supported. > > > > - Flow pattern without any specific vlan will match for vlan packe= ts as > well: > > > > @@ -127,6 +128,8 @@ Limitations > > > > - A multi segment packet must have less than 6 segments in case > > > > the Tx > > > burst function > > > > is set to multi-packet send or Enhanced multi-packet send. > > > > Otherwise it > > > must have > > > > less than 50 segments. > > > > +- Count action for RTE flow is only supported in OFED 4.2. > > > > +- Two identical rules with count action are not supported. > > > > > > This last line does not bring anything, having two identical rules > > > already create a collision which is not defined by the flow API. > > > In PMD situation is is even worse, as it will match both rules and > > > thus it will duplicate a packet. > > > > > > There is no need to add a limit on an undefined behavior by the API i= tself. > > > > > > > The thing is that when you try adding duplicate rules without the > > count it works without any error while if you add the count action then= for > the second rule you get an error. > > This line address this inconsistency. >=20 > According to Flow API documentation [1] >=20 > "If a packet is matched by several rules of a given group for a given pri= ority > level, the outcome is undefined. It can take any path, may be duplicated = or > even cause unrecoverable errors." >=20 > This is already documented and application makers should avoid it. > There is no need to duplicate this information. >=20 Will fix in version 3. > > > Thanks, > > > > > > PS: when you send a new revision, please use the --thread and > > > --in-reply-to to link it with the previous one. > > > > > > > > > My bad, > > > > > -- > > > N=E9lio Laranjeiro > > > 6WIND > > > > Regards, > > Ori Kam >=20 > Thanks, >=20 > [1] > https://emea01.safelinks.protection.outlook.com/?url=3Dhttp%3A%2F%2Fdpd > k.org%2Fdoc%2Fguides%2Fprog_guide%2Frte_flow.html&data=3D02%7C01%7 > Corika%40mellanox.com%7Ccc884d2a17c641d6388b08d51492886c%7Ca65297 > 1c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636437541948539609&sdata=3Dfh > 67Sys0ZaabU6hmpv5uo%2BgfXlRe2eDjTn65MUVO7IU%3D&reserved=3D0 >=20 > -- > N=E9lio Laranjeiro > 6WIND Regards, Ori Kam