From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0044.outbound.protection.outlook.com [104.47.1.44]) by dpdk.org (Postfix) with ESMTP id 9418D1B2A8 for ; Sat, 21 Oct 2017 09:20:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=QyS0c98+wF4PFgHbC5TxiHB5C+kY/ZeTM8lqDUAebDo=; b=njA2ZzP+2peYPR/WV6kwoPFEvRxnYx9+WgDgWFRbJWzfe6CR3xd5MGeNispi+AmQxAK40KHNTB7DawUt2x5o2fkObr/lyDfMa7pQYPFp1JD62Vdheno5sn2oI4PNOZRMdR7rXmxtc+Cmyz5im1ylnwasG4kJIYZ+VwBN47WyUHI= Received: from AM4PR05MB3202.eurprd05.prod.outlook.com (10.171.186.31) by AM4PR05MB3204.eurprd05.prod.outlook.com (10.171.186.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Sat, 21 Oct 2017 07:20:41 +0000 Received: from AM4PR05MB3202.eurprd05.prod.outlook.com ([fe80::49f9:72b9:df85:7a8]) by AM4PR05MB3202.eurprd05.prod.outlook.com ([fe80::49f9:72b9:df85:7a8%13]) with mapi id 15.20.0156.005; Sat, 21 Oct 2017 07:20:41 +0000 From: Ori Kam To: "Mcnamara, John" , Adrien Mazarguil , Thomas Monjalon CC: "dev@dpdk.org" Thread-Topic: [PATCH 2/2] doc: add flow_filtering example documentation Thread-Index: AQHTSMNQ1Noub12GekeMkoxvc0ZJxqLs8LcAgAD2RCA= Date: Sat, 21 Oct 2017 07:20:41 +0000 Message-ID: References: <1508408167-9001-1-git-send-email-orika@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=orika@mellanox.com; x-originating-ip: [85.64.232.108] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM4PR05MB3204; 6:7SO09msjHBffUfOyRL0x+RlvgaBMFZuQiewKVxK+23kvJldNomDmWDoXHdDxaY2MQGFlHhLbmiY8qAfnVUm9Y/TwSGgG+LchtyzXg2NWAXl++K6MUxHVCZdUP7GfyvYyOGr1zJKXbAp7IraMlZZgPwUMilQ0PIWInQPPdKTaXEiJIH1dFi1rcbQzgdqReKIOJtfVPZpnSlUg7ZXMGEE+8MYFXADQbaMnSaRxSqty+OzqD/t4anDeTw4Ae45jW3um0AF8v1eCJR5MqukctZsc+HLhJJY0+1UXOolsXJfT9iXrCNgdtPbU4qUPEW6lcdgw+M9990n1mBPDdUDQuGXKUQ==; 5:Bcv7SapEwysr3eI0qbZlMjQ+Yzu+HTl+ouPaSl7LnhA44Y5ZK8gpRdl5VbOGxdKoF6vYujY2wbrW34MLevUf2vY5NMKPa6JbZf6j6JnjOtG/2nRTPpK6CYZ0n5UXhA0hGW5ZbcgCiK7Hun2DrnJqUQ==; 24:H+ACcDuURBVa9aIzRCCuPlLVR+5XnpIIDWIn5qH4Z5MvFFVlC1kNcakce+Fvs1TQq4NL7xgadnJGW2q8GYCWGebNXLCm2K9P7AosBSF/W/4=; 7:Byj9+XasbwF7nzab/RZK2nVf1vkCXsI8hOdyp5sIp1T0HVt/7hP9H/diOnKqhw0cZTr+0WdgUxwpfuF20/0z0SxIxnILZb8A3wJiXr3vXCmVlOQFCUnsSrxDzQuHOYlj+zf8XeSo893otQMzyiCr/gX1yJsChW60Exd6VgqS0Vj/kT/lksOIRrhGqdiTXc7MlunaGjAX0ns2znunRfQDp2byRT0M5MorfpcsMcVuKzY= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 6e27d8e9-50ac-4d69-1992-08d518543c85 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081)(4534020)(4602075)(4627075)(201703031133081)(201702281549075)(2017052603199); SRVR:AM4PR05MB3204; x-ms-traffictypediagnostic: AM4PR05MB3204: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-exchange-antispam-report-test: UriScan:(278428928389397)(228905959029699); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231020)(100000703101)(100105400095)(3002001)(6055026)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AM4PR05MB3204; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AM4PR05MB3204; x-forefront-prvs: 046753C63C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(39860400002)(346002)(199003)(13464003)(189002)(2950100002)(110136005)(81166006)(55016002)(50986999)(76176999)(316002)(81156014)(189998001)(54356999)(25786009)(6506006)(6436002)(99286003)(6246003)(3660700001)(305945005)(2900100001)(7736002)(101416001)(8676002)(33656002)(3280700002)(229853002)(2906002)(4326008)(9686003)(106356001)(478600001)(7696004)(5250100002)(105586002)(53546010)(68736007)(3846002)(86362001)(5660300001)(6116002)(14454004)(102836003)(8936002)(74316002)(66066001)(53936002)(97736004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3204; H:AM4PR05MB3202.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2017 07:20:41.3531 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3204 Subject: Re: [dpdk-dev] [PATCH 2/2] doc: add flow_filtering example documentation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Oct 2017 07:20:42 -0000 Hi John, > -----Original Message----- > From: Mcnamara, John [mailto:john.mcnamara@intel.com] > Sent: Friday, October 20, 2017 7:33 PM > To: Ori Kam ; Adrien Mazarguil > ; Thomas Monjalon > > Cc: dev@dpdk.org > Subject: RE: [PATCH 2/2] doc: add flow_filtering example documentation >=20 >=20 >=20 > > -----Original Message----- > > From: Ori Kam [mailto:orika@mellanox.com] > > Sent: Thursday, October 19, 2017 11:16 AM > > To: adrien.mazarguil@6wind.com; Mcnamara, John > > ; thomas@monjalon.net > > Cc: dev@dpdk.org; orika@mellanox.com > > Subject: [PATCH 2/2] doc: add flow_filtering example documentation > > > > Signed-off-by: Ori Kam >=20 > Hi, >=20 > 1. This file needs to be included in the index.rst file. May bad will be fixed. > 2. There is a doc compilation issue due to a missing blank line after one= of the > code-block sections. Sorry for that I didn't get any compilation issue during my tests. I will c= heck what I missed. > 3. There is a white space warning on merge. >=20 I will check this.=20 > Apart from that the doc looks good. >=20 > Below are the changes I made to get it to compile. >=20 > John >=20 > $ git diff > diff --git a/doc/guides/sample_app_ug/flow_filtering.rst > b/doc/guides/sample_app_ug/flow_filtering.rst > index b8d59af..f2d7db2 100644 > --- a/doc/guides/sample_app_ug/flow_filtering.rst > +++ b/doc/guides/sample_app_ug/flow_filtering.rst > @@ -113,7 +113,8 @@ The ``main()`` also allocates a mempool to hold the > mbufs (Message Buffers) used by the application: >=20 > .. code-block:: c > - mbuf_pool =3D rte_pktmbuf_pool_create("mbuf_pool", 4096, 128, 0, > + > + mbuf_pool =3D rte_pktmbuf_pool_create("mbuf_pool", 4096, 128, 0, > RTE_MBUF_DEFAULT_BUF_SIZE, > rte_socket_id()); >=20 > @@ -536,4 +537,3 @@ The last part of the function is to validate the rule= and > create it. > int res =3D rte_flow_validate(port_id, &attr, pattern, action, &error= ); > if (!res) > flow =3D rte_flow_create(port_id, &attr, pattern, action, &error= ); > - > diff --git a/doc/guides/sample_app_ug/index.rst > b/doc/guides/sample_app_ug/index.rst > index 069d4f1..ca1f544 100644 > --- a/doc/guides/sample_app_ug/index.rst > +++ b/doc/guides/sample_app_ug/index.rst > @@ -77,6 +77,7 @@ Sample Applications User Guides > ptpclient > performance_thread > ipsec_secgw > + flow_filtering >=20 > **Figures** Thanks for your comments, Ori