From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85409A00C5; Thu, 30 Apr 2020 10:52:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 30BFA1D95E; Thu, 30 Apr 2020 10:52:01 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40050.outbound.protection.outlook.com [40.107.4.50]) by dpdk.org (Postfix) with ESMTP id 27FCE1D95B; Thu, 30 Apr 2020 10:52:00 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PEqAHizD2a/XOEnJIAFk87Gywc1cHybesrRHKR05UVEuMjcVaopA5g0u75WuE9TPAmAsUfa0MrBuS+meizdvmgGYASJUIsBbIuK52Up2gFDaqJL3j9WBl6/BK6PnO+xyPC0BBj+fbTC/ipZOO0ktdnuGiTP3emwuWEWD414YML3bIC7GIv810xKJEBN+n37o8wPzNL6gQGCtv6/eUhkXOrmGFjfSK5gNTxLQFHLuM+9QXOBVVxLM7RGjUisWOJZjRvzz2pYXkf6BNu+NPHe2HdTsI2GEBZwTPHt/+1FVHkV7DFh6i/ZXzqJcu6aer0tW0D413Ir0PiqOl7WiH9tpzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x+whxxrYUKVBrAwqwOLkj6thI10BNR8rJ27UPk70kFI=; b=HU9Jln/YzrQV478tV1fxjWxbHjtY3+5xaJdqFaNaVSTCmnbdAlNHvFXpRb3B95J7LW0jNmSsJK+Jfs+OfYpRUIo4RPWKT3ulrWGRZhsAMQPzFED1A5CsTYvgQAvKi703I/L0NR3jXGtQEsGHONvWcjwxY2vOoiaAHyJMy6BeaJmcVTLSuhoscNCLAoWylVB+WqwT5fRiu5PZL2mBXbKDNedBVJawQrmkeuZ1ewyeXzFonf/ceP6vDLOBIBSyjoeVNA+HehuxL47ZSE0Id5dQjbrloFQ+teLpf4MF5/kRK659tC+8aaK6OyJlCezi3ukU6pdK9hZoZqXkim0nkYEI1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x+whxxrYUKVBrAwqwOLkj6thI10BNR8rJ27UPk70kFI=; b=fQT2YRYkNcaUESwheb3sR/jX2cncP2umH9Z8JhX51by5O+kCCXCA1zwMRL3BvKcnSX3lB4Xn0SQATmKgCrQhI2QuNEZqwwLuUM51qLwvNITf1G9IAdB232vKjlZ6wSPmpMuVekJhIt/3TBgzLK4/SEih8oouprWvLvXFGbZJxTs= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (2603:10a6:205:8::26) by AM4PR05MB3460.eurprd05.prod.outlook.com (2603:10a6:205:6::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13; Thu, 30 Apr 2020 08:51:59 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::bdf0:88a3:3a39:4be4]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::bdf0:88a3:3a39:4be4%7]) with mapi id 15.20.2937.023; Thu, 30 Apr 2020 08:51:59 +0000 From: Slava Ovsiienko To: Jack Min , Matan Azrad , Shahaf Shuler CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix default rule do RSS regardless rxmode Thread-Index: AQHWHiY218LSMy3CTEm088p7UEWbeqiRXNJQ Date: Thu, 30 Apr 2020 08:51:59 +0000 Message-ID: References: <208bd4b9828bf89cba4d546f9091e2807d478502.1588164500.git.jackmin@mellanox.com> In-Reply-To: <208bd4b9828bf89cba4d546f9091e2807d478502.1588164500.git.jackmin@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 986025ed-147b-45b1-0ee9-08d7ece3be66 x-ms-traffictypediagnostic: AM4PR05MB3460:|AM4PR05MB3460: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-forefront-prvs: 0389EDA07F x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM4PR05MB3265.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(346002)(376002)(396003)(136003)(366004)(110136005)(7696005)(478600001)(8676002)(53546011)(6506007)(54906003)(33656002)(55016002)(9686003)(86362001)(450100002)(316002)(8936002)(26005)(186003)(4326008)(5660300002)(6636002)(52536014)(66446008)(64756008)(76116006)(2906002)(66946007)(66556008)(66476007)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7UvPBltcJnf7JLTrBdVTTayZoPuaOQcWpPjyaqQlO3yGOuVz3phcrKpqQ+J+oZRPgvefvZIJnqm7kkTgwSWMENK+CXIFroybvDICKmSL0Aj+WcLx6C/u3wXxoAu1/Qw5rc1o6NKvJj+G3OWTHU8lWphGHmU9+mfuaDK6OXRaHcqei7UBE+xN34DGcrD00OvYWEAUm2EoitCNeN6cOp+CiLXZ6F4ZMxa8WaxkTNy3J9OgxfHL6ti2O3kFP/zht5HsGrmXi95Okk8vAKh0ZGJxz7fmPeRDDOd5S6kymt0j79nsukiDgTD2iAv4D4CvQrUyAJVwXLSrkp+MQokHpGqTlc8bPG2PCKUw3qR+d5pdGdjOkEEOB+fcRUUFEtRfaKCSPN3kX+MLWd11JtFqn5yPqa6SfPGcTcM/ZdD2RxhrL/GHg+n6cgim/qllz63FzRkx x-ms-exchange-antispam-messagedata: ZfUPrkObGZyibeU9SF88tuLLqtwGdJuBtwuLA1Mg8WAtGmjmCiEtrfeRIa7/0lsnrNzT4oI8vPI8+JBQe6wPWfUnw3zBAPvS91f1EuJrN7MjIdLVR7aO/pOGJKefU8+2JlUOfm1GZxJwfyecbF3bc44zG2DLdPPd57LS6Oht0ljQtEeTK2K3tDLZIkbpTQoHeMZ9hB7CZkm+lmNeIJPeLOaxxDObEByO8b9HNfT+6fXViZ9zVCHfIGMsIleQw9jFUAjafFYn67M+X2KvljOFFa6VWpdL1nLgeRBAU22uBZK0JndxpB1kBAMuET7HzDAe3btpXofodoVlrrIdFPngAFlzqctOso9f0/tBrxyMiJ08WsrDZ8gtKGVLlQoXyGff1OXfIJC3Q0uD49f3+cyueh7tYYy8O9+utW5TAFeAXejpl+e1+pGIAZwTtA48eonTt6fXS6clOZRhluXAF5fij1tGjqH4nJU3LejPh5r39scIxBa6cM2jXw+tMMK2iHQj391Mie7KisWF3v5TKLItkPMty4ivv09URSrXXafjpIT44bJ5SB2KoePuDL4ywhePg1sn70qeHUH09wMUN8AB4Gx9h96N/UQBw+E4TALHOj0o391mHbYe5ITRylYlDO22a93MLiPRlBV5vjyD6sEGTKe53jY5MYRsECvbQNYENmhCZfgCvmNzulXvml7mxMEdkvCBE/3fydPIXAXwNx3hHruzoymyKg3pnpzCS/3XLFMk6b36k3xvDVzm6y/akEmEuu0/6m2tJBILNST9mIWFO+rZOeZ0ieloJrXduZheMPk= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 986025ed-147b-45b1-0ee9-08d7ece3be66 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2020 08:51:59.0706 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ruzo0cdekK2b++A+bwNGfGtdEwZDebjDFjMNUbPgpBJ6/NG/97YjZFn999Hh/dkw/I9fcwfGWE9+oKIjVR/7zyT4dyOR+ABNYBHzYiyM1yg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3460 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix default rule do RSS regardless rxmode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Xiaoyu Min > Sent: Wednesday, April 29, 2020 16:01 > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [PATCH] net/mlx5: fix default rule do RSS regardless rxmode >=20 > PMD create some default control rules with RSS action if it's not isolate= d > mode. >=20 > However whether default control rules need to do RSS or not should be > controlled by device configuration, the mq_mode of rxmode configuration i= n > specific. >=20 > In another word, only when mq_mode is configured with > ETH_MQ_RX_RSS_FLAG set, then RSS is needed for default rules. >=20 > Fixes: c64ccc0eca2f ("mlx5: fix overwritten RSS configuration") > Cc: stable@dpdk.org >=20 > Signed-off-by: Xiaoyu Min Signed-off-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_flow.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index e9ae2f782c..cb593c9449 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -4912,6 +4912,8 @@ mlx5_ctrl_flow_vlan(struct rte_eth_dev *dev, > if (!priv->reta_idx_n || !priv->rxqs_n) { > return 0; > } > + if (!(dev->data->dev_conf.rxmode.mq_mode & > ETH_MQ_RX_RSS_FLAG)) > + action_rss.types =3D 0; > for (i =3D 0; i !=3D priv->reta_idx_n; ++i) > queue[i] =3D (*priv->reta_idx)[i]; > flow_idx =3D flow_list_create(dev, &priv->ctrl_flows, > -- > 2.26.0