From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BFDFCA0352; Sun, 3 Nov 2019 08:50:28 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0D2B71DFE7; Sun, 3 Nov 2019 08:50:28 +0100 (CET) Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50074.outbound.protection.outlook.com [40.107.5.74]) by dpdk.org (Postfix) with ESMTP id ADBC21D483 for ; Sun, 3 Nov 2019 08:50:26 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ThKcNtYyeml2qCSpP6JRgY62AF9kgTaytPsfz7Xli1WlidbbFTTNpxsdpSSHQfq/axFQrtt5a3t2gemoszd/CyMLN4yZEmXZcDwh/npV9MMKcrBAKoPwLnZjX33w4kYPvNyFCCaRAz+/6SZE7Ffiljt+zYniBsFQD8t2dziFabR/K7yXB1LrDjpTzQN113UTeYe3ZpejcK1klfd+9gc2NjuYoiTbAmrDGscOxlxxIcDE/fkUeHls+7MbGInGGQIZ1CiSr/HEAGgpJiHS0RnMURrnSCI3y4oX1hJsZyC5yXNQBCjOd/83kDPV6aH3qq8kOFaj6f6fm5GXT2fhuPkGEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OGOuPOgO+7XHpkzNYw2RxZIjkuILmh77/h0Q1oBjVjE=; b=Y8hYxZOaeYV2k1+7AalMjdCFl9c9BDXraRNGdTduP3tnALVqtDpaoWbTzXBZeFukTmwSu68XDDD6IqzruZeiGo+wcOa1n/HB+q7xbYKlDebFovb7OY1FAP0P1+oT/bp/3LM8Asmhf0i4GjdSCa9gryCOaxuPRTX7EwyRaE9nj+hFiOREYJ/DrnUAoGwW2s9kTClLrdYeA9LGzsIJseFZuz1UhSIvJLQiH86Fss/qaap5YdmT4djmOh5i/Nm+PB0+5rNzTJfCTgcVoBHLU7TpEXbcoN6LEQM/kRIEdMrOcoebfHsm6CHbuXm+a4VAZiVnVunPMAS5Mu9tJiP5X8roqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OGOuPOgO+7XHpkzNYw2RxZIjkuILmh77/h0Q1oBjVjE=; b=iZL7jAH6CiJQNQPfnxlRb35VDVNx1fEAj+ZTCHkah2BQw3Vj2Kj/CDiqxKNopThlgV9eFZCxUfTsD5NosBXPxxITblXMl2wcROQwsrQaJ8cFjW0lul4XyEngmZC8H2b8jOcFB7aD37DmjtpchL6Z8NTAfbXie4GYJ2Fxd3CIcM4= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3300.eurprd05.prod.outlook.com (10.171.186.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.24; Sun, 3 Nov 2019 07:50:25 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::9940:94f2:db23:aa2c]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::9940:94f2:db23:aa2c%4]) with mapi id 15.20.2408.024; Sun, 3 Nov 2019 07:50:25 +0000 From: Slava Ovsiienko To: "Damjan Marion (damarion)" CC: "Liu, Yu Y" , "Wang, Haiyue" , Thomas Monjalon , "dev@dpdk.org" , "arybchenko@solarflare.com" , "Yigit, Ferruh" , "jerinjacobk@gmail.com" , "Ye, Xiaolong" , Ray Kinsella , "Sun, Chenmin" Thread-Topic: [PATCH v1 3/3] ethdev: enhance the API for getting burst mode information Thread-Index: AQHVkQY1BkrzvtNkw0WO7M2IFajIc6d3WxAAgAAYC4CAABc7cIAAuPsAgADPweA= Date: Sun, 3 Nov 2019 07:50:25 +0000 Message-ID: References: <20191031171139.105110-1-haiyue.wang@intel.com> <20191031171139.105110-3-haiyue.wang@intel.com> <20693558.VL3dRorq05@xps> <56850BFA-ABD1-476D-9ED0-F599EBD6D1EE@cisco.com> In-Reply-To: <56850BFA-ABD1-476D-9ED0-F599EBD6D1EE@cisco.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: b5c6a410-54b5-470b-b3a2-08d760327cbc x-ms-traffictypediagnostic: AM4PR05MB3300: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0210479ED8 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(396003)(376002)(366004)(136003)(39850400004)(199004)(189003)(13464003)(52536014)(81156014)(66556008)(99286004)(76176011)(14444005)(5660300002)(478600001)(8936002)(7736002)(256004)(476003)(11346002)(8676002)(71200400001)(6436002)(3846002)(486006)(446003)(6116002)(81166006)(45080400002)(71190400001)(4326008)(305945005)(33656002)(74316002)(66446008)(26005)(86362001)(25786009)(6916009)(7696005)(6246003)(66946007)(76116006)(66476007)(316002)(53546011)(6506007)(7416002)(229853002)(9686003)(186003)(54906003)(102836004)(55016002)(14454004)(2906002)(64756008)(66066001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3300; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PsgpPlOVtkroLedgcJwFfmCE9sjBWnezjRGU7vcRq17ykqgfXYfuTRv8MY+7X/zYaAdGAI5Zf/i2pK+j/dKxU3iWJYC/Syk8U+NdSxRdrEALK2CjIBW8RVlCy+t4u5HT9gDzRcZv+/yDDFbyB1Ja7FvWjWOj2KZotWGZVO/v8AuUZWT4S1oe49d7cCvyXF2c6afi72vA3/N/fJ1nAti3yZow4LyK1FTOjie9VSM7RP9cTB4sT5OPT6/api8dKzz6gdbS+JMHp2tFj44bWUhg3qC4qOMA9+XOWcT9aqmG0IF5yNSCH3/yqmy+pv+JWi6+cTanCSpeTXR+74w65rqosw5eRG/Zm2BMxpi38qTWm5TPpePoQcWn6uQpzOYMibOmt/JFBBvkxInGRCW4J5ngC981xgrx+VuPSjPUxsf24+WfeWWcePZDJMtH9WpXb0Th x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: b5c6a410-54b5-470b-b3a2-08d760327cbc X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2019 07:50:25.3187 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: a0tQ5pr266yhgb8VlW6i60HvVfmtF26W6jN8pFrbuLFO6TIda0uC+io0CxpunL9q86vINB6/p575ZRYu1CD5DsC5M6kZRuUc3Ys0ZY/Npig= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3300 Subject: Re: [dpdk-dev] [PATCH v1 3/3] ethdev: enhance the API for getting burst mode information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Damjan Marion (damarion) > Sent: Saturday, November 2, 2019 21:21 > To: Slava Ovsiienko > Cc: Liu, Yu Y ; Wang, Haiyue ; > Thomas Monjalon ; dev@dpdk.org; > arybchenko@solarflare.com; Yigit, Ferruh ; > jerinjacobk@gmail.com; Ye, Xiaolong ; Ray Kinsella > ; Sun, Chenmin > Subject: Re: [PATCH v1 3/3] ethdev: enhance the API for getting burst mod= e > information >=20 >=20 >=20 > > On 2 Nov 2019, at 09:38, Slava Ovsiienko > wrote: > > > > Hi > >> -----Original Message----- > >> From: Liu, Yu Y > >> Sent: Saturday, November 2, 2019 8:56 > >> To: Wang, Haiyue ; Thomas Monjalon > >> > >> Cc: dev@dpdk.org; arybchenko@solarflare.com; Yigit, Ferruh > >> ; jerinjacobk@gmail.com; Ye, Xiaolong > >> ; Kinsella, Ray ; Sun, > >> Chenmin ; Slava Ovsiienko > >> ; Damjan Marion (damarion) > >> ; Liu, Yu Y > >> Subject: RE: [PATCH v1 3/3] ethdev: enhance the API for getting burst > >> mode information > >> > >> Add Damjan from FD.io for awareness... > >> > >> Hi Thomas, > >> > >> Long time no see. Sorry I use outlook which is not friendly to > >> community email. > >> > >>> Anyway I will propose to replace this API in the next release. > >> Will your plan be affected by API/ABI stable plan? > >> BTW, if you propose new change in next release, it will make DPDK > >> consumer(FD.io) to change again. > >> So even if it is not affected to the API/ABI stable plan, do we still > >> have time to get a solution for everyone in DPDK 19.11 with your > >> contribution/acceleration? > >> > >>> I suspect a real hidden issue in Intel CPUs that you try to mitigate. > >> Please be rest assured it is not the case. > >> This request is just from one FD.io project internal bug " tx/rx > >> burst function is shown as nil" reported by Chenmin. > > > > Why just the presenting string with function name (possible with suffix= ) is > not enough? > > I would like to see this API (strings approach) in mlx5 either, > > dropping the entire feature does not look nice, as for me. > > > > We could consider some requirements for the name suffices to > > distinguish whether function uses vector instructions and which ones if= any. > > > >> My understanding is DPDK behavior was taken as bug for someone in > >> FD.io project and potentially will mislead other DPDK consumer. > > > > Why does FD.io code want to know which vector extension is used by burs= t > routines? > > Is it going to share/preserve some resources (registers, etc.)? Is it r= obust ? > > Burst routines might not know whether vector extensions is used (they > > might call libraries, even rte_memcpy() can use vectors in implicit fas= hion). >=20 > This is jut debug CLI print, it was added by me as a result of frustratio= n of > dealing constantly with operational issues where people are reporting low= er > performance caused by DPDK deciding for variety of reasons to switch from > vector PMD to scalar one. And it seems there is no need for flags, as for me. I think the simple string would be quite enough to identify the datapath ro= utine. Also, we have exact the same issue with mlx5 PMD, so the API (in simple string version) is desirable (+1 from me). With best regards, Slava > > > >> Haiyue is working with Chenmin to address the issue and with your > >> support it will be even better. > >> > >> Your support will be highly appreciated! > >> > >> Thanks & Regards, > >> Yu Liu > >> > >> -----Original Message----- > >> From: dev On Behalf Of Wang, Haiyue > >> Sent: Saturday, November 2, 2019 1:30 PM > >> To: Thomas Monjalon > >> Cc: dev@dpdk.org; arybchenko@solarflare.com; Yigit, Ferruh > >> ; jerinjacobk@gmail.com; Ye, Xiaolong > >> ; Kinsella, Ray ; Sun, > >> Chenmin ; Slava Ovsiienko > >> > >> Subject: Re: [dpdk-dev] [PATCH v1 3/3] ethdev: enhance the API for > >> getting burst mode information > >> > >>> -----Original Message----- > >>> From: Thomas Monjalon > >>> Sent: Saturday, November 2, 2019 06:46 > >>> To: Wang, Haiyue > >>> Cc: dev@dpdk.org; arybchenko@solarflare.com; Yigit, Ferruh > >>> ; jerinjacobk@gmail.com; Ye, Xiaolong > >>> ; Kinsella, Ray ; > >>> Sun, Chenmin ; Slava Ovsiienko > >>> > >>> Subject: Re: [PATCH v1 3/3] ethdev: enhance the API for getting > >>> burst mode information > >>> > >>> Thank you for trying to address comments done late. > >>> > >>> 31/10/2019 18:11, Haiyue Wang: > >>>> --- a/lib/librte_ethdev/rte_ethdev.h > >>>> +++ b/lib/librte_ethdev/rte_ethdev.h > >> > >> > >>>> +#define RTE_ETH_BURST_ALTIVEC (1ULL << 2) > >>>> +#define RTE_ETH_BURST_NEON (1ULL << 3) > >>>> +#define RTE_ETH_BURST_SSE (1ULL << 4) > >>>> +#define RTE_ETH_BURST_AVX2 (1ULL << 5) > >>>> +#define RTE_ETH_BURST_AVX512 (1ULL << 6) > >>> > >>> Of course, I still believe that giving a special treatment to vector > >>> instructions is wrong. > >>> You did not justify why it needs to be defined in bits instead of > >>> string. I am not asking again because anyway you don't really reply. > >>> I think you are executing an order you received and I don't want to > >>> blame you more. > >>> I suspect a real hidden issue in Intel CPUs that you try to mitigate. > >>> No need to reply to this comment. > >>> Anyway I will propose to replace this API in the next release. > >> > >> Never mind, if this design is truly ugly, drop it all now. I also > >> prefer to do the best, that's why open source is amazing, thanks! ;-) > >