From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D6E8A0487 for ; Tue, 2 Jul 2019 17:03:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A81F41B9F3; Tue, 2 Jul 2019 17:03:51 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10064.outbound.protection.outlook.com [40.107.1.64]) by dpdk.org (Postfix) with ESMTP id D4D6A1B9EE; Tue, 2 Jul 2019 17:03:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CI5wuGJX80YTCAEygUu96aVmt7mDqZcxD9pam+zMa2g=; b=BJcMSBAxieDVWohKCTrW6pAYadzSmhJrHJnhbQdpIoO9vNLmhJjAKG8gHmlrByjbALVQb4OtGTy6rW+PyqP2RuzdZrHdlUK1BwG/1E4Pz1fnWrYd7Md5Wmcpl6BonMy3kJrZ7fLNaOSVzOEluN0DYdYPUc+hksVsGE6Cy6KmW2Q= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3348.eurprd05.prod.outlook.com (10.171.187.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2032.18; Tue, 2 Jul 2019 15:03:48 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::1442:fc4d:41ad:29d2]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::1442:fc4d:41ad:29d2%5]) with mapi id 15.20.2032.019; Tue, 2 Jul 2019 15:03:48 +0000 From: Slava Ovsiienko To: Asaf Penso , Yongseok Koh , Shahaf Shuler CC: "dev@dpdk.org" , "srinivas.narayan@att.com" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix condition for calling mlx5_link_update_unlocked_gset Thread-Index: AQHVJoTKmgyl4GaYCkS7lf20ijlkraa3gS1Q Date: Tue, 2 Jul 2019 15:03:48 +0000 Message-ID: References: <1560937965-448702-1-git-send-email-asafp@mellanox.com> In-Reply-To: <1560937965-448702-1-git-send-email-asafp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.67.35.250] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ce00a6f4-df7c-4b5b-b6e7-08d6fefe7ca0 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM4PR05MB3348; x-ms-traffictypediagnostic: AM4PR05MB3348: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 008663486A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(346002)(136003)(39860400002)(376002)(396003)(13464003)(189003)(199004)(305945005)(2906002)(478600001)(6246003)(55016002)(186003)(8936002)(64756008)(68736007)(7696005)(25786009)(9686003)(81156014)(81166006)(5660300002)(74316002)(33656002)(86362001)(102836004)(6436002)(76176011)(53546011)(6116002)(3846002)(52536014)(256004)(71200400001)(14444005)(71190400001)(446003)(11346002)(6636002)(66066001)(229853002)(73956011)(76116006)(99286004)(486006)(316002)(53936002)(476003)(6506007)(110136005)(66446008)(54906003)(26005)(7736002)(66476007)(66946007)(4326008)(14454004)(66556008); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3348; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: A9ZUhgeEvYQY4Vm2k2Moh2JfMG2PtzZszH+OiNIU1bORy+jl25M6Vlrbn/Eld/m4qzpA2iL8lOfZ37SnTa8v7Mt351CvBUBUfTks/1pEKCKCM4Hl51xt5ipPNU7+l5wKPOyhN8ev9T91EX0ksxR7TD19ZmdJtF0bSFw63TBDmey4ThYO7oinCs1w5+cKor4xDANqWhmZ3Ui6qMlU91pNcZZ7d+M6b5HVuNyTNm/jsieNdVmmSPxCOGikHv9vG9wi8YAKWV3OhMfyzy2+CY31wocrvrN+0F2rfWiv1a0Hks2kir0wo9UU0Gka117TwVtkJvGx8wp+W66JkTUhq+o5EKx6dlEc/eELV1be8L/dMgaKARssw2xdW+0PYAxOlAtNYJ4HgRLPPqBhfsS36u7CHTfLVXU1qETpt6wmIXzknmI= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: ce00a6f4-df7c-4b5b-b6e7-08d6fefe7ca0 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2019 15:03:48.4270 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: viacheslavo@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3348 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix condition for calling mlx5_link_update_unlocked_gset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Asaf Penso > Sent: Wednesday, June 19, 2019 12:53 > To: Yongseok Koh ; Shahaf Shuler > > Cc: dev@dpdk.org; srinivas.narayan@att.com; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix condition for calling > mlx5_link_update_unlocked_gset >=20 > mlx5_link_update uses the newer ethtool command > ETHTOOL_GLINKSETTINGS to determine interface capabilities but falls > back to the older (deprecated) ETHTOOL_GSET command if the new > method fails for any reason. > The older method only supports reporting of capabilities up to 40G. >=20 > However, mlx5_link_update_unlocked_gs can return a failure for a > number of reasons (including the link being down). > Using the older method in cases of transient failure of the method > can result in reporting of reduced capabilities to the application. >=20 > The older method (mlx5_link_update_unlocked_gset) should only be > invoked if the newer method returns EOPNOTSUPP. >=20 > Fixes: 7d2e32f7 ("net/mlx5: fix ethtool link setting call order") > Cc: stable@dpdk.org >=20 > Signed-off-by: Asaf Penso > Reported-by: Srinivas Narayan Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_ethdev.c > b/drivers/net/mlx5/mlx5_ethdev.c > index ac0500a..61e12cc 100644 > --- a/drivers/net/mlx5/mlx5_ethdev.c > +++ b/drivers/net/mlx5/mlx5_ethdev.c > @@ -947,7 +947,7 @@ int mlx5_fw_version_get(struct rte_eth_dev *dev, > char *fw_ver, size_t fw_size) >=20 > do { > ret =3D mlx5_link_update_unlocked_gs(dev, &dev_link); > - if (ret) > + if (ret =3D=3D -ENOTSUP) > ret =3D mlx5_link_update_unlocked_gset(dev, > &dev_link); > if (ret =3D=3D 0) > break; > -- > 1.8.3.1