From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150044.outbound.protection.outlook.com [40.107.15.44]) by dpdk.org (Postfix) with ESMTP id DB8401B4EA for ; Thu, 21 Mar 2019 15:11:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N5tktBppIpAg15hLgkUEXL2Rs9fCktImgZ4Q6eSzGNY=; b=a2U4FzoDWWe42yTjpHhTSH2XBzclJ1/awxSvxjO+JLbFvuxkHXDeTWRquxpwwfdt0LBjTAm1ol3uarIIM/agz/SBhv0lWl0hjAG2GB/dcFAEsvPBtcJWNpA4oRT5sBqvCjKR8rZhv8iLqvb35NkfjrVBKgEylkT+q1sCT1nWEIg= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3364.eurprd05.prod.outlook.com (10.171.191.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1709.14; Thu, 21 Mar 2019 14:11:58 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::11b0:de86:8d93:8b02]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::11b0:de86:8d93:8b02%3]) with mapi id 15.20.1709.015; Thu, 21 Mar 2019 14:11:58 +0000 From: Slava Ovsiienko To: Shahaf Shuler , "dev@dpdk.org" Thread-Topic: [PATCH 14/14] net/mlx5: add source vport match to the ingress rules Thread-Index: AQHU39++4AjtEJh4pUyzk70yNW+HRKYWH4Ew Date: Thu, 21 Mar 2019 14:11:58 +0000 Message-ID: References: <1551376985-11096-1-git-send-email-viacheslavo@mellanox.com> <1553155888-27498-1-git-send-email-viacheslavo@mellanox.com> <1553155888-27498-15-git-send-email-viacheslavo@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.67.35.250] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f956aff6-1673-4cf3-1ee6-08d6ae072e4e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM4PR05MB3364; x-ms-traffictypediagnostic: AM4PR05MB3364: x-microsoft-antispam-prvs: x-forefront-prvs: 0983EAD6B2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(376002)(346002)(366004)(136003)(39860400002)(189003)(199004)(13464003)(6436002)(305945005)(97736004)(68736007)(74316002)(33656002)(8676002)(478600001)(2906002)(14454004)(81166006)(8936002)(81156014)(9686003)(229853002)(7736002)(55016002)(53936002)(86362001)(106356001)(102836004)(6506007)(53546011)(486006)(476003)(446003)(11346002)(52536014)(71190400001)(105586002)(71200400001)(256004)(14444005)(5660300002)(99286004)(26005)(93886005)(25786009)(2501003)(186003)(66066001)(76176011)(316002)(3846002)(6246003)(6116002)(7696005)(110136005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3364; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: C3AAdEIwOX5ZZQiqTzrw/bj8vriK9FGcmW7YoNysgocgMDGE1w+XbE/JL/VoN5FSRHTLxEoKV8KhG4Yf/RZBdZ2yEIRObXD6mX78/9Yqg9auzjG5Ke+V86Fn9AeWk7ORItfAMp7ZvC+f0ROjuqpJ9inLkmiO/Peqz12jUMG8hJOmpvszbc0GLgz6KZE/8rdfYa/6/uHsA1rHu7gr8rGReQ6Izw2jf3L3IgJEc8d3Y35laD0Vt8iEaHZFFtLlAWsKEb7nhDpF6L8IzXpbY4VGkUfg4vlVjfiujdfod/2jloM358HiAjRwYFdz08M1ubXRtpKJQKDPrf5LiD8c1UnJUqAL/q/tVVzC6sEH6oHps4VLLTio5Q1R4qYydYCH00kkmv314X6edfsOZE4TvbLWZfF6I5RPHHGsGMBOTgStFsw= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: f956aff6-1673-4cf3-1ee6-08d6ae072e4e X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2019 14:11:58.2528 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3364 Subject: Re: [dpdk-dev] [PATCH 14/14] net/mlx5: add source vport match to the ingress rules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Mar 2019 14:12:00 -0000 > -----Original Message----- > From: Shahaf Shuler > Sent: Thursday, March 21, 2019 14:15 > To: Slava Ovsiienko ; dev@dpdk.org > Subject: RE: [PATCH 14/14] net/mlx5: add source vport match to the ingres= s > rules >=20 > Thursday, March 21, 2019 10:11 AM, Viacheslav Ovsiienko: > > Subject: [PATCH 14/14] net/mlx5: add source vport match to the ingress > > rules > > > > For E-Switch configurations over multiport Infiniband devices we > > should add source vport match to correctly distribute traffic between > representors. > > > > Signed-off-by: Viacheslav Ovsiienko > > --- > > drivers/net/mlx5/mlx5_flow_dv.c | 38 > > ++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 38 insertions(+) > > > > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > > b/drivers/net/mlx5/mlx5_flow_dv.c index b8943da..489b3bd 100644 > > --- a/drivers/net/mlx5/mlx5_flow_dv.c > > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > > @@ -3095,6 +3095,29 @@ struct field_modify_info modify_tcp[] =3D { } > > > > /** > > + * Add source vport match to the specified matcher. > > + * > > + * @param[in, out] matcher > > + * Flow matcher. > > + * @param[in, out] key > > + * Flow matcher value. > > + * @param[in] port > > + * Source vport value to match > > + * @param[in] mask > > + * Mask > > + */ > > +static void > > +flow_dv_translate_source_vport(void *matcher, void *key, > > + int16_t port, uint16_t mask) { > > + void *misc_m =3D MLX5_ADDR_OF(fte_match_param, matcher, > > misc_parameters); > > + void *misc_v =3D MLX5_ADDR_OF(fte_match_param, key, > > misc_parameters); > > + > > + MLX5_SET(fte_match_set_misc, misc_m, source_port, mask); > > + MLX5_SET(fte_match_set_misc, misc_v, source_port, port); } > > + > > +/** > > * Fill the flow with DV spec. > > * > > * @param[in] dev > > @@ -3389,6 +3412,21 @@ struct field_modify_info modify_tcp[] =3D { > > } > > dev_flow->dv.actions_n =3D actions_n; > > flow->actions =3D action_flags; > > + if (attr->ingress && !attr->transfer && > > + (priv->representor || priv->master)) { > > + /* It was validated - we support unidirections flows only. */ > > + assert(!attr->egress); > > + /* > > + * Add matching on source vport index only > > + * for ingress rules in E-Switch configurations. > > + */ > > + flow_dv_translate_source_vport(matcher.mask.buf, > > + dev_flow->dv.value.buf, > > + priv->representor_id < 0 ? > > + priv->representor_id : > > + priv->representor_id + 1, >=20 > The vport of representor_id 0 will be 1? > Who owns vport 0? PF. There is the foillowing vport mapping (for single E-Switch per PF): -1 - wire 0 - PF (uplink + VF reps) 1 - VF0 2 - VF1 ... n+1 - VFn This code is subject to change - (SF, multi E-Switch per function, etc), this patch currently supports single E-Switch per PF. >=20 > > + 0xffff); > > + } > > for (; items->type !=3D RTE_FLOW_ITEM_TYPE_END; items++) { > > int tunnel =3D !!(item_flags & MLX5_FLOW_LAYER_TUNNEL); > > void *match_mask =3D matcher.mask.buf; > > -- > > 1.8.3.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 18493A00E6 for ; Thu, 21 Mar 2019 15:12:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B6C9A1B4FB; Thu, 21 Mar 2019 15:12:01 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150044.outbound.protection.outlook.com [40.107.15.44]) by dpdk.org (Postfix) with ESMTP id DB8401B4EA for ; Thu, 21 Mar 2019 15:11:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N5tktBppIpAg15hLgkUEXL2Rs9fCktImgZ4Q6eSzGNY=; b=a2U4FzoDWWe42yTjpHhTSH2XBzclJ1/awxSvxjO+JLbFvuxkHXDeTWRquxpwwfdt0LBjTAm1ol3uarIIM/agz/SBhv0lWl0hjAG2GB/dcFAEsvPBtcJWNpA4oRT5sBqvCjKR8rZhv8iLqvb35NkfjrVBKgEylkT+q1sCT1nWEIg= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3364.eurprd05.prod.outlook.com (10.171.191.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1709.14; Thu, 21 Mar 2019 14:11:58 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::11b0:de86:8d93:8b02]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::11b0:de86:8d93:8b02%3]) with mapi id 15.20.1709.015; Thu, 21 Mar 2019 14:11:58 +0000 From: Slava Ovsiienko To: Shahaf Shuler , "dev@dpdk.org" Thread-Topic: [PATCH 14/14] net/mlx5: add source vport match to the ingress rules Thread-Index: AQHU39++4AjtEJh4pUyzk70yNW+HRKYWH4Ew Date: Thu, 21 Mar 2019 14:11:58 +0000 Message-ID: References: <1551376985-11096-1-git-send-email-viacheslavo@mellanox.com> <1553155888-27498-1-git-send-email-viacheslavo@mellanox.com> <1553155888-27498-15-git-send-email-viacheslavo@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.67.35.250] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f956aff6-1673-4cf3-1ee6-08d6ae072e4e x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM4PR05MB3364; x-ms-traffictypediagnostic: AM4PR05MB3364: x-microsoft-antispam-prvs: x-forefront-prvs: 0983EAD6B2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(376002)(346002)(366004)(136003)(39860400002)(189003)(199004)(13464003)(6436002)(305945005)(97736004)(68736007)(74316002)(33656002)(8676002)(478600001)(2906002)(14454004)(81166006)(8936002)(81156014)(9686003)(229853002)(7736002)(55016002)(53936002)(86362001)(106356001)(102836004)(6506007)(53546011)(486006)(476003)(446003)(11346002)(52536014)(71190400001)(105586002)(71200400001)(256004)(14444005)(5660300002)(99286004)(26005)(93886005)(25786009)(2501003)(186003)(66066001)(76176011)(316002)(3846002)(6246003)(6116002)(7696005)(110136005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3364; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: C3AAdEIwOX5ZZQiqTzrw/bj8vriK9FGcmW7YoNysgocgMDGE1w+XbE/JL/VoN5FSRHTLxEoKV8KhG4Yf/RZBdZ2yEIRObXD6mX78/9Yqg9auzjG5Ke+V86Fn9AeWk7ORItfAMp7ZvC+f0ROjuqpJ9inLkmiO/Peqz12jUMG8hJOmpvszbc0GLgz6KZE/8rdfYa/6/uHsA1rHu7gr8rGReQ6Izw2jf3L3IgJEc8d3Y35laD0Vt8iEaHZFFtLlAWsKEb7nhDpF6L8IzXpbY4VGkUfg4vlVjfiujdfod/2jloM358HiAjRwYFdz08M1ubXRtpKJQKDPrf5LiD8c1UnJUqAL/q/tVVzC6sEH6oHps4VLLTio5Q1R4qYydYCH00kkmv314X6edfsOZE4TvbLWZfF6I5RPHHGsGMBOTgStFsw= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: f956aff6-1673-4cf3-1ee6-08d6ae072e4e X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Mar 2019 14:11:58.2528 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3364 Subject: Re: [dpdk-dev] [PATCH 14/14] net/mlx5: add source vport match to the ingress rules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190321141158.SX6W5onNNqroLaItfEPhqPyKSHLfmW9uY2WwFNgXHbw@z> > -----Original Message----- > From: Shahaf Shuler > Sent: Thursday, March 21, 2019 14:15 > To: Slava Ovsiienko ; dev@dpdk.org > Subject: RE: [PATCH 14/14] net/mlx5: add source vport match to the ingres= s > rules >=20 > Thursday, March 21, 2019 10:11 AM, Viacheslav Ovsiienko: > > Subject: [PATCH 14/14] net/mlx5: add source vport match to the ingress > > rules > > > > For E-Switch configurations over multiport Infiniband devices we > > should add source vport match to correctly distribute traffic between > representors. > > > > Signed-off-by: Viacheslav Ovsiienko > > --- > > drivers/net/mlx5/mlx5_flow_dv.c | 38 > > ++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 38 insertions(+) > > > > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > > b/drivers/net/mlx5/mlx5_flow_dv.c index b8943da..489b3bd 100644 > > --- a/drivers/net/mlx5/mlx5_flow_dv.c > > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > > @@ -3095,6 +3095,29 @@ struct field_modify_info modify_tcp[] =3D { } > > > > /** > > + * Add source vport match to the specified matcher. > > + * > > + * @param[in, out] matcher > > + * Flow matcher. > > + * @param[in, out] key > > + * Flow matcher value. > > + * @param[in] port > > + * Source vport value to match > > + * @param[in] mask > > + * Mask > > + */ > > +static void > > +flow_dv_translate_source_vport(void *matcher, void *key, > > + int16_t port, uint16_t mask) { > > + void *misc_m =3D MLX5_ADDR_OF(fte_match_param, matcher, > > misc_parameters); > > + void *misc_v =3D MLX5_ADDR_OF(fte_match_param, key, > > misc_parameters); > > + > > + MLX5_SET(fte_match_set_misc, misc_m, source_port, mask); > > + MLX5_SET(fte_match_set_misc, misc_v, source_port, port); } > > + > > +/** > > * Fill the flow with DV spec. > > * > > * @param[in] dev > > @@ -3389,6 +3412,21 @@ struct field_modify_info modify_tcp[] =3D { > > } > > dev_flow->dv.actions_n =3D actions_n; > > flow->actions =3D action_flags; > > + if (attr->ingress && !attr->transfer && > > + (priv->representor || priv->master)) { > > + /* It was validated - we support unidirections flows only. */ > > + assert(!attr->egress); > > + /* > > + * Add matching on source vport index only > > + * for ingress rules in E-Switch configurations. > > + */ > > + flow_dv_translate_source_vport(matcher.mask.buf, > > + dev_flow->dv.value.buf, > > + priv->representor_id < 0 ? > > + priv->representor_id : > > + priv->representor_id + 1, >=20 > The vport of representor_id 0 will be 1? > Who owns vport 0? PF. There is the foillowing vport mapping (for single E-Switch per PF): -1 - wire 0 - PF (uplink + VF reps) 1 - VF0 2 - VF1 ... n+1 - VFn This code is subject to change - (SF, multi E-Switch per function, etc), this patch currently supports single E-Switch per PF. >=20 > > + 0xffff); > > + } > > for (; items->type !=3D RTE_FLOW_ITEM_TYPE_END; items++) { > > int tunnel =3D !!(item_flags & MLX5_FLOW_LAYER_TUNNEL); > > void *match_mask =3D matcher.mask.buf; > > -- > > 1.8.3.1