From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A20AFA00C5; Thu, 30 Apr 2020 10:54:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 89E8B1D9C9; Thu, 30 Apr 2020 10:54:05 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2071.outbound.protection.outlook.com [40.107.22.71]) by dpdk.org (Postfix) with ESMTP id 233181D979; Thu, 30 Apr 2020 10:54:04 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EPgEx+0IVfznE+kFAia0xtlGnh3GEfyjLEtYX9ArxFDURB+wWBbvy8Qs3atfIXyrHy2mWrvWkpPd2VoDyHRUNdtO2yqFvJikEjv+MBRnhK8H3ctyb51mUf2Id4zaeZOjdIYFA+JdVE4AzjbNPKcpYZ3xuc/Z+JO/Uhsvi5WfZAJ4cajYK6/aRoJQLFLt89hwYNqOhnFqsh+XzhF+iHYl1OK6HarL9FWnHfHBdGoQa95/svqpl67TVLi1cq4u6XR3OpYqaKGn+OGWuqo24Y+2SOxXt/B28WVYypNFeSdIMcLkdOMMmr4dxT0+cV5eN/vvCKyKV4fPCSEI7/5iHfRTDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lxT/+jQc2L6/Ieg2w9ODty7TiB3z3IEmPQI0M6a25IY=; b=Lell+cPPySYMhCk0FARipEIklJ24NOkLckEISt+NZi2i8pud3b5hPPSdDDEyDMNlcz+yL1CK+4Tx7PTUWnbwSKudD7C4roXfGnK/hzQcw4ER8c17mn76yEL5Bx7qjv9+l8mEKGhecMYQu8oUroWWKOsE+SfI/N8fzftf3ZCbYOdZLSqsWyutXhentjaFCkc65cKw3rSLdQXO7J5+5eVu8IVpzeMA/846z8rprfB49D3kYeq6yrDaeXerYtM+D7ugq5JPjYVR8Rx0Y/NKm6VnRxMhiU/Hbrgxnht+4OFVIb3G3gJC+Ixn3mMe1uFMeRXQ4g+uVkshfPF9KkLpjKQsQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lxT/+jQc2L6/Ieg2w9ODty7TiB3z3IEmPQI0M6a25IY=; b=bq7N4CsrtZ9zFqL4sIgRd22Am8Cm9fPOvy4IhDYHN64SYMqh0d8WSPK9yq4OlZ49tq/K2LiBQRTURxKcB+X8n4zkW6yDflS+FmKbyfQr59plISzGdhxYfbzC7qBlIYya2SCfViCLCWCokFKTpUqZuWRoorq0msA6eFOEL0ru2Dg= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (2603:10a6:205:8::26) by AM4PR05MB3377.eurprd05.prod.outlook.com (2603:10a6:205:b::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Thu, 30 Apr 2020 08:54:03 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::bdf0:88a3:3a39:4be4]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::bdf0:88a3:3a39:4be4%7]) with mapi id 15.20.2937.023; Thu, 30 Apr 2020 08:54:03 +0000 From: Slava Ovsiienko To: Jack Min , Matan Azrad , Shahaf Shuler CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix default rule do RSS regardless rxmode Thread-Index: AQHWHiY218LSMy3CTEm088p7UEWbeqiRXNJQgAAAlGA= Date: Thu, 30 Apr 2020 08:54:03 +0000 Message-ID: References: <208bd4b9828bf89cba4d546f9091e2807d478502.1588164500.git.jackmin@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: mellanox.com; dkim=none (message not signed) header.d=none;mellanox.com; dmarc=none action=none header.from=mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 8c322c8d-e7ee-4fe9-500e-08d7ece4084a x-ms-traffictypediagnostic: AM4PR05MB3377:|AM4PR05MB3377: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-forefront-prvs: 0389EDA07F x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM4PR05MB3265.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(346002)(366004)(396003)(136003)(376002)(66446008)(66946007)(316002)(66556008)(52536014)(2906002)(76116006)(66476007)(54906003)(110136005)(6636002)(8676002)(9686003)(8936002)(71200400001)(450100002)(86362001)(478600001)(64756008)(5660300002)(55016002)(2940100002)(53546011)(7696005)(6506007)(33656002)(4326008)(186003)(26005); DIR:OUT; SFP:1101; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4epyWTvfB+D45R/c0APLQ2vpbdcWSsvzqpptkXMTVxOeItFlG//eomRcwgVcC77OKnZ0/mOLgdAbJggJiRzUMFr3hJEXwOe/nTPlP9UX4P4G0Wid8aa98yjvTqV9RLhUPLWFCmVGdqZDgzukcS2PQ5a6oO20mvn2VmIqazfDE5Zn7newf7wTxHeRxmNFq0zshrOu3H3cq4kCorDz0DC811B6jN8fpfyRx3KeSo8fZVt1WiFzH/wEDqJUQoIyDo+5yW1MCJGaIQhJ3r6/OOXH0x5RBbycJEJCahSBlGc1j00KK6bI0dUFJLcEjXQXTE9a79b8abafP62wMql27QGCceSCQ96Qu1lo1TvMvkKBDlNOSM7Y7peFv0jn95wCRhH5m2hmmxxQaLay70qZuWHH4JiqX90g5yZbtsg/vry0QC++TdwBa6at6Ixsxo5knEDE x-ms-exchange-antispam-messagedata: Z0t+CMnmG9cl1A1XBkHJ7p9fOpZ0979/Xhw+SUFsstkdVSvouigDGojYsTSDNT9MSRlSJcbc31NgdajRFrYTbGpodpsjAcLjHIpTdEfPEECI5lrLx1w3sDzWEDSTLzZZFh2kCX7f+huiHYPZUcOduMtnLDFruxAjpf5d+f9HDpB322pEORgK3XWD5ugHgxsVZSaq2mhlSOs9KcBV6fyDxsZcfdf5SL7PzVBgrVGzlKxortVZwmkSLX4BSxyqc4GtHzLcGgvAft3NEke/cSQl384CXm7vWnK+8Bms0U55NBKSITPQyT/0SlWInoRXT81E3VQVHhnLMA9rTdvxOJrU6j68GnNvnFYT/WfFz/H2QDeFbz8jkIFDWyzNmRRbruE/HKcwU6tmWJ+7uw3u3EQGjWG6L+NmwqfBOADhzb2dRigN/AwYdyBiYk5/8ASb/yj5zbH1ypEGYEyrAnfqs2HUuhKb4/C3F7HIXbORSN0lixT38GxmndZPqa4IUF58oPvn6O8zW71RCE1m6cpV0iB+TXWtapLxSFKmp3PoZe+/OI3OpXBGCIcMbWCV4IH6BftvnDsheV18JS+J3aXb6yl6/SlSCVv2nhxY6dRP0i/A6p87UsI88CqPkfPPP4F+2bfkdvlQuibjb6zh9v4nSoEubGFLCIgrqy8SEdtAtsjj7YhszA++ZjUv6bhgNqtmtZMQ+qoRgPYnbf99oaAd7oc8/+JO5bNihYWuFvmHFb6Nb5CmyvzvpuSZgMISzADdNaFFzq+jkQf5gh3n2YwXGSVwtRnO5nPo7iQXD78ebwzDZ3o= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8c322c8d-e7ee-4fe9-500e-08d7ece4084a X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2020 08:54:03.1091 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DMIIDKAgqGONiJfkKN7oZss5IWK9NjJtKU3dEyCTwcPNgix0KiM2/+6VAX+jSJ1qtoPP3ndS0Ff5B5Yn1GFxtyETlG6XPhXbiIWEXoUrT90= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3377 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix default rule do RSS regardless rxmode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Slava Ovsiienko > Sent: Thursday, April 30, 2020 11:52 > To: Xiaoyu Min ; Matan Azrad > ; Shahaf Shuler > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH] net/mlx5: fix default rule do RSS regardless rxmode >=20 > > -----Original Message----- > > From: Xiaoyu Min > > Sent: Wednesday, April 29, 2020 16:01 > > To: Matan Azrad ; Shahaf Shuler > > ; Slava Ovsiienko > > Cc: dev@dpdk.org; stable@dpdk.org > > Subject: [PATCH] net/mlx5: fix default rule do RSS regardless rxmode > > > > PMD create some default control rules with RSS action if it's not > > isolated mode. > > > > However whether default control rules need to do RSS or not should be > > controlled by device configuration, the mq_mode of rxmode > > configuration in specific. > > > > In another word, only when mq_mode is configured with > > ETH_MQ_RX_RSS_FLAG set, then RSS is needed for default rules. > > > > Fixes: c64ccc0eca2f ("mlx5: fix overwritten RSS configuration") > > Cc: stable@dpdk.org > > > > Signed-off-by: Xiaoyu Min Acked-by: Viacheslav Ovsiienko >=20 > > --- > > drivers/net/mlx5/mlx5_flow.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/net/mlx5/mlx5_flow.c > > b/drivers/net/mlx5/mlx5_flow.c index e9ae2f782c..cb593c9449 100644 > > --- a/drivers/net/mlx5/mlx5_flow.c > > +++ b/drivers/net/mlx5/mlx5_flow.c > > @@ -4912,6 +4912,8 @@ mlx5_ctrl_flow_vlan(struct rte_eth_dev *dev, > > if (!priv->reta_idx_n || !priv->rxqs_n) { > > return 0; > > } > > + if (!(dev->data->dev_conf.rxmode.mq_mode & > > ETH_MQ_RX_RSS_FLAG)) > > + action_rss.types =3D 0; > > for (i =3D 0; i !=3D priv->reta_idx_n; ++i) > > queue[i] =3D (*priv->reta_idx)[i]; > > flow_idx =3D flow_list_create(dev, &priv->ctrl_flows, > > -- > > 2.26.0