From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51D59A3201 for ; Mon, 21 Oct 2019 09:29:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 70C1C2C28; Mon, 21 Oct 2019 09:29:16 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30041.outbound.protection.outlook.com [40.107.3.41]) by dpdk.org (Postfix) with ESMTP id E02872BF7 for ; Mon, 21 Oct 2019 09:29:14 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XOIIH1LJHmjT3ZybW/SZ5eoXBuEh01p17fVA+73kOS52DRrTbgqSHomeUthwp6/xUzOrepWMqc8YjyJO5P+hYu/uno0EX/a+cQ6HasfrUK5jHxjXK8Sj8grqbYJdSUWk/4CWxcvd5SZCDhiO+PABJ9dK/3FA9IEx9lWiGMcKnoByg8ucmcuJ751osBKj6fEs8KwZmPewaf+r6FLzhaXG969GOld2a5PNtOSO8BWeDVXYoE0FyAkiI1W33b2Bl4CGjEosS8uOoIROmg1XIx2lYQRkUtvfXZh6NFELrWtt04QAzJFuYt3IoTy09xMSvifAj7ADFzBK1A3h1e9IM/ESmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bNs+6V2ekrkrkrJpwcRTV3WapQ5w5gJ6D3ag+j0HrnI=; b=hE6wyap/KT4izPaeHTWPRlYVodiXgUGBHsP1YUWDz62rbWU8SlHujPN3APG/1v+6xHPRR5P188PUeM5WbM7NS00h5eam4GqiT/vohsEIXVnZHK3aMhSPUADkkcTuKwbhrPcJPmQiudV6J4E6EEx3VZ90PZyeCsTEgEcl2EKECYbzko4q/uY+SLoiUNH3/A3Edpr0h1Ri5L3VrgQiB4G3fbS/q/CvFZnHmuqodMTZAyD+J5qzpdhLYxW8YFzBXqNOVVRNZMZsiPWt75vAM3OCuzH8ESeh+edmRUBWX0m5Isty7V0RkabFRuSGjn9gSxelSrtAZWNpPKgX9Udc9SxNDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bNs+6V2ekrkrkrJpwcRTV3WapQ5w5gJ6D3ag+j0HrnI=; b=miptOW8+4o6qO5BJaViYMMLaQDB5e/Wv4JtNI/sq1PB3LgzjBFGHvFNvewfjmObfIoIEyxRen8vdJJFtZmHE1uA/1yJ2eel7jO4Ep7KKIU/Px58nqIEBkc/BfHWfoR8kA6aH21n6m0mEOi5LMZRGFmJtBvCJiwgpBVq//MLFZo0= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3153.eurprd05.prod.outlook.com (10.171.188.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.16; Mon, 21 Oct 2019 07:29:11 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::edab:529f:d14e:d3b]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::edab:529f:d14e:d3b%7]) with mapi id 15.20.2347.028; Mon, 21 Oct 2019 07:29:11 +0000 From: Slava Ovsiienko To: Hideyuki Yamashita CC: Moti Haimovsky , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 0/7] net/mlx5: support for flow action on VLAN header Thread-Index: AQHVep9vAaM+AojguUG9N9frUX50nqdKSfMAgBYF6oCABHh/AIAAAyGQ Date: Mon, 21 Oct 2019 07:29:11 +0000 Message-ID: References: <20191018195529.F654.17218CA3@ntt-tx.co.jp_1> <20191021161147.EF4C.17218CA3@ntt-tx.co.jp_1> In-Reply-To: <20191021161147.EF4C.17218CA3@ntt-tx.co.jp_1> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 29b65b9f-7c71-4efe-374c-08d755f85df9 x-ms-office365-filtering-ht: Tenant x-ms-traffictypediagnostic: AM4PR05MB3153:|AM4PR05MB3153: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0197AFBD92 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(396003)(39850400004)(376002)(346002)(366004)(136003)(189003)(199004)(52314003)(13464003)(316002)(14454004)(33656002)(6116002)(71190400001)(71200400001)(2906002)(7736002)(3846002)(54906003)(256004)(74316002)(486006)(305945005)(5660300002)(66476007)(66556008)(64756008)(55016002)(76116006)(66946007)(476003)(66446008)(11346002)(446003)(9686003)(52536014)(6436002)(6916009)(99286004)(76176011)(7696005)(6246003)(186003)(6506007)(4326008)(66066001)(53546011)(26005)(102836004)(86362001)(478600001)(229853002)(81166006)(8936002)(81156014)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3153; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wlRX4jZC6ocougdxvUT1dhzjABLSU68jTYd6U7LpsImNiXklnhQctRaiCBH0jDooXUPGZGAXCrgnNqMH9c1pooJlsW4WPirSqngmsAgLbuv090+/FAEl84uqNLoDCS2fW1Tq6QDy4FSFmC4uudiaJ2f9/3B1JTtBMM/JmWR01GAJ4wylTs+QTVGQPX1xWJcASYbfs9Oy7k4SEWXN2DzY4Rwt9u3CI8h7gAFtMJiYI/sTQECg4Y+Ch+W9xXEM2Lw0uKJJUOPS/rf1HVBM/koKgdGNY4h/FrXTejlvRpS0Z8s9tNjWqnuP2KXcv6aYhDQK5XlGEyCeaptMdPbOnwQ81BIgfT4/baJKCERKQPD2slmU3CHftQVEAHiR80nv0ptAFXWn7SgnPGl5g7o/3P3iOLTTjkNfZ6BOaVDYSDuVEcH0SJvRiFKc4HcZORYtKpVl Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 29b65b9f-7c71-4efe-374c-08d755f85df9 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2019 07:29:11.2389 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4nKBPldV26Ffc0mxyXzJBsftWNfR0jpxj/kyZaH93e/F2mfCSq4AaSPeD2hoR5jyqHU+SMHq6LmaFIVpjgik8RlzfrOXrtXB0AQml9XfrY8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3153 Subject: Re: [dpdk-dev] [PATCH 0/7] net/mlx5: support for flow action on VLAN header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Hideyuki > -----Original Message----- > From: Hideyuki Yamashita > Sent: Monday, October 21, 2019 10:12 > To: Hideyuki Yamashita > Cc: Slava Ovsiienko ; Moti Haimovsky > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/7] net/mlx5: support for flow action on > VLAN header >=20 > Dear Slava, Moti and all, >=20 > Please let me know if you need more information. > Partial answer is acceptable for me. >=20 > Thanks in advaince! I'm sorry for delay, your issue is still in progress. I've tested your rules on my standard configuration - these ones are reject= ed by FW/SW, not by DPDK code. Moti tested the flows on custom setup (I suppose experime= ntal FW/kernel). AFAIK, VLAN feature was planned to GA with OFED 4.7.1, please, let me check it (hope in few days, there are holidays still lasting= in IL). With best regards, Slava >=20 > BR, > HIdeyuki Yamashita > NTT TechnoCross >=20 > > Dear Slava and experts, > > > > Thanks for your answering me. > > Baased on your answer, I tested using testpmd. > > And about the outcome, I have several questions. > > > > > > [1.Test environment] > > OS:Ubuntu18.04 > > NIC1:MCX4121A-ACAT 25G > > NIC2:MCX516A-CCAT 100G > > Repo:dpdk-next-net > > > > I checked that the following is shown in git log command. > > 9f1e94469 net/mlx5: fix netlink rdma socket callback routine 50735012c > > net/mlx5: support reading module EEPROM data > > f53a5f917 net/mlx5: support modify VLAN ID on existing VLAN header > > 9af8046a1 net/mlx5: support modify VLAN ID on new VLAN header > > 43184603e net/mlx5: support modifying VLAN priority on VLAN header > > 4f59ffbd8 net/mlx5: support push flow action on VLAN header b4bd8f5da > > net/mlx5: support pop flow action on VLAN header 048e3e84c net/mlx5: > > add VLAN push/pop DR commands to glue > > > > [2.Test result] > > I tested the follwoing flows with testpmd included in dpdk-next-net. > > > > A.flow create 0 ingress pattern eth / vlan id is 100 / end actions > > OF_POP_VLAN / end B.flow create 0 ingress pattern eth dst is > > BB:BB:BB:BB:BB:BB / end actions OF_PUSH_VLAN ethertype 1000 / end > > C.flow create 0 ingress pattern eth dst is BB:BB:BB:BB:BB:BB / end > > actions OF_SET_VLAN_VID vlan_vid 200 / end D.flow create X ingress > > pattern eth dst is BB:BB:BB:BB:BB:BB / end actions of_SET_VLAN_PCP > > vlan_pcp 3 / end E.flow create 0 egress pattern eth src is > > BB:BB:BB:BB:BB:BB / end actions OF_PUSH_VLAN ethertype 1000 / end > > > > A-D, resulted in "Caught error type 16 (specific action): cause: > 0x7ffcc711db48, action not supported: Operation not supported". > > E resulted in "Egress is not supported". > > > > [3. Quetions] > > Q1. What is the appropriate flow to entag/detag VLAN using testpmd? > > I think related commits are included so it "should" work and my guess = is > that my flow is somehow wrong. > > Q2. Is it correct understanding that "egress" is not supported for mlx5 > PMD? > > Q3. If yes, is it possible to entag VLAN tag to the outgoing packet fro= m > physical NIC by using rte_flow? > > > > BR, > > Hideyuki Yamashita > > NTT TechnoCross > > > > > > > > -----Original Message----- > > > > From: Hideyuki Yamashita > > > > Sent: Friday, October 4, 2019 13:35 > > > > To: Hideyuki Yamashita > > > > Cc: Moti Haimovsky ; Slava Ovsiienko > > > > ; dev@dpdk.org > > > > Subject: Re: [dpdk-dev] [PATCH 0/7] net/mlx5: support for flow > > > > action on VLAN header > > > > > > > > Can somebody (Mellanox guys?) help me out? > > > > > > Hi, Hideyuki > > > > > > I'm sorry, there are long holidays in IL, so let me try to answer. > > > > > > > > > > > > Hello Moti, > > > > > > > > > > I have some questions on the patch. > > > > > Just want to know how to use it. > > > > > > > > > > Q1. Is it correct understanding that the patch will be reflected > > > > > in > > > > > 19.11 if it is approved? > > > > > > Yes, it is merged and should be reflected. > > > > > > > > > > > > > Q2.Which action should I specify when I want to insert VLAN tag > > > > > to non-VLAN frame? > > > > > > > > > > OF_PUSH_VLAN and OF_SET_VLAN_VID and OF_SET_VLAN_PCP ? > > > > > > All of them, OF_PUSH_VLAN inserts the VLAN header, OF_SET_VLAN_VID > > > and OF_SET_VLAN_PCP fill the fields with appropriate values. > > > > > > > > > > > > > Q3. Is it possible to detag VLAN when it receives VLAN tagged > > > > > frame from outside of the host? > > > Do you mean some complex configuration with multiple VMs and > engaged > > > E-Switch feature? Anyway, there are multiple ways to strip (untag) VL= AN > header: > > > - with E-Switch rules (including match on specified port) > > > - with local port rules > > > - stripping VLAN in Rx queue > > > > > > > > > > > > > Q4. Is it possible to entag VLAN to non-VLAN frame when it sends > > > > > packet to outside of host? > > > Yes. > > > > > > > > > > > > > Q5.Are there any restriction to conbime other ACTIONS like QUEUE? > > > Should no be. Action QUEUE is on Rx NIC namespace, VLAN POP is > supported there. > > > > > > > > > > > > > Q6. Is it possible to apply rte_flow actions for specified tx > > > > > queue of physical NIC? > > > > > (e.g. VM connect with PHY:0 using tx queue index:1, I want to > > > > > entag VLAN 101 to the traffic from VM to PHY:0 is it possible?) > > > Directly - no, there is no item to match with specific Tx queue. > > > > > > If setting VLAN on specific Tx queue is desired we have two options: > > > > > > - engage Tx offload DEV_TX_OFFLOAD_VLAN_INSERT, and provide VLAN > > > with each packet being transferred to tx_burst > > > > > > - engage DEV_TX_OFFLOAD_MATCH_METADATA feature, and set > specific > > > metadata for all packets on specific queue. Then the rules matching > > > with this metadata may be inserted. > > > > > > [snip] > > > > > > With best regards, Slava > > >=20 >=20