From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BA24A046B for ; Wed, 24 Jul 2019 07:04:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9B1071C113; Wed, 24 Jul 2019 07:04:01 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140088.outbound.protection.outlook.com [40.107.14.88]) by dpdk.org (Postfix) with ESMTP id 99B5A1C112 for ; Wed, 24 Jul 2019 07:04:00 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KFZUppTAtlKDJPN2t+hDLqFrrQdsd80eS2I/9wZaLtlhSaELWvxmbUr53axw1E9aD4M1oK7puEtmP0MLTLAu3TXTaz7CPIM4nCfxxLTTIMvwnIToAvp9f2KBnJCmR3/DVo0CP1ct1I0kL7BTetCsgTe6fBgN2357rPwPtl9dExAFKO0n+eWTwsZLAk18juB7cLYhYamR1Dkzh9nCIIW0qLld1llaCI2ZdA8MrcHf1gyNSyft1c8cPY9aAlbCk029xCdN3XlbEuqCtIFChWVInsUb44zq8Vw4IMo796n26NGajydMhzo8xAX9p4SWxV+jhPGn/Ctr4fOObuAasGETng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z/RZ1s2flL3xFSgwEHmc76Gjem1ZiV0X282fhuu2IGM=; b=Z6I+hQxOwZCuT9sHOGiaJgAXcEscjs9m6qm20PQOd2EFLIdq3q3gMmEsC2zGZa4GUCtn8D8EUAEYmubd+SAriNBTPFbJFbwESNLXLtHcQYv85voqsIsqQdq4JFbKsJfPN4dW+yx5IwBCpfHmNJcm2FgT+hWltO2sHEQIkXsYm9vOFLlZZO6oUvdjxr7RX0XMDGzrtWbILroRbAQl8wfMHiejkjPr6vHcfiiHYDpdSOS4CQTTGPgmr7HiDM7XUU8HqN4nxIPVrvatPYftUNLPjcq17B2qICjYCDOetAMRAbSFm7We/86tnw8RV3REXD80JqL0xKAiU3W4tU44kjRxjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z/RZ1s2flL3xFSgwEHmc76Gjem1ZiV0X282fhuu2IGM=; b=D2u6geZiJy9uxQemzPyR6ICPeSVoo0JxkIWR/0rJdruTsbnAc6lMIK1IJrrolGlstGKyRVLEGeuPzQqSNKBxt3NY0agwcFAC2BBp/7R8aT87eBWUifKFKDsZmRyzcLSVYdcbJugK2wZruJ2H454KCAbdJazbhhhoSUCzbX0dBAA= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3267.eurprd05.prod.outlook.com (10.171.188.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.14; Wed, 24 Jul 2019 05:03:59 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::ec83:c573:8eda:b6a]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::ec83:c573:8eda:b6a%4]) with mapi id 15.20.2094.013; Wed, 24 Jul 2019 05:03:59 +0000 From: Slava Ovsiienko To: Dekel Peled , Yongseok Koh , Shahaf Shuler CC: Ori Kam , "dev@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix Rx queue release of resources Thread-Index: AQHVQWxU8zg/eKqiRUODbVVR6q6blKbZN12g Date: Wed, 24 Jul 2019 05:03:59 +0000 Message-ID: References: <0bf488cf0466b23710a4cf2cd68943a3354de6ef.1563896047.git.dekelp@mellanox.com> In-Reply-To: <0bf488cf0466b23710a4cf2cd68943a3354de6ef.1563896047.git.dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.67.35.250] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c8ae5baf-dae7-4c52-5c02-08d70ff45679 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM4PR05MB3267; x-ms-traffictypediagnostic: AM4PR05MB3267: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2399; x-forefront-prvs: 0108A997B2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(396003)(39860400002)(366004)(346002)(136003)(199004)(189003)(13464003)(476003)(2906002)(305945005)(316002)(6436002)(74316002)(55016002)(54906003)(9686003)(4326008)(53546011)(86362001)(14454004)(53936002)(6246003)(8676002)(3846002)(33656002)(66946007)(478600001)(110136005)(71190400001)(71200400001)(64756008)(66476007)(66446008)(66556008)(66066001)(6636002)(68736007)(6116002)(76116006)(81156014)(446003)(7696005)(76176011)(7736002)(256004)(11346002)(25786009)(14444005)(52536014)(186003)(229853002)(486006)(99286004)(81166006)(6506007)(8936002)(5660300002)(102836004)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3267; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: paJUA6MdqZxKnQ12Qs7hwbNmfojuqVKe8zz2fnypBQqJ0GXhBR9lhTgQEO8XCpV7hUD8OsXEfDRbNJXNBlCCnUfW8voevTSnwAYt8ySq5vtKZD0ftV7z4Rusd+Ls1+/vH23QlEevrm2sganDlfsR21O5+hIFAA3YlNJtTVYlOMJ9QyWoZFguISQAQU71DnxvOOpCOtMbvss43ctDEVAwzZ0Don1wD2XrVX2IHNGOWFvlRUT3AxXOV9G/qsTothn2WzJt8q+E4my/ET5NzsYTj4vX84zNp8p1aFjzJiPL53iUgBewsWcbfkZkhVAT6z4YH2P+Z9YRTffOfBgsAWhMXxOxl1P9qPpJBceLxbvevsuUECnMWTD8/0Gr+nm74L+PadcQ+NRxVgfFukjlisi0qmD4bX7+rr1ky0/4VeIAUTQ= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: c8ae5baf-dae7-4c52-5c02-08d70ff45679 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2019 05:03:59.1026 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: viacheslavo@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3267 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix Rx queue release of resources X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Dekel Peled > Sent: Tuesday, July 23, 2019 18:35 > To: Yongseok Koh ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org > Subject: [PATCH] net/mlx5: fix Rx queue release of resources >=20 > Function rxq_release_rq_resources() releases resources of RQ object creat= ed > by DevX API. >=20 > This patch updates this function to properly clear the released resources= , to > avoid repeated release of the same resource. >=20 > Fixes: 69abf7b1db4a ("net/mlx5: create advanced RxQ using new API") >=20 > Signed-off-by: Dekel Peled Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_rxq.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c in= dex > c9df8b0..441f158 100644 > --- a/drivers/net/mlx5/mlx5_rxq.c > +++ b/drivers/net/mlx5/mlx5_rxq.c > @@ -573,8 +573,10 @@ > rte_free((void *)(uintptr_t)rxq_ctrl->rxq.wqes); > rxq_ctrl->rxq.wqes =3D NULL; > } > - if (rxq_ctrl->wq_umem) > + if (rxq_ctrl->wq_umem) { > mlx5_glue->devx_umem_dereg(rxq_ctrl->wq_umem); > + rxq_ctrl->wq_umem =3D NULL; > + } > } >=20 > /** > -- > 1.8.3.1