From: Slava Ovsiienko <viacheslavo@mellanox.com>
To: Ophir Munk <ophirmu@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Raslan Darawsheh <rasland@mellanox.com>,
Ophir Munk <ophirmu@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v1] net/mlx5: fix VLAN PCP item calculation
Date: Wed, 26 Feb 2020 09:34:20 +0000 [thread overview]
Message-ID: <AM4PR05MB3265596165A5961CAB98B6C3D2EA0@AM4PR05MB3265.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20200226082748.18445-1-ophirmu@mellanox.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Ophir Munk
> Sent: Wednesday, February 26, 2020 10:28
> To: dev@dpdk.org
> Cc: Thomas Monjalon <thomas@monjalon.net>; Raslan Darawsheh
> <rasland@mellanox.com>; Ophir Munk <ophirmu@mellanox.com>
> Subject: [dpdk-dev] [PATCH v1] net/mlx5: fix VLAN PCP item calculation
>
> The VLAN 16 bits tci field contains both values of PCP and VID. When
> extracting any one of them - it is required not to affect the other one.
> Previous to this commit in routine flow_dev_get_vlan_info_from_items()
> we calcualted the PCP as follows:
> (1) vlan->vlan_tci &= MLX5DV_FLOW_VLAN_PCP_MASK;
> (2) vlan->vlan_tci |= <3 bits value of PCP> In line (1) we should have used
> the negated mask ('~' operator) such that only the PCP bits will be nullified
> before ORing them with the updated PCP value.
>
> Fixes: 9aee7a8418 ("net/mlx5: support push flow action on VLAN header")
>
> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
PS. Ophir, I suppose this patch should be sent to the stable@dpdk.org either.
> ---
> drivers/net/mlx5/mlx5_flow_dv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> b/drivers/net/mlx5/mlx5_flow_dv.c index 06592b5..2414a97 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -1771,7 +1771,7 @@ flow_dev_get_vlan_info_from_items(const struct
> rte_flow_item *items,
> /* Only full match values are accepted */
> if ((vlan_m->tci & MLX5DV_FLOW_VLAN_PCP_MASK_BE) ==
> MLX5DV_FLOW_VLAN_PCP_MASK_BE) {
> - vlan->vlan_tci &= MLX5DV_FLOW_VLAN_PCP_MASK;
> + vlan->vlan_tci &= ~MLX5DV_FLOW_VLAN_PCP_MASK;
> vlan->vlan_tci |=
> rte_be_to_cpu_16(vlan_v->tci &
>
> MLX5DV_FLOW_VLAN_PCP_MASK_BE);
> --
> 2.8.4
next prev parent reply other threads:[~2020-02-26 9:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 8:27 Ophir Munk
2020-02-26 9:34 ` Slava Ovsiienko [this message]
2020-03-01 11:16 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM4PR05MB3265596165A5961CAB98B6C3D2EA0@AM4PR05MB3265.eurprd05.prod.outlook.com \
--to=viacheslavo@mellanox.com \
--cc=dev@dpdk.org \
--cc=ophirmu@mellanox.com \
--cc=rasland@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).