From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B16EFA052E; Mon, 3 Feb 2020 15:44:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C96291BFAF; Mon, 3 Feb 2020 15:44:02 +0100 (CET) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60066.outbound.protection.outlook.com [40.107.6.66]) by dpdk.org (Postfix) with ESMTP id C40DD1BFAD for ; Mon, 3 Feb 2020 15:44:00 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C6jRayCVuda7o6VtI7LuVnkxhqdZj4tYVXrjMlgwWbAp23V7Kgva4AaXgu+9XSlyZ0lKsdputlIRIiT1Sd5MuIZ26hT7fbiYNI3kRwAckjnbXrtLd9aKBoIslVT1rsQId81yri3Y4/diDWK4hYaMCThxZLUg3bPNw0Ak/8X5C8xHI7O6aspRF4U3vDXt6yRp45EH3/yLCzVYlg6ZaT5Z6rQTvTf6sifPGfUONP5V/w0gMzT9GrCM0+aQsy0lf6n7jFVDb5kFWS5N2dBQZyfDe88vQN0fjGcZpD5q8R+OAf/mZ3ndowNExP/awo73zDAx7zh/gStoHreloQD3Aj1vgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WYCNO1TBaTQHEsJQ0LvctkwlPDbKC6hBNp+NAHzguis=; b=jv9U4AYPXwTCig+toEwC86rJ1n5XklCUWRQVQ/GseUZrSpC//kmp/lSYRuu+rYYpYeu+CePcpLlLRFE7ySqxcfyC8GuMRRFR+dSMwQIo+FlqI6k4Tvm8HdZ2iDeE5n3z23oXO793P0NPkluFxlEy7uJAiS0SNGnsatrUUZ71hRTHayYXZ2do+GZ7jlA37G677WBjBSF1ESmsfhow97CzFj7hb1PQ7A3W/rlXbAlnZ+ecijwo+rSg1uWrIVVf7pxCsrN99Q+Tgpi9aiMw4GOF+6gUmYR5MCYtNTOrkCo7tJnRUZKdZCh8K/OzcmOT2/4GNfYyWa4dtnVuAN8lpdq9dQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WYCNO1TBaTQHEsJQ0LvctkwlPDbKC6hBNp+NAHzguis=; b=iqmc/G7BXj5DR1inm9a1tWFa+cxkpYDgv4uh/nJv4Qzr3T3b8ra+OTxkSwgpWl5abcnsjak2AoxVG25nL0MeKs/u6fBOHZDuWBlV+ul2ekLcW4jlan0VOSS4JxgOXM0taVeX2lqEvhRjZGVmpGWmfSXdspnaQPO06OAVE79fP9o= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3330.eurprd05.prod.outlook.com (10.171.191.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.29; Mon, 3 Feb 2020 14:43:59 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::68eb:ad79:71f4:110f]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::68eb:ad79:71f4:110f%3]) with mapi id 15.20.2686.031; Mon, 3 Feb 2020 14:43:59 +0000 From: Slava Ovsiienko To: Stephen Hemminger , Thinh Tran CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] examples/ip_reassembly: enable scatter mode for Mellanox PMDs Thread-Index: AQHVnnbZyA1APC24e0eCK7SgDHBhyagKA4Kg Date: Mon, 3 Feb 2020 14:43:59 +0000 Message-ID: References: <20191118181833.541-1-thinhtr@linux.vnet.ibm.com> <20191118171526.1d06f711@hermes.lan> In-Reply-To: <20191118171526.1d06f711@hermes.lan> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 85f6ef39-b1fb-40fa-9474-08d7a8b7813b x-ms-traffictypediagnostic: AM4PR05MB3330: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-forefront-prvs: 0302D4F392 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(396003)(346002)(136003)(39860400002)(376002)(199004)(189003)(66946007)(7696005)(81156014)(81166006)(71200400001)(55016002)(66476007)(478600001)(76116006)(2906002)(66556008)(66446008)(64756008)(6506007)(86362001)(8676002)(53546011)(33656002)(26005)(5660300002)(186003)(316002)(9686003)(110136005)(4326008)(52536014)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3330; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: G1BKD2b2QHIDH1iiro0sLgrEM3lVsoeXUxX2uIOMlsuH3LdNkEcsvSB6dcCyyEofhBTM1Rj2a4lpLHloFCZ9O3kO3V8ZY0mw81ffIYW+tsnCfZJFCO2q66bOaJLoe6rnKqrGPQgKuhHwSlFQUXkxLJywey2lO5dlYTPqbWBDwFJ9Gqn41VRNst61hDzmCds27W8ZgGXMwUkWvhDyfOBRnR7pCdmhobMAIlxmxKPnp5TiDCTYBeT/WtcgtNr8jfRCxwUEnnCaME5Jk+dCOmYrcqdLXUOEvA7bK8S3o5skuJ//ugXoYL1mnJghW9CYibK7nZD7AUVvyBeAKRjTxxBCDbgukM88pTnTzQZeSTWjFJ16Xt1YRkQhfWZVpawAxLbuaGMZ4O5dDOcifcNumP3RbKLk3f4dNe0eq+LWalZlg+Wg/CJ5z/N20Qrq3dwO4VSh x-ms-exchange-antispam-messagedata: sVlWxgDlFRI9HMKeZnQqii/CDCBTssjbUDEEgOndYOpi7IU3e1NHcLbYd3aRmETNwicHYi17jR6Hx40WB56SH93LrWbGJvS1nZZHVJAX8BG7jYkpkQI2+i+nm8aEch45HV3eoIoM56QPYdAhXPamQw== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 85f6ef39-b1fb-40fa-9474-08d7a8b7813b X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2020 14:43:59.5232 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pf0jJibohqR3JQkgUqbXXnv4hbZ6z2u/USOTZi5YFnIoBtKbQD2xrnEK3QXRz5gVNeERpMqhjnEvbi5SvvEupmQXEep7E+lRTeogQZxr5sU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3330 Subject: Re: [dpdk-dev] [PATCH] examples/ip_reassembly: enable scatter mode for Mellanox PMDs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Stephen Hemminger > Sent: Tuesday, November 19, 2019 3:15 > To: Thinh Tran > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] examples/ip_reassembly: enable scatter > mode for Mellanox PMDs >=20 > On Mon, 18 Nov 2019 12:18:33 -0600 > Thinh Tran wrote: >=20 > > Simple change to enable scatter for Mellanox CX4/CX5 PMDs to run this > > example > > > > Signed-off-by: Thinh Tran > > --- > > examples/ip_reassembly/main.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/examples/ip_reassembly/main.c > > b/examples/ip_reassembly/main.c index d59e6d02f..f881b89d1 100644 > > --- a/examples/ip_reassembly/main.c > > +++ b/examples/ip_reassembly/main.c > > @@ -1109,6 +1109,9 @@ main(int argc, char **argv) > > port_conf.rx_adv_conf.rss_conf.rss_hf, > > local_port_conf.rx_adv_conf.rss_conf.rss_hf); > > } > > + /* Mellanox PMDs needs scatter mode to be explicitly > enabled */ > > + if (!strcmp(dev_info.driver_name, "net_mlx5")) > > + local_port_conf.rxmode.offloads |=3D > DEV_RX_OFFLOAD_SCATTER; >=20 > This is a bad, bad precedent. > Either fix MLX driver or enable it for all PMD's. > Forcing applications to do workarounds indicates a poor design abstractio= n. +1 What about checking whether PMD supports scattering offload and enable thes= e one?