From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1876BA00BE; Wed, 30 Oct 2019 11:08:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2C5151BFC0; Wed, 30 Oct 2019 11:08:35 +0100 (CET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130057.outbound.protection.outlook.com [40.107.13.57]) by dpdk.org (Postfix) with ESMTP id 12D541BFB6 for ; Wed, 30 Oct 2019 11:08:33 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ffeYnjFJ+XtFommIz1eTBV6E9VMcESROLXB7M+WFEmDDLwGCVLosfW1rGZ0US5JRDc35jmimbFs90MRc4zC7VyXJvrloYYXJMFCQyyPKvyPA//UdOEJ7X1E28+1/iS8XtUL8y8SsokIzUahL7SD66ucTcrIIM/0Dx5L/i/aPxdue7Kx9R6ymZHBwW6mll0Ac58xjZEFTPPL4szntXzfJ97xoSpr69NnKJPcDZ0ym5sdT01FQYHnq7BxKh2Gu2JRGh+N8VnF3EQpdWwDJnMIvwbOGSmVTNHl+dqfzkAvN4qVdxQOlksV5cWSQCDuAwtVrNJ2I4n8eehZxtPCGA9Z+pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y9vZ+ZE0SHpe9szKinh0GH5Xn6+SFM6qFNL4J+h5Dsc=; b=eyuHeXXfUJShmSBlZm2TFxBqyA1IFSotqfEGXf0r4Whfpmc47Xc4iGa57fb/Nd7KfHK+3NSrKgL28DzymkcuVGt8s2o/fZSc0yMaYqXikbMHfUB1/9ctQmtMrndZ7UYVcwOgyvtZ2kXrtQQiByqoRzqk81C2HocrNYnOlohdrj1cyZtKMN+o7xnr1st1lbT2DVg7+J4Co11MXmx4eecuwnNjiCiax+tYOBZJDkSRG8UzB4TFLWua2ePrSW+gnjgLlIBhVBEyp8Tq9Imm6HFwxtqhqIMcBhHT06whqJpngH3rNOr7H3x/nbVH+267OY6LQrl57lYC6e+0H90zF2+0hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y9vZ+ZE0SHpe9szKinh0GH5Xn6+SFM6qFNL4J+h5Dsc=; b=CUbQTuIicZoA99ApLf77VazlcFlnQvHAvsNf9VZMP4TSqJS1q7g+1aA3E5SkOWxXsvj6lKxtoxy4WuEPpQr5T+Rm3JfPprg39ZaKfCIqUHE6XrU+PD6kwZwt1UccfskZP7rx8ExGshOebrBXvmhBGBQ6zUjCg9hOGP4pP2N2jUM= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3283.eurprd05.prod.outlook.com (10.170.125.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.28; Wed, 30 Oct 2019 10:08:31 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::edab:529f:d14e:d3b]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::edab:529f:d14e:d3b%7]) with mapi id 15.20.2387.027; Wed, 30 Oct 2019 10:08:31 +0000 From: Slava Ovsiienko To: Hideyuki Yamashita CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 0/7] net/mlx5: support for flow action on VLAN header Thread-Index: AQHVep9vAaM+AojguUG9N9frUX50nqdKSfMAgBYF6oCABHh/AIAAAyGQgAYeM4CABlZewIAB3Z8AgAAAaUA= Date: Wed, 30 Oct 2019 10:08:31 +0000 Message-ID: References: <20191025134838.66ED.17218CA3@ntt-tx.co.jp_1> <20191030190448.5C58.17218CA3@ntt-tx.co.jp_1> In-Reply-To: <20191030190448.5C58.17218CA3@ntt-tx.co.jp_1> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 4c1c6009-a41c-4ce6-a112-08d75d211e2b x-ms-traffictypediagnostic: AM4PR05MB3283: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 02065A9E77 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(979002)(4636009)(136003)(366004)(346002)(39860400002)(396003)(376002)(189003)(199004)(52314003)(13464003)(30864003)(74316002)(305945005)(7736002)(52536014)(2906002)(5660300002)(6916009)(86362001)(33656002)(66066001)(6246003)(6436002)(6306002)(55016002)(4326008)(9686003)(66946007)(3846002)(6116002)(81156014)(81166006)(229853002)(8936002)(25786009)(316002)(5024004)(64756008)(66556008)(7696005)(66446008)(66476007)(76116006)(14454004)(256004)(14444005)(478600001)(186003)(102836004)(6506007)(26005)(486006)(966005)(476003)(11346002)(446003)(53546011)(71200400001)(71190400001)(76176011)(99286004)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3283; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PQccPjo6EHONST+FgUp8hCmkvp4v/92BnbFRiwbjffF8nfsav24D5indFltObvGx4tBxPVWKXRc2TtUXk6/iFHsFGhWsBP3OLnpZi0Pmyb5KcSTyW03OFC80YiZmsNqWjbIDhl6q0QLJihNGgaDuTkJQJgFX+gAHg5DvqFbPsAccfu1xAxQFyPtdtqMyOh0HvzWA6+UMTES4OifXHiV1jlrsYc/RxAEoP/HFSaWiPzWHjKAknUqaed5BtLMJWAkQx0V4eQNfYCxCLYc1L21xvz/fLSd97O+R0MAFIflBrWOw8ThmnDR5YNeDR0np6nnyHzF7BN5rJOlKK6W5TnqOMt1pe2LWtFavhqWxfbcZtgL1DyTavQwoMRSmiEhTkcP34c+1pihmOr7l1qf0WHxPP9HtYrNXccr/0HEfPriZR+OWtCxBXjrWmIU5C7zYx+fVKoZjwiB0Pxx8VRtFcleAtN5Owq1+uAka4BsPImXfUs8= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c1c6009-a41c-4ce6-a112-08d75d211e2b X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2019 10:08:31.6225 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: u1U4pnJ6We7Dy5pjmYaWM7Ie3m59OHo+6b1Gs3bKf4YP6jddrw4BKaqTL1VeEvjMsIiPiRhwpzov8+NBSg1qDNk4m1Ka72iVPH/PRNR+Ffo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3283 Subject: Re: [dpdk-dev] [PATCH 0/7] net/mlx5: support for flow action on VLAN header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Hideyuki > -----Original Message----- > From: Hideyuki Yamashita > Sent: Wednesday, October 30, 2019 12:05 > To: Slava Ovsiienko > Cc: Moti Haimovsky ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/7] net/mlx5: support for flow action on > VLAN header >=20 > Hi Slava, >=20 > Thanks for your response back and letting me know the limitation. >=20 > I tried to input flow you suggested. > But it returns error. Did you specify the magic "dv_flow_en=3D1" devarg in testpmd command line? Something like this: "-w 82:00.0,dv_flow_en=3D1" With best regards, Slava >=20 > testpmd> flow create 0 ingress group 1 priority 0 pattern eth dst is > testpmd> 00:16:3e:2e:7b:6a / vlan vid is 1480 / end actions of_pop_vlan > testpmd> / queue index 0 / end > Caught error type 3 (group field): groups is not supported: Operation not > supported >=20 > Note that my setup OFED is NOT 4.7.1.0.0.2, but 4.7.1.0.0.1 because that = is > the latest version which I can download from the following web site. >=20 > https://jp.mellanox.com/page/products_dyn?product_family=3D26&ssn=3Du44h3 > rn8ngcmbdl6v0fvhqrgt3 >=20 > Do you have any hints? >=20 > BR, > Hideyuki Yamashita > NTT TechnoCross >=20 > > Hi, Hideyuki. > > > > Thanks for providing extra information. > > > > We rechecked the VLAN actions support in OFED 4.7.1, it should be > supported. > > There are some limitations: > > - VLAN pop is supported on ingress direction only > > - VLAN push is supported on egress direction only > > - not supported in group 0 (this is root table, has some limitations) > > we should insert into group 0 flow with jump to group 1, and then > > insert the rule with VLAN actions to group 1 > > > > I tried this flow (on my setup OFED 4.7.1.0.0.2): > > > > flow create 0 ingress group 1 priority 0 pattern eth dst is > > 00:16:3e:2e:7b:6a / vlan vid is 1480 / end actions of_pop_vlan / queue > index 0 / end It was created successfully. > > > > With best regards, Slava > > > > > -----Original Message----- > > > From: Hideyuki Yamashita > > > Sent: Friday, October 25, 2019 7:49 > > > To: Slava Ovsiienko > > > Cc: Moti Haimovsky ; dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH 0/7] net/mlx5: support for flow > > > action on VLAN header > > > > > > Hello Slava, > > > > > > Thanks for your response back. > > > > > > While waiting your final response, > > > I am sending additional info from my side. > > > > > > 1 > > > I am using "MLNX_OFED_LINUX-4.7-1.0.0.1-ubuntu18.04-x86_64" > > > as OFED. > > > > > > tx_h-yamashita@R730n10:~/dpdk-next-net$ pwd /home/tx_h- > > > yamashita/dpdk-next-net tx_h-yamashita@R730n10:~/dpdk-next-net$ ls > > > app MAINTAINERS > > > buildtools Makefile > > > config meson.build > > > devtools meson_options.txt > > > doc mk > > > drivers MLNX_OFED_LINUX-4.7-1.0.0.1-ubuntu18.04-x86_64 > > > examples MLNX_OFED_LINUX-4.7-1.0.0.1-ubuntu18.04-x86_64.tgz > > > GNUmakefile README > > > kernel usertools > > > lib VERSION > > > license x86_64-native-linuxapp-gcc > > > > > > 2. > > > I am using ConnextX-4 and ConnectX-5. > > > I attach the result of typing ethtool -i . > > > > > > Bus info Device Class Description > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > pci@0000:03:00.0 enp3s0f0 network MT27710 Family [Connec= tX- > 4 > > > Lx] > > > pci@0000:03:00.1 enp3s0f1 network MT27710 Family [Connec= tX- > 4 > > > Lx] > > > pci@0000:04:00.0 enp4s0f0 network MT27800 Family [Connec= tX- > 5] > > > pci@0000:04:00.1 enp4s0f1 network MT27800 Family [Connec= tX- > 5] > > > > > > tx_h-yamashita@R730n10:~/dpdk-next-net$ ethtool -i enp3s0f0 > > > driver: mlx5_core > > > version: 4.7-1.0.0 > > > firmware-version: 14.25.1020 (MT_0000000266) > > > expansion-rom-version: > > > bus-info: 0000:03:00.0 > > > supports-statistics: yes > > > supports-test: yes > > > supports-eeprom-access: no > > > supports-register-dump: no > > > supports-priv-flags: yes > > > tx_h-yamashita@R730n10:~/dpdk-next-net$ ethtool -i enp4s0f0 > > > driver: mlx5_core > > > version: 4.7-1.0.0 > > > firmware-version: 16.25.6000 (MT_0000000012) > > > expansion-rom-version: > > > bus-info: 0000:04:00.0 > > > supports-statistics: yes > > > supports-test: yes > > > supports-eeprom-access: no > > > supports-register-dump: no > > > supports-priv-flags: yes > > > > > > If you needs more info from my side, please let me know. > > > > > > BR, > > > Hideyuki Yamashita > > > NTT TechnoCross > > > > > > > Hi, Hideyuki > > > > > > > > > -----Original Message----- > > > > > From: Hideyuki Yamashita > > > > > Sent: Monday, October 21, 2019 10:12 > > > > > To: Hideyuki Yamashita > > > > > Cc: Slava Ovsiienko ; Moti Haimovsky > > > > > ; dev@dpdk.org > > > > > Subject: Re: [dpdk-dev] [PATCH 0/7] net/mlx5: support for flow > > > > > action on VLAN header > > > > > > > > > > Dear Slava, Moti and all, > > > > > > > > > > Please let me know if you need more information. > > > > > Partial answer is acceptable for me. > > > > > > > > > > Thanks in advaince! > > > > > > > > I'm sorry for delay, your issue is still in progress. > > > > I've tested your rules on my standard configuration - these ones > > > > are rejected by FW/SW, not by DPDK code. Moti tested the flows on > > > > custom > > > setup (I suppose experimental FW/kernel). > > > > AFAIK, VLAN feature was planned to GA with OFED 4.7.1, please, let > > > > me check it (hope in few days, there are holidays still lasting in = IL). > > > > > > > > With best regards, Slava > > > > > > > > > > BR, > > > > > HIdeyuki Yamashita > > > > > NTT TechnoCross > > > > > > > > > > > Dear Slava and experts, > > > > > > > > > > > > Thanks for your answering me. > > > > > > Baased on your answer, I tested using testpmd. > > > > > > And about the outcome, I have several questions. > > > > > > > > > > > > > > > > > > [1.Test environment] > > > > > > OS:Ubuntu18.04 > > > > > > NIC1:MCX4121A-ACAT 25G > > > > > > NIC2:MCX516A-CCAT 100G > > > > > > Repo:dpdk-next-net > > > > > > > > > > > > I checked that the following is shown in git log command. > > > > > > 9f1e94469 net/mlx5: fix netlink rdma socket callback routine > > > > > > 50735012c > > > > > > net/mlx5: support reading module EEPROM data > > > > > > f53a5f917 net/mlx5: support modify VLAN ID on existing VLAN > > > > > > header > > > > > > 9af8046a1 net/mlx5: support modify VLAN ID on new VLAN header > > > > > > 43184603e net/mlx5: support modifying VLAN priority on VLAN > > > > > > header > > > > > > 4f59ffbd8 net/mlx5: support push flow action on VLAN header > > > > > > b4bd8f5da > > > > > > net/mlx5: support pop flow action on VLAN header 048e3e84c > > > net/mlx5: > > > > > > add VLAN push/pop DR commands to glue > > > > > > > > > > > > [2.Test result] > > > > > > I tested the follwoing flows with testpmd included in dpdk-next= -net. > > > > > > > > > > > > A.flow create 0 ingress pattern eth / vlan id is 100 / end > > > > > > actions OF_POP_VLAN / end B.flow create 0 ingress pattern eth > > > > > > dst is BB:BB:BB:BB:BB:BB / end actions OF_PUSH_VLAN ethertype > > > > > > 1000 / end C.flow create 0 ingress pattern eth dst is > > > > > > BB:BB:BB:BB:BB:BB / end actions OF_SET_VLAN_VID vlan_vid 200 / > > > > > > end D.flow create X ingress pattern eth dst is > > > > > > BB:BB:BB:BB:BB:BB / end actions of_SET_VLAN_PCP vlan_pcp 3 / > > > > > > end E.flow create 0 egress pattern eth src is > > > > > > BB:BB:BB:BB:BB:BB / end actions OF_PUSH_VLAN ethertype 1000 / > > > > > > end > > > > > > > > > > > > A-D, resulted in "Caught error type 16 (specific action): cause= : > > > > > 0x7ffcc711db48, action not supported: Operation not supported". > > > > > > E resulted in "Egress is not supported". > > > > > > > > > > > > [3. Quetions] > > > > > > Q1. What is the appropriate flow to entag/detag VLAN using > testpmd? > > > > > > I think related commits are included so it "should" work and > > > > > > my guess is > > > > > that my flow is somehow wrong. > > > > > > Q2. Is it correct understanding that "egress" is not supported > > > > > > for > > > > > > mlx5 > > > > > PMD? > > > > > > Q3. If yes, is it possible to entag VLAN tag to the outgoing > > > > > > packet from > > > > > physical NIC by using rte_flow? > > > > > > > > > > > > BR, > > > > > > Hideyuki Yamashita > > > > > > NTT TechnoCross > > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > From: Hideyuki Yamashita > > > > > > > > Sent: Friday, October 4, 2019 13:35 > > > > > > > > To: Hideyuki Yamashita > > > > > > > > Cc: Moti Haimovsky ; Slava Ovsiienko > > > > > > > > ; dev@dpdk.org > > > > > > > > Subject: Re: [dpdk-dev] [PATCH 0/7] net/mlx5: support for > > > > > > > > flow action on VLAN header > > > > > > > > > > > > > > > > Can somebody (Mellanox guys?) help me out? > > > > > > > > > > > > > > Hi, Hideyuki > > > > > > > > > > > > > > I'm sorry, there are long holidays in IL, so let me try to an= swer. > > > > > > > > > > > > > > > > > > > > > > > > Hello Moti, > > > > > > > > > > > > > > > > > > I have some questions on the patch. > > > > > > > > > Just want to know how to use it. > > > > > > > > > > > > > > > > > > Q1. Is it correct understanding that the patch will be > > > > > > > > > reflected in > > > > > > > > > 19.11 if it is approved? > > > > > > > > > > > > > > Yes, it is merged and should be reflected. > > > > > > > > > > > > > > > > > > > > > > > > > Q2.Which action should I specify when I want to insert > > > > > > > > > VLAN tag to non-VLAN frame? > > > > > > > > > > > > > > > > > > OF_PUSH_VLAN and OF_SET_VLAN_VID and > OF_SET_VLAN_PCP ? > > > > > > > > > > > > > > All of them, OF_PUSH_VLAN inserts the VLAN header, > > > > > > > OF_SET_VLAN_VID and OF_SET_VLAN_PCP fill the fields with > > > appropriate values. > > > > > > > > > > > > > > > > > > > > > > > > > Q3. Is it possible to detag VLAN when it receives VLAN > > > > > > > > > tagged frame from outside of the host? > > > > > > > Do you mean some complex configuration with multiple VMs and > > > > > engaged > > > > > > > E-Switch feature? Anyway, there are multiple ways to strip > > > > > > > (untag) VLAN > > > > > header: > > > > > > > - with E-Switch rules (including match on specified port) > > > > > > > - with local port rules > > > > > > > - stripping VLAN in Rx queue > > > > > > > > > > > > > > > > > > > > > > > > > Q4. Is it possible to entag VLAN to non-VLAN frame when > > > > > > > > > it sends packet to outside of host? > > > > > > > Yes. > > > > > > > > > > > > > > > > > > > > > > > > > Q5.Are there any restriction to conbime other ACTIONS > > > > > > > > > like > > > QUEUE? > > > > > > > Should no be. Action QUEUE is on Rx NIC namespace, VLAN POP > > > > > > > is > > > > > supported there. > > > > > > > > > > > > > > > > > > > > > > > > > Q6. Is it possible to apply rte_flow actions for > > > > > > > > > specified tx queue of physical NIC? > > > > > > > > > (e.g. VM connect with PHY:0 using tx queue index:1, I > > > > > > > > > want to entag VLAN 101 to the traffic from VM to PHY:0 > > > > > > > > > is it > > > > > > > > > possible?) > > > > > > > Directly - no, there is no item to match with specific Tx que= ue. > > > > > > > > > > > > > > If setting VLAN on specific Tx queue is desired we have two > options: > > > > > > > > > > > > > > - engage Tx offload DEV_TX_OFFLOAD_VLAN_INSERT, and > provide > > > VLAN > > > > > > > with each packet being transferred to tx_burst > > > > > > > > > > > > > > - engage DEV_TX_OFFLOAD_MATCH_METADATA feature, and set > > > > > specific > > > > > > > metadata for all packets on specific queue. Then the rules > > > > > > > matching with this metadata may be inserted. > > > > > > > > > > > > > > [snip] > > > > > > > > > > > > > > With best regards, Slava > > > > > > > > > > > > > > > > > > > > > >=20 >=20