From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4AD17A046B for ; Wed, 24 Jul 2019 07:04:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 18E5F1C113; Wed, 24 Jul 2019 07:04:46 +0200 (CEST) Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10050.outbound.protection.outlook.com [40.107.1.50]) by dpdk.org (Postfix) with ESMTP id 20B261C112 for ; Wed, 24 Jul 2019 07:04:44 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KQseyHcL8pKMe/NcbyEhJZt1kM7+wWYijVlxW7QoMFXKkjJIwzq3GWpYcGYmeghyhIK7YZMcgKCvmK6t+OAuqyy7jpPttXebW5vtk470f4BmxLz/Xed7A21iTuA7CDwypJAMVJ0UCtRcMk5gONwxl7BexdrRIi+p3wqMnVGnN0QnQHPIwV3oD9YKAYuT33E18jsBeQ49zBFDyRP/LvKpoclc+nGbPiiYvwGgIejSGcgHydTFGd6VmMC7GVUK5pM3LWZHMBSfzgTBtO/rL6ASQUdSimtL2+4PbYz7Tt+p0iNgBj4Xhlj2E/aQXcQoXWXxIu/IM1DkNtKB7KCTvC4W+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=deeXLOFNFAaPbIt9JSKMY64J5hTo/gLyBh0+8Ct18WI=; b=JYqd/dDYxqWsk7gyddJ+y+jR2kQx9jfdq8EnQSm8QDW+bGhyonyPlb/46FKh/SfGZqVkTXr4U97eCCc6PZok3IYPJpe21JzpTAhbFO8CGr2u1ToRWOGic6NV1vkrHVdy6z3o8Vq02NPLT1RS5067I5XAh8AVDHKLHPdO4kRFVCx0rPaf+M1bJLDxaV/o5tCSk2546aRH1fJdJBguxmgT/1kac0H4HbhoXxVjWcTsf7kWdD5dNcxOJIWLADK9K0blbzcp5csEtx8T/ZuSECyl24r0thBiCe+53YpRV9gAn7JkpHrgwvk297nUuGQXtvR9XuYk8HeEQdk4NTw4179l4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=deeXLOFNFAaPbIt9JSKMY64J5hTo/gLyBh0+8Ct18WI=; b=ZoUykibzoN4MEPPNw7e1exDzNWgZl8z7oRWU4fMUnDnMwanbYFIjWkOh2VMJzST7GCBpP4bKjGHTDlHCMFUkghR2MjN1FbeZwJO6kVUGSGxnbWVddPf8j2o3oAXzjqfsizvGFaAHrff4ulLSETWDttG53PEH1jCOQNAP8K18U98= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3138.eurprd05.prod.outlook.com (10.171.188.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2094.16; Wed, 24 Jul 2019 05:04:42 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::ec83:c573:8eda:b6a]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::ec83:c573:8eda:b6a%4]) with mapi id 15.20.2094.013; Wed, 24 Jul 2019 05:04:42 +0000 From: Slava Ovsiienko To: Dekel Peled , Yongseok Koh , Shahaf Shuler CC: Ori Kam , "dev@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix doorbell release on Rx queue release Thread-Index: AQHVQWbsginu/U0YQ0uC/WnlPERqqqbZN57A Date: Wed, 24 Jul 2019 05:04:39 +0000 Message-ID: References: <5e8f2b2e164caab06b4310629769c198ba9dc0d7.1563893499.git.dekelp@mellanox.com> In-Reply-To: <5e8f2b2e164caab06b4310629769c198ba9dc0d7.1563893499.git.dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.67.35.250] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fa5ea4f2-3f22-484c-b1f7-08d70ff4703b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM4PR05MB3138; x-ms-traffictypediagnostic: AM4PR05MB3138: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-forefront-prvs: 0108A997B2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(136003)(396003)(346002)(366004)(39860400002)(199004)(189003)(13464003)(316002)(110136005)(54906003)(74316002)(256004)(7736002)(2906002)(66066001)(229853002)(6436002)(26005)(6666004)(76176011)(86362001)(53546011)(6116002)(476003)(305945005)(33656002)(486006)(6636002)(446003)(11346002)(6506007)(102836004)(7696005)(186003)(478600001)(25786009)(14454004)(71190400001)(8676002)(76116006)(66476007)(3846002)(64756008)(4326008)(66446008)(81166006)(66556008)(99286004)(81156014)(71200400001)(66946007)(52536014)(5660300002)(6246003)(53936002)(9686003)(8936002)(55016002)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3138; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: drk+P8k+UexL86tL0SirxKoqcxrVVgPTy/I83WZuPVvgqZ7kvUvVeFpJc9Fdn74kX5B2bszriHQ9KkHPdsyxmvkU74cs4ENK0eW9jRedOIq3o3nllGt/Pli/a9064IylJb16VO1z06TnkTIiLGBWaxezkWgCOkKM7sqel+jcoF7gHvg0kOyDFe2GMBgj5iq13ic0AcpCA1ggPxe3zRrLLR2eJJLqJ85eKd5Pq/yi6SzwI4fO28Zktxyx/D6DTKRjjGnajlqGc+Ink86bWyB8gAQ7I+zEFnLoopRZOUNbavONLNHdD02pbpHBXRsvvfnNEKxfbULE5TR6QaBBvXKD/6wNrTnH9JRRfvnb7NY0QK2Vj7OwvV10TcRBQgTAldrx30a+L8dGKFBDSV6fWAzxF4x8MkJfsap9a0JEtITuEoM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa5ea4f2-3f22-484c-b1f7-08d70ff4703b X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2019 05:04:42.4352 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: viacheslavo@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3138 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix doorbell release on Rx queue release X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Dekel Peled > Sent: Tuesday, July 23, 2019 17:55 > To: Yongseok Koh ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org > Subject: [PATCH] net/mlx5: fix doorbell release on Rx queue release >=20 > Function mlx5_rxq_release() calls mlx5_release_dbr() to release the doorb= ell > allocated for this Rx queue. > This call is relevant only for Rx queue objects created using DevX API. >=20 > This patch adds the required check, to call mlx5_release_dbr() only when > relevant. > It also updates mlx5_release_dbr() to use the input offset correctly. >=20 > Fixes: 69abf7b1db4a ("net/mlx5: create advanced RxQ using new API") >=20 > Signed-off-by: Dekel Peled Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5.c | 1 + > drivers/net/mlx5/mlx5_rxq.c | 6 ++++-- drivers/net/mlx5/mlx5_rxtx.h | = 1 + > 3 files changed, 6 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index > 973c80a..8f9693c 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -1460,6 +1460,7 @@ struct mlx5_dev_spawn_data { > rte_free(page); > } else { > /* Mark in bitmap that this door-bell is not in use. */ > + offset /=3D MLX5_DBR_SIZE; > int i =3D offset / 64; > int j =3D offset % 64; >=20 > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c in= dex > b225055..c9df8b0 100644 > --- a/drivers/net/mlx5/mlx5_rxq.c > +++ b/drivers/net/mlx5/mlx5_rxq.c > @@ -1242,6 +1242,7 @@ struct mlx5_rxq_obj * > goto error; > rxq_ctrl->dbr_offset =3D dbr_offset; > rxq_ctrl->dbr_umem_id =3D dbr_page->umem->umem_id; > + rxq_ctrl->dbr_umem_id_valid =3D 1; > rxq_data->rq_db =3D (uint32_t *)((uintptr_t)dbr_page->dbrs + > (uintptr_t)rxq_ctrl->dbr_offset); > } > @@ -1829,8 +1830,9 @@ struct mlx5_rxq_ctrl * > if (rxq_ctrl->obj && !mlx5_rxq_obj_release(rxq_ctrl->obj)) > rxq_ctrl->obj =3D NULL; > if (rte_atomic32_dec_and_test(&rxq_ctrl->refcnt)) { > - claim_zero(mlx5_release_dbr(dev, rxq_ctrl->dbr_umem_id, > - rxq_ctrl->dbr_offset)); > + if (rxq_ctrl->dbr_umem_id_valid) > + claim_zero(mlx5_release_dbr(dev, rxq_ctrl- > >dbr_umem_id, > + rxq_ctrl->dbr_offset)); > mlx5_mr_btree_free(&rxq_ctrl->rxq.mr_ctrl.cache_bh); > LIST_REMOVE(rxq_ctrl, next); > rte_free(rxq_ctrl); > diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h > index 928d6c3..60d871c 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.h > +++ b/drivers/net/mlx5/mlx5_rxtx.h > @@ -184,6 +184,7 @@ struct mlx5_rxq_ctrl { > struct mlx5_priv *priv; /* Back pointer to private data. */ > unsigned int socket; /* CPU socket ID for allocations. */ > unsigned int irq:1; /* Whether IRQ is enabled. */ > + unsigned int dbr_umem_id_valid:1; /* dbr_umem_id holds a valid > value. > +*/ > uint32_t flow_mark_n; /* Number of Mark/Flag flows using this > Queue. */ > uint32_t flow_tunnels_n[MLX5_FLOW_TUNNEL]; /* Tunnels > counters. */ > uint32_t wqn; /* WQ number. */ > -- > 1.8.3.1