From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2CA70A0487 for ; Mon, 1 Jul 2019 06:57:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 403EE3195; Mon, 1 Jul 2019 06:57:33 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140074.outbound.protection.outlook.com [40.107.14.74]) by dpdk.org (Postfix) with ESMTP id 9E6972C60 for ; Mon, 1 Jul 2019 06:57:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j49yXpHV252jWWVsZEvhcu0J8YmBdCwWWTPbD6+9Ta0=; b=rbVd3JPyiKwD5/hozjRhPWmYapdAoMdsHWG1x8P1d8vBh1L3C+9v2gp1M7oTmgldWF7uAijMWNoGefhiqx7IB5exanaT0uEN8fkFFROnCXnWYBImWUZaPaKBgP9YHNGfWxMdw5R7bTcrqhZzkWwDQO8p7mM8AzizKHEkruLK5MM= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3314.eurprd05.prod.outlook.com (10.171.191.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2032.20; Mon, 1 Jul 2019 04:57:30 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::1442:fc4d:41ad:29d2]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::1442:fc4d:41ad:29d2%5]) with mapi id 15.20.2032.019; Mon, 1 Jul 2019 04:57:30 +0000 From: Slava Ovsiienko To: Bruce Richardson , "Iremonger, Bernard" CC: "dev@dpdk.org" , "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx burst routines Thread-Index: AQHVLB684bjTosGyukmH5WaeRSplKKat5gbwgAAF1wCAAQEZkIACKjiAgAAJx4CABBdjoA== Date: Mon, 1 Jul 2019 04:57:30 +0000 Message-ID: References: <1561553317-16777-1-git-send-email-viacheslavo@mellanox.com> <20190626125732.GC862@bricha3-MOBL.ger.corp.intel.com> <20190626132124.GD862@bricha3-MOBL.ger.corp.intel.com> <8CEF83825BEC744B83065625E567D7C260DBE4EB@IRSMSX108.ger.corp.intel.com> <20190628142012.GA366@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20190628142012.GA366@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.67.35.250] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cd54a17f-390e-43a4-eb64-08d6fde09f79 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM4PR05MB3314; x-ms-traffictypediagnostic: AM4PR05MB3314: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 00851CA28B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(366004)(396003)(136003)(376002)(39860400002)(13464003)(189003)(199004)(102836004)(8936002)(6506007)(76176011)(53546011)(52536014)(4326008)(25786009)(186003)(5660300002)(14454004)(68736007)(54906003)(476003)(110136005)(316002)(11346002)(26005)(6116002)(2906002)(446003)(486006)(3846002)(7696005)(99286004)(76116006)(66476007)(66066001)(73956011)(66556008)(55016002)(33656002)(7736002)(64756008)(6246003)(66446008)(74316002)(14444005)(256004)(478600001)(86362001)(66946007)(9686003)(53936002)(81166006)(81156014)(71200400001)(229853002)(71190400001)(6436002)(305945005)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3314; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: y43d4X3YB0GFh/qcT9iR9aglRnEuRQ0RbNMrNbm/wjkUuBnIgmIbY/FurqyVj8Oy3/toy4VTMtM43PJlGAc4FgKKXSvsXAx/r2jy4J5kR+k0gjxUPr/0M08Y9fM4OeeoQvSUe4/gXqKjpB0w2KtxwSqr34h2w7/vojBcQuElJIm6dFweGJDvJpLzmpN7gXdSV74bQ6kXHDj4suMCsJi+aLl0fRtUhOUjufacQxfwWECmIFL1DhPR3bARxYOqqWHnHEMHUpycddhuT4TJUbVg2uZg/Xp6DvdV9eeL7Kg1GX+HhYBDCKEkm/GeA1KdCd0G0I0ZUoyaT0tmaxrlCg1kre0siF9rYEoSgWSncK39/S7IrpUrx1JVMW18ueT/MMlKhSX8LGgqK1V8Vc6T189MiPVNpov+z2YGKlmFtTTTez4= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: cd54a17f-390e-43a4-eb64-08d6fde09f79 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2019 04:57:30.7903 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: viacheslavo@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3314 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx burst routines X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" I think we should compromise: keep existing RTE_TEST_PMD_RECORD_CORE_CYCLES and extend with runtime switch under this build-time option: #ifdef RTE_TEST_PMD_RECORD_CORE_CYCLES if (record_tx) .. gather tx related stats... if (record_rx) .. gather rx related stats... #endif This is very specific feature, it is needed while debugging and testing dat= apath routines, and It seems this feature with appropriate overhead should not be= always enabled. existing build-time configuration options looks OK as for me.=20 Bruce, if proposed runtime extension is acceptable - I will update the patc= h. WBR, Slava > -----Original Message----- > From: Bruce Richardson > Sent: Friday, June 28, 2019 17:20 > To: Iremonger, Bernard > Cc: Slava Ovsiienko ; dev@dpdk.org; Yigit, > Ferruh > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx burs= t > routines >=20 > On Fri, Jun 28, 2019 at 02:45:13PM +0100, Iremonger, Bernard wrote: > > Hi Bruce, Slava, > > > > > -----Original Message----- > > > From: Slava Ovsiienko [mailto:viacheslavo@mellanox.com] > > > Sent: Thursday, June 27, 2019 5:49 AM > > > To: Richardson, Bruce > > > Cc: dev@dpdk.org; Iremonger, Bernard ; > > > Yigit, Ferruh > > > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx > > > burst routines > > > > > > OK, what do you think about this: > > > > > > #ifdef RTE_TEST_PMD_RECORD_CORE_CYCLES if (record_cycle & > > > RECORD_TX_CORE_CYCLES) { > > > .. do measurement stuff .. > > > } > > > #endif > > > > > > + add some new command to config in runtime: "set record_cycle 3" > > > > > > We keep existing RTE_TEST_PMD_RECORD_CORE_CYCLES, do not > introduce > > > new build-time configs and get some new runtime configuring. > > > > > > WBR, > > > Slava > > > > > > > -----Original Message----- > > > > From: Bruce Richardson > > > > Sent: Wednesday, June 26, 2019 16:21 > > > > To: Slava Ovsiienko > > > > Cc: dev@dpdk.org; bernard.iremonger@intel.com; > > > > ferruh.yigit@intel.com > > > > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add profiling for > > > > Rx/Tx burst routines > > > > > > > > On Wed, Jun 26, 2019 at 01:19:24PM +0000, Slava Ovsiienko wrote: > > > > > Hi, Bruce > > > > > > > > > > Do you mean using "if (core_rx_cycle_enabled) {...}" instead of #= ifdef > ? > > > > > > > > > > No, I did not try runtime control settings. > > > > > Instead I compared performance with all RECORD_CORE_XX_CYCLES > > > > options > > > > > enabled/disabled builds and have seen the ~1-2% performance > > > > > difference > > > > on my setups (mainly fwd txonly with retry). > > > > > So, ticks measuring is not free. > > > > > > > > > > With best regards, > > > > > Slava > > > > > > > > > Yes, I realise that measuring ticks is going to have a performance > impact. > > > > However, what I was referring to was exactly the former - using an = "if" > > > > rather than an "ifdef". I would hope with ticks disable using this > > > > option shows no perf impact, and we can reduce the use of > > > > build-time > > > configs. > > > > > > > > /Bruce > > > > Given that RTE_TEST_PMD_RECORD_CORE_CYCLES is already in the > config file. > > I think it is better to be consistent and add the new RECORD macros the= re. > > > > Would it be reasonable to have runtime settings available as well? > > > That configuration option is only present right now for the make builds, = so I'd > like to see it replaced with a runtime option rather than see about addin= g > more config options to the meson build. The first step should be to avoid > adding more config options and just look to use dynamic ones. Ideally the > existing build option should be replaced at the same time. >=20 > /Bruce