From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20069.outbound.protection.outlook.com [40.107.2.69]) by dpdk.org (Postfix) with ESMTP id 24D945699 for ; Wed, 27 Mar 2019 08:31:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HAX0tczwJUB7mCEGTXi+sm3Pp3iWVLtrJBUjd6g7E30=; b=jj3CgWPQzjWWGavTz5vYXqS7i0c+5xpOaNkClWPFFPwOIVe2Di2p9Az2mB7TD0NN/mALqY06S4259dMm1qqGepDPqbDMOHp5GuNu8pka3QmUfhmOyx+Advsg31vn46kn99t1FuLBxWZxrThDgxls6hMfeDZxBEm2woo9duSpj5A= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3249.eurprd05.prod.outlook.com (10.171.188.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.15; Wed, 27 Mar 2019 07:31:16 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::11b0:de86:8d93:8b02]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::11b0:de86:8d93:8b02%3]) with mapi id 15.20.1730.019; Wed, 27 Mar 2019 07:31:16 +0000 From: Slava Ovsiienko To: Shahaf Shuler , "dev@dpdk.org" Thread-Topic: [PATCH v3 00/14] net/mlx5: add support for multiport IB devices Thread-Index: AQHU5GJVn0U/A7XhK0K5troy8isy0qYfE3Uw Date: Wed, 27 Mar 2019 07:31:16 +0000 Message-ID: References: <1553533414-9911-1-git-send-email-viacheslavo@mellanox.com> <1553614522-12151-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 593250a0-2b2b-4a07-1e5b-08d6b28632b1 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM4PR05MB3249; x-ms-traffictypediagnostic: AM4PR05MB3249: x-ms-exchange-purlcount: 5 x-microsoft-antispam-prvs: x-forefront-prvs: 0989A7979C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(396003)(136003)(39860400002)(376002)(346002)(13464003)(199004)(189003)(97736004)(66066001)(53546011)(102836004)(6506007)(446003)(11346002)(86362001)(6436002)(14444005)(256004)(476003)(2501003)(55016002)(5660300002)(966005)(186003)(26005)(76176011)(25786009)(305945005)(74316002)(486006)(229853002)(7736002)(71200400001)(71190400001)(8676002)(6306002)(6246003)(316002)(106356001)(53936002)(105586002)(81166006)(81156014)(110136005)(8936002)(9686003)(52536014)(68736007)(14454004)(33656002)(3846002)(99286004)(6116002)(478600001)(7696005)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3249; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Wbu0E+JWQYeUsiW2TjV831s/xKQymN0BmMkfooUMgBDMFKkBdt1DoX9oANdiBlqh4b3qbXusr2uUOrW98bQiMjfSa1jgbAHYtnUxZgMFAh4lNAw36bYhdSrklgEe2B3vpeLemg9JYUSq6XiLVK339r4ED4nt378++fPVBm2RVSZdwDovxuaMj+qKiyxZCbG6jQRa+hZXSQrYo8CnrwOdX3JAYLfXIddj5KPO0d6Cuc9x7w/mB5lolyZBq0Za9ZHw8LqDFcn0slo74rg5YgzZfVOPIk9xjwdfv4n62U2tR3RFTJel2k7ADMSck4/AiZwcLXBWjKBob8Zhy0W/KhzCWdPL/3BUez53/GXRqWzqmEkemimBO1Xyb9Nboxo7EceAvdtTooBBsmk2kUESgkNlyYhqSIfUSeaHuVFaIN78Etg= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 593250a0-2b2b-4a07-1e5b-08d6b28632b1 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Mar 2019 07:31:16.2402 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3249 Subject: Re: [dpdk-dev] [PATCH v3 00/14] net/mlx5: add support for multiport IB devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Mar 2019 07:31:18 -0000 > -----Original Message----- > From: Shahaf Shuler > Sent: Wednesday, March 27, 2019 8:00 > To: Slava Ovsiienko ; dev@dpdk.org > Subject: RE: [PATCH v3 00/14] net/mlx5: add support for multiport IB devi= ces >=20 > Tuesday, March 26, 2019 5:35 PM, Viacheslav Ovsiienko: > > Subject: [PATCH v3 00/14] net/mlx5: add support for multiport IB > > devices > > > > The Mellanox NICs support SR-IOV and have E-Switch feature. [..] > > > > This patchset also superseedes http://patches.dpdk.org/patch/50486/ > > > > Signed-off-by: Viacheslav Ovsiienko >=20 > Slava, basically I am OK w/ the series, in order for me to apply: > 1. need to rebase on top of latest master. There are some merge conflicts= . > 2. at least patch[1] seems to be taken from another branch (checkout the > HAVE_MLX5DV_DR flag). Please handle. >=20 > [1] > https://patches.dpdk.org/patch/51739/ Off the list: My patchset is rebased on the top, but there are three Ori's commits not m= erged I was to told to base on: http://patches.dpdk.org/patch/51403/ >=20 >=20 > > > > --- > > v3: > > - vport_id field is added, contains associated VF vport > > index on E-Switch. representor_id field is reverted > > to keep the VF index > > - some comment spellcheck > > - some error logging is added for master/representor > > wrong recognition > > - shared IB context alloc/free routines mutex > > protection added > > > > v2: > > http://patches.dpdk.org/patch/51642/ > > - clarifying comments added > > - secondary process does not probe IB device at all and > > does not create shared context > > - minor bugs (like ++ in assert) fixed > > - representor_id contains corresponding VF vport index, > > no corrections +1 is needed anymore. vport index is > > calculated in the only place in code and if indexing > > schema is changed it would be easy to modify > > > > v1: > > http://patches.dpdk.org/cover/51451/ > > > > Viacheslav Ovsiienko (13): > > net/mlx5: add representor recognition on kernels 5.x > > net/mlx5: modify get ifindex routine for multiport IB > > net/mlx5: add getting IB ports number for multiport IB > > net/mlx5: add multiport IB device support to probing > > net/mlx5: add IB shared context alloc/free functions > > net/mlx5: switch to the names in the shared IB context > > net/mlx5: switch to the shared Protection Domain > > net/mlx5: switch to the shared context IB attributes > > net/mlx5: switch to the shared IB device context > > net/mlx5: provide IB port for the object being created > > net/mlx5: update install/uninstall int handler routines > > net/mlx5: update event handler for multiport IB devices > > net/mlx5: add source vport match to the ingress rules > > > > drivers/net/mlx5/Makefile | 10 + > > drivers/net/mlx5/meson.build | 4 + > > drivers/net/mlx5/mlx5.c | 651 ++++++++++++++++++++++++++---= ----- > > --- > > drivers/net/mlx5/mlx5.h | 45 ++- > > drivers/net/mlx5/mlx5_ethdev.c | 248 +++++++++----- > > drivers/net/mlx5/mlx5_flow.c | 2 + > > drivers/net/mlx5/mlx5_flow_dv.c | 45 ++- > > drivers/net/mlx5/mlx5_flow_verbs.c | 7 +- > > drivers/net/mlx5/mlx5_mr.c | 4 +- > > drivers/net/mlx5/mlx5_nl.c | 108 +++++- > > drivers/net/mlx5/mlx5_rxq.c | 41 +-- > > drivers/net/mlx5/mlx5_socket.c | 4 +- > > drivers/net/mlx5/mlx5_stats.c | 22 +- > > drivers/net/mlx5/mlx5_trigger.c | 2 +- > > drivers/net/mlx5/mlx5_txq.c | 24 +- > > 15 files changed, 879 insertions(+), 338 deletions(-) > > > > -- > > 1.8.3.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 6499EA05D3 for ; Wed, 27 Mar 2019 08:31:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4EDB4569B; Wed, 27 Mar 2019 08:31:19 +0100 (CET) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20069.outbound.protection.outlook.com [40.107.2.69]) by dpdk.org (Postfix) with ESMTP id 24D945699 for ; Wed, 27 Mar 2019 08:31:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HAX0tczwJUB7mCEGTXi+sm3Pp3iWVLtrJBUjd6g7E30=; b=jj3CgWPQzjWWGavTz5vYXqS7i0c+5xpOaNkClWPFFPwOIVe2Di2p9Az2mB7TD0NN/mALqY06S4259dMm1qqGepDPqbDMOHp5GuNu8pka3QmUfhmOyx+Advsg31vn46kn99t1FuLBxWZxrThDgxls6hMfeDZxBEm2woo9duSpj5A= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3249.eurprd05.prod.outlook.com (10.171.188.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.15; Wed, 27 Mar 2019 07:31:16 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::11b0:de86:8d93:8b02]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::11b0:de86:8d93:8b02%3]) with mapi id 15.20.1730.019; Wed, 27 Mar 2019 07:31:16 +0000 From: Slava Ovsiienko To: Shahaf Shuler , "dev@dpdk.org" Thread-Topic: [PATCH v3 00/14] net/mlx5: add support for multiport IB devices Thread-Index: AQHU5GJVn0U/A7XhK0K5troy8isy0qYfE3Uw Date: Wed, 27 Mar 2019 07:31:16 +0000 Message-ID: References: <1553533414-9911-1-git-send-email-viacheslavo@mellanox.com> <1553614522-12151-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 593250a0-2b2b-4a07-1e5b-08d6b28632b1 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM4PR05MB3249; x-ms-traffictypediagnostic: AM4PR05MB3249: x-ms-exchange-purlcount: 5 x-microsoft-antispam-prvs: x-forefront-prvs: 0989A7979C x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(396003)(136003)(39860400002)(376002)(346002)(13464003)(199004)(189003)(97736004)(66066001)(53546011)(102836004)(6506007)(446003)(11346002)(86362001)(6436002)(14444005)(256004)(476003)(2501003)(55016002)(5660300002)(966005)(186003)(26005)(76176011)(25786009)(305945005)(74316002)(486006)(229853002)(7736002)(71200400001)(71190400001)(8676002)(6306002)(6246003)(316002)(106356001)(53936002)(105586002)(81166006)(81156014)(110136005)(8936002)(9686003)(52536014)(68736007)(14454004)(33656002)(3846002)(99286004)(6116002)(478600001)(7696005)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3249; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Wbu0E+JWQYeUsiW2TjV831s/xKQymN0BmMkfooUMgBDMFKkBdt1DoX9oANdiBlqh4b3qbXusr2uUOrW98bQiMjfSa1jgbAHYtnUxZgMFAh4lNAw36bYhdSrklgEe2B3vpeLemg9JYUSq6XiLVK339r4ED4nt378++fPVBm2RVSZdwDovxuaMj+qKiyxZCbG6jQRa+hZXSQrYo8CnrwOdX3JAYLfXIddj5KPO0d6Cuc9x7w/mB5lolyZBq0Za9ZHw8LqDFcn0slo74rg5YgzZfVOPIk9xjwdfv4n62U2tR3RFTJel2k7ADMSck4/AiZwcLXBWjKBob8Zhy0W/KhzCWdPL/3BUez53/GXRqWzqmEkemimBO1Xyb9Nboxo7EceAvdtTooBBsmk2kUESgkNlyYhqSIfUSeaHuVFaIN78Etg= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 593250a0-2b2b-4a07-1e5b-08d6b28632b1 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Mar 2019 07:31:16.2402 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3249 Subject: Re: [dpdk-dev] [PATCH v3 00/14] net/mlx5: add support for multiport IB devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190327073116.rMy6B1I-z1VFvbRdjH7DNNqY7MuQvUn9hdqaVTY2AVQ@z> > -----Original Message----- > From: Shahaf Shuler > Sent: Wednesday, March 27, 2019 8:00 > To: Slava Ovsiienko ; dev@dpdk.org > Subject: RE: [PATCH v3 00/14] net/mlx5: add support for multiport IB devi= ces >=20 > Tuesday, March 26, 2019 5:35 PM, Viacheslav Ovsiienko: > > Subject: [PATCH v3 00/14] net/mlx5: add support for multiport IB > > devices > > > > The Mellanox NICs support SR-IOV and have E-Switch feature. [..] > > > > This patchset also superseedes http://patches.dpdk.org/patch/50486/ > > > > Signed-off-by: Viacheslav Ovsiienko >=20 > Slava, basically I am OK w/ the series, in order for me to apply: > 1. need to rebase on top of latest master. There are some merge conflicts= . > 2. at least patch[1] seems to be taken from another branch (checkout the > HAVE_MLX5DV_DR flag). Please handle. >=20 > [1] > https://patches.dpdk.org/patch/51739/ Off the list: My patchset is rebased on the top, but there are three Ori's commits not m= erged I was to told to base on: http://patches.dpdk.org/patch/51403/ >=20 >=20 > > > > --- > > v3: > > - vport_id field is added, contains associated VF vport > > index on E-Switch. representor_id field is reverted > > to keep the VF index > > - some comment spellcheck > > - some error logging is added for master/representor > > wrong recognition > > - shared IB context alloc/free routines mutex > > protection added > > > > v2: > > http://patches.dpdk.org/patch/51642/ > > - clarifying comments added > > - secondary process does not probe IB device at all and > > does not create shared context > > - minor bugs (like ++ in assert) fixed > > - representor_id contains corresponding VF vport index, > > no corrections +1 is needed anymore. vport index is > > calculated in the only place in code and if indexing > > schema is changed it would be easy to modify > > > > v1: > > http://patches.dpdk.org/cover/51451/ > > > > Viacheslav Ovsiienko (13): > > net/mlx5: add representor recognition on kernels 5.x > > net/mlx5: modify get ifindex routine for multiport IB > > net/mlx5: add getting IB ports number for multiport IB > > net/mlx5: add multiport IB device support to probing > > net/mlx5: add IB shared context alloc/free functions > > net/mlx5: switch to the names in the shared IB context > > net/mlx5: switch to the shared Protection Domain > > net/mlx5: switch to the shared context IB attributes > > net/mlx5: switch to the shared IB device context > > net/mlx5: provide IB port for the object being created > > net/mlx5: update install/uninstall int handler routines > > net/mlx5: update event handler for multiport IB devices > > net/mlx5: add source vport match to the ingress rules > > > > drivers/net/mlx5/Makefile | 10 + > > drivers/net/mlx5/meson.build | 4 + > > drivers/net/mlx5/mlx5.c | 651 ++++++++++++++++++++++++++---= ----- > > --- > > drivers/net/mlx5/mlx5.h | 45 ++- > > drivers/net/mlx5/mlx5_ethdev.c | 248 +++++++++----- > > drivers/net/mlx5/mlx5_flow.c | 2 + > > drivers/net/mlx5/mlx5_flow_dv.c | 45 ++- > > drivers/net/mlx5/mlx5_flow_verbs.c | 7 +- > > drivers/net/mlx5/mlx5_mr.c | 4 +- > > drivers/net/mlx5/mlx5_nl.c | 108 +++++- > > drivers/net/mlx5/mlx5_rxq.c | 41 +-- > > drivers/net/mlx5/mlx5_socket.c | 4 +- > > drivers/net/mlx5/mlx5_stats.c | 22 +- > > drivers/net/mlx5/mlx5_trigger.c | 2 +- > > drivers/net/mlx5/mlx5_txq.c | 24 +- > > 15 files changed, 879 insertions(+), 338 deletions(-) > > > > -- > > 1.8.3.1