From: Slava Ovsiienko <viacheslavo@mellanox.com>
To: Alexander Kozyrev <akozyrev@mellanox.com>,
Mohsin Shaikh <mohsinshaikh@niometrics.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: use open/read/close for reading ib stat
Date: Mon, 13 Apr 2020 10:48:11 +0000 [thread overview]
Message-ID: <AM4PR05MB326592CB27F209ADE8517754D2DD0@AM4PR05MB3265.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <AM0PR05MB456145D464996C5E7DA5BC59A2C10@AM0PR05MB4561.eurprd05.prod.outlook.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Alexander Kozyrev
> Sent: Friday, April 10, 2020 1:21
> To: Mohsin Shaikh <mohsinshaikh@niometrics.com>; dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: use open/read/close for reading ib
> stat
>
> > -----Original Message-----
> > From: Mohsin Shaikh <mohsinshaikh@niometrics.com>
> > Sent: Thursday, April 9, 2020 16:37
> > To: dev@dpdk.org
> > Cc: stable@dpdk.org; Alexander Kozyrev <akozyrev@mellanox.com>;
> Mohsin
> > Shaikh <mohsinshaikh@niometrics.com>
> > Subject: [PATCH] net/mlx5: use open/read/close for reading ib stat
> >
> > fgets(3)/fread(3)/fscanf(3) etc. use mmap(2)/munmap(2) which leads to
> > TLB shootdown interrupts to all dpdk app cores including RX cores.
> > This can cause packet drops. Use read(2)/write(2) instead.
> >
> > Bugzilla ID: 440
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Mohsin Shaikh <mohsinshaikh@niometrics.com>
> > ---
>
> Reviewed-by: Alexander Kozyrev <akozyrev@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
Thank you, Mohsin for the patch.
Alexander, thank you for the review and test.
With best regards,
Slava
next prev parent reply other threads:[~2020-04-13 10:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 20:37 Mohsin Shaikh
2020-04-09 22:20 ` Alexander Kozyrev
2020-04-13 10:48 ` Slava Ovsiienko [this message]
2020-04-14 14:17 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM4PR05MB326592CB27F209ADE8517754D2DD0@AM4PR05MB3265.eurprd05.prod.outlook.com \
--to=viacheslavo@mellanox.com \
--cc=akozyrev@mellanox.com \
--cc=dev@dpdk.org \
--cc=mohsinshaikh@niometrics.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).