From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7FD3A00BE; Tue, 29 Oct 2019 06:45:27 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 30D1A1BEDD; Tue, 29 Oct 2019 06:45:26 +0100 (CET) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130049.outbound.protection.outlook.com [40.107.13.49]) by dpdk.org (Postfix) with ESMTP id 35BE81BEC0 for ; Tue, 29 Oct 2019 06:45:25 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q/HPDk0MBqPKHZI+P/HLwEdSUj/FeiJZRYE7V2GFgcq7HC65eFTPHykIeVJOD9EVhnhASlPeGsnCS3b6aMEJ5YBiBXJIcYhjOU2DURVCZjfGKMweyekSdn2ot+jwSdVJVsqyzchBCtZ3v1beYVPFyoNj3fOCMnKYlie0IpAZbcpbrxyDLqfTbDwyUo6uIRyyjNePMCDScmUOq2LiELOtLe84r9L2a0if9XbN37OLw8eOtXlowU6je0EDh3KciU4aB/jycbtSaC2Q+UGh6VonKvyadsrB1Rue3rWgpAzHnKckMhLvKV1OoISAQ0SPsqWtNy3N4iNJfN42ddQnWRiLzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6FMx4j5qkS17nuN8T5PynH7jf2AP5TLJ33XxjluhEJY=; b=Og4Q5iA+549s00yReLPxFInx+QTTihqP2QQ/Vf0aRfRvomNrS7Kui2mWEKZqPhy0FCSHwj1RboIQEPpkoSgr4QfGewafXpw09TgTTOoOl9cPtwfy+nGoOXtlil0jR//n7p/pGTf/bUYWSY+0jVA1Vws5SQa8iIVpPQysoj/AUWLbdAuxpUb1cSqKkOWvN1TbDaH5cq+WyfUw5AvUl0u8jmbfln+Sl2HyoP0Ahsj2IvY2UxAgK62p6q2LYKyEQPgzoNmlSP28wBkv4uaQKwnfjKes5t/lYtzuxehPAHNCKm0e1QPOfteN1sOahbRdtoRxTYEGORLLXSeHUWVXQwSVWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6FMx4j5qkS17nuN8T5PynH7jf2AP5TLJ33XxjluhEJY=; b=UbsbTrCrPN1iE06J4eMElAu98O4GNkMzN0FrsgPaAYvHnD8lkyMNS0q3cfIqAJ2Mqf8iCQ6jnHV4pUrk9M5MBBrZxcF0A9IF3OyNbxN12+0nR4lIjkInsZMushknDceYkXskk1IO+tO9MuCHtzmFFmSdblvquJWfqTxV0Z19b6I= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3187.eurprd05.prod.outlook.com (10.171.189.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.25; Tue, 29 Oct 2019 05:45:23 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::edab:529f:d14e:d3b]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::edab:529f:d14e:d3b%7]) with mapi id 15.20.2387.027; Tue, 29 Oct 2019 05:45:23 +0000 From: Slava Ovsiienko To: Hideyuki Yamashita CC: Moti Haimovsky , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 0/7] net/mlx5: support for flow action on VLAN header Thread-Index: AQHVep9vAaM+AojguUG9N9frUX50nqdKSfMAgBYF6oCABHh/AIAAAyGQgAYeM4CABlZewA== Date: Tue, 29 Oct 2019 05:45:23 +0000 Message-ID: References: <20191021161147.EF4C.17218CA3@ntt-tx.co.jp_1> <20191025134838.66ED.17218CA3@ntt-tx.co.jp_1> In-Reply-To: <20191025134838.66ED.17218CA3@ntt-tx.co.jp_1> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: f260f95e-45c5-419b-77d7-08d75c333156 x-ms-traffictypediagnostic: AM4PR05MB3187:|AM4PR05MB3187: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0205EDCD76 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(396003)(346002)(366004)(376002)(39860400002)(13464003)(52314003)(199004)(189003)(305945005)(316002)(4326008)(66476007)(76116006)(186003)(66446008)(64756008)(3846002)(66946007)(5024004)(6436002)(8936002)(14444005)(256004)(66556008)(71200400001)(6246003)(66066001)(478600001)(14454004)(54906003)(71190400001)(86362001)(476003)(33656002)(9686003)(486006)(52536014)(81166006)(6116002)(446003)(11346002)(74316002)(2906002)(76176011)(7696005)(6506007)(53546011)(102836004)(6916009)(55016002)(5660300002)(7736002)(25786009)(26005)(229853002)(99286004)(81156014); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3187; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hQvqXYQthFPYLLQa5lY5U0xwqCSF+APiC2cq0ZDKDOWW502I8fjrO1/LbIezqp0VcZuggZDadIA1YNMcus3frloWBd1hzf5sQywTK6jDbxVOFJa7/nyZU5yIDM/B20D/4CWQkZKmsDSMfJaSyHSNjV0+8c1eE6aTi7h9BbijUk06ywX7Rq3Aaw9YcCwX8BHpnIfb3A+ulpLXt274OXHyFPbvTyUm6m8jGJJh2zMjVwun3AbB4Q44IoSFVfAZGiwHKrA8WkZK10VYnIX4fkT3SBLIkxFgsVNY6+pHKcx0UbIzHwEowaFmXyQCqaCIgXwhsFR4nn81JT1YcozttBGfaMUs7022dc+w/wCxipqQxK8kRmuhSjd0R5SrIj4tiJAqCGHbVEwK58yccqMxbslAREGc3HE6oE9mwtNGU44yMdonTH15+DHtU8lZlnayLOhj Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: f260f95e-45c5-419b-77d7-08d75c333156 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2019 05:45:23.5463 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 74JkCxNYJizDML4BiuWpeyLjjQjW4FLVv6w+WnHEW6kzXl7eS3kEEyeaT2Hx6Sy58dXiuCHV5ghpRIRvO7oRM1LFA82J6YA8ReiYQGPwtE0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3187 Subject: Re: [dpdk-dev] [PATCH 0/7] net/mlx5: support for flow action on VLAN header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Hideyuki. Thanks for providing extra information.=20 We rechecked the VLAN actions support in OFED 4.7.1, it should be supported= . There are some limitations: - VLAN pop is supported on ingress direction only - VLAN push is supported on egress direction only - not supported in group 0 (this is root table, has some limitations) we should insert into group 0 flow with jump to group 1, and then insert the rule with VLAN actions to group 1 I tried this flow (on my setup OFED 4.7.1.0.0.2): flow create 0 ingress group 1 priority 0 pattern eth dst is 00:16:3e:2e:7b:= 6a / vlan vid is 1480 / end actions of_pop_vlan / queue index 0 / end It was created successfully. With best regards, Slava > -----Original Message----- > From: Hideyuki Yamashita > Sent: Friday, October 25, 2019 7:49 > To: Slava Ovsiienko > Cc: Moti Haimovsky ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 0/7] net/mlx5: support for flow action on > VLAN header >=20 > Hello Slava, >=20 > Thanks for your response back. >=20 > While waiting your final response, > I am sending additional info from my side. >=20 > 1 > I am using "MLNX_OFED_LINUX-4.7-1.0.0.1-ubuntu18.04-x86_64" > as OFED. >=20 > tx_h-yamashita@R730n10:~/dpdk-next-net$ pwd /home/tx_h- > yamashita/dpdk-next-net > tx_h-yamashita@R730n10:~/dpdk-next-net$ ls > app MAINTAINERS > buildtools Makefile > config meson.build > devtools meson_options.txt > doc mk > drivers MLNX_OFED_LINUX-4.7-1.0.0.1-ubuntu18.04-x86_64 > examples MLNX_OFED_LINUX-4.7-1.0.0.1-ubuntu18.04-x86_64.tgz > GNUmakefile README > kernel usertools > lib VERSION > license x86_64-native-linuxapp-gcc >=20 > 2. > I am using ConnextX-4 and ConnectX-5. > I attach the result of typing ethtool -i . >=20 > Bus info Device Class Description > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D > pci@0000:03:00.0 enp3s0f0 network MT27710 Family [ConnectX-4 > Lx] > pci@0000:03:00.1 enp3s0f1 network MT27710 Family [ConnectX-4 > Lx] > pci@0000:04:00.0 enp4s0f0 network MT27800 Family [ConnectX-5= ] > pci@0000:04:00.1 enp4s0f1 network MT27800 Family [ConnectX-5= ] >=20 > tx_h-yamashita@R730n10:~/dpdk-next-net$ ethtool -i enp3s0f0 > driver: mlx5_core > version: 4.7-1.0.0 > firmware-version: 14.25.1020 (MT_0000000266) > expansion-rom-version: > bus-info: 0000:03:00.0 > supports-statistics: yes > supports-test: yes > supports-eeprom-access: no > supports-register-dump: no > supports-priv-flags: yes > tx_h-yamashita@R730n10:~/dpdk-next-net$ ethtool -i enp4s0f0 > driver: mlx5_core > version: 4.7-1.0.0 > firmware-version: 16.25.6000 (MT_0000000012) > expansion-rom-version: > bus-info: 0000:04:00.0 > supports-statistics: yes > supports-test: yes > supports-eeprom-access: no > supports-register-dump: no > supports-priv-flags: yes >=20 > If you needs more info from my side, please let me know. >=20 > BR, > Hideyuki Yamashita > NTT TechnoCross >=20 > > Hi, Hideyuki > > > > > -----Original Message----- > > > From: Hideyuki Yamashita > > > Sent: Monday, October 21, 2019 10:12 > > > To: Hideyuki Yamashita > > > Cc: Slava Ovsiienko ; Moti Haimovsky > > > ; dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH 0/7] net/mlx5: support for flow > > > action on VLAN header > > > > > > Dear Slava, Moti and all, > > > > > > Please let me know if you need more information. > > > Partial answer is acceptable for me. > > > > > > Thanks in advaince! > > > > I'm sorry for delay, your issue is still in progress. > > I've tested your rules on my standard configuration - these ones are > > rejected by FW/SW, not by DPDK code. Moti tested the flows on custom > setup (I suppose experimental FW/kernel). > > AFAIK, VLAN feature was planned to GA with OFED 4.7.1, please, let me > > check it (hope in few days, there are holidays still lasting in IL). > > > > With best regards, Slava > > > > > > BR, > > > HIdeyuki Yamashita > > > NTT TechnoCross > > > > > > > Dear Slava and experts, > > > > > > > > Thanks for your answering me. > > > > Baased on your answer, I tested using testpmd. > > > > And about the outcome, I have several questions. > > > > > > > > > > > > [1.Test environment] > > > > OS:Ubuntu18.04 > > > > NIC1:MCX4121A-ACAT 25G > > > > NIC2:MCX516A-CCAT 100G > > > > Repo:dpdk-next-net > > > > > > > > I checked that the following is shown in git log command. > > > > 9f1e94469 net/mlx5: fix netlink rdma socket callback routine > > > > 50735012c > > > > net/mlx5: support reading module EEPROM data > > > > f53a5f917 net/mlx5: support modify VLAN ID on existing VLAN header > > > > 9af8046a1 net/mlx5: support modify VLAN ID on new VLAN header > > > > 43184603e net/mlx5: support modifying VLAN priority on VLAN header > > > > 4f59ffbd8 net/mlx5: support push flow action on VLAN header > > > > b4bd8f5da > > > > net/mlx5: support pop flow action on VLAN header 048e3e84c > net/mlx5: > > > > add VLAN push/pop DR commands to glue > > > > > > > > [2.Test result] > > > > I tested the follwoing flows with testpmd included in dpdk-next-net= . > > > > > > > > A.flow create 0 ingress pattern eth / vlan id is 100 / end actions > > > > OF_POP_VLAN / end B.flow create 0 ingress pattern eth dst is > > > > BB:BB:BB:BB:BB:BB / end actions OF_PUSH_VLAN ethertype 1000 / end > > > > C.flow create 0 ingress pattern eth dst is BB:BB:BB:BB:BB:BB / end > > > > actions OF_SET_VLAN_VID vlan_vid 200 / end D.flow create X ingress > > > > pattern eth dst is BB:BB:BB:BB:BB:BB / end actions of_SET_VLAN_PCP > > > > vlan_pcp 3 / end E.flow create 0 egress pattern eth src is > > > > BB:BB:BB:BB:BB:BB / end actions OF_PUSH_VLAN ethertype 1000 / end > > > > > > > > A-D, resulted in "Caught error type 16 (specific action): cause: > > > 0x7ffcc711db48, action not supported: Operation not supported". > > > > E resulted in "Egress is not supported". > > > > > > > > [3. Quetions] > > > > Q1. What is the appropriate flow to entag/detag VLAN using testpmd? > > > > I think related commits are included so it "should" work and my > > > > guess is > > > that my flow is somehow wrong. > > > > Q2. Is it correct understanding that "egress" is not supported for > > > > mlx5 > > > PMD? > > > > Q3. If yes, is it possible to entag VLAN tag to the outgoing > > > > packet from > > > physical NIC by using rte_flow? > > > > > > > > BR, > > > > Hideyuki Yamashita > > > > NTT TechnoCross > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: Hideyuki Yamashita > > > > > > Sent: Friday, October 4, 2019 13:35 > > > > > > To: Hideyuki Yamashita > > > > > > Cc: Moti Haimovsky ; Slava Ovsiienko > > > > > > ; dev@dpdk.org > > > > > > Subject: Re: [dpdk-dev] [PATCH 0/7] net/mlx5: support for flow > > > > > > action on VLAN header > > > > > > > > > > > > Can somebody (Mellanox guys?) help me out? > > > > > > > > > > Hi, Hideyuki > > > > > > > > > > I'm sorry, there are long holidays in IL, so let me try to answer= . > > > > > > > > > > > > > > > > > > Hello Moti, > > > > > > > > > > > > > > I have some questions on the patch. > > > > > > > Just want to know how to use it. > > > > > > > > > > > > > > Q1. Is it correct understanding that the patch will be > > > > > > > reflected in > > > > > > > 19.11 if it is approved? > > > > > > > > > > Yes, it is merged and should be reflected. > > > > > > > > > > > > > > > > > > > Q2.Which action should I specify when I want to insert VLAN > > > > > > > tag to non-VLAN frame? > > > > > > > > > > > > > > OF_PUSH_VLAN and OF_SET_VLAN_VID and OF_SET_VLAN_PCP ? > > > > > > > > > > All of them, OF_PUSH_VLAN inserts the VLAN header, > > > > > OF_SET_VLAN_VID and OF_SET_VLAN_PCP fill the fields with > appropriate values. > > > > > > > > > > > > > > > > > > > Q3. Is it possible to detag VLAN when it receives VLAN > > > > > > > tagged frame from outside of the host? > > > > > Do you mean some complex configuration with multiple VMs and > > > engaged > > > > > E-Switch feature? Anyway, there are multiple ways to strip > > > > > (untag) VLAN > > > header: > > > > > - with E-Switch rules (including match on specified port) > > > > > - with local port rules > > > > > - stripping VLAN in Rx queue > > > > > > > > > > > > > > > > > > > Q4. Is it possible to entag VLAN to non-VLAN frame when it > > > > > > > sends packet to outside of host? > > > > > Yes. > > > > > > > > > > > > > > > > > > > Q5.Are there any restriction to conbime other ACTIONS like > QUEUE? > > > > > Should no be. Action QUEUE is on Rx NIC namespace, VLAN POP is > > > supported there. > > > > > > > > > > > > > > > > > > > Q6. Is it possible to apply rte_flow actions for specified > > > > > > > tx queue of physical NIC? > > > > > > > (e.g. VM connect with PHY:0 using tx queue index:1, I want > > > > > > > to entag VLAN 101 to the traffic from VM to PHY:0 is it > > > > > > > possible?) > > > > > Directly - no, there is no item to match with specific Tx queue. > > > > > > > > > > If setting VLAN on specific Tx queue is desired we have two optio= ns: > > > > > > > > > > - engage Tx offload DEV_TX_OFFLOAD_VLAN_INSERT, and provide > VLAN > > > > > with each packet being transferred to tx_burst > > > > > > > > > > - engage DEV_TX_OFFLOAD_MATCH_METADATA feature, and set > > > specific > > > > > metadata for all packets on specific queue. Then the rules > > > > > matching with this metadata may be inserted. > > > > > > > > > > [snip] > > > > > > > > > > With best regards, Slava > > > > > > > > > > >=20