From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 887A5A057B; Thu, 2 Apr 2020 13:23:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 63F9C2C15; Thu, 2 Apr 2020 13:23:27 +0200 (CEST) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2069.outbound.protection.outlook.com [40.107.21.69]) by dpdk.org (Postfix) with ESMTP id 03167FFA for ; Thu, 2 Apr 2020 13:23:26 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SpeXU22DDi1UEBYuZOFLZYb5PmRoVPiajNuuoOLo4LXsQiEVNZxxTqa5dncoHDHFJCqHreOqXrceCAdhvzM11547KDNw2qKoWvY/P9JTzQE2n+s13i1HM3SFnjZOFqwrDeeWSeWn26SF3Y3+8d9cjsTOHbrobfgU77BNWRJkOpHpyrZwutPLts5Z+1ixrSBbSVOyxqh5knEO1oGwDDGI+usr8QX//8axe7jDv4yx9lmgc20KYsl3MzT7AUtrvnMaEBODLMQynBdFtcDQdN0V6yZID1wKSZQkdc6htzMW8Zm262Zg2YCytwFrNCy5g0aQnwlY6HV+s5OjhyHlGQkhBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MWj7L2GCJoiJWN79F6qRY8KxhsXuXEUwLe/nwTdlbLc=; b=Mg4dBB/jF9NAjcnZhKusXzgKTv+Q3Lx5e7vjjBXHHnG/dwaouVANJO12ZPBW832+vFu1/Vtm9X8St+90yAvB28DXrYANlRwM5+TRm5IDf4c7mDhkWCnxrdRYCDsiIdpY0PrCRsVpHxBzYyT+VZBithuoy2eNX5odU81iZekYfZuchp6jS/7eDe614sz5EwSRlDBONsKIfKUhvtEFprX6exlykK1m0MCUauaA2t++CCzjhzfp7pV9t+1J5S6rtVXlDRNRgdY3cX1TfBAYQBdg9WODjuezfT/E+YqoF0PlXmBHlLyhOTZr7CCWN3T6puVSsQtATUT3kb50fuDRvWRW0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MWj7L2GCJoiJWN79F6qRY8KxhsXuXEUwLe/nwTdlbLc=; b=Mb9IObaF5TAX5hEVIwmML/CYKmA0N2GeRQ6RP2bnzpMauEJiDVPbiiMvdVh9fGPZNmxGQ3ABBJqOt8c9lD4tCZ3o7+i+OuUhYwE0MlNqw/KOLdRiumVQP5y7pqorh6082BYLrulZgdx1N8rWXMdzf95L9VQsjOHY0YQyAmWSxmA= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3154.eurprd05.prod.outlook.com (10.170.125.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Thu, 2 Apr 2020 11:23:23 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::da5:7919:35c1:894]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::da5:7919:35c1:894%6]) with mapi id 15.20.2856.019; Thu, 2 Apr 2020 11:23:23 +0000 From: Slava Ovsiienko To: Thomas Monjalon CC: "dev@dpdk.org" , "ferruh.yigit@intel.com" , "bernard.iremonger@intel.com" Thread-Topic: [dpdk-dev] [PATCH v2 2/3] app/testpmd: gather Rx and Tx routines profiling Thread-Index: AQHWCOC2HgitKYLYqk65bWWqa8jkbKhlr+9g Date: Thu, 2 Apr 2020 11:23:23 +0000 Message-ID: References: <1561553317-16777-1-git-send-email-viacheslavo@mellanox.com> <1584625851-10291-1-git-send-email-viacheslavo@mellanox.com> <1584625851-10291-3-git-send-email-viacheslavo@mellanox.com> <2267488.53lzm7zTb9@xps> In-Reply-To: <2267488.53lzm7zTb9@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 6d491e97-192e-4f80-6ce6-08d7d6f84184 x-ms-traffictypediagnostic: AM4PR05MB3154: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-forefront-prvs: 0361212EA8 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM4PR05MB3265.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(366004)(39860400002)(376002)(396003)(346002)(136003)(81156014)(86362001)(52536014)(33656002)(5660300002)(71200400001)(9686003)(54906003)(7696005)(2906002)(6916009)(316002)(66446008)(55016002)(66476007)(478600001)(8936002)(66556008)(81166006)(66946007)(26005)(53546011)(6506007)(4326008)(186003)(76116006)(64756008)(8676002); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WwP72TAVOoor+Ol1wGrWCMemf6p3Z+hVXbiu/KBhLyAxXtNUxyLI2sqGXy4Cmu3E8wUT0h7njPbjkJtrmaODrey8NcyNas91tGFw+6kvmfjeuNOW1uVS8PkGfIswtlK23YVG6eBD3neftuyVOdlZGcKvI8HG486TCF0iE0lkLNp4yw28Uxep22l6exPg9m5BbzKP+F81r9o2+yPkG5NwbHo3GT+c1D06Hdf+whFGGOgEItERV9sWVJmqTsdXvE1TK7jkvJ9jS1AOJDulDZuQ332z970hT1OWwSx1Q6J+DVCO5/mj5hTRCCbmQhlhdvzXOXojfZA4LNVZB/9RWr9MuQ4yC9ZWbBNly6dZLV2tT37GJj8kkFnrHYW7p2SEKQTl6WlwHV3Mph9aT0gj5zHTw4GnDFOCTbBlSkpcHZymgF7s1qUfw8Ord/fJlXTHRM3v x-ms-exchange-antispam-messagedata: ktcPdPewYGPI+IgDfUcFGQ6lk+xK889KyLny/ZEBq038heQo66aMqZGh17bsfvBJKba2b4sw4dyFw2vFga+6VXMNNvcirQI9QbypN1heSvWhMmy+IFdUVBxPiK3uG99Pl0yFkTO4MS2BIe8DkHaUmg== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6d491e97-192e-4f80-6ce6-08d7d6f84184 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2020 11:23:23.4506 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CJJzx4DiXYHcBhHchPI+Ezz9w7rJlR5M3r+SgNZqI5ppXbtiRZRqdf1y5J7HPsAeAH7DeGBSzO88ytTU1eTpy7m95v9zJiX2wkUlcuGgCJI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3154 Subject: Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: gather Rx and Tx routines profiling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Thanks to all for reviewing and comments, will address ones in v3. With best regards, Slava > -----Original Message----- > From: Thomas Monjalon > Sent: Thursday, April 2, 2020 14:20 > To: Slava Ovsiienko > Cc: dev@dpdk.org; ferruh.yigit@intel.com; bernard.iremonger@intel.com > Subject: Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: gather Rx and Tx > routines profiling >=20 > 19/03/2020 14:50, Viacheslav Ovsiienko: > > + if (fwdprof_flags & RECORD_CORE_CYCLES_RX && total_recv > 0) > > + printf("\n rx CPU cycles/packet=3D%u (total cycles=3D" > > + "%"PRIu64" / total RX packets=3D%"PRIu64")\n", > > + (unsigned int)(rx_cycles / total_recv), > > + rx_cycles, total_recv); > > + if (fwdprof_flags & RECORD_CORE_CYCLES_TX && total_xmit > 0) > > + printf("\n tx CPU cycles/packet=3D%u (total cycles=3D" > > + "%"PRIu64" / total TX packets=3D%"PRIu64")\n", > > + (unsigned int)(tx_cycles / total_xmit), > > + tx_cycles, total_xmit); >=20 > This is the "UI", so I think it deserves a cautious review. >=20 > Instead of "=3D" without space, I think ": " is easier to read. >=20 > Please use "Rx" and "Tx" instead of lowercase ones. >=20 > "CPU cycles/packet" is hard to read. I would prefer either > "cycles/packet" without CPU > or > "cycles per packet" >=20 > I will continue some UI comments in next patch. >=20