From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D5AFA0525; Fri, 21 Feb 2020 08:39:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6B02C1BF9A; Fri, 21 Feb 2020 08:39:55 +0100 (CET) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00051.outbound.protection.outlook.com [40.107.0.51]) by dpdk.org (Postfix) with ESMTP id BB5C8397D for ; Fri, 21 Feb 2020 08:39:54 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fwJv6B1GAiKH1jpIPBdy2qRq+otgtU0WgM19cU0s9HerS3aLiWWB0Hxu0hspc1laF+UZrYhcG2J6wQEIb/77jcThWN2IUTam09PMupfhNpWkbFfqimF8On7zCc1gpAuCQN386BsBGKHXVveVutiGKGVGoSegVJ9Oc3ojhCgy4AWio9giIuF7EWx0G9qx9w+ql5DBbPhBSl+3WqqLBlHUbj+9ICuiNZI03yM0QFRXC4MYvAu5jGTFBpnPLTYcj1dzZ4ajTM0vuB1CnhHA/beON1V0LozsI+aAEk8Yj4Ah1hAxBszZg6B/UXJsgKUQLLhWtB1mJtaSXxX0BLqLpJVPsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tDm7TG8jkT+LWxTTADDSSuaH3zp6rLBJjn8p3lR3gDY=; b=oK9b1sBGdQFCVp70+D37aEtd0uunli4IEQCnXrj21QONaLIK3/MTNi610/SALekaaXRdsIzHA9a6tYqJuJ+xiO1bYByBqIH2obtOgF5ur2eRoxPWe8gsE3ZvfzV8AxmbJECd5JpH2RnYH+xCqdAq8bl1T5FLvMyvZW7rPbCtxQpAElSURRjCkKx/zD+alA2lhBMRSR/df/VgdMCO17GmYVUHx18kVw0LnZzr0Nsb2PUFJW8YQtwNwqMsEjKeXVKhPlNvqLmrXe9u3Ij1qYeaMd/hUP7qGG6zBIKpnoIwCo8EmR/IhhC5Px3P1IobLlpdR3kF7i1GqoKa8Z74MBKiMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tDm7TG8jkT+LWxTTADDSSuaH3zp6rLBJjn8p3lR3gDY=; b=Bes8BqhhqyN/2XFL23ZEeMncvGdcG9EkY0uTuJj0EtGHI3ZoW6gRx3JJfeE2txz5kO6fjrxoFRmDZRF0yV2HgGGBaKpODRSMWc2ewwdTrYswpHBZWdbW3s3S9JDSjAT+MuiaryT9XmiJoICzdB1SBq7jLsglie1P5bZq4SxUD6g= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3473.eurprd05.prod.outlook.com (10.170.126.150) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2729.25; Fri, 21 Feb 2020 07:39:53 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::da5:7919:35c1:894]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::da5:7919:35c1:894%6]) with mapi id 15.20.2729.032; Fri, 21 Feb 2020 07:39:53 +0000 From: Slava Ovsiienko To: Matan Azrad , "dev@dpdk.org" CC: Raslan Darawsheh , Thomas Monjalon , "ferruh.yigit@intel.com" Thread-Topic: [PATCH] net/mlx5: fix inline packet size for ConnectX-4LX Thread-Index: AQHV6InHWbCeK2I41kyxe83eE0r3zqglQr9w Date: Fri, 21 Feb 2020 07:39:53 +0000 Message-ID: References: <1582233513-3372-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: cb4a1ad8-8517-4ef4-52b3-08d7b6a13da4 x-ms-traffictypediagnostic: AM4PR05MB3473:|AM4PR05MB3473: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr,ExtFwd x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-forefront-prvs: 0320B28BE1 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(136003)(376002)(39860400002)(346002)(396003)(199004)(189003)(55016002)(86362001)(4326008)(81156014)(81166006)(9686003)(8676002)(8936002)(33656002)(5660300002)(478600001)(186003)(66946007)(7696005)(66446008)(54906003)(71200400001)(52536014)(26005)(316002)(2906002)(76116006)(64756008)(66476007)(110136005)(6506007)(53546011)(66556008); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3473; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EJS+ndIv9I7aaFa0cymxunEyBoc0pxEYAPvRKciKtu/xfarX/kWhKqFN1lzkd3Zip4ot63h6tP7Owh5kmZPYb6QMu5HJHrpZGotR5duWIOs3hpEvb4YYlm+J+dLFFQTmrCk+nqHsE24kJxdectm4Qo8LeNjcNhUlk8js/p5PL6D5d0FZtbbeTyZL88MAx9fSVCi1yswSd4jdCikGGGWelrpxpVuoEdpf6abxou0KrogqCvPzLghaXuwijbMytWg/wVDgyUu0JX8QDJUGAdCe2qNeuDjBb658ThZg4kjlZrevuOCLWa7gVrRXsFllQWQ8O6AslxAFUnCziiSERL+eHuqyAEy8pMdcbQrUEmKx/btMqwTePwxZ/2wzNTZgyoYuHv0B5xlwzINObVuhSc+lBXp6vbTDVPih8MEc/OobhQelqrYzY9sxMFKZQm6LSy8U x-ms-exchange-antispam-messagedata: mbgVzp5llGM/i8Rm74V/stLzPwPT0SmlsIuhJI6/UhDoiwTycArH5NTYQc6R7AssQ2XfPD78SqHJ2VGbksZE5b+5iU5oG3IvMmXi2fKHJTxYa53FF8EiOAQBVFCf6MNBSbQLzirNf9aHsHRToky/dg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb4a1ad8-8517-4ef4-52b3-08d7b6a13da4 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2020 07:39:53.4934 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 03TIvSfK21vUqX5Epjyy30M1zjbQ/TEfrlrDCInjfTxVkOFEpYzc1gqvZ4nbqnM2Le1spWyA7ABreJzCZtAdG7SrYuaWnsiM+vTL6xCLe0c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3473 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix inline packet size for ConnectX-4LX X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Matan Azrad > Sent: Friday, February 21, 2020 9:38 > To: Slava Ovsiienko ; dev@dpdk.org > Cc: Raslan Darawsheh ; Thomas Monjalon > ; ferruh.yigit@intel.com > Subject: RE: [PATCH] net/mlx5: fix inline packet size for ConnectX-4LX >=20 >=20 >=20 > From: Viacheslav Ovsiienko > > This patch does extra inline packet size check to tune the > > ConnectX-4LX performance in the legacy Multi-Packet Write mode. > > > > Signed-off-by: Viacheslav Ovsiienko >=20 > Slava, Don't you think we want it for stable releases? Yes, thanks for reminding, just forgot "cc: stable", will send to stable ML= . >=20 > Besides it: > Acked-by: Matan Azrad >=20 > > drivers/net/mlx5/mlx5_rxtx.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/net/mlx5/mlx5_rxtx.c > > b/drivers/net/mlx5/mlx5_rxtx.c index b55db4f..0df811b 100644 > > --- a/drivers/net/mlx5/mlx5_rxtx.c > > +++ b/drivers/net/mlx5/mlx5_rxtx.c > > @@ -4281,6 +4281,8 @@ enum mlx5_txcmp_code { > > loc->mbuf->ol_flags & PKT_TX_DYNF_NOINLINE) > > goto pointer_empw; > > if (MLX5_TXOFF_CONFIG(MPW)) { > > + if (dlen > txq->inlen_send) > > + goto pointer_empw; > > tlen =3D dlen; > > if (part =3D=3D room) { > > /* Open new inline MPW session. */ > > -- > > 1.8.3.1