From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C188A046B for ; Thu, 27 Jun 2019 06:48:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B901331FC; Thu, 27 Jun 2019 06:48:34 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20073.outbound.protection.outlook.com [40.107.2.73]) by dpdk.org (Postfix) with ESMTP id 5473A2BE2 for ; Thu, 27 Jun 2019 06:48:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SZju7UBVYHE8t0HXcvktwuA8EM7q/bxPOJMNtPAdpm0=; b=aVo65gte/Tg+MTCs95rZJffla4RP0vCBzBAZm1P4rzZbT1JYHSBC4sacBFJKaouKIw7beMOv/ONyzePID08dqqwJjNRjFrag2KgMVS/ZTniSAKaWNu0mm3I2theAa4/G5TU89BdxYe4odkJoUJkQs6h0zdoOHSxXHzZ2lZxx+CU= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3411.eurprd05.prod.outlook.com (10.171.190.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2008.16; Thu, 27 Jun 2019 04:48:32 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::1442:fc4d:41ad:29d2]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::1442:fc4d:41ad:29d2%5]) with mapi id 15.20.2008.014; Thu, 27 Jun 2019 04:48:32 +0000 From: Slava Ovsiienko To: Bruce Richardson CC: "dev@dpdk.org" , "bernard.iremonger@intel.com" , "ferruh.yigit@intel.com" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx burst routines Thread-Index: AQHVLB684bjTosGyukmH5WaeRSplKKat5gbwgAAF1wCAAQEZkA== Date: Thu, 27 Jun 2019 04:48:32 +0000 Message-ID: References: <1561553317-16777-1-git-send-email-viacheslavo@mellanox.com> <20190626125732.GC862@bricha3-MOBL.ger.corp.intel.com> <20190626132124.GD862@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20190626132124.GD862@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.67.35.250] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ca98bbfe-94c6-4e93-8366-08d6fabab4e5 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM4PR05MB3411; x-ms-traffictypediagnostic: AM4PR05MB3411: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 008184426E x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(396003)(346002)(136003)(39860400002)(376002)(13464003)(189003)(199004)(66446008)(71190400001)(14444005)(33656002)(14454004)(6436002)(8936002)(66556008)(11346002)(5660300002)(508600001)(7696005)(76176011)(52536014)(229853002)(66476007)(64756008)(66066001)(446003)(4326008)(73956011)(53546011)(102836004)(476003)(25786009)(26005)(2906002)(186003)(6506007)(68736007)(6916009)(486006)(6116002)(8676002)(305945005)(71200400001)(76116006)(53936002)(66946007)(3846002)(9686003)(7736002)(6246003)(81156014)(81166006)(86362001)(316002)(99286004)(74316002)(54906003)(55016002)(256004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3411; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 1LlmFfGy2TKpfx/STg3/OcmFrc5qSyfGYRw9414DR4Ns6yKxwaSbhWJfL20R3CycAZaWVKnh3A/+Uh6nKT2Vjo3jlLLASGSxfzJxMpuc9e51+gUJwlMfcu0aj1RodVdf6XxBtUI1vttwHVCdkomjNioUVKlgab9ri75OoVEhRmmmE9UjRIwwedxzU/cOV+Rom8fofvuaZBEjSzHEnX7Q8esYVs4RWNzB5Zu4BjVn4e0fpfQMwsKRIc/isI7S+119ln6mxIfJgAKXkaUdNzN+HQW8bsznIe3DrgVO5xZYuWPNrcO2Ma2I0SaCR579O7u08ibaOkrXCEQq0imOQGhs9Jg2T6aLNTJUyuPnXBO0c8FEbgVHl7EAFhbBsPAnj0NOtyDD2w2EP9heXICeqXAGA1TE+CyZVXwe1rgRLOLA+jM= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca98bbfe-94c6-4e93-8366-08d6fabab4e5 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jun 2019 04:48:32.3576 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: viacheslavo@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3411 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx burst routines X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" OK, what do you think about this: #ifdef RTE_TEST_PMD_RECORD_CORE_CYCLES if (record_cycle & RECORD_TX_CORE_CYCLES) { .. do measurement stuff .. } #endif + add some new command to config in runtime: "set record_cycle 3" We keep existing RTE_TEST_PMD_RECORD_CORE_CYCLES, do not introduce new build-time configs and get some new runtime configuring. WBR, Slava > -----Original Message----- > From: Bruce Richardson > Sent: Wednesday, June 26, 2019 16:21 > To: Slava Ovsiienko > Cc: dev@dpdk.org; bernard.iremonger@intel.com; ferruh.yigit@intel.com > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx burs= t > routines >=20 > On Wed, Jun 26, 2019 at 01:19:24PM +0000, Slava Ovsiienko wrote: > > Hi, Bruce > > > > Do you mean using "if (core_rx_cycle_enabled) {...}" instead of #ifdef = ? > > > > No, I did not try runtime control settings. > > Instead I compared performance with all RECORD_CORE_XX_CYCLES > options > > enabled/disabled builds and have seen the ~1-2% performance difference > on my setups (mainly fwd txonly with retry). > > So, ticks measuring is not free. > > > > With best regards, > > Slava > > > Yes, I realise that measuring ticks is going to have a performance impact= . > However, what I was referring to was exactly the former - using an "if" > rather than an "ifdef". I would hope with ticks disable using this option= shows > no perf impact, and we can reduce the use of build-time configs. >=20 > /Bruce