From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0602AA00E6 for ; Mon, 5 Aug 2019 14:44:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 484F31BDE9; Mon, 5 Aug 2019 14:44:16 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40083.outbound.protection.outlook.com [40.107.4.83]) by dpdk.org (Postfix) with ESMTP id 90BDC1B9F6 for ; Mon, 5 Aug 2019 14:44:14 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BTGYd4QMg50IDqpL1FDzayRBc9qB5+0R52NrkNQCL8rCGAo153xlBgdkmjo6qij/nK/tDtTHuqLwOHNUp5rwvtNgCXvKb/jsgdY8umdQyODqClZvLZyoRvok5f1DxIVDl93KOjMyRVlsldh64lpmsZCmFf29wCf4BESFdPDoMn+/4U7iWMU8WITtRrE4ZgeNNR2DZUpay7owLMXbdXHSaAU235bWkLr0j8aO3l2Vi1PyraXt+wMp3Pt1sJnn2N0O96Tjs5nueJHHeF/2bb+zSAFjxzzgHSvPCHmHx2xk23lAL80L0Ep56+vsM19toNgHQraCkz2mD8FnLvXUWZKsTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8cQ8yELONoTt+0ON2y7FIgtKFfDogmrsAmV6Q5vLLtQ=; b=U0475z6RNg6X0T7UlUuxVm6NrmqHzIFhvhCd5go/ZM7FObld6O/XMA1FVUdDcLSWUkBAyreVwDXjForZVYYQuNxIIiVaWkEoxTw0T/7tUaZc6RcVmr+aV3oM50+3m4c09LQiUfu7yZqWz68HlyEnA/cdU/IxXaC3HGtGnVHdRiOnNYEpr6Fu7EyNwOoAUJGtcPOH4DkNV4GI9zpQWA4lZ05a+4GifMDAwp5QdhTUfpRqdfxZEYJTDzL40TPwt/izCwQs/3Zhah2DtmkS/ccScoN91ousQxLZHJcuxPdVHhhENYrJXQPZgAJh+QSWcHrvOGdAjQ4w4raJVhpd9IE5Cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8cQ8yELONoTt+0ON2y7FIgtKFfDogmrsAmV6Q5vLLtQ=; b=qKICo6r69f8hebCx3oof9u1BAWPJzenhQrLQobv+HTEXS4ooJwkq9t56U2Es+MP+epQEhQqxPloSsbv7Ani9WiRxONbPGI8CjFEejjtpdF4XLiaWsMNK7CJ5Tej2+qDAoHJH5+u3iDNRBZdu1TCJg+9Bs3coNjjNVb4yXaSSWuI= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3457.eurprd05.prod.outlook.com (10.170.126.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2136.17; Mon, 5 Aug 2019 12:44:13 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::ec83:c573:8eda:b6a]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::ec83:c573:8eda:b6a%4]) with mapi id 15.20.2136.018; Mon, 5 Aug 2019 12:44:13 +0000 From: Slava Ovsiienko To: Dekel Peled , Yongseok Koh , Shahaf Shuler CC: Ori Kam , "dev@dpdk.org" , Eli Britstein Thread-Topic: [PATCH] net/mlx5: fix order of lines in loop Thread-Index: AQHVS4RSGp6W50jF0kmoHcrI3JhTfKbsf9lQ Date: Mon, 5 Aug 2019 12:44:12 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.67.35.250] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c402ec89-3382-490d-9536-08d719a29e8a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:AM4PR05MB3457; x-ms-traffictypediagnostic: AM4PR05MB3457: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-forefront-prvs: 01208B1E18 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(136003)(396003)(366004)(376002)(346002)(199004)(189003)(13464003)(99286004)(54906003)(110136005)(6506007)(7696005)(76176011)(64756008)(66446008)(66556008)(66946007)(66476007)(71200400001)(71190400001)(2906002)(316002)(55016002)(305945005)(7736002)(102836004)(52536014)(3846002)(25786009)(76116006)(6116002)(6246003)(53936002)(14444005)(256004)(6436002)(229853002)(4326008)(68736007)(8676002)(81156014)(81166006)(86362001)(107886003)(5660300002)(33656002)(478600001)(66066001)(9686003)(486006)(26005)(476003)(6636002)(446003)(11346002)(53546011)(14454004)(74316002)(186003)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3457; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: rsH43e8kMURUt/hRXxtGD+0G/TqTCvlhF0FlR1V7s3BjwwXZfaFzhw1Dm1LLrQuZj8sAk4i9HgD76NZOGpbbkyJCdC5Io5zzGS2RTvuyEt5TLpCM6jJVqM+/0qy3UuV2E3pUtZA1n1PdU/YoWZgTxJ10dhHnMFQ7J/R1tH1XsJ24CKr+t/aYz0UuCPwaEJl9/kxbEKRuJCEh5CntEhKTp4MogBuQvAAVgeUMUZKDUGOcb7l9PnJrHw0MCJuT4PRVMSyEz2QBtGz8OKwQt/J3FDqh3XL2DLE+j0gdxcNwAHn4r9l/8oRww6ZIXYgXDRsF6+X2pvMwr1nnvIaiZtwStKmM9119AeZWabb7DlKb+N8BGWk6KLLD3Ijt88V/cHiIFOetyJsuyBU2BvFoXht/GpDJ8Hix4cLAdFTqat820c0= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: c402ec89-3382-490d-9536-08d719a29e8a X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2019 12:44:12.9894 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: viacheslavo@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3457 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix order of lines in loop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Dekel Peled > Sent: Monday, August 5, 2019 14:51 > To: Yongseok Koh ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org; Eli Britstein > > Subject: [PATCH] net/mlx5: fix order of lines in loop >=20 > Function flow_dv_zero_encap_udp_csum() uses a while loop to iterate over > vlan items in flow rule. > Pointer next_hdr is incremented to the next item before it is used, so th= e first > item is skipped. >=20 > This patch moves the incrementing of next_hdr to the correct place. >=20 > Fixes: bf1d7d9a033a ("net/mlx5: zero out UDP checksum in encapsulation") > Cc: elibr@mellanox.com >=20 > Signed-off-by: Dekel Peled Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_flow_dv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c index 536059d..6c58634 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -1504,9 +1504,9 @@ struct field_modify_info modify_tcp[] =3D { >=20 > /* VLAN skipping */ > while (proto =3D=3D RTE_ETHER_TYPE_VLAN || proto =3D=3D > RTE_ETHER_TYPE_QINQ) { > - next_hdr +=3D sizeof(struct rte_vlan_hdr); > vlan =3D (struct rte_vlan_hdr *)next_hdr; > proto =3D RTE_BE16(vlan->eth_proto); > + next_hdr +=3D sizeof(struct rte_vlan_hdr); > } >=20 > /* HW calculates IPv4 csum. no need to proceed */ > -- > 1.8.3.1