From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF31BA00BE; Wed, 30 Oct 2019 10:00:59 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 955811BF33; Wed, 30 Oct 2019 10:00:59 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150083.outbound.protection.outlook.com [40.107.15.83]) by dpdk.org (Postfix) with ESMTP id E906E1BEE0 for ; Wed, 30 Oct 2019 10:00:57 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AVS6REkfYcqZ2hAHZUVrSlxPlXTh7HrSjx1igaIF4kLHQH+eJz8UUgwTvREnx69bL421QrjWAtdq10zWasxDa1WVsn1bmjg+8hlouVKUDgrU57URTucH+AYIHq7Ke2Vh29YIg8Eplm/qX/UyijUilWCv0zwUJ5OJbPc35dCPj/5yq0lQ73hGP3ELN5i59/sjBsXcSuzQcABbNCLisfvh7MuHKAvSFQaEobOnsW8PSjOx7d23/5ZuhamVKyTYdnGlmzRenQu4Z2hIN4I1HyY4oyhT5mhjket7Ga5Yd8d0Rw8mmw7tkyLcGjhJj07JL/UjDTD+EeqNJc++AHsOerbxLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ofO+N5d5s3Je/OEb+Va08n2IVSYpv96OrixkWU7d7IY=; b=k6S9ejFKrZgnKF7eDuXWW/MdXXBuJUKBMmmJaJkhXT+hwnm9CR0+7QAs5dNLHxLfVo9g+P2yUXiVLfOI/K+z11v3xQ8VeBq1TsYxxbx3VtbqMbViSC2IhQbLLFpoEFGr958SxBs3Y0PrlLpfN/jjQAP3dtfCn2OScatbS0qlTOb8FG0YzgqvvxL75Ms4uaAJkbbmhUu8zxQK2CKA0qJp3vFZ9s/i1kjQDF4wcNmGxibigur+3ZAM9s2CuXrmGcTHWDtAR3+o67fRA4Vhi2DQA5ER9n6EFdTWyPbNE4sDm5v08WCAXPC3/IoBggGsEraf+BXyfCYrJBytj6yLFBhUCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ofO+N5d5s3Je/OEb+Va08n2IVSYpv96OrixkWU7d7IY=; b=n09kYcxsWDNbZLREib/8xOTHHJgxlRwry7nlGujw0ViTu9OeptiY/pUCVkQI3J4gd/V8Dh4ZykVMS96C8RiKqYPd6liti3LzJn44TceE1eth+nOdOlDDMm1xihmfGmLH8bdkQxX0LKYPRs3rrCROtTE4TCXRLgMrbIY4B0d8hVY= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3330.eurprd05.prod.outlook.com (10.171.191.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2387.20; Wed, 30 Oct 2019 09:00:57 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::edab:529f:d14e:d3b]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::edab:529f:d14e:d3b%7]) with mapi id 15.20.2387.027; Wed, 30 Oct 2019 09:00:57 +0000 From: Slava Ovsiienko To: Dekel Peled , Matan Azrad , Shahaf Shuler CC: Ori Kam , "dev@dpdk.org" Thread-Topic: [PATCH] net/mlx5: remove redundant new line char in logs Thread-Index: AQHVjv57PzdmgiPCjUep/QGqHMg/rqdy4v7g Date: Wed, 30 Oct 2019 09:00:56 +0000 Message-ID: References: <5fa7aac59baffdc90720fc9b229f619c87a29122.1572425052.git.dekelp@mellanox.com> In-Reply-To: <5fa7aac59baffdc90720fc9b229f619c87a29122.1572425052.git.dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 3fe903df-6e59-4384-09fe-08d75d17ad5f x-ms-traffictypediagnostic: AM4PR05MB3330:|AM4PR05MB3330: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1332; x-forefront-prvs: 02065A9E77 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(346002)(396003)(376002)(366004)(136003)(13464003)(189003)(199004)(478600001)(71190400001)(71200400001)(316002)(86362001)(25786009)(486006)(14454004)(110136005)(54906003)(256004)(14444005)(5024004)(476003)(446003)(11346002)(99286004)(7696005)(76176011)(186003)(26005)(102836004)(53546011)(6506007)(4326008)(52536014)(8936002)(7736002)(6246003)(5660300002)(33656002)(55016002)(229853002)(6116002)(6436002)(3846002)(9686003)(305945005)(2906002)(66446008)(64756008)(66556008)(66476007)(66946007)(74316002)(81166006)(6636002)(81156014)(8676002)(66066001)(76116006); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3330; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5djdDb4/6R9YNPLkrFgLh/Zqwf0AlB33y6WinqjgQ6GtyUj1wNfFQSVPheRWsvBq07jMyuTdZTa4IvzXj9Md+YiOBOV0gdgR+rV9azfotIGAVEzzTKsRT/mrEkEAtKNhGrLZfo70cDiS7sRbrbyZKOhF48+SLyiVMauFmnOTHjIBdqABF8XZS400jgUKDnLdC4/5OwuczhGWeeKqdyYYcn5i9kpLQqKKCgqTpcOXuE8c1/gMLFGsQs/8e4rx/9OCif5z16Q8Dqtf1GmZ6Kq2U3rcupQa72Glg5eQQtcpt68cly77OsXHYMVM67X/0IYYYuOOITuaOoN2jqQgd33WKRYkBhs1otp8n5/3CZBdIr6pO0OKTIGHC5tf3ni5WzGUbXD+hyG7x52LYY4gtEcJvlRcl9PCk5Pb9saJjgJwjnHMyjyrh3yvFY1jLG+Fc0Af Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3fe903df-6e59-4384-09fe-08d75d17ad5f X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2019 09:00:56.8963 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tjvQ32KhDVBCBHfXSdVHFEJnZrOowHm4Wc5oc+1tFR/2OlYSce0yqnHkU35Rt99avPg9vAssHIuH5fdUO8E4RUVB5E3MFGgA+hMeBC1KuUM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3330 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: remove redundant new line char in logs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Dekel Peled > Sent: Wednesday, October 30, 2019 10:42 > To: Matan Azrad ; Slava Ovsiienko > ; Shahaf Shuler > Cc: Ori Kam ; dev@dpdk.org > Subject: [PATCH] net/mlx5: remove redundant new line char in logs >=20 > DRV_LOG macro is used to print log messages, one per line. > In several locations this macro is used with redundant '\n' character at = the > end of the log message, causing blank lines between log lines. >=20 > This patch removes the '\n' character where it is redundant. >=20 > Signed-off-by: Dekel Peled Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5.c | 14 +++++++------- > drivers/net/mlx5/mlx5_devx_cmds.c | 8 ++++---- > drivers/net/mlx5/mlx5_flow.c | 8 ++++---- > drivers/net/mlx5/mlx5_rxtx.c | 20 +++++++++----------- > 4 files changed, 24 insertions(+), 26 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index > 6e48d43..73b4ae3 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -819,7 +819,7 @@ struct mlx5_flow_id_pool * > SOCKET_ID_ANY, 0); > if (mz =3D=3D NULL) { > DRV_LOG(ERR, > - "Cannot allocate mlx5 shared > data\n"); > + "Cannot allocate mlx5 shared data"); > ret =3D -rte_errno; > goto error; > } > @@ -831,7 +831,7 @@ struct mlx5_flow_id_pool * > mz =3D > rte_memzone_lookup(MZ_MLX5_PMD_SHARED_DATA); > if (mz =3D=3D NULL) { > DRV_LOG(ERR, > - "Cannot attach mlx5 shared data\n"); > + "Cannot attach mlx5 shared data"); > ret =3D -rte_errno; > goto error; > } > @@ -2019,7 +2019,7 @@ struct mlx5_flow_id_pool * > MLX5DV_DEVX_PORT_MATCH_REG_C_0; > err =3D mlx5_glue->devx_port_query(sh->ctx, spawn->ibv_port, > &devx_port); > if (err) { > - DRV_LOG(WARNING, "can't query devx port %d on device > %s\n", > + DRV_LOG(WARNING, "can't query devx port %d on device > %s", > spawn->ibv_port, spawn->ibv_dev->name); > devx_port.comp_mask =3D 0; > } > @@ -2028,14 +2028,14 @@ struct mlx5_flow_id_pool * > priv->vport_meta_mask =3D devx_port.reg_c_0.mask; > if (!priv->vport_meta_mask) { > DRV_LOG(ERR, "vport zero mask for port %d" > - " on bonding device %s\n", > + " on bonding device %s", > spawn->ibv_port, spawn->ibv_dev- > >name); > err =3D ENOTSUP; > goto error; > } > if (priv->vport_meta_tag & ~priv->vport_meta_mask) { > DRV_LOG(ERR, "invalid vport tag for port %d" > - " on bonding device %s\n", > + " on bonding device %s", > spawn->ibv_port, spawn->ibv_dev- > >name); > err =3D ENOTSUP; > goto error; > @@ -2044,7 +2044,7 @@ struct mlx5_flow_id_pool * > priv->vport_id =3D devx_port.vport_num; > } else if (spawn->pf_bond >=3D 0) { > DRV_LOG(ERR, "can't deduce vport index for port %d" > - " on bonding device %s\n", > + " on bonding device %s", > spawn->ibv_port, spawn->ibv_dev->name); > err =3D ENOTSUP; > goto error; > @@ -2191,7 +2191,7 @@ struct mlx5_flow_id_pool * > priv->counter_fallback =3D 1; > #endif > if (priv->counter_fallback) > - DRV_LOG(INFO, "Use fall-back DV counter > management\n"); > + DRV_LOG(INFO, "Use fall-back DV counter > management"); > /* Check for LRO support. */ > if (config.dest_tir && config.hca_attr.lro_cap && > config.dv_flow_en) { > diff --git a/drivers/net/mlx5/mlx5_devx_cmds.c > b/drivers/net/mlx5/mlx5_devx_cmds.c > index 3471a9b..d6e89b6 100644 > --- a/drivers/net/mlx5/mlx5_devx_cmds.c > +++ b/drivers/net/mlx5/mlx5_devx_cmds.c > @@ -40,7 +40,7 @@ struct mlx5_devx_obj * > dcs->obj =3D mlx5_glue->devx_obj_create(ctx, in, > sizeof(in), out, sizeof(out)); > if (!dcs->obj) { > - DRV_LOG(ERR, "Can't allocate counters - error %d\n", > errno); > + DRV_LOG(ERR, "Can't allocate counters - error %d", errno); > rte_errno =3D errno; > rte_free(dcs); > return NULL; > @@ -111,7 +111,7 @@ struct mlx5_devx_obj * > out_len, async_id, > cmd_comp); > if (rc) { > - DRV_LOG(ERR, "Failed to query devx counters with rc %d\n ", > rc); > + DRV_LOG(ERR, "Failed to query devx counters with rc %d", > rc); > rte_errno =3D rc; > return -rc; > } > @@ -171,7 +171,7 @@ struct mlx5_devx_obj * > mkey->obj =3D mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, > sizeof(out)); > if (!mkey->obj) { > - DRV_LOG(ERR, "Can't create mkey - error %d\n", errno); > + DRV_LOG(ERR, "Can't create mkey - error %d", errno); > rte_errno =3D errno; > rte_free(mkey); > return NULL; > @@ -202,7 +202,7 @@ struct mlx5_devx_obj * > if (status) { > int syndrome =3D MLX5_GET(query_flow_counter_out, out, > syndrome); >=20 > - DRV_LOG(ERR, "Bad devX status %x, syndrome =3D %x\n", > status, > + DRV_LOG(ERR, "Bad devX status %x, syndrome =3D %x", status, > syndrome); > } > return status; > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index 5f01f9c..b4b08f4 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -3136,7 +3136,7 @@ struct rte_flow * > if (!flow) { > DRV_LOG(DEBUG, > "Failed to create ctrl flow: rte_errno(%d)," > - " type(%d), message(%s)\n", > + " type(%d), message(%s)", > rte_errno, error.type, > error.message ? error.message : " (no stated > reason)"); > return -rte_errno; > @@ -3856,10 +3856,10 @@ struct rte_flow * > cont =3D MLX5_CNT_CONTAINER(sh, 1, 0); > pools_n +=3D rte_atomic16_read(&cont->n_valid); > us =3D MLX5_POOL_QUERY_FREQ_US / pools_n; > - DRV_LOG(DEBUG, "Set alarm for %u pools each %u us\n", pools_n, > us); > + DRV_LOG(DEBUG, "Set alarm for %u pools each %u us", pools_n, us); > if (rte_eal_alarm_set(us, mlx5_flow_query_alarm, sh)) { > sh->cmng.query_thread_on =3D 0; > - DRV_LOG(ERR, "Cannot reinitialize query alarm\n"); > + DRV_LOG(ERR, "Cannot reinitialize query alarm"); > } else { > sh->cmng.query_thread_on =3D 1; > } > @@ -3931,7 +3931,7 @@ struct rte_flow * > (uint64_t)(uintptr_t)pool); > if (ret) { > DRV_LOG(ERR, "Failed to trigger asynchronous query for dcs > ID" > - " %d\n", pool->min_dcs->id); > + " %d", pool->min_dcs->id); > pool->raw_hw =3D NULL; > goto set_alarm; > } > diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c > index f597c89..7f99f22 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.c > +++ b/drivers/net/mlx5/mlx5_rxtx.c > @@ -583,18 +583,16 @@ enum mlx5_txcmp_code { > MKSTR(path, "%s/%s", MLX5_SYSTEM_LOG_DIR, fname); > fd =3D fopen(path, "a+"); > if (!fd) { > - DRV_LOG(WARNING, "cannot open %s for debug dump\n", > - path); > + DRV_LOG(WARNING, "cannot open %s for debug dump", > path); > MKSTR(path2, "./%s", fname); > fd =3D fopen(path2, "a+"); > if (!fd) { > - DRV_LOG(ERR, "cannot open %s for debug dump\n", > - path2); > + DRV_LOG(ERR, "cannot open %s for debug dump", > path2); > return; > } > - DRV_LOG(INFO, "New debug dump in file %s\n", path2); > + DRV_LOG(INFO, "New debug dump in file %s", path2); > } else { > - DRV_LOG(INFO, "New debug dump in file %s\n", path); > + DRV_LOG(INFO, "New debug dump in file %s", path); > } > if (hex_title) > rte_hexdump(fd, hex_title, buf, hex_len); @@ -850,7 +848,7 > @@ enum mlx5_txcmp_code { > &rq_attr); > } > if (ret) { > - DRV_LOG(ERR, "Cannot change Rx WQ state to %u - > %s\n", > + DRV_LOG(ERR, "Cannot change Rx WQ state to %u - > %s", > sm->state, strerror(errno)); > rte_errno =3D errno; > return ret; > @@ -868,7 +866,7 @@ enum mlx5_txcmp_code { > ret =3D mlx5_glue->modify_qp(qp, &mod, IBV_QP_STATE); > if (ret) { > DRV_LOG(ERR, "Cannot change the Tx QP state to > RESET " > - "%s\n", strerror(errno)); > + "%s", strerror(errno)); > rte_errno =3D errno; > return ret; > } > @@ -876,7 +874,7 @@ enum mlx5_txcmp_code { > ret =3D mlx5_glue->modify_qp(qp, &mod, > (IBV_QP_STATE | IBV_QP_PORT)); > if (ret) { > - DRV_LOG(ERR, "Cannot change Tx QP state to INIT > %s\n", > + DRV_LOG(ERR, "Cannot change Tx QP state to INIT > %s", > strerror(errno)); > rte_errno =3D errno; > return ret; > @@ -884,7 +882,7 @@ enum mlx5_txcmp_code { > mod.qp_state =3D IBV_QPS_RTR; > ret =3D mlx5_glue->modify_qp(qp, &mod, IBV_QP_STATE); > if (ret) { > - DRV_LOG(ERR, "Cannot change Tx QP state to RTR > %s\n", > + DRV_LOG(ERR, "Cannot change Tx QP state to RTR > %s", > strerror(errno)); > rte_errno =3D errno; > return ret; > @@ -892,7 +890,7 @@ enum mlx5_txcmp_code { > mod.qp_state =3D IBV_QPS_RTS; > ret =3D mlx5_glue->modify_qp(qp, &mod, IBV_QP_STATE); > if (ret) { > - DRV_LOG(ERR, "Cannot change Tx QP state to RTS > %s\n", > + DRV_LOG(ERR, "Cannot change Tx QP state to RTS > %s", > strerror(errno)); > rte_errno =3D errno; > return ret; > -- > 1.8.3.1