From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1ECA8A057C; Thu, 26 Mar 2020 11:24:45 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B8B262C15; Thu, 26 Mar 2020 11:24:44 +0100 (CET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2054.outbound.protection.outlook.com [40.107.21.54]) by dpdk.org (Postfix) with ESMTP id 32DF6F12; Thu, 26 Mar 2020 11:24:43 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HrqiqqpyqMX7TP4PorMXr3UxBr3MbwrL1J5OUPQZyGBTERpCBsqX5q0tJAlwewILRHKfFsolGX9j472f6FIL6UR27CBwN7WWTMlh2LSdIekxslPxU24hXVY73RpGVtkENH4ULXnt1ZednbFh31leOpH41YsyfPKaHS0oom60o96qLHoC9EUOPmIcV67iEz5hWrzHhHFFcdpRQG6PY88PQoscrpWZDCY5u7d7o6EoK2TyMoperH9GYh/MOLpi/Oj/R0/q5586I7043THgt/qmqPXoG0toYsnvQjHKRz6onYcYdvzMj5OX9GGqdFwgMA0QBcogxlRD/foWETG3jovGiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SRpNy2g+lrw7oQTTg264NtL4qgwK/kxIMeHV4gAfHQ4=; b=Nhi7huh0UiIiCPasU6JKP45tbTWEBV7+F+m7CmAXXeSlhwECIiwUWrUv2qXJORfVORbhKDi17wxWlUOZ6+4vZzBMf+A6krTgiKS8UAWVCuCnpZM3RDcOroUsu3ss4LzbE+mdJawYAlk8D4W7/yi2nogQLFd0osBpFqqbPINCnhxRDSmgjNTREMoFeyFwcT63KPac2U2P0c3ZbjRnNgeLwMB9o20AhL78IFgD2JlWPtrGbQAFEOmwys3AKWx6cXRtvFl+fQ8awL1zz82lv3NVuO6OXc5hNceKsfx0j+sKeHIJpyoXsXdgynaQ1QVQo3Z6RCVkbQpY9akeq2mhPWltfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SRpNy2g+lrw7oQTTg264NtL4qgwK/kxIMeHV4gAfHQ4=; b=HcC9hmRS6KxhHiahfFbiGtX+9DMRsFFqcnf876RV4bapS0rUlEuemDzj+VhzfTq0fHfQu1hhXpoN43ARDHchrvy/1ze/KJ46HSvTDg5LST/PiiV+cVvsC/STQtztfoEnTnkXTDBlifABX7sDP3DiB7mVdRYtSRvLtI67COv8HiQ= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3140.eurprd05.prod.outlook.com (10.171.186.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.18; Thu, 26 Mar 2020 10:24:42 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::da5:7919:35c1:894]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::da5:7919:35c1:894%6]) with mapi id 15.20.2835.023; Thu, 26 Mar 2020 10:24:42 +0000 From: Slava Ovsiienko To: Wisam Monther , Ori Kam , Matan Azrad , "dev@dpdk.org" CC: Raslan Darawsheh , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/mlx5: fix zero value validation for metadata Thread-Index: AQHWA1hzpSZjHCNbaU2QjeIVhr+Ky6haqq5A Date: Thu, 26 Mar 2020 10:24:41 +0000 Message-ID: References: <20200319090237.15639-1-wisamm@mellanox.com> <20200326102200.15281-1-wisamm@mellanox.com> In-Reply-To: <20200326102200.15281-1-wisamm@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: c7da3f68-2c88-4714-62d1-08d7d16fe5a7 x-ms-traffictypediagnostic: AM4PR05MB3140:|AM4PR05MB3140: x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1751; x-forefront-prvs: 0354B4BED2 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM4PR05MB3265.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(376002)(39850400004)(366004)(136003)(396003)(346002)(76116006)(71200400001)(66476007)(26005)(66446008)(186003)(5660300002)(66556008)(64756008)(66946007)(86362001)(4326008)(450100002)(54906003)(110136005)(52536014)(316002)(8936002)(55016002)(6506007)(9686003)(8676002)(478600001)(2906002)(33656002)(81156014)(81166006)(53546011)(7696005); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MU/MGBrkCJlsvX5AfyO9LOcqa0LIbquLzIrq/xOctvVzUyoHchxzljf+Ny8EjfOTX4sbsNQ88fhL5lbWN3Vhzr4RhurHDU646zGTyLBNuRx9IzFb0PsyTq2maWIaUMK+FK04cpptbyUMf+HB228EkcQxIopxdei2g+z/XAAGsU8QOx6YGAxbb0bHP6fJHD2jy8P59cJyAZoOOkQFtu23Kyti1U9Xfk8Swi04LgUzZXSWbx6OGTgfS7XAdCqWOj0+0YspJB8LzdedOsS6zS36B1Qi8gqezqB/Zksb5bOoNMvqbKqih0hPj96xrY4KGUcWVyS0zsFqK9prOYdiXgZU27GPx2PkSmGMJupBPmAOPaR5rALCjU2w/lj3U64S9seg4TJUEV/4iUvYiv1BDhbisDfJCJE7tSEku6eclZ3KBVl9+M/EgVv2lB42PdEJ/Vof x-ms-exchange-antispam-messagedata: 4pgB/CdgkAxPRJ5Y8o5lKCrsEHjnQvnMVHSyS5tINQm2kBXesmzrLywIr1lz3/exbKNt7nG0rYzgkZfocJYZ03MyvJpYFV6KfoAW1PJezFXhsgBNyvIRL586LVhnHyomm8NIqx2HCJxPXTRcMYfFtQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: c7da3f68-2c88-4714-62d1-08d7d16fe5a7 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Mar 2020 10:24:41.9622 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6tGkGP8KVhml9Pu/a/E8TF0E8szQFKHbU6WfzjNi0NmhmpvDYGeWhBbMkYksa2ugRK+9gQZ56wQw1mqOJPJtyMs86/kIciCqyyHhebGD/NI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3140 Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix zero value validation for metadata X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Wisam Monther > Sent: Thursday, March 26, 2020 12:22 > To: Ori Kam ; Matan Azrad ; > dev@dpdk.org > Cc: Raslan Darawsheh ; Slava Ovsiienko > ; stable@dpdk.org > Subject: [PATCH v2] net/mlx5: fix zero value validation for metadata >=20 > MARK and META items are interrelated with datapath - they might move > from/to the applications in mbuf. >=20 > zero value for these items has the special meaning - it means "no metadat= a > are provided", not zero values are treated by applications and PMD as val= id > ones. >=20 > Moreover in the flow engine domain the value zero is acceptable to match > and set, and we should allow to specify zero values as rte_flow parameter= s > for the META and MARK items and actions. In the same time zero mask has > no meaning and and should be rejected on validation stage. >=20 > Fixes: fcc8d2f716fd ("net/mlx5: extend flow metadata support") > Fixes: e554b672aa05 ("net/mlx5: support flow tag") > Fixes: 55deee1715f0 ("net/mlx5: extend flow mark support") > Cc: viacheslavo@mellanox.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Wisam Jaddo Acked-by: Viacheslav Ovsiienko > --- > Changes in v2 > - Fix commit message > - Fix documentation > - Remove extra line > - Always check for zero mask > --- > --- > doc/guides/nics/mlx5.rst | 12 ++++++++++++ > drivers/net/mlx5/mlx5_flow_dv.c | 19 +++++++++++++++---- > 2 files changed, 27 insertions(+), 4 deletions(-) >=20 > diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index > e8f9984df0..e13c07d9ab 100644 > --- a/doc/guides/nics/mlx5.rst > +++ b/doc/guides/nics/mlx5.rst > @@ -1275,6 +1275,18 @@ Supported hardware offloads > | | | ConnectX-5 | | ConnectX-5 | > +-----------------------+-----------------+-----------------+ >=20 > +Notes for metadata > +------------------ > +MARK and META items are interrelated with datapath - they might move > +from/to the applications in mbuf fields. Hence, zero value for these > +items has the special meaning - it means "no metadata are provided", > +not zero values are treated by applications and PMD as valid ones. > + > +Moreover in the flow engine domain the value zero is acceptable to > +match and set, and we should allow to specify zero values as rte_flow > +parameters for the META and MARK items and actions. In the same time > +zero mask has no meaning and should be rejected on validation stage. > + > Notes for testpmd > ----------------- >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c index 809833b7ee..da4a925404 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -1406,6 +1406,11 @@ flow_dv_validate_item_mark(struct rte_eth_dev > *dev, > "mark id exceeds the limit"); > if (!mask) > mask =3D &nic_mask; > + if (!mask->id) > + return rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ITEM_SPEC, > NULL, > + "mask cannot be zero"); > + > ret =3D mlx5_flow_item_acceptable(item, (const uint8_t *)mask, > (const uint8_t *)&nic_mask, > sizeof(struct rte_flow_item_mark), > @@ -1451,10 +1456,6 @@ flow_dv_validate_item_meta(struct rte_eth_dev > *dev __rte_unused, >=20 > RTE_FLOW_ERROR_TYPE_ITEM_SPEC, > item->spec, > "data cannot be empty"); > - if (!spec->data) > - return rte_flow_error_set(error, EINVAL, > - > RTE_FLOW_ERROR_TYPE_ITEM_SPEC, NULL, > - "data cannot be zero"); > if (config->dv_xmeta_en !=3D MLX5_XMETA_MODE_LEGACY) { > if (!mlx5_flow_ext_mreg_supported(dev)) > return rte_flow_error_set(error, ENOTSUP, @@ - > 1474,6 +1475,11 @@ flow_dv_validate_item_meta(struct rte_eth_dev *dev > __rte_unused, > } > if (!mask) > mask =3D &rte_flow_item_meta_mask; > + if (!mask->data) > + return rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ITEM_SPEC, > NULL, > + "mask cannot be zero"); > + > ret =3D mlx5_flow_item_acceptable(item, (const uint8_t *)mask, > (const uint8_t *)&nic_mask, > sizeof(struct rte_flow_item_meta), > @@ -1522,6 +1528,11 @@ flow_dv_validate_item_tag(struct rte_eth_dev > *dev, > "data cannot be empty"); > if (!mask) > mask =3D &rte_flow_item_tag_mask; > + if (!mask->data) > + return rte_flow_error_set(error, EINVAL, > + RTE_FLOW_ERROR_TYPE_ITEM_SPEC, > NULL, > + "mask cannot be zero"); > + > ret =3D mlx5_flow_item_acceptable(item, (const uint8_t *)mask, > (const uint8_t *)&nic_mask, > sizeof(struct rte_flow_item_tag), > -- > 2.17.1