From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06354A034E; Thu, 7 Nov 2019 16:09:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 192B91BF1B; Thu, 7 Nov 2019 16:09:40 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140081.outbound.protection.outlook.com [40.107.14.81]) by dpdk.org (Postfix) with ESMTP id CFBA81BF19 for ; Thu, 7 Nov 2019 16:09:38 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IL25vk0SVYgwOpiMOmIwCqWV5nQH6M9INsSaUaMVNFtzJxDQKvXhnvWCmbvyAcBz9QHmi/3R+l3lvVNwJIcgtZjPRE1CAbUwqarg3xgYAWX/1rnTIC+Av8OdjR1lDjZvTe6A3f0wrbm5KAqs+BUnOjSepsFQ0qoUyJYAnhFeOg0r9uSqVhlAPLEcCGOI5INr//4QBmG8wmT0sla/tlAA0uUi1r0hiSNm9Z4XiWbdlpgnj1eaz17buwuFbJGHqQkmCzFy0OeeMO+CCzCCsl/2cRscw7BV/LNCsEBzLFZ7o+MmRdax9YahJ0mz7nr0WLJzQVo/EtKLndhtAvvJyT/ayw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lETG/vNaZrIQifYo6Z0qRxGu4rZ50+PWQGDL4F++hes=; b=G4MSeq1RdmCAmng6NcjxTTz3yxGh4ktFG7OeMltq1t/jcEtrYwjbMLp8oGxbnBUy4gTuMcKYJjctioaPra5NUljOJXe/5BmGU7OaqA1L3l7zbStQkAjgef2VU7CSvoRWKXvrwAJv5x9gGgSsDGZAApsLEJ5CF0jZWJki7dtwIYhLjcLJwWXxweP785hSDnk7P+xHYp0m9vJ+GXw3XyHXyxxT0oDSwXE5eFf5iT4BekYhYCB9pSeM4TNKi/jU8a6cUUTPfslt8Xmc1Lgmq23bJr5gOni+pLQSzgSjS6uux+TrKKJN2JeOvzbqJLBznjU4aGih45tvyxxttzJOKO57ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lETG/vNaZrIQifYo6Z0qRxGu4rZ50+PWQGDL4F++hes=; b=OPW2VyMd7NEvdKpkLWtqU+BUUPFZZPXAQ0TZPAxHu8kqsuLR360ivCwqC1s0gFTFvzkjdSgeIwdRVC6v3tm4ylb1PC35XxXPUMUlBTsKjPYPbdPU/XwJtiQmWE0QvKk5L4FU+HLfgB0LZ+V7Hb3ntglx7euC6UxztsQ5eW5SmXU= Received: from AM4PR05MB3265.eurprd05.prod.outlook.com (10.171.188.154) by AM4PR05MB3233.eurprd05.prod.outlook.com (10.171.188.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2408.24; Thu, 7 Nov 2019 15:09:37 +0000 Received: from AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::9940:94f2:db23:aa2c]) by AM4PR05MB3265.eurprd05.prod.outlook.com ([fe80::9940:94f2:db23:aa2c%4]) with mapi id 15.20.2408.028; Thu, 7 Nov 2019 15:09:37 +0000 From: Slava Ovsiienko To: Dekel Peled , Matan Azrad , Shahaf Shuler CC: Ori Kam , "dev@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix condition to create default rule Thread-Index: AQHVlXytFLy5yEAe+kSbNdHjKmSZhqd/z62w Date: Thu, 7 Nov 2019 15:09:37 +0000 Message-ID: References: <68c9b97142373f84eb6af76e5fcf3178bfe4e21c.1573138940.git.dekelp@mellanox.com> In-Reply-To: <68c9b97142373f84eb6af76e5fcf3178bfe4e21c.1573138940.git.dekelp@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=viacheslavo@mellanox.com; x-originating-ip: [95.67.35.250] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ecf44a0c-52f2-4d7a-05e0-08d763948164 x-ms-traffictypediagnostic: AM4PR05MB3233:|AM4PR05MB3233: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-forefront-prvs: 0214EB3F68 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(346002)(136003)(396003)(39860400002)(376002)(366004)(199004)(13464003)(189003)(5660300002)(76176011)(7696005)(71200400001)(53546011)(26005)(99286004)(102836004)(52536014)(25786009)(446003)(11346002)(71190400001)(6506007)(476003)(486006)(186003)(81156014)(81166006)(14444005)(66066001)(8936002)(8676002)(54906003)(110136005)(316002)(256004)(4326008)(7736002)(305945005)(6246003)(66446008)(6636002)(33656002)(229853002)(478600001)(64756008)(66946007)(9686003)(66556008)(66476007)(6116002)(74316002)(86362001)(76116006)(14454004)(2906002)(6436002)(55016002)(3846002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM4PR05MB3233; H:AM4PR05MB3265.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: YNaDz60s/fHDf2PpVJHLX25WW8z0Rm7xqtustQMsGZ7ZYL+akAqldFdX2LjhivJTNkRXPC68sohP3RrjRJyXDT+xsfoF5vibqlVtVqP14Qu2slPEFHXaRaIcvWrJO8ruBzQdxWtUIrBkQRPrAPxpJgzXQpnM+R7BrIn8IL3PKS3dnkKejc92fxpssighC1ckB0qp8kkfL+SYAqNjlXZ9GGr6b/Vjmg4xP9wjNcs7vMkvRdg/r+Xht5LdJe+gtzxev5rmoLF7njDrC9KDR22DvDIsxaXZz6duUDCWMNhiZBUGINtOPOet2U5fGKDuFlD/7xbq43hOHd33x6X1ZdzztWNc6eDiXzjSAl5omcZVq+G018GDUUbfy1HIHrz93U2idbLDFsd6ATU357R803hujew/VyrxApVvZvEFZ+fn3Gcg4VrI5hTLlJ3cLEnxreWi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: ecf44a0c-52f2-4d7a-05e0-08d763948164 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Nov 2019 15:09:37.2370 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XJiHtNY+BTZD1p4lLjnxWRRGZzVmd9/ZcMzC1Yk3UeVepDJFsqc68v3ONL1/e4dGP6fb709mK9bPrZMh7ZgYocyEmpBjF6RVzjlbXMvFZ6c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR05MB3233 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix condition to create default rule X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Dekel Peled > Sent: Thursday, November 7, 2019 17:04 > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: Ori Kam ; dev@dpdk.org > Subject: [PATCH] net/mlx5: fix condition to create default rule >=20 > Previous patch added creation of a default flow rule on port start. > Rule is created under the condition that device is in eswitch mode, and i= s not > a VF, to make sure rule is created only once. > In Bluefield, where PF representor is used, this condition is not suffici= ent. > Rule is created twice, causing loss of traffic. >=20 > This patch updates this condition, adding check that device is also not a > representor. >=20 > Fixes: b67b4ecbde22 ("net/mlx5: skip table zero to improve insertion rate= ") >=20 > Signed-off-by: Dekel Peled > --- > drivers/net/mlx5/mlx5_trigger.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_trigger.c > b/drivers/net/mlx5/mlx5_trigger.c index cafab25..f4dc047 100644 > --- a/drivers/net/mlx5/mlx5_trigger.c > +++ b/drivers/net/mlx5/mlx5_trigger.c > @@ -420,7 +420,7 @@ > } > mlx5_txq_release(dev, i); > } > - if (priv->config.dv_esw_en && !priv->config.vf) > + if (priv->config.dv_esw_en && !priv->config.vf && !priv- > >representor) > if (!mlx5_flow_create_esw_table_zero_flow(dev)) > goto error; > if (priv->isolated) > -- > 1.8.3.1 Acked-by: Viacheslav Ovsiienko